[kudu-CR] docs: add warning to wait between FS rebuilds

2018-02-09 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9279 Change subject: docs: add warning to wait between FS rebuilds .. docs: add warning to wait between FS rebuilds Customers who are

[kudu-CR] util: fix logged Kudu URL

2018-02-09 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9280 Change subject: util: fix logged Kudu URL .. util: fix logged Kudu URL Previously we would log urls like:

[kudu-CR] fs: clarify error message at startup

2018-02-09 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9281 Change subject: fs: clarify error message at startup .. fs: clarify error message at startup Currently the error messages you get when

[kudu-CR] tools: a bit more detail for unsafe change config

2018-02-09 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9278 Change subject: tools: a bit more detail for unsafe_change_config .. tools: a bit more detail for unsafe_change_config Given the tooling

[kudu-CR] WIP [tests] scenario to repro off-by-one error in TestWorkload

2018-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9277 Change subject: WIP [tests] scenario to repro off-by-one error in TestWorkload .. WIP [tests] scenario to repro off-by-one error in

[kudu-CR] WIP [non voter-itest] stress test for the 3-4-3 replacement scheme

2018-02-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9255 ) Change subject: WIP [non_voter-itest] stress test for the 3-4-3 replacement scheme .. Patch Set 1: (4 comments) Nice torture test

[kudu-CR] cmeta: Use more efficient form of GetConsensusRole()

2018-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9261 ) Change subject: cmeta: Use more efficient form of GetConsensusRole() .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2274. Shut down tombstoned replica when replacing it

2018-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9246 ) Change subject: KUDU-2274. Shut down tombstoned replica when replacing it .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [tablet] Avoid compactions in the past

2018-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8965 ) Change subject: [tablet] Avoid compactions in the past .. Patch Set 10: How does this end up working in upgrade scenarios? The previous

[kudu-CR] Random cleanups in RaftConsensus

2018-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9267 ) Change subject: Random cleanups in RaftConsensus .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9267

[kudu-CR] KUDU-2274. RaftConsensus should not access cmeta when shutdown

2018-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9266 ) Change subject: KUDU-2274. RaftConsensus should not access cmeta when shutdown .. Patch Set 2: (7 comments)

[kudu-CR] Simplify OpId/Timestamp assignment and make it atomic

2018-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7221 ) Change subject: Simplify OpId/Timestamp assignment and make it atomic .. Patch Set 17: (10 comments)

[kudu-CR] [consensus] add queue/cmeta consistency DCHECK

2018-02-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9272 ) Change subject: [consensus] add queue/cmeta consistency DCHECK .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [consensus] add queue/cmeta consistency DCHECK

2018-02-09 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9272 ) Change subject: [consensus] add queue/cmeta consistency DCHECK .. [consensus] add queue/cmeta consistency DCHECK Added an

[kudu-CR] Expose RPC method info map and various metrics

2018-02-09 Thread Lars Volker (Code Review)
Hello Michael Ho, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9269 to look at the new patch set (#2). Change subject: Expose RPC method info map and various metrics ..

[kudu-CR] Simplify OpId/Timestamp assignment and make it atomic

2018-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7221 ) Change subject: Simplify OpId/Timestamp assignment and make it atomic .. Patch Set 17: (1 comment)

[kudu-CR] Fix client comaptibility with gcc 4.4

2018-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9257 ) Change subject: Fix client comaptibility with gcc 4.4 .. Fix client comaptibility with gcc 4.4 We expect the client lib to work

[kudu-CR] Fix client comaptibility with gcc 4.4

2018-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9257 ) Change subject: Fix client comaptibility with gcc 4.4 .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [consensus] add queue/cmeta consistency DCHECK

2018-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9272 Change subject: [consensus] add queue/cmeta consistency DCHECK .. [consensus] add queue/cmeta consistency DCHECK Added an assertion on

[kudu-CR] KUDU-2233 Add a test case for compactions in the past

2018-02-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has removed a vote on this change. Change subject: KUDU-2233 Add a test case for compactions in the past .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8885 To

[kudu-CR] KUDU-2233 Add a test case for compactions in the past

2018-02-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8885 ) Change subject: KUDU-2233 Add a test case for compactions in the past .. Patch Set 12: Verified+1 Overriding, flake -- To

[kudu-CR] KUDU-721: [Java] Add DECIMAL column type support

2018-02-09 Thread Grant Henke (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8882 to look at the new patch set (#13). Change subject: KUDU-721: [Java] Add DECIMAL column type support

[kudu-CR] KUDU-721: [Java] Add DECIMAL column type support

2018-02-09 Thread Grant Henke (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8882 to look at the new patch set (#12). Change subject: KUDU-721: [Java] Add DECIMAL column type support

[kudu-CR] Simplify OpId/Timestamp assignment and make it atomic

2018-02-09 Thread David Ribeiro Alves (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7221 to look at the new patch set (#17). Change subject: Simplify OpId/Timestamp assignment and make it atomic

[kudu-CR] KUDU-2274. RaftConsensus should not access cmeta when shutdown

2018-02-09 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9266 to look at the new patch set (#2). Change subject: KUDU-2274. RaftConsensus should not access cmeta when shutdown

[kudu-CR] Fix client comaptibility with gcc 4.4

2018-02-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9257 ) Change subject: Fix client comaptibility with gcc 4.4 .. Patch Set 4: (1 comment)

[kudu-CR] Fix client comaptibility with gcc 4.4

2018-02-09 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9257 to look at the new patch set (#5). Change subject: Fix client comaptibility with gcc 4.4 ..

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-09 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9263 to look at the new patch set (#2). Change subject: Make tcmalloc heap sampling more useful .. Make

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode .. Patch Set 12: (2 comments)

[kudu-CR] thirdparty: disable the gperftools heap checker

2018-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9258 ) Change subject: thirdparty: disable the gperftools heap checker .. thirdparty: disable the gperftools heap checker We haven't

[kudu-CR] WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown

2018-02-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9266 ) Change subject: WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown .. Patch Set 1: (1 comment)

[kudu-CR] DRAFT: Expose RPC method info map and various metrics

2018-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9269 ) Change subject: DRAFT: Expose RPC method info map and various metrics .. Patch Set 1: Looks fine to me. Would be good to include in the

[kudu-CR] Fix client comaptibility with gcc 4.4

2018-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9257 ) Change subject: Fix client comaptibility with gcc 4.4 .. Patch Set 4: (1 comment)

[kudu-CR] DRAFT: Expose RPC method info map and various metrics

2018-02-09 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9269 Change subject: DRAFT: Expose RPC method info map and various metrics .. DRAFT: Expose RPC method info map and various metrics Change-Id:

[kudu-CR] WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown

2018-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9266 ) Change subject: WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown .. Patch Set 1: (1 comment)

[kudu-CR] WIP: [non voter-itest] repro the bug we hit at the flash cluster

2018-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/9116 ) Change subject: WIP: [non_voter-itest] repro the bug we hit at the flash cluster .. Abandoned Obsoleted in favor of

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-09 Thread Grant Henke (Code Review)
Hello Dan Burkert, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9213 to look at the new patch set (#4). Change subject: KUDU-721: [Spark] Add DECIMAL type support

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9213 ) Change subject: KUDU-721: [Spark] Add DECIMAL type support .. Patch Set 2: (1 comment)

[kudu-CR] Fix client comaptibility with gcc 4.4

2018-02-09 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9257 to look at the new patch set (#4). Change subject: Fix client comaptibility with gcc 4.4 ..

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9213 ) Change subject: KUDU-721: [Spark] Add DECIMAL type support .. Patch Set 3: (1 comment)