[kudu-CR] [webui] Convert /tablets page to mustache

2018-05-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10422 ) Change subject: [webui] Convert /tablets page to mustache .. Patch Set 4: Code-Review+2 LGTM. Maybe it's worth to wait for Andrew's

[kudu-CR] [rebalancing] Add a rebalancing algorithm

2018-05-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] Add a rebalancing algorithm .. Patch Set 10: Code-Review+1 (1 comment) Thank you for improving this

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-18 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10443 to look at the new patch set (#2). Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-05-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10217 to look at the new patch set (#7). Change subject: KUDU-2191: HMS Metadata Consistency Check Tool

[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-05-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 ) Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. Patch Set 7: (4 comments)

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-18 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. KUDU-2191: Metadata Upgrade Tool This commit introduces an upgrade tool to

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 20: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 20: (7 comments)

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#20). Change subject: KUDU-2191: Metadata Upgrade Tool

[kudu-CR] KUDU-2314 Add wal and metadata directories info to FsReport

2018-05-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10456 ) Change subject: KUDU-2314 Add wal and metadata directories info to FsReport .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2314 Add wal and metadata directories info to FsReport

2018-05-18 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10456 ) Change subject: KUDU-2314 Add wal and metadata directories info to FsReport .. Patch Set 1: (1 comment) There are probably quite a

[kudu-CR] KUDU-2314 Add wal and metadata directories info to FsReport

2018-05-18 Thread Fengling Wang (Code Review)
Fengling Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10456 Change subject: KUDU-2314 Add wal and metadata directories info to FsReport .. KUDU-2314 Add wal and metadata directories info to

[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test

2018-05-18 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10453 to look at the new patch set (#3). Change subject: [rebalancing] Add a randomized rebalancing algorithm test

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10443 ) Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. Patch Set 1: Saw the same problem on another

[kudu-CR] [webui] Convert /tablets page to mustache

2018-05-18 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10422 to look at the new patch set (#4). Change subject: [webui] Convert /tablets page to mustache

[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-05-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 ) Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. Patch Set 6: (4 comments)

[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10453 ) Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. Patch Set 1: (1 comment)

[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10453 ) Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. Patch Set 2: (2 comments)

[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test

2018-05-18 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10453 to look at the new patch set (#2). Change subject: [rebalancing] Add a randomized rebalancing algorithm test

[kudu-CR] [webui] Convert /tablets page to mustache

2018-05-18 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10422 to look at the new patch set (#3). Change subject: [webui] Convert /tablets page to mustache

[kudu-CR] [webui] Convert /tablets page to mustache

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10422 ) Change subject: [webui] Convert /tablets page to mustache .. Patch Set 2: > Hm.. To Alexey's point, maybe we should meet in the

[kudu-CR] [webui] Convert /tablets page to mustache

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10422 ) Change subject: [webui] Convert /tablets page to mustache .. Patch Set 2: The test failures indicate the templates in www/ were not

[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10453 Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. [rebalancing] Add a randomized rebalancing algorithm test

[kudu-CR] [rebalancing] Add a rebalancing algorithm

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#10) to the change originally created by Alexey Serbin. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] Add a rebalancing algorithm .. [rebalancing] Add a

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. KUDU-2035 Enable HTTP compression for all

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10332 To

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 13: Verified+1 -- To view, visit

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 13: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-18 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-18 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10419 to look at the new patch set (#6). Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-18 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 9: (1 comment)

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-18 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10332 to look at the new patch set (#13). Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths

[kudu-CR] KUDU-1889: support openssl 1.1

2018-05-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10436 ) Change subject: KUDU-1889: support openssl 1.1 .. Patch Set 4: Tested this on a Fedora 27 box I have laying around all all tests pass

[kudu-CR] KUDU-2035 Enable HTTP compression for all webserver's paths

2018-05-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 ) Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths .. Patch Set 12: (1 comment)

[kudu-CR] KUDU-1889: support openssl 1.1

2018-05-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10436 ) Change subject: KUDU-1889: support openssl 1.1 .. Patch Set 4: Code-Review+2 (2 comments)

[kudu-CR] [rebalancing] Add a rebalancing algorithm

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] Add a rebalancing algorithm .. Patch Set 9: Ah, just noticed that to fit with the current convention we

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 19: (7 comments)

[kudu-CR] [rebalancing] Add a rebalancing algorithm

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#9) to the change originally created by Alexey Serbin. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] Add a rebalancing algorithm .. [rebalancing] Add a

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 ) Change subject: KUDU-2191: Metadata Upgrade Tool .. Patch Set 19: Verified+1 (9 comments) Unrelated flaky test failure.

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-18 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: KUDU-2191: Metadata Upgrade Tool .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10075 To unsubscribe, visit

[kudu-CR] KUDU-1889: support openssl 1.1

2018-05-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10436 ) Change subject: KUDU-1889: support openssl 1.1 .. Patch Set 4: Code-Review+1 (1 comment)

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 5: (3 comments)

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

2018-05-18 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10419 ) Change subject: KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log .. Patch Set 4: (1 comment)

[kudu-CR] WIP [rebalancing] high-level rebalancing algorithm

2018-05-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: WIP [rebalancing] high-level rebalancing algorithm .. Patch Set 3: (2 comments) FYI Alexey I am revising this patch

[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool

2018-05-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10217 to look at the new patch set (#6). Change subject: KUDU-2191: HMS Metadata Consistency Check Tool

[kudu-CR] KUDU-2191: Metadata Upgrade Tool

2018-05-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10075 to look at the new patch set (#19). Change subject: KUDU-2191: Metadata Upgrade Tool

[kudu-CR] KUDU-2437 Generate ScanToken from small chunks in tablet

2018-05-18 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/10406 ) Change subject: KUDU-2437 Generate ScanToken from small chunks in tablet .. Patch Set 4: Thank Todd for the question pointed out, we will

Re: [kudu-CR] KUDU-2437 Generate ScanToken from small chunks in tablet

2018-05-18 Thread 徐瑶
Hi Todd, Thank you for the question pointed out, we will modify the patch according to your design. Yao 2018-05-18 1:13 GMT+08:00 Todd Lipcon (Code Review) : > Todd Lipcon *posted comments* on this change. > > View Change > > Patch