[kudu-CR] KUDU-2483 (part 1/3) Add bloom filter predicate for Java API

2019-06-21 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13703 ) Change subject: KUDU-2483 (part 1/3) Add bloom filter predicate for Java API .. Patch Set 1: (3 comments) I will first answer some

[kudu-CR] [docs] Add docs for extra configuration properties

2019-06-21 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13704 ) Change subject: [docs] Add docs for extra configuration properties .. Patch Set 2: (1 comment) > (1 comment) > > Thanks for this change!

[kudu-CR] [docs] Add docs for extra configuration properties

2019-06-21 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13704 to look at the new patch set (#2). Change subject: [docs] Add docs for extra configuration properties

[kudu-CR] [docs] Add docs for extra configuration properties

2019-06-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13704 ) Change subject: [docs] Add docs for extra configuration properties .. Patch Set 1: (1 comment) Thanks for this change! Sorry for the

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

2019-06-21 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 ) Change subject: [maintenance] Add extra config for maintenance manager task priority .. Patch Set 1: (1 comment)

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

2019-06-21 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 ) Change subject: [maintenance] Add extra config for maintenance manager task priority .. Patch Set 1: Code-Review+1 LGTM -- To view, visit

[kudu-CR] KUDU-2483 (part 1/3) Add bloom filter predicate for Java API

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13703 ) Change subject: KUDU-2483 (part 1/3) Add bloom filter predicate for Java API .. Patch Set 1: (8 comments) Thanks for the contribution!

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 ) Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 3: (4 comments)

[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs

2019-06-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13707 ) Change subject: thirdparty: fix build-if-necessary in tarballs .. Patch Set 1: (1 comment)

[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13707 ) Change subject: thirdparty: fix build-if-necessary in tarballs .. thirdparty: fix build-if-necessary in tarballs

[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs

2019-06-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13707 ) Change subject: thirdparty: fix build-if-necessary in tarballs .. Patch Set 1: Code-Review+2 +2 since this is a backport. May want to

[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13707 ) Change subject: thirdparty: fix build-if-necessary in tarballs .. Patch Set 1: (1 comment)

[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs

2019-06-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13707 ) Change subject: thirdparty: fix build-if-necessary in tarballs .. Patch Set 1: (1 comment)

[kudu-CR] thirdparty: fix build-if-necessary in tarballs

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13706 ) Change subject: thirdparty: fix build-if-necessary in tarballs .. thirdparty: fix build-if-necessary in tarballs

[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13707 Change subject: thirdparty: fix build-if-necessary in tarballs .. thirdparty: fix build-if-necessary in tarballs build-if-necessary,

[kudu-CR] thirdparty: fix build-if-necessary in tarballs

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13706 ) Change subject: thirdparty: fix build-if-necessary in tarballs .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] thirdparty: fix build-if-necessary in tarballs

2019-06-21 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13706 to review the following change. Change subject: thirdparty: fix build-if-necessary in tarballs .. thirdparty: fix

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 ) Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 3: > Patch Set 3: > > The server shutdown

[kudu-CR](branch-1.10.x) [docs] Add 1.10.0 release notes

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13669 ) Change subject: [docs] Add 1.10.0 release notes .. [docs] Add 1.10.0 release notes Change-Id:

[kudu-CR](branch-1.10.x) [backup] Fix backup tools packaging

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13705 ) Change subject: [backup] Fix backup tools packaging .. [backup] Fix backup tools packaging This patch adjusts how we package

[kudu-CR](branch-1.10.x) [backup] Fix backup tools packaging

2019-06-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13705 ) Change subject: [backup] Fix backup tools packaging .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 ) Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 3: The server shutdown test case in rpc-test

[kudu-CR](branch-1.10.x) [backup] Fix backup tools packaging

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13705 ) Change subject: [backup] Fix backup tools packaging .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13705

[kudu-CR](branch-1.10.x) [backup] Fix backup tools packaging

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [backup] Fix backup tools packaging .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13705 To unsubscribe, visit

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 ) Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 3: I mostly tested this change using iptables

[kudu-CR](branch-1.10.x) [docs] Add 1.10.0 release notes

2019-06-21 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/13669 ) Change subject: [docs] Add 1.10.0 release notes .. Patch Set 5: Code-Review+1 -- To view, visit

[kudu-CR](branch-1.10.x) [docs] Add 1.10.0 release notes

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13669 ) Change subject: [docs] Add 1.10.0 release notes .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13669 To

[kudu-CR](branch-1.10.x) [docs] Add 1.10.0 release notes

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [docs] Add 1.10.0 release notes .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13669 To unsubscribe, visit

[kudu-CR](branch-1.10.x) [backup] Fix backup tools packaging

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13705 Change subject: [backup] Fix backup tools packaging .. [backup] Fix backup tools packaging This patch adjusts how we package the

[kudu-CR] [backup] Fix backup tools packaging

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13691 ) Change subject: [backup] Fix backup tools packaging .. [backup] Fix backup tools packaging This patch adjusts how we package

[kudu-CR] [backup] Fix backup tools packaging

2019-06-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13691 ) Change subject: [backup] Fix backup tools packaging .. Patch Set 3: (1 comment)

[kudu-CR] [backup] Fix backup tools packaging

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13691 ) Change subject: [backup] Fix backup tools packaging .. Patch Set 3: (1 comment)

[kudu-CR] [backup] Fix backup tools packaging

2019-06-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13691 ) Change subject: [backup] Fix backup tools packaging .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 ) Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 3: (1 comment) Were you able to test this in

[kudu-CR](branch-1.10.x) [docs] Add 1.10.0 release notes

2019-06-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13669 ) Change subject: [docs] Add 1.10.0 release notes .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.10.x) [docs] Add 1.10.0 release notes

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13669 ) Change subject: [docs] Add 1.10.0 release notes .. Patch Set 4: (2 comments)

[kudu-CR](branch-1.10.x) [docs] Add 1.10.0 release notes

2019-06-21 Thread Grant Henke (Code Review)
Hello Will Berkeley, Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13669 to look at the new patch set (#5). Change subject: [docs] Add 1.10.0 release notes

[kudu-CR](branch-1.10.x) [docs] Add 1.10.0 release notes

2019-06-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13669 ) Change subject: [docs] Add 1.10.0 release notes .. Patch Set 4: (2 comments)

[kudu-CR](branch-1.10.x) [backup] Deflake TestKuduBackup.testRandomBackupAndRestore

2019-06-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13700 ) Change subject: [backup] Deflake TestKuduBackup.testRandomBackupAndRestore .. [backup] Deflake

[kudu-CR](branch-1.10.x) [backup] Deflake TestKuduBackup.testRandomBackupAndRestore

2019-06-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13700 ) Change subject: [backup] Deflake TestKuduBackup.testRandomBackupAndRestore .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [backup] Fix backup tools packaging

2019-06-21 Thread Grant Henke (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13691 to look at the new patch set (#3). Change subject: [backup] Fix backup tools packaging

[kudu-CR] [backup] Fix backup tools packaging

2019-06-21 Thread Grant Henke (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13691 to look at the new patch set (#2). Change subject: [backup] Fix backup tools packaging

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-21 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#15). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-21 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#14). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-21 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 13: (12 comments)

[kudu-CR] [docs] Add docs for extra configuration properties

2019-06-21 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13704 Change subject: [docs] Add docs for extra configuration properties .. [docs] Add docs for extra configuration properties Change-Id:

[kudu-CR] KUDU-2483 (part 1/3) Add bloom filter predicate for Java API

2019-06-21 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13703 Change subject: KUDU-2483 (part 1/3) Add bloom filter predicate for Java API .. KUDU-2483 (part 1/3) Add bloom filter predicate for Java API

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-21 Thread Michael Ho (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13702 to look at the new patch set (#3). Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-21 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13702 to look at the new patch set (#2). Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections ..