[kudu-CR] [tests] fix a few typos in comments

2021-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17394 ) Change subject: [tests] fix a few typos in comments .. [tests] fix a few typos in comments This patch does not contain any

[kudu-CR] KUDU-3223: Management of per-table level limit

2021-05-04 Thread Hongjiang Zhang (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17273 to look at the new patch set (#38). Change subject: KUDU-3223: Management of per-table level limit

[kudu-CR] wip [txns][tools] show details of a transaction

2021-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17391 ) Change subject: wip [txns][tools] show details of a transaction .. Patch Set 1: (1 comment) Another suggestion is to start using the

[kudu-CR] [txns][tools] tool to list transactions

2021-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17370 ) Change subject: [txns][tools] tool to list transactions .. Patch Set 5: (1 comment)

[kudu-CR] [tests] fix a few typos in comments

2021-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17394 ) Change subject: [tests] fix a few typos in comments .. Patch Set 2: Code-Review+2 Carrying over Mahesh's +1 and Grant's +2 from PS1.

[kudu-CR] [tests] fix a few typos in comments

2021-05-04 Thread Alexey Serbin (Code Review)
Hello Mahesh Reddy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17394 to look at the new patch set (#2). Change subject: [tests] fix a few typos in comments

[kudu-CR] wip [txns][tools] show details of a transaction

2021-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17391 ) Change subject: wip [txns][tools] show details of a transaction .. Patch Set 1: (6 comments)

[kudu-CR] [util] Add special handling for empty strings in FastHash

2021-05-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17376 ) Change subject: [util] Add special handling for empty strings in FastHash .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2612: update Java client API to commit a transaction

2021-05-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17393 ) Change subject: KUDU-2612: update Java client API to commit a transaction .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2612: update C++ client API to commit a transaction

2021-05-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17392 ) Change subject: KUDU-2612: update C++ client API to commit a transaction .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] [tests] fix a few typos in comments

2021-05-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17394 ) Change subject: [tests] fix a few typos in comments .. Patch Set 1: There is an IWYU complaint, but it's clearly not a result of this

[kudu-CR] [tests] fix a few typos in comments

2021-05-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17394 ) Change subject: [tests] fix a few typos in comments .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] [tests] fix a few typos in comments

2021-05-04 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [tests] fix a few typos in comments .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17394 To unsubscribe, visit

[kudu-CR] KUDU-3223: Management of per-table level limit

2021-05-04 Thread Hongjiang Zhang (Code Review)
Hongjiang Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 ) Change subject: KUDU-3223: Management of per-table level limit .. Patch Set 37: (6 comments)

[kudu-CR] KUDU-3223: Management of per-table level limit

2021-05-04 Thread Hongjiang Zhang (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17273 to look at the new patch set (#37). Change subject: KUDU-3223: Management of per-table level limit

[kudu-CR] [util] Add a function to fetch non-default flags as a map

2021-05-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17400 ) Change subject: [util] Add a function to fetch non-default flags as a map .. Patch Set 2: (1 comment)

[kudu-CR] [util] Add a function to fetch non-default flags as a map

2021-05-04 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17400 ) Change subject: [util] Add a function to fetch non-default flags as a map .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-3223: Management of per-table level limit

2021-05-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 ) Change subject: KUDU-3223: Management of per-table level limit .. Patch Set 36: (7 comments)

[kudu-CR] [txns][tools] tool to list transactions

2021-05-04 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17370 to look at the new patch set (#8). Change subject: [txns][tools] tool to list transactions ..

[kudu-CR] [txns][tools] tool to list transactions

2021-05-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17370 ) Change subject: [txns][tools] tool to list transactions .. Patch Set 7: Verified+1 Test failure was unrelated. -- To view, visit

[kudu-CR] [txns][tools] tool to list transactions

2021-05-04 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [txns][tools] tool to list transactions .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17370 To unsubscribe, visit

[kudu-CR] [util] Add a function to fetch non-default flags as a map

2021-05-04 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17400 ) Change subject: [util] Add a function to fetch non-default flags as a map .. Patch Set 2: (1 comment)

[kudu-CR] [util] Add a function to fetch non-default flags as a map

2021-05-04 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17400 to look at the new patch set (#2). Change subject: [util] Add a function to fetch non-default flags as a map ..

[kudu-CR] [util] Add a function to fetch non-default flags as a map

2021-05-04 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17400 ) Change subject: [util] Add a function to fetch non-default flags as a map .. Patch Set 1: (1 comment)

[kudu-CR] [master] KUDU-2181 Unhide master change config flag & other improvements

2021-05-04 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17401 Change subject: [master] KUDU-2181 Unhide master change config flag & other improvements .. [master] KUDU-2181 Unhide master change

[kudu-CR] [util] Add a function to fetch non-default flags as a map

2021-05-04 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17400 Change subject: [util] Add a function to fetch non-default flags as a map .. [util] Add a function to fetch non-default flags as a map

[kudu-CR] KUDU-3164: Add table comment support to Kudu

2021-05-04 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17399 to look at the new patch set (#2). Change subject: KUDU-3164: Add table comment support to Kudu ..

[kudu-CR] KUDU-3164: Add table comment support to Kudu

2021-05-04 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17399 Change subject: KUDU-3164: Add table comment support to Kudu .. KUDU-3164: Add table comment support to Kudu This patch adds the basic

[kudu-CR] [txns][tools] add a state filter to `txns list` tool

2021-05-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17371 ) Change subject: [txns][tools] add a state filter to `txns list` tool .. Patch Set 4: (1 comment)

[kudu-CR] [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job

2021-05-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 ) Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job .. Patch Set 1: > Patch Set 1: > > Might be

[kudu-CR] [txns][tools] tool to list transactions

2021-05-04 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17370 to look at the new patch set (#7). Change subject: [txns][tools] tool to list transactions ..

[kudu-CR] [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job

2021-05-04 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 ) Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job .. Patch Set 1: Might be confusing to have

[kudu-CR] [txns][tools] tool to list transactions

2021-05-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17370 ) Change subject: [txns][tools] tool to list transactions .. Patch Set 5: (10 comments)

[kudu-CR] [txns][tools] tool to list transactions

2021-05-04 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17370 to look at the new patch set (#6). Change subject: [txns][tools] tool to list transactions ..