[kudu-CR] [refactor] improve code readability by reducing if-statement levels

2022-11-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19239 ) Change subject: [refactor] improve code readability by reducing if-statement levels .. [refactor] improve code readability by r

[kudu-CR] [refactor] improve code readability by reducing if-statement levels

2022-11-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19239 ) Change subject: [refactor] improve code readability by reducing if-statement levels .. Patch Set 1: (1 comment) http://gerrit.clouder

[kudu-CR] [Client] Add query id to trace the whole query process

2022-11-14 Thread Wang Xixu (Code Review)
Hello Mahesh Reddy, Tidy Bot, Jian Zhang, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18846 to look at the new patch set (#22). Change subject: [Client] Add query id to trace the whole

[kudu-CR] [build] mute some build complains

2022-11-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19244 ) Change subject: [build] mute some build complains .. Patch Set 1: -Code-Review -- To view, visit http://gerrit.cloudera.org:8080/1924

[kudu-CR] [refactor] improve code readability by reducing if-statement levels

2022-11-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19239 ) Change subject: [refactor] improve code readability by reducing if-statement levels .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [Tools] support set flag for all in tserver use optional parameter 'force'.

2022-11-14 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19243 ) Change subject: [Tools] support set_flag_for_all in tserver use optional parameter 'force'. .. Patch Set 2: Code-Review+2 -- To view,

[kudu-CR] [refactor] improve code readability by reducing if-statement levels

2022-11-14 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19239 ) Change subject: [refactor] improve code readability by reducing if-statement levels .. Patch Set 1: Code-Review+2 -- To view, visit ht

[kudu-CR] [client] Fix a kudu c++ client bug when using replica selection policy

2022-11-14 Thread Yuqi Du (Code Review)
Hello Mahesh Reddy, Tidy Bot, Alexey Serbin, Yingchun Lai, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18877 to look at the new patch set (#30). Change subject: [client] Fix a kudu c++ client bug when using replica_sel

[kudu-CR] [client] Fix a kudu c++ client bug when using replica selection policy

2022-11-14 Thread Yuqi Du (Code Review)
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 ) Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy .. Patch Set 30: (3 comments) Thank you. http://ge

[kudu-CR] KUDU-3403 Enable kudu cli to accept specific leader to step down

2022-11-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19024 ) Change subject: KUDU-3403 Enable kudu cli to accept specific leader to step down .. Patch Set 6: (8 comments) http://gerrit.cloudera.

[kudu-CR] [Tools] support set flag for all in tserver use optional parameter 'force'.

2022-11-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19243 ) Change subject: [Tools] support set_flag_for_all in tserver use optional parameter 'force'. .. Patch Set 2: (1 comment) http://gerri

[kudu-CR] [refactor] improve code readability by reducing if-statement levels

2022-11-14 Thread Yuqi Du (Code Review)
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19239 ) Change subject: [refactor] improve code readability by reducing if-statement levels .. Patch Set 1: Code-Review+1 (1 comment) http://gerri

[kudu-CR] [Flag] Check flags consistency when setting a flag

2022-11-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19237 ) Change subject: [Flag] Check flags consistency when setting a flag .. Patch Set 3: IWYU isn't yet happy: please take a look at the rep

[kudu-CR] [Flag] Check flags consistency when setting a flag

2022-11-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19237 ) Change subject: [Flag] Check flags consistency when setting a flag .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] WIP [compact] Increase chances of compaction for large number deltas

2022-11-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19246 ) Change subject: WIP [compact] Increase chances of compaction for large number deltas .. Patch Set 1: (1 comment) http://gerrit.cloud

[kudu-CR] WIP [compact] Increase chances of compaction for large number deltas

2022-11-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19246 ) Change subject: WIP [compact] Increase chances of compaction for large number deltas .. Patch Set 1: (5 comments) http://gerrit.clou

[kudu-CR] [Flag] Check flags consistency when setting a flag

2022-11-14 Thread Wang Xixu (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19237 to look at the new patch set (#4). Change subject: [Flag] Check flags consistency when setting a flag ..

[kudu-CR] KUDU-3406: add --memory flush prioritization prob flag

2022-11-14 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19197 ) Change subject: KUDU-3406: add --memory_flush_prioritization_prob flag .. Patch Set 1: (1 comment) We can have this flag in place

[kudu-CR] [build] mute some build complains

2022-11-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19244 ) Change subject: [build] mute some build complains .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19244/1//COMMIT_MS

[kudu-CR] [build] mute some build complains

2022-11-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19244 ) Change subject: [build] mute some build complains .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.cloudera.org:8080/#/c/19244

[kudu-CR] WIP [compact] Increase chances of compaction for large number deltas

2022-11-14 Thread Ashwani Raina (Code Review)
Ashwani Raina has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19246 Change subject: WIP [compact] Increase chances of compaction for large number deltas .. WIP [compact] Increase chances of compaction fo

[kudu-CR] [docker] Update Maven download link

2022-11-14 Thread Zoltan Chovan (Code Review)
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19245 ) Change subject: [docker] Update Maven download link .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/1

[kudu-CR] [docker] Update Maven download link

2022-11-14 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19245 ) Change subject: [docker] Update Maven download link .. [docker] Update Maven download link This patch updates the download link

[kudu-CR] [docker] Update Maven download link

2022-11-14 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19245 ) Change subject: [docker] Update Maven download link .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19

[kudu-CR] [docker] Update Maven download link

2022-11-14 Thread Marton Greber (Code Review)
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19245 Change subject: [docker] Update Maven download link .. [docker] Update Maven download link This patch updates the download link in the

[kudu-CR] Follow-up on OpenSSL 3 FIPS mode removal

2022-11-14 Thread Code Review
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19232 to look at the new patch set (#3). Change subject: Follow-up on OpenSSL 3 FIPS_mode removal .. Follow-up on OpenSSL

[kudu-CR] KUDU-1698 Test that RPC and session timeout are separate entities

2022-11-14 Thread Code Review
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19175 to look at the new patch set (#5). Change subject: KUDU-1698 Test that RPC and session timeout are separate entities ..

[kudu-CR] [build] mute some build complains

2022-11-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19244 Change subject: [build] mute some build complains .. [build] mute some build complains Mute some build complains on CentOS 7.5.1804, GCC

[kudu-CR] [client] Fix a kudu c++ client bug when using replica selection policy

2022-11-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 ) Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy .. Patch Set 29: Code-Review+1 I change my vote

[kudu-CR] [Tools] support set flag for all in tserver use optional parameter 'force'.

2022-11-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19243 ) Change subject: [Tools] support set_flag_for_all in tserver use optional parameter 'force'. .. Patch Set 2: Code-Review+2 -- To view,

[kudu-CR] [client] Fix a kudu c++ client bug when using replica selection policy

2022-11-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy .. Removed Code-Review+2 by Yingchun Lai -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] [Tools] support set flag for all in tserver use optional parameter 'force'.

2022-11-14 Thread yejiabao (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19243 to look at the new patch set (#2). Change subject: [Tools] support set_flag_for_all in tserver use optional parameter 'force'.

[kudu-CR] [Tools] support set flag for all in tserver use optional parameter 'force'.

2022-11-14 Thread yejiabao (Code Review)
yejiabao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19243 Change subject: [Tools] support set_flag_for_all in tserver use optional parameter 'force'. .. [Tools] support set_flag_for_all in tserver u

[kudu-CR] [Flag] Check flags consistency when setting a flag

2022-11-14 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19237 ) Change subject: [Flag] Check flags consistency when setting a flag .. Patch Set 3: (13 comments) > Patch Set 1: > > (2 comments) http://

[kudu-CR] [Flag] Check flags consistency when setting a flag

2022-11-14 Thread Wang Xixu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19237 to look at the new patch set (#3). Change subject: [Flag] Check flags consistency when setting a flag ...

[kudu-CR] [Flag] Check flags consistency when setting a flag

2022-11-14 Thread Wang Xixu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19237 to look at the new patch set (#2). Change subject: [Flag] Check flags consistency when setting a flag ...

[kudu-CR] [threadpool] Fix unsafe behaviour when SchedulerThread shutdown

2022-11-14 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18867 ) Change subject: [threadpool] Fix unsafe behaviour when SchedulerThread shutdown .. Patch Set 17: (1 comment) > Patch Set 17: > > (1 com

[kudu-CR] [client] Fix a kudu c++ client bug when using replica selection policy

2022-11-14 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 ) Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy .. Patch Set 29: (3 comments) http://gerrit.clo

[kudu-CR] [refactor] improve code readability by reducing if-statement levels

2022-11-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19239 Change subject: [refactor] improve code readability by reducing if-statement levels .. [refactor] improve code readability by reducing i