[kudu-CR] java: use new ConnectToMaster RPC with fallback

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use new ConnectToMaster RPC with fallback .. Patch Set 1: (1 comment)

[kudu-CR] java: fix a missing lock in TabletClient

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix a missing lock in TabletClient .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6050 To unsubscribe, visit

[kudu-CR] java: refactor logic for fanning out master connection into a class

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: refactor logic for fanning out master connection into a class .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6028

[kudu-CR] KUDU-1888. java: fix handling of RPCs which fail before they are sent

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1888. java: fix handling of RPCs which fail before they are sent .. Patch Set 2: (1 comment)

[kudu-CR] java: fix a missing lock in TabletClient

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix a missing lock in TabletClient .. Patch Set 2: (1 comment)

[kudu-CR] WIP: Delete ancient UNDO delta blocks in the background

2017-02-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP: Delete ancient UNDO delta blocks in the background .. Patch Set 2: (7 comments)

[kudu-CR] [java client] Fix javadoc in ServerInfo

2017-02-16 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6039 to review the following change. Change subject: [java client] Fix javadoc in ServerInfo .. [java client] Fix javadoc

[kudu-CR] java: refactor logic for fanning out master connection into a class

2017-02-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: refactor logic for fanning out master connection into a class .. Patch Set 2: (1 comment)

[kudu-CR] WIP: java: use new ConnectToMaster RPC with fallback

2017-02-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP: java: use new ConnectToMaster RPC with fallback .. Patch Set 1: (2 comments)

[kudu-CR] [KUDU-1880] Prevent eager ignoring of NULLs

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [KUDU-1880] Prevent eager ignoring of NULLs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6029/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] java: refactor logic for fanning out master connection into a class

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: refactor logic for fanning out master connection into a class .. Patch Set 1: (2 comments)

[kudu-CR] java: redo locking and simplify TabletClient

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: redo locking and simplify TabletClient .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6017 To unsubscribe, visit

[kudu-CR] java: set max status error length to 32KB

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: set max status error length to 32KB .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] java: redo locking and simplify TabletClient

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: redo locking and simplify TabletClient .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6017/3//COMMIT_MSG Commit Message: Line 21:

[kudu-CR] java: set max status error length to 32KB

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: set max status error length to 32KB .. Patch Set 1: (1 comment)

[kudu-CR] java: set max status error length to 32KB

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: set max status error length to 32KB .. Patch Set 1: (1 comment)

[kudu-CR] java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] java: drop some DEBUG messages to TRACE

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: drop some DEBUG messages to TRACE .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6017 To unsubscribe, visit

[kudu-CR] java: refactor KuduRpc so it isn't responsible for serialization

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: refactor KuduRpc so it isn't responsible for serialization .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6016 To

[kudu-CR] java: drop some DEBUG messages to TRACE

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: drop some DEBUG messages to TRACE .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR](gh-pages) Add a blog post for 1.2.0 release

2017-02-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add a blog post for 1.2.0 release .. Patch Set 1: Code-Review+2 I trust you double checked the rendering. -- To view, visit

[kudu-CR] Refactor HybridClock and add a local clock mode

2017-02-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Refactor HybridClock and add a local clock mode .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5982/1/src/kudu/server/hybrid_clock.cc

[kudu-CR] [client] retry operation in case of ServiceUnavailable

2017-02-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [client] retry operation in case of ServiceUnavailable .. Patch Set 5: (1 comment)

[kudu-CR] csd: remove from repo

2017-02-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: csd: remove from repo .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5973 To unsubscribe, visit

[kudu-CR] [docs] Update encodings section

2017-02-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [docs] Update encodings section .. [docs] Update encodings section With KUDU-100 and KUDU-1751 we need to update our encodings docs. Change-Id:

[kudu-CR] [java client] Limit the message size in Status

2017-02-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Limit the message size in Status .. [java client] Limit the message size in Status We've seen cases where RPC traces that are

[kudu-CR] [docs] Update encodings section

2017-02-10 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5966 to review the following change. Change subject: [docs] Update encodings section .. [docs] Update encodings section

[kudu-CR] [java client] Limit the message size in Status

2017-02-10 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5956 to look at the new patch set (#2). Change subject: [java client] Limit the message size in Status .. [java client]

[kudu-CR] [java client] Limit the message size in Status

2017-02-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Limit the message size in Status .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/5956/1//COMMIT_MSG Commit Message: Line

[kudu-CR] [java client] Limit the message size in Status

2017-02-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/5956 Change subject: [java client] Limit the message size in Status .. [java client] Limit the message size in Status We've seen cases

[kudu-CR] java: use an outbound Encoder, add a test for Negotiator

2017-02-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use an outbound Encoder, add a test for Negotiator .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5947 To

[kudu-CR] Use an outbound Encoder, add a test for Negotiator

2017-02-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Use an outbound Encoder, add a test for Negotiator .. Patch Set 1: (4 comments)

[kudu-CR] Make SecureRpcHelper a Netty pipeline stage

2017-02-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Make SecureRpcHelper a Netty pipeline stage .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5927 To unsubscribe, visit

[kudu-CR] java: fix ability to connect to a real Kerberized cluster

2017-02-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix ability to connect to a real Kerberized cluster .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5922 To

[kudu-CR] java: remove unused parts of SecureRpcHelper

2017-02-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: remove unused parts of SecureRpcHelper .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5925 To unsubscribe, visit

[kudu-CR] java: use a netty frame decoder instead of replaying decoder

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use a netty frame decoder instead of replaying decoder .. Patch Set 2: (1 comment)

[kudu-CR] java: fix ability to connect to a real Kerberized cluster

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix ability to connect to a real Kerberized cluster .. Patch Set 3: (4 comments)

[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates .. Patch Set 7: (2 comments) Two nits and please add a comment regarding string

[kudu-CR] tablet: Include peer uuid in log prefix

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: tablet: Include peer uuid in log prefix .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5918 To unsubscribe, visit

[kudu-CR] tablet: Include peer uuid in log prefix

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: tablet: Include peer uuid in log prefix .. tablet: Include peer uuid in log prefix Also, add LogPrefix() to the tablet mm op. Change-Id:

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: compaction: Add additional validation in DeltaTracker .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5919 To unsubscribe,

[kudu-CR] Make SecureRpcHelper a Netty pipeline stage

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Make SecureRpcHelper a Netty pipeline stage .. Patch Set 1: (1 comment)

[kudu-CR] java: use a netty frame decoder instead of replaying decoder

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use a netty frame decoder instead of replaying decoder .. Patch Set 1: (2 comments) Good on you for addressing this. I'd be curious to see how it

[kudu-CR] java: remove unused parts of SecureRpcHelper

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: remove unused parts of SecureRpcHelper .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5925 To unsubscribe, visit

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: compaction: Add additional validation in DeltaTracker .. Patch Set 1: Worth adding a test? -- To view, visit http://gerrit.cloudera.org:8080/5919 To

[kudu-CR] Update Impala docs for Impala 2.8 release

2017-02-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Update Impala docs for Impala 2.8 release .. Patch Set 3: Verified+1 Unrelated flake. -- To view, visit http://gerrit.cloudera.org:8080/5733 To

[kudu-CR] Update Impala docs for Impala 2.8 release

2017-02-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Update Impala docs for Impala 2.8 release .. Update Impala docs for Impala 2.8 release * No longer needs to document the special 'IMPALA_KUDU'

[kudu-CR] Update Impala docs for Impala 2.8 release

2017-02-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Update Impala docs for Impala 2.8 release .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5733 To unsubscribe, visit

[kudu-CR] Fix flakiness of TestConnectionCache

2017-01-31 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Fix flakiness of TestConnectionCache .. Fix flakiness of TestConnectionCache This test would fail if one of the masters was a bit slow in

[kudu-CR] KUDU-1854 Fixed broken links to Cloudera's Kudu documentation and archive.cloudera

2017-01-31 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1854 Fixed broken links to Cloudera's Kudu documentation and archive.cloudera .. KUDU-1854 Fixed broken links to Cloudera's Kudu

[kudu-CR] KUDU-1854 Fixed broken links to Cloudera's Kudu documentation and archive.cloudera

2017-01-31 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1854 Fixed broken links to Cloudera's Kudu documentation and archive.cloudera .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] Fix flakiness of TestConnectionCache

2017-01-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix flakiness of TestConnectionCache .. Patch Set 1: Todd, since you're out sick I pushed a new rev over yours. Your variable naming was very C++ and not

[kudu-CR] Fix flakiness of TestConnectionCache

2017-01-30 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5803 to look at the new patch set (#2). Change subject: Fix flakiness of TestConnectionCache .. Fix flakiness of

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. KUDU-1831. Java client does not check if the primary key

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 3: (1 comment) I'm good with the change, just one

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-23 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: -Code-Review (1 comment) Jun, what motivated you to

[kudu-CR](gh-pages) Change links for old releases to Apache archive

2017-01-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Change links for old releases to Apache archive .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5751 To unsubscribe, visit

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Bump version in branch to 1.2.1-SNAPSHOT Change-Id: Ide4527df249f91fe60c19f7a0a7be18a0cb012d5

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5750 To unsubscribe, visit

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Patch Set 1: Need to also change python/setup.py -- To view, visit http://gerrit.cloudera.org:8080/5750 To

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: > It seems like in the context of a projection, we

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: Code-Review-2 I'm pretty sure we don't want this

[kudu-CR] Remove Schema#toString from RowResult#toString

2017-01-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Remove Schema#toString from RowResult#toString .. Patch Set 1: Code-Review+2 I'm wondering if we had a Schema#toString implementation in the past...

[kudu-CR] Remove Schema#toString from RowResult#toString

2017-01-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Remove Schema#toString from RowResult#toString .. Remove Schema#toString from RowResult#toString In RowResult#toString, the result string is

[kudu-CR] KUDU-1771. Java client "connection refused" errors logged as "connection reset"

2017-01-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1771. Java client "connection refused" errors logged as "connection reset" .. KUDU-1771. Java client "connection refused" errors logged as

[kudu-CR](branch-1.2.x) Update version to non-snapshot 1.2

2017-01-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Update version to non-snapshot 1.2 .. Update version to non-snapshot 1.2 Change-Id: I9730ba902956d03c0baf244d51555ff339da45c9 Reviewed-on:

[kudu-CR](branch-1.2.x) Update version to non-snapshot 1.2

2017-01-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Update version to non-snapshot 1.2 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5700 To unsubscribe, visit

[kudu-CR] docs: update quickstart to a new dataset

2017-01-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: docs: update quickstart to a new dataset .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5701/2/docs/quickstart.adoc File

[kudu-CR] docs: KUDU-1767. Document possible client op reordering

2017-01-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: docs: KUDU-1767. Document possible client op reordering .. Patch Set 6: (1 comment)

[kudu-CR] Doc review for 1.2

2017-01-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Doc review for 1.2 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5676 To unsubscribe, visit

[kudu-CR] KUDU-1771. Java client "connection refused" errors logged as "connection reset"

2017-01-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1771. Java client "connection refused" errors logged as "connection reset" .. Patch Set 1: (2 comments)

[kudu-CR] tpch: improve encodings and compression

2017-01-11 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: tpch: improve encodings and compression .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5689 To unsubscribe, visit

[kudu-CR] tpch: dont clear data when loading is disabled

2017-01-11 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: tpch: dont clear data when loading is disabled .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5691 To unsubscribe, visit

[kudu-CR] docs: KUDU-1767. Document possible client op reordering

2017-01-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: docs: KUDU-1767. Document possible client op reordering .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart

2017-01-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Initial draft of release notes and doc updates for 1.2

2017-01-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Initial draft of release notes and doc updates for 1.2 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5604 To

[kudu-CR] KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart

2017-01-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart .. Patch Set 1: Intuitively restart means "stop then start" for me,

[kudu-CR] Restructure release notes in preparation for 1.2 release

2017-01-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Restructure release notes in preparation for 1.2 release .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5602 To

[kudu-CR](branch-1.2.x) KUDU-1817. Fix kudu-spark2 artifactId in pom.xml

2017-01-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1817. Fix kudu-spark2 artifactId in pom.xml .. KUDU-1817. Fix kudu-spark2 artifactId in pom.xml kudu-spark2 pom.xml is malformed due to a

[kudu-CR](branch-1.2.x) KUDU-1817. Fix kudu-spark2 artifactId in pom.xml

2017-01-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/5612 Change subject: KUDU-1817. Fix kudu-spark2 artifactId in pom.xml .. KUDU-1817. Fix kudu-spark2 artifactId in pom.xml kudu-spark2

[kudu-CR] Initial draft of release notes and doc updates for 1.2

2017-01-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Initial draft of release notes and doc updates for 1.2 .. Patch Set 2: Do you have a rendering? -- To view, visit http://gerrit.cloudera.org:8080/5604 To

[kudu-CR] KUDU-1733. Update consistency semantics doc

2017-01-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1733. Update consistency semantics doc .. Patch Set 1: I didn't do a diff but did you look at https://gerrit.cloudera.org/#/c/1504/ ? -- To view,

[kudu-CR] Initial draft of release notes and doc updates for 1.2

2017-01-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Initial draft of release notes and doc updates for 1.2 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5604/2/docs/release_notes.adoc File

[kudu-CR] Restructure release notes in preparation for 1.2 release

2017-01-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Restructure release notes in preparation for 1.2 release .. Patch Set 1: (3 comments) Mind also generating site we can look at while reviewing?

[kudu-CR](gh-pages) KUDU-1818. Add link to Cloudera training in FAQ

2017-01-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1818. Add link to Cloudera training in FAQ .. KUDU-1818. Add link to Cloudera training in FAQ Additionally I snuck in a formatting fix I

[kudu-CR](gh-pages) KUDU-1818. Add link to Cloudera training in FAQ

2017-01-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1818. Add link to Cloudera training in FAQ .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5601 To

[kudu-CR] [java-client] add missing check for open client

2017-01-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] add missing check for open client .. Patch Set 1: > Somehow the buffers are not flushed by the time the close() method > returns, and from a

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1812: don't log user data in the Java client .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5549 to look at the new patch set (#2). Change subject: KUDU-1812: don't log user data in the Java client .. KUDU-1812:

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1812: don't log user data in the Java client .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-1812: redact sensitive partition keys from logs

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1812: redact sensitive partition keys from logs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5548 To unsubscribe,

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/5549 Change subject: KUDU-1812: don't log user data in the Java client .. KUDU-1812: don't log user data in the Java client I manually

[kudu-CR](branch-1.2.x) spark: continue scanning after encountering empty batch

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: spark: continue scanning after encountering empty batch .. spark: continue scanning after encountering empty batch The Spark connector would

[kudu-CR](branch-1.2.x) spark: continue scanning after encountering empty batch

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: spark: continue scanning after encountering empty batch .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5541 To

[kudu-CR](branch-1.2.x) KUDU-1775 (fixup): fix error message for too-large encoded key

2016-12-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/5521 Change subject: KUDU-1775 (fixup): fix error message for too-large encoded key .. KUDU-1775 (fixup): fix error message for

[kudu-CR](branch-1.2.x) Modify the default value of log dir flag.

2016-12-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Modify the default value of log_dir flag. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5511 To unsubscribe, visit

[kudu-CR](branch-1.2.x) Remove gcc/libstdcxx from thirdparty/LICENSE.txt

2016-12-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Remove gcc/libstdcxx from thirdparty/LICENSE.txt .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5509 To unsubscribe,

[kudu-CR] KUDU-1767. Add java test for client operation interleaving

2016-12-11 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1767. Add java test for client operation interleaving .. Patch Set 2: (7 comments)

<    1   2   3   4   5   6   7   8   >