[kudu-CR] [consensus] KUDU-1407 replica is not evcited when TABLET NOT RUNNING

2016-12-04 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5352 to review the following change. Change subject: [consensus] KUDU-1407 replica is not evcited when TABLET_NOT_RUNNING

[kudu-CR] [consensus] KUDU-1613: Fix replica eviction failure for WRONG SERVER UUID

2016-12-04 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [consensus] KUDU-1613: Fix replica eviction failure for WRONG_SERVER_UUID .. Patch Set 5: (2 comments)

[kudu-CR] [consensus] KUDU-1407 replica is not evcited when TABLET NOT RUNNING

2016-12-04 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5352 to look at the new patch set (#2). Change subject: [consensus] KUDU-1407 replica is not evcited when TABLET_NOT_RUNNING

[kudu-CR] KUDU-1782. Fault injection crashes should exit with a specific exit code

2016-12-04 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5353 to review the following change. Change subject: KUDU-1782. Fault injection crashes should exit with a specific exit code

[kudu-CR] KUDU-1782. Fault injection crashes should exit with a specific exit code

2016-12-04 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5353 to look at the new patch set (#2). Change subject: KUDU-1782. Fault injection crashes should exit with a specific exit code

[kudu-CR] KUDU-1782. Fault injection crashes should exit with a specific exit code

2016-12-04 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5353 to look at the new patch set (#3). Change subject: KUDU-1782. Fault injection crashes should exit with a specific exit code

[kudu-CR] WIP: KUDU-798 (part 5) Safe time advancement in the absense of writes

2016-12-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-798 (part 5) Safe time advancement in the absense of writes .. Patch Set 21: (29 comments) mostly small stuff

[kudu-CR] KUDU-1782. Fault injection crashes should exit with a specific exit code

2016-12-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1782. Fault injection crashes should exit with a specific exit code .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] rpc-test: fix flakiness in tests that expect timeouts

2016-12-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: rpc-test: fix flakiness in tests that expect timeouts .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5356/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] ssl factory: avoid a non-POD (vector<>) in static storage

2016-12-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: ssl_factory: avoid a non-POD (vector<>) in static storage .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5354 To unsubscribe,

[kudu-CR] ts recovery-itest: reduce test flakiness

2016-12-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: ts_recovery-itest: reduce test flakiness .. ts_recovery-itest: reduce test flakiness In the flaky test dashboard, this test case was flaky in two cases:

[kudu-CR] KUDU-1608: Catalog manager can stop retrying DeleteTablet upon fatal errors

2016-12-04 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5357 to review the following change. Change subject: KUDU-1608: Catalog manager can stop retrying DeleteTablet upon fatal errors

[kudu-CR] rpc-test: fix flakiness of TestCallLongerThanKeepalive

2016-12-04 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5355 to review the following change. Change subject: rpc-test: fix flakiness of TestCallLongerThanKeepalive ..

[kudu-CR] ssl factory: avoid a non-POD (vector<>) in static storage

2016-12-04 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5354 to review the following change. Change subject: ssl_factory: avoid a non-POD (vector<>) in static storage

[kudu-CR] WIP: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-04 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5300 to look at the new patch set (#8). Change subject: WIP: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

[kudu-CR] [consensus] KUDU-1407 replica is not evcited when TABLET NOT RUNNING

2016-12-04 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5352 to look at the new patch set (#3). Change subject: [consensus] KUDU-1407 replica is not evcited when TABLET_NOT_RUNNING

[kudu-CR] KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-04 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5300 to look at the new patch set (#10). Change subject: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

[kudu-CR] KUDU-1782. Fault injection crashes should exit with a specific exit code

2016-12-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1782. Fault injection crashes should exit with a specific exit code .. KUDU-1782. Fault injection crashes should exit with a specific exit code

[kudu-CR] KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

2016-12-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 2: JD and Dan, do you guys have opinions on this? -- To

[kudu-CR] rpc-test: fix flakiness in tests that expect timeouts

2016-12-04 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5356 to review the following change. Change subject: rpc-test: fix flakiness in tests that expect timeouts ..

[kudu-CR] KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

2016-12-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads .. Patch Set 6: (2 comments)

[kudu-CR] client: throttle some warning messages when lookup RPCs fail

2016-12-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: client: throttle some warning messages when lookup RPCs fail .. client: throttle some warning messages when lookup RPCs fail In an Impala stress

[kudu-CR] rpc-test: fix flakiness of TestCallLongerThanKeepalive

2016-12-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: rpc-test: fix flakiness of TestCallLongerThanKeepalive .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5355 To unsubscribe, visit

[kudu-CR] ts recovery-itest: reduce test flakiness

2016-12-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: ts_recovery-itest: reduce test flakiness .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5351 To unsubscribe, visit

[kudu-CR] client: throttle some warning messages when lookup RPCs fail

2016-12-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: client: throttle some warning messages when lookup RPCs fail .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5332 To unsubscribe,

[kudu-CR] KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

2016-12-04 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5321 to look at the new patch set (#6). Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

[kudu-CR] client: throttle some warning messages when lookup RPCs fail

2016-12-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: client: throttle some warning messages when lookup RPCs fail .. Patch Set 1: (2 comments) OK, added throttling in a few other spots

[kudu-CR] client: throttle some warning messages when lookup RPCs fail

2016-12-04 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5332 to look at the new patch set (#2). Change subject: client: throttle some warning messages when lookup RPCs fail ..

[kudu-CR] [i-tests] TestWorkload::set num tablets() accepts 1

2016-12-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [i-tests] TestWorkload::set_num_tablets() accepts 1 .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5347/1//COMMIT_MSG Commit

[kudu-CR] WIP: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 8: (19 comments)

[kudu-CR] WIP: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

2016-12-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 7: (3 comments)

[kudu-CR] KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

2016-12-04 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5321 to look at the new patch set (#7). Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

[kudu-CR] ssl factory: avoid a non-POD (vector<>) in static storage

2016-12-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: ssl_factory: avoid a non-POD (vector<>) in static storage .. ssl_factory: avoid a non-POD (vector<>) in static storage The global vector in

[kudu-CR] rpc-test: fix flakiness of TestCallLongerThanKeepalive

2016-12-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: rpc-test: fix flakiness of TestCallLongerThanKeepalive .. rpc-test: fix flakiness of TestCallLongerThanKeepalive The 50ms keepalive was apparently short

[kudu-CR] KUDU-1782. Fault injection crashes should exit with a specific exit code

2016-12-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1782. Fault injection crashes should exit with a specific exit code .. Patch Set 3: (1 comment)