[kudu-CR] consensus: Add gflag to enable improved re-replication

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8626 ) Change subject: consensus: Add gflag to enable improved re-replication .. Patch Set 2: (1 comment)

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-22 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8605 to look at the new patch set (#10). Change subject: tablet: mark delta tracker read-only on error

[kudu-CR] make registration of maintenance ops thread-safe

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8635 ) Change subject: make registration of maintenance ops thread-safe .. Patch Set 1: (2 comments)

[kudu-CR] make registration of maintenance ops thread-safe

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8635 ) Change subject: make registration of maintenance ops thread-safe .. Patch Set 2: (1 comment)

[kudu-CR] WIP: KUDU-1097 (patch 1): Make leader report config member health to master

2017-11-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8630 ) Change subject: WIP: KUDU-1097 (patch 1): Make leader report config member health to master .. Patch Set 1: (3 comments)

[kudu-CR] make registration of maintenance ops thread-safe

2017-11-22 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8635 to look at the new patch set (#3). Change subject: make registration of maintenance ops thread-safe

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7442 ) Change subject: shutdown tablets on disk failure at runtime .. Patch Set 13: Code-Review+2 -- To view, visit

[kudu-CR] WIP KUDU-1097 (patch 2&4): added 3-4-3 behavior for catalog manager

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8619 ) Change subject: WIP KUDU-1097 (patch 2&4): added 3-4-3 behavior for catalog manager .. Patch Set 6: (14 comments)

[kudu-CR] disk failure: randomized tserver test

2017-11-22 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8387 to look at the new patch set (#3). Change subject: disk failure: randomized tserver test .. disk failure:

[kudu-CR] fix warning in stop tablet-itest

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8634 Change subject: fix warning in stop_tablet-itest .. fix warning in stop_tablet-itest This patch fixes the WARN_UNUSED_RESULT() warning

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-22 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7442 to look at the new patch set (#12). Change subject: shutdown tablets on disk failure at runtime

[kudu-CR] make registration of maintenance ops thread-safe

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8635 ) Change subject: make registration of maintenance ops thread-safe .. Patch Set 2: (1 comment)

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-22 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7442 to look at the new patch set (#13). Change subject: shutdown tablets on disk failure at runtime

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7442 ) Change subject: shutdown tablets on disk failure at runtime .. shutdown tablets on disk failure at runtime Before, various code

[kudu-CR] make registration of maintenance ops thread-safe

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8635 ) Change subject: make registration of maintenance ops thread-safe .. make registration of maintenance ops thread-safe Before,

[kudu-CR] WIP: KUDU-1097 (patch 1): Make leader report config member health to master

2017-11-22 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8630 to look at the new patch set (#4). Change subject: WIP: KUDU-1097 (patch 1): Make leader report config member health to master

[kudu-CR] WIP: KUDU-1097 (patch 3): Implement promotion of NON VOTER replicas

2017-11-22 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8633 to review the following change. Change subject: WIP: KUDU-1097 (patch 3): Implement promotion of NON_VOTER replicas

[kudu-CR] WIP KUDU-1097 (patch 2&4): added 3-4-3 behavior for catalog manager

2017-11-22 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8619 to look at the new patch set (#5). Change subject: WIP KUDU-1097 (patch 2&4): added 3-4-3 behavior for catalog manager

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7442 ) Change subject: shutdown tablets on disk failure at runtime .. Patch Set 12: (2 comments)

[kudu-CR] error manager: synchronize/serialize handling

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 14: Code-Review+2 -- To view, visit

[kudu-CR] disk failure: itest for tablet copies

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8636 ) Change subject: disk failure: itest for tablet copies .. Patch Set 2: Note: build failed due to lint failure. -- To view, visit

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7442 ) Change subject: shutdown tablets on disk failure at runtime .. Patch Set 14: Code-Review+2 -- To view, visit

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7442 ) Change subject: shutdown tablets on disk failure at runtime .. Patch Set 14: Carrying forward Mike's +2 -- To view, visit

[kudu-CR] make registration of maintenance ops thread-safe

2017-11-22 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8635 to look at the new patch set (#2). Change subject: make registration of maintenance ops thread-safe

[kudu-CR] WIP: KUDU-1097 (patch 1): Make leader report config member health to master

2017-11-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8630 ) Change subject: WIP: KUDU-1097 (patch 1): Make leader report config member health to master .. Patch Set 4: (1 comment)

[kudu-CR] fix warning in stop tablet-itest

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8634 ) Change subject: fix warning in stop_tablet-itest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8634 To

[kudu-CR] make registration of maintenance ops thread-safe

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8635 ) Change subject: make registration of maintenance ops thread-safe .. Patch Set 1: (2 comments)

[kudu-CR] fix warning in stop tablet-itest

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: fix warning in stop_tablet-itest .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8634 To unsubscribe, visit

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7442 ) Change subject: shutdown tablets on disk failure at runtime .. Patch Set 12: Code-Review+2 I've convinced myself this should work. --

[kudu-CR] fix warning in stop tablet-itest

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8634 ) Change subject: fix warning in stop_tablet-itest .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8634 To

[kudu-CR] fix warning in stop tablet-itest

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8634 ) Change subject: fix warning in stop_tablet-itest .. Patch Set 1: build failure is an unrelated spark test failure -- To view, visit

[kudu-CR] fix warning in stop tablet-itest

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8634 ) Change subject: fix warning in stop_tablet-itest .. fix warning in stop_tablet-itest This patch fixes the WARN_UNUSED_RESULT()

[kudu-CR] make registration of maintenance ops thread-safe

2017-11-22 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8635 to look at the new patch set (#4). Change subject: make registration of maintenance ops thread-safe

[kudu-CR] disk failure: itest for tablet copies

2017-11-22 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8636 to look at the new patch set (#2). Change subject: disk failure: itest for tablet copies ..

[kudu-CR] shutdown tablets on disk failure at runtime

2017-11-22 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7442 to look at the new patch set (#14). Change subject: shutdown tablets on disk failure at runtime

[kudu-CR] disk failure: randomized tserver test

2017-11-22 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8387 to look at the new patch set (#4). Change subject: disk failure: randomized tserver test ..

[kudu-CR] make registration of maintenance ops thread-safe

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8635 ) Change subject: make registration of maintenance ops thread-safe .. Patch Set 4: Code-Review+2 fixed tidy warning. no other changes,

[kudu-CR] disk failure: randomized tserver test

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8387 ) Change subject: disk failure: randomized tserver test .. Patch Set 4: Interestingly not due to disk failure handling, I don't think. The

[kudu-CR] error manager: synchronize/serialize handling

2017-11-22 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8395 to look at the new patch set (#14). Change subject: error_manager: synchronize/serialize handling

[kudu-CR] WIP: KUDU-1097 (patch 1): Make leader report config member health to master

2017-11-22 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8630 to look at the new patch set (#6). Change subject: WIP: KUDU-1097 (patch 1): Make leader report config member health to master

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8605 ) Change subject: tablet: mark delta tracker read-only on error .. Patch Set 10: Code-Review+2 It's a little gross but this is what we get

[kudu-CR] make registration of maintenance ops thread-safe

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8635 Change subject: make registration of maintenance ops thread-safe .. make registration of maintenance ops thread-safe Before, access to

[kudu-CR] error manager: synchronize/serialize handling

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. error_manager: synchronize/serialize handling The

[kudu-CR] KUDU-1097 (patch 3): Implement promotion of NON VOTER replicas

2017-11-22 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8633 to look at the new patch set (#3). Change subject: KUDU-1097 (patch 3): Implement promotion of NON_VOTER replicas

[kudu-CR] WIP KUDU-1097 (patch 2&4): added 3-4-3 behavior for catalog manager

2017-11-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8619 ) Change subject: WIP KUDU-1097 (patch 2&4): added 3-4-3 behavior for catalog manager .. Patch Set 6: (2 comments)

[kudu-CR] WIP KUDU-1097 (patch 2&4): added 3-4-3 behavior for catalog manager

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8619 ) Change subject: WIP KUDU-1097 (patch 2&4): added 3-4-3 behavior for catalog manager .. Patch Set 6: (1 comment)

[kudu-CR] WIP: Make leader report config member health to master

2017-11-22 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8630 to review the following change. Change subject: WIP: Make leader report config member health to master .. WIP: Make

[kudu-CR] error manager: synchronize/serialize handling

2017-11-22 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8395 to look at the new patch set (#13). Change subject: error_manager: synchronize/serialize handling

[kudu-CR] error manager: synchronize/serialize handling

2017-11-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 13: fixed iwyu -- To view, visit

[kudu-CR] WIP KUDU-1097 (patch 2&4): added 3-4-3 behavior for catalog manager

2017-11-22 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8619 to look at the new patch set (#6). Change subject: WIP KUDU-1097 (patch 2&4): added 3-4-3 behavior for catalog manager

[kudu-CR] make registration of maintenance ops thread-safe

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8635 ) Change subject: make registration of maintenance ops thread-safe .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1097 (patch 3): Implement promotion of NON VOTER replicas

2017-11-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8633 ) Change subject: KUDU-1097 (patch 3): Implement promotion of NON_VOTER replicas .. Patch Set 3: (14 comments) looks good overall, some

[kudu-CR] KUDU-1097: 3-4-3 behavior for catalog manager

2017-11-22 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8619 to look at the new patch set (#7). Change subject: KUDU-1097: 3-4-3 behavior for catalog manager

[kudu-CR] KUDU-1097: 3-4-3 behavior for catalog manager

2017-11-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8619 ) Change subject: KUDU-1097: 3-4-3 behavior for catalog manager .. Patch Set 6: (14 comments)

[kudu-CR] consensus: Add gflag to enable improved re-replication

2017-11-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8626 ) Change subject: consensus: Add gflag to enable improved re-replication .. Patch Set 2: (1 comment)

[kudu-CR] WIP [catalog manager] added 3-4-3 behavior

2017-11-22 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8619 to look at the new patch set (#4). Change subject: WIP [catalog_manager] added 3-4-3 behavior

[kudu-CR] WIP: Make leader report config member health to master

2017-11-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8630 ) Change subject: WIP: Make leader report config member health to master .. Patch Set 1: (8 comments) Overall looks good to me, just a

[kudu-CR] tablet: mark delta tracker read-only on error

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8605 ) Change subject: tablet: mark delta tracker read-only on error .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] consensus: Add gflag to enable improved re-replication

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8626 ) Change subject: consensus: Add gflag to enable improved re-replication .. Patch Set 3: Great, thanks! -- To view, visit

[kudu-CR] WIP: Make leader report config member health to master

2017-11-22 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8630 to look at the new patch set (#2). Change subject: WIP: Make leader report config member health to master

[kudu-CR] [spark] add 'local-cluster' mode for unit test

2017-11-22 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8585 ) Change subject: [spark] add 'local-cluster' mode for unit test .. Patch Set 1: (1 comment)

[kudu-CR] consensus: Add gflag to enable improved re-replication

2017-11-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8626 ) Change subject: consensus: Add gflag to enable improved re-replication .. consensus: Add gflag to enable improved

[kudu-CR] consensus: Add gflag to enable improved re-replication

2017-11-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8626 ) Change subject: consensus: Add gflag to enable improved re-replication .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] [spark] add 'local-cluster' mode for unit test

2017-11-22 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8585 ) Change subject: [spark] add 'local-cluster' mode for unit test .. Patch Set 1: (3 comments) > I pointed SPARK_HOME at the unpacked release

[kudu-CR] relnotes: Prepare for Kudu 1.6 release

2017-11-22 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8632 to review the following change. Change subject: relnotes: Prepare for Kudu 1.6 release .. relnotes: Prepare for Kudu

[kudu-CR] relnotes: Prepare for Kudu 1.6 release

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8632 ) Change subject: relnotes: Prepare for Kudu 1.6 release .. Patch Set 1: Code-Review+2 Self +2 for initial 1.6.0 release notes based on my

[kudu-CR] relnotes: Prepare for Kudu 1.6 release

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8632 ) Change subject: relnotes: Prepare for Kudu 1.6 release .. relnotes: Prepare for Kudu 1.6 release This patch simply removes the

[kudu-CR] WIP: Make leader report config member health to master

2017-11-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8630 ) Change subject: WIP: Make leader report config member health to master .. Patch Set 2: (10 comments)

[kudu-CR] WIP: Make leader report config member health to master

2017-11-22 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8630 to look at the new patch set (#3). Change subject: WIP: Make leader report config member health to master