[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 10: (9 comments) I tried doing a bit of a refactor on the

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-24 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#11). Change subject: KUDU-2245 Graceful leadership transfer

[kudu-CR] Implement BloomFilter Predicate in server side.

2018-09-24 Thread ZhangYao (Code Review)
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11100 ) Change subject: Implement BloomFilter Predicate in server side. .. Patch Set 8: (66 comments)

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 3: (1 comment)

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-24 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#6). Change subject: [tools] ksck checksums: Factor out of main ksck code

[kudu-CR] [tools] ksck checksums: Add KsckChecksummer class

2018-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11498 Change subject: [tools] ksck checksums: Add KsckChecksummer class .. [tools] ksck checksums: Add KsckChecksummer class This removes

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-24 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#5). Change subject: [tools] ksck checksums: Factor out of main ksck code

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 5: Fixed some bad indenting. -- To view, visit

[kudu-CR] Implement BloomFilter Predicate in server side.

2018-09-24 Thread ZhangYao (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11100 to look at the new patch set (#8). Change subject: Implement BloomFilter Predicate in server side.

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 6: Verified+1 Precommit failure due to known +

[kudu-CR] KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

2018-09-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/11394 ) Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer .. Patch Set 5: Code-Review+2 -- To

[kudu-CR] KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

2018-09-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/11394 ) Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer .. Patch Set 4: (1 comment)

[kudu-CR] [tools] ksck checksums: Add KsckChecksummer class

2018-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11498 ) Change subject: [tools] ksck checksums: Add KsckChecksummer class .. Patch Set 1: (7 comments)

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: [tools] ksck checksums: Factor out of main ksck code .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11488 To

[kudu-CR] hybrid clock: restore SleepFor in WaitUntilAfterLocally

2018-09-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/11495 ) Change subject: hybrid_clock: restore SleepFor in WaitUntilAfterLocally .. Patch Set 2: I guess I should have +2 before the

[kudu-CR] [tools] ksck checksums: Add KsckChecksummer class

2018-09-24 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11498 to look at the new patch set (#2). Change subject: [tools] ksck checksums: Add KsckChecksummer class ..

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 9: Code-Review+2 Thanks! I'll work on getting this

[kudu-CR] [location awareness] Add location info in ksck report

2018-09-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 2: > Uploaded patch set 2. Please address the

[kudu-CR] hybrid clock: restore SleepFor in WaitUntilAfterLocally

2018-09-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11495 ) Change subject: hybrid_clock: restore SleepFor in WaitUntilAfterLocally .. hybrid_clock: restore SleepFor in

[kudu-CR] hybrid clock: restore SleepFor in WaitUntilAfterLocally

2018-09-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/11495 ) Change subject: hybrid_clock: restore SleepFor in WaitUntilAfterLocally .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 10: (1 comment)

[kudu-CR] [location awareness] Add location info in ksck report

2018-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 2: (3 comments)

[kudu-CR] Implement BloomFilter Predicate in server side.

2018-09-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11100 ) Change subject: Implement BloomFilter Predicate in server side. .. Patch Set 8: (7 comments)

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 9: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 11: > (9 comments) > > I tried doing a bit of a refactor on the

[kudu-CR] [location awareness] Add location info in ksck report

2018-09-24 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11422 to look at the new patch set (#4). Change subject: [location_awareness] Add location info in ksck report

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-24 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 9: Verified-1 we should probably change the date in the

[kudu-CR] Add Hive Metastore service principal configuration

2018-09-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11503 ) Change subject: Add Hive Metastore service principal configuration .. Patch Set 2: (1 comment)

[kudu-CR] [location awareness] Add location info in ksck report

2018-09-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 5: > Uploaded patch set 5. It seems

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 10: I'm planning on pushing this out and tweeting it out

[kudu-CR] Add Hive Metastore service principal configuration

2018-09-24 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11503 to review the following change. Change subject: Add Hive Metastore service principal configuration .. Add

[kudu-CR] [tablet server-test] cleaner exit-on-failure in TestStatus

2018-09-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11506 ) Change subject: [tablet_server-test] cleaner exit-on-failure in TestStatus .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] [tablet server-test] cleaner exit-on-failure in TestStatus

2018-09-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11506 ) Change subject: [tablet_server-test] cleaner exit-on-failure in TestStatus .. Patch Set 1: Verified+1 Unrelated flake in

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-24 Thread Anupama Gupta (Code Review)
Hello Alexey Serbin, Mike Percy, Attila Bukor, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11263 to look at the new patch set (#10). Change subject: Blogpost describing index skip scan optimization.

[kudu-CR] Add Hive Metastore service principal configuration

2018-09-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11503 ) Change subject: Add Hive Metastore service principal configuration .. Patch Set 1: (1 comment)

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 10: Code-Review+2 -- To view, visit

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-24 Thread Anupama Gupta (Code Review)
Anupama Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 9: Sorry for the confusion. I have renamed the file

[kudu-CR] [location awareness] Add location info in ksck report

2018-09-24 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11422 to look at the new patch set (#5). Change subject: [location_awareness] Add location info in ksck report

[kudu-CR] [tablet server-test] cleaner exit-on-failure in TestStatus

2018-09-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11506 Change subject: [tablet_server-test] cleaner exit-on-failure in TestStatus .. [tablet_server-test] cleaner exit-on-failure in

[kudu-CR] Add Hive Metastore service principal configuration

2018-09-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11503 to look at the new patch set (#2). Change subject: Add Hive Metastore service principal configuration

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 9: > Patch Set 9: Verified-1 > > we should probably

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-24 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 9: > Patch Set 9: > > > Patch Set 9: Verified-1 > > > >

[kudu-CR] [location awareness] Add location info in ksck report

2018-09-24 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11422 to look at the new patch set (#3). Change subject: [location_awareness] Add location info in ksck report

[kudu-CR] [location awareness] Add location info in ksck report

2018-09-24 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 3: (4 comments)