[kudu-CR] KUDU-3011 p7: add tool to quiesce server

2020-01-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15091 to look at the new patch set (#2). Change subject: KUDU-3011 p7: add tool to quiesce server .. KUDU-3011 p7: add

[kudu-CR] [utility] auto-detection of cloud VM instance type

2020-01-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14866 ) Change subject: [utility] auto-detection of cloud VM instance type .. Patch Set 5: (6 comments)

[kudu-CR] [utility] auto-detection of cloud VM instance type

2020-01-21 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, Bankim Bhavsar, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14866 to look at the new patch set (#5). Change subject: [utility] auto-detection of cloud VM instance

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 4: Code-Review+2 For some reason, IWYU is

[kudu-CR] KUDU-3011 p7: add tool to quiesce server

2020-01-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15091 to look at the new patch set (#3). Change subject: KUDU-3011 p7: add tool to quiesce server .. KUDU-3011

[kudu-CR] KUDU-3011 p7: add tool to quiesce server

2020-01-21 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15091 Change subject: KUDU-3011 p7: add tool to quiesce server .. KUDU-3011 p7: add tool to quiesce server Adds the following commands: $ kudu

[kudu-CR] [clock] auto-config of built-in NTP client in cloud

2020-01-21 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15070 to look at the new patch set (#2). Change subject: [clock] auto-config of built-in NTP client in cloud

[kudu-CR] tablet copy client: delete WAL data using existing function

2020-01-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15077 ) Change subject: tablet copy client: delete WAL data using existing function .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] compression: fix handling of NO COMPRESSION

2020-01-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15078 ) Change subject: compression: fix handling of NO_COMPRESSION .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] rpc-test-base.h: squelch a warning

2020-01-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15079 ) Change subject: rpc-test-base.h: squelch a warning .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] rpc-test-base.h: squelch a warning

2020-01-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15079 ) Change subject: rpc-test-base.h: squelch a warning .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] file cache: evict open fd when descriptor goes out of scope

2020-01-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15080 ) Change subject: file cache: evict open fd when descriptor goes out of scope .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [spark] Replace bad Guava import

2020-01-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15084 ) Change subject: [spark] Replace bad Guava import .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15084

[kudu-CR] [utility] auto-detection of cloud VM instance type

2020-01-21 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, Bankim Bhavsar, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14866 to look at the new patch set (#4). Change subject: [utility] auto-detection of cloud VM instance

[kudu-CR] [utility] auto-detection of cloud VM instance type

2020-01-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14866 ) Change subject: [utility] auto-detection of cloud VM instance type .. Patch Set 4: (3 comments)

[kudu-CR] [utility] auto-detection of cloud VM instance type

2020-01-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14866 ) Change subject: [utility] auto-detection of cloud VM instance type .. Patch Set 1: (1 comment)

[kudu-CR] [clock] auto-config of built-in NTP client in cloud

2020-01-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15070 ) Change subject: [clock] auto-config of built-in NTP client in cloud .. Patch Set 1: (1 comment)

[kudu-CR] [python] Use positional formatting in Python scripts

2020-01-21 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15075 Change subject: [python] Use positional formatting in Python scripts .. [python] Use positional formatting in Python scripts

[kudu-CR] [python] Use positional formatting in Python scripts

2020-01-21 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15075 to look at the new patch set (#2). Change subject: [python] Use positional formatting in Python scripts

[kudu-CR] [master] Replace hive metastore sasl enabled validator

2020-01-21 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15076 Change subject: [master] Replace hive_metastore_sasl_enabled validator .. [master] Replace hive_metastore_sasl_enabled validator The

[kudu-CR] [master] Replace hive metastore sasl enabled validator

2020-01-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15076 ) Change subject: [master] Replace hive_metastore_sasl_enabled validator .. Patch Set 1: Code-Review+2 Thanks for catching this! -- To

[kudu-CR] [master] Replace hive metastore sasl enabled validator

2020-01-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15076 ) Change subject: [master] Replace hive_metastore_sasl_enabled validator .. [master] Replace hive_metastore_sasl_enabled validator

[kudu-CR] tablet copy client: delete WAL data using existing function

2020-01-21 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15077 to review the following change. Change subject: tablet copy client: delete WAL data using existing function

[kudu-CR] compression: fix handling of NO COMPRESSION

2020-01-21 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15078 to review the following change. Change subject: compression: fix handling of NO_COMPRESSION ..

[kudu-CR] log: start using file cache

2020-01-21 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15082 to review the following change. Change subject: log: start using file cache .. log: start using file

[kudu-CR] rpc-test-base.h: squelch a warning

2020-01-21 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15079 to review the following change. Change subject: rpc-test-base.h: squelch a warning ..

[kudu-CR] file cache: support alternate open modes

2020-01-21 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15081 to review the following change. Change subject: file cache: support alternate open modes .. file

[kudu-CR] file cache: evict open fd when descriptor goes out of scope

2020-01-21 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15080 to review the following change. Change subject: file cache: evict open fd when descriptor goes out of scope

[kudu-CR] tablet copy client: delete WAL data using existing function

2020-01-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15077 ) Change subject: tablet copy client: delete WAL data using existing function .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [python] Use positional formatting in Python scripts

2020-01-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15075 ) Change subject: [python] Use positional formatting in Python scripts .. [python] Use positional formatting in Python scripts

[kudu-CR] [python] Use positional formatting in Python scripts

2020-01-21 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15075 ) Change subject: [python] Use positional formatting in Python scripts .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] [python] Use positional formatting in Python scripts

2020-01-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15075 ) Change subject: [python] Use positional formatting in Python scripts .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [spark] Replace bad Guava import

2020-01-21 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15084 Change subject: [spark] Replace bad Guava import .. [spark] Replace bad Guava import TestImportExportFiles uses the shaded Spark import

[kudu-CR] compression: fix handling of NO COMPRESSION

2020-01-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15078 ) Change subject: compression: fix handling of NO_COMPRESSION .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-01-21 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 7: (2 comments)

[kudu-CR] [spark] Replace bad Guava import

2020-01-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15084 ) Change subject: [spark] Replace bad Guava import .. [spark] Replace bad Guava import TestImportExportFiles uses the shaded

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. Patch Set 3: Hit a gcc 4.8 compatibility bug. Added a

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15064 to look at the new patch set (#4). Change subject: schema: use dense_hash_map instead of std::unordered_map

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-01-21 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 8: > Patch Set 8: Verified-1

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-21 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15058 to look at the new patch set (#4). Change subject: build: restrict clang version, prefer lld, enable thinlto

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-01-21 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, helifu, Yao Xu, Adar Dembo, ZhangYao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15034 to look at the new patch set (#8). Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

[kudu-CR] [spark] Replace bad Guava import

2020-01-21 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15084 ) Change subject: [spark] Replace bad Guava import .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] file cache: support alternate open modes

2020-01-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15081 ) Change subject: file cache: support alternate open modes .. Patch Set 1: (3 comments)

[kudu-CR] [utility] auto-detection of cloud VM instance type

2020-01-21 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14866 ) Change subject: [utility] auto-detection of cloud VM instance type .. Patch Set 4: Code-Review+1 (6 comments)

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-01-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 8: Verified+1 Code-Review+2 Looks

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-01-21 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Removed reviewer Kudu Jenkins with

[kudu-CR] compression: fix handling of NO COMPRESSION

2020-01-21 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15078 ) Change subject: compression: fix handling of NO_COMPRESSION .. compression: fix handling of NO_COMPRESSION The string values of

[kudu-CR] rpc-test-base.h: squelch a warning

2020-01-21 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15079 ) Change subject: rpc-test-base.h: squelch a warning .. rpc-test-base.h: squelch a warning Change-Id:

[kudu-CR] tablet copy client: delete WAL data using existing function

2020-01-21 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15077 ) Change subject: tablet copy client: delete WAL data using existing function .. tablet copy client: delete WAL data using existing

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15058 ) Change subject: build: restrict clang version, prefer lld, enable thinlto .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] log: start using file cache

2020-01-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15082 ) Change subject: log: start using file cache .. Patch Set 1: (2 comments)

[kudu-CR] file cache: evict open fd when descriptor goes out of scope

2020-01-21 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15080 ) Change subject: file cache: evict open fd when descriptor goes out of scope .. file cache: evict open fd when descriptor goes out

[kudu-CR] file cache: evict open fd when descriptor goes out of scope

2020-01-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15080 ) Change subject: file cache: evict open fd when descriptor goes out of scope .. Patch Set 1: Verified+1 Overriding Jenkins, unrelated

[kudu-CR] file cache: evict open fd when descriptor goes out of scope

2020-01-21 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: file cache: evict open fd when descriptor goes out of scope .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15080 To

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. Patch Set 4: (1 comment)

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15064 to look at the new patch set (#5). Change subject: schema: use dense_hash_map instead of std::unordered_map

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15058 ) Change subject: build: restrict clang version, prefer lld, enable thinlto .. build: restrict clang version, prefer lld, enable

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15042 to look at the new patch set (#4). Change subject: cfile: change BlockBuilder API to yield a vector of Slices

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] file cache: support alternate open modes

2020-01-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15081 ) Change subject: file cache: support alternate open modes .. Patch Set 1: (2 comments)

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. schema: use dense_hash_map instead of