[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16101 ) Change subject: [client] KUDU-3152 fix predicates on DATE column .. Patch Set 1: (1 comment) It seems the failures in

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-23 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16043 ) Change subject: KUDU-2612 p1: add initial transaction status storage .. Patch Set 7: (4 comments)

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

2020-06-23 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16101 ) Change subject: [client] KUDU-3152 fix predicates on DATE column .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-23 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 ) Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. Patch Set 6: > Patch Set 5: > > >

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

2020-06-23 Thread Greg Solovyev (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16101 to look at the new patch set (#2). Change subject: [client] KUDU-3152 fix predicates on DATE column

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

2020-06-23 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16101 ) Change subject: [client] KUDU-3152 fix predicates on DATE column .. Patch Set 3: > Patch Set 3: > > Looking at the C++ client for

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

2020-06-23 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16101 ) Change subject: [client] KUDU-3152 fix predicates on DATE column .. Patch Set 1: (1 comment) > (1 comment) > > It seems the

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

2020-06-23 Thread Greg Solovyev (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16101 to look at the new patch set (#3). Change subject: [client] KUDU-3152 fix predicates on DATE column

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-23 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16036 to look at the new patch set (#6). Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

2020-06-23 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16101 ) Change subject: [client] KUDU-3152 fix predicates on DATE column .. Patch Set 3: Looking at the C++ client for comparison and in

[kudu-CR] [docs] Add a section about using Gradle checkstyle

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16105 ) Change subject: [docs] Add a section about using Gradle checkstyle .. [docs] Add a section about using Gradle checkstyle

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16043 ) Change subject: KUDU-2612 p1: add initial transaction status storage .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] [mini-cluster] fix GetLeaderMasterIndex()

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16106 Change subject: [mini-cluster] fix GetLeaderMasterIndex() .. [mini-cluster] fix GetLeaderMasterIndex() Prior to this patch, when

[kudu-CR] [autn token expire-itest] make one scenario more robust

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16107 Change subject: [autn_token_expire-itest] make one scenario more robust .. [autn_token_expire-itest] make one scenario more robust

[kudu-CR] KUDU-1802: Avoid calls to master when using scan tokens

2020-06-23 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16031 to look at the new patch set (#11). Change subject: KUDU-1802: Avoid calls to master when using scan tokens

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16043 ) Change subject: KUDU-2612 p1: add initial transaction status storage .. Patch Set 8: (7 comments)

[kudu-CR] KUDU-1802: Avoid calls to master when using scan tokens

2020-06-23 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16031 ) Change subject: KUDU-1802: Avoid calls to master when using scan tokens .. Patch Set 11: The c++ client still needs work to handle

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

2020-06-23 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16101 ) Change subject: [client] KUDU-3152 fix predicates on DATE column .. Patch Set 3: > > Patch Set 3: > > > > Looking at the C++ client

[kudu-CR] [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter

2020-06-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16036 ) Change subject: [perf] KUDU-3140 Heuristics to disable predicate evaluation for Bloom filter .. Patch Set 6: Code-Review+2 (2

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-23 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16043 to look at the new patch set (#8). Change subject: KUDU-2612 p1: add initial transaction status storage

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-23 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16043 to look at the new patch set (#9). Change subject: KUDU-2612 p1: add initial transaction status storage

[kudu-CR] KUDU-1802: Avoid calls to master when using scan tokens

2020-06-23 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16031 to look at the new patch set (#12). Change subject: KUDU-1802: Avoid calls to master when using scan tokens

[kudu-CR] [mini-cluster] fix GetLeaderMasterIndex()

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16106 ) Change subject: [mini-cluster] fix GetLeaderMasterIndex() .. Patch Set 2: Code-Review+2 Carrying on Grant's +2 from PS1. -- To

[kudu-CR] [mini-cluster] fix GetLeaderMasterIndex()

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16106 ) Change subject: [mini-cluster] fix GetLeaderMasterIndex() .. [mini-cluster] fix GetLeaderMasterIndex() Prior to this patch,

[kudu-CR] [autn token expire-itest] make one scenario more robust

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16107 ) Change subject: [autn_token_expire-itest] make one scenario more robust .. Patch Set 2: Verified+1 Unrelated test failure in

[kudu-CR] [autn token expire-itest] make one scenario more robust

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16107 ) Change subject: [autn_token_expire-itest] make one scenario more robust .. [autn_token_expire-itest] make one scenario more

[kudu-CR] [autn token expire-itest] make one scenario more robust

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [autn_token_expire-itest] make one scenario more robust .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16107 To

[kudu-CR] [mini-cluster] fix GetLeaderMasterIndex()

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16106 ) Change subject: [mini-cluster] fix GetLeaderMasterIndex() .. Patch Set 2: Verified+1 unrelated tests failures: *

[kudu-CR] [mini-cluster] fix GetLeaderMasterIndex()

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [mini-cluster] fix GetLeaderMasterIndex() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16106 To unsubscribe,

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-23 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16043 ) Change subject: KUDU-2612 p1: add initial transaction status storage .. Patch Set 9: Code-Review+2 (2 comments)

[kudu-CR] [docs] Add a section about using Gradle checkstyle

2020-06-23 Thread Greg Solovyev (Code Review)
Greg Solovyev has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16105 Change subject: [docs] Add a section about using Gradle checkstyle .. [docs] Add a section about using Gradle checkstyle Coming from

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16043 ) Change subject: KUDU-2612 p1: add initial transaction status storage .. Patch Set 9: Verified+1 Seems ASAN dist-test run timed out for

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-23 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2612 p1: add initial transaction status storage .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16043 To

[kudu-CR] [docs] Add a section about using Gradle checkstyle

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16105 ) Change subject: [docs] Add a section about using Gradle checkstyle .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-23 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16043 to look at the new patch set (#10). Change subject: KUDU-2612 p1: add initial transaction status storage

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-23 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16043 to look at the new patch set (#11). Change subject: KUDU-2612 p1: add initial transaction status storage

[kudu-CR] [autn token expire-itest] make one scenario more robust

2020-06-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16107 ) Change subject: [autn_token_expire-itest] make one scenario more robust .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [autn token expire-itest] make one scenario more robust

2020-06-23 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16107 ) Change subject: [autn_token_expire-itest] make one scenario more robust .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [autn token expire-itest] make one scenario more robust

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16107 ) Change subject: [autn_token_expire-itest] make one scenario more robust .. Patch Set 1: (1 comment)

[kudu-CR] [autn token expire-itest] make one scenario more robust

2020-06-23 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16107 to look at the new patch set (#2). Change subject: [autn_token_expire-itest] make one scenario more robust

[kudu-CR] [mini-cluster] fix GetLeaderMasterIndex()

2020-06-23 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16106 ) Change subject: [mini-cluster] fix GetLeaderMasterIndex() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2612 p1: add initial transaction status storage

2020-06-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16043 ) Change subject: KUDU-2612 p1: add initial transaction status storage .. Patch Set 10: (1 comment)

[kudu-CR] [mini-cluster] fix GetLeaderMasterIndex()

2020-06-23 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16106 to look at the new patch set (#2). Change subject: [mini-cluster] fix GetLeaderMasterIndex()

[kudu-CR] [mini-cluster] fix GetLeaderMasterIndex()

2020-06-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16106 ) Change subject: [mini-cluster] fix GetLeaderMasterIndex() .. Patch Set 1: (1 comment)