[kudu-CR] [client] updated multi-row transaction API

2021-01-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16948 ) Change subject: [client] updated multi-row transaction API .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 7: (4 comments) Yep, I agree

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-14 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16648 to look at the new patch set (#8). Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[kudu-CR] KUDU-2612 Java client transaction API

2021-01-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, Hao Hao, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16894 to look at the new patch set (#7). Change subject: KUDU-2612 Java client transaction API

[kudu-CR] KUDU-2612 Java client transaction API

2021-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16894 ) Change subject: KUDU-2612 Java client transaction API .. Patch Set 7: > We discussed offline changing from a

[kudu-CR] [client] updated multi-row transaction API

2021-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16948 ) Change subject: [client] updated multi-row transaction API .. Patch Set 1: (1 comment)

[kudu-CR] [client] updated multi-row transaction API

2021-01-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16948 ) Change subject: [client] updated multi-row transaction API .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16953 ) Change subject: [build] Seperate protobuf java compilation into a seperate module .. Patch Set 1: Code-Review+1 (3 comments)

[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16953 ) Change subject: [build] Seperate protobuf java compilation into a seperate module .. Patch Set 1: (1 comment)

[kudu-CR] [client] updated multi-row transaction API

2021-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16948 ) Change subject: [client] updated multi-row transaction API .. Patch Set 1: (1 comment)

[kudu-CR] [client] updated multi-row transaction API

2021-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16948 ) Change subject: [client] updated multi-row transaction API .. Patch Set 3: Code-Review+2 LGTM, though would be good to get another look

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 7: (1 comment)

[kudu-CR] [client] updated multi-row transaction API

2021-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16948 ) Change subject: [client] updated multi-row transaction API .. Patch Set 1: (1 comment)

[kudu-CR] [client] updated multi-row transaction API

2021-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16948 ) Change subject: [client] updated multi-row transaction API .. Patch Set 3: Tagging Tim for context. -- To view, visit

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 8: (2 comments)

[kudu-CR] [client] updated multi-row transaction API

2021-01-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16948 to look at the new patch set (#3). Change subject: [client] updated multi-row transaction API

[kudu-CR] wip KUDU-2612: background task to commit transaction

2021-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16952 ) Change subject: wip KUDU-2612: background task to commit transaction .. Patch Set 1: I'm looking into the test failures, but would

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 8: (1 comment)

[kudu-CR] [client] updated multi-row transaction API

2021-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16948 ) Change subject: [client] updated multi-row transaction API .. [client] updated multi-row transaction API This patch removes

[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-14 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [build] Seperate protobuf java compilation into a seperate module .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16953 ) Change subject: [build] Seperate protobuf java compilation into a seperate module .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] wip KUDU-2612: background task to commit transaction

2021-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16952 Change subject: wip KUDU-2612: background task to commit transaction .. wip KUDU-2612: background task to commit transaction This patch

[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-14 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16953 Change subject: [build] Seperate protobuf java compilation into a seperate module .. [build] Seperate protobuf java compilation into a

[kudu-CR] [build] Add a test coverage report to the Java build

2021-01-14 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16954 Change subject: [build] Add a test coverage report to the Java build .. [build] Add a test coverage report to the Java build This patch

[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16953 ) Change subject: [build] Seperate protobuf java compilation into a seperate module .. Patch Set 1: (1 comment)

[kudu-CR] [client] updated multi-row transaction API

2021-01-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16948 ) Change subject: [client] updated multi-row transaction API .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] allow customize sasl proto name instead of always using "kudu"

2021-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16955 ) Change subject: allow customize sasl_proto_name instead of always using "kudu" .. Patch Set 1: (6 comments) Thank you for the patch!

[kudu-CR] KUDU-2612 Java client transaction API

2021-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16894 ) Change subject: KUDU-2612 Java client transaction API .. Patch Set 7: Code-Review+2 (2 comments) LGTM for the most part, but would be

[kudu-CR] wip KUDU-2612: background task to commit transaction

2021-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16952 ) Change subject: wip KUDU-2612: background task to commit transaction .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-2612 Java client transaction API

2021-01-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16894 ) Change subject: KUDU-2612 Java client transaction API .. Patch Set 7: Code-Review+2 Looks good to me. Thanks for revising. -- To

[kudu-CR] [build] Add a test coverage report to the Java build

2021-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16954 ) Change subject: [build] Add a test coverage report to the Java build .. Patch Set 1: (2 comments) I checked this out and ran the

[kudu-CR] allow customize sasl proto name instead of always using "kudu"

2021-01-14 Thread Anonymous Coward (Code Review)
hongjizh...@ebay.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16955 Change subject: allow customize sasl_proto_name instead of always using "kudu" .. allow customize sasl_proto_name instead of

[kudu-CR] KUDU-2612 Java client transaction API

2021-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16894 ) Change subject: KUDU-2612 Java client transaction API .. Patch Set 8: Code-Review+2 Carrying over +2 from Andrew and Grant on PS7.

[kudu-CR] KUDU-2612 Java client transaction API

2021-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16894 ) Change subject: KUDU-2612 Java client transaction API .. KUDU-2612 Java client transaction API This patch is focused on the

[kudu-CR] KUDU-2612 Java client transaction API

2021-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16894 ) Change subject: KUDU-2612 Java client transaction API .. Patch Set 7: (2 comments)

[kudu-CR] KUDU-2612 Java client transaction API

2021-01-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, Hao Hao, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16894 to look at the new patch set (#8). Change subject: KUDU-2612 Java client transaction API

[kudu-CR] wip KUDU-2612: background task to commit transaction

2021-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16952 ) Change subject: wip KUDU-2612: background task to commit transaction .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-14 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16648 to look at the new patch set (#9). Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

[kudu-CR] KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 8: (3 comments)

[kudu-CR] allow customize sasl proto name instead of always using "kudu"

2021-01-14 Thread Anonymous Coward (Code Review)
hongjizh...@ebay.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16955 ) Change subject: allow customize sasl_proto_name instead of always using "kudu" .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-3230: Fix the issue of hardcode sasl proto name

2021-01-14 Thread Hongjiang Zhang (Code Review)
Hongjiang Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16956 Change subject: KUDU-3230: Fix the issue of hardcode sasl_proto_name .. KUDU-3230: Fix the issue of hardcode sasl_proto_name 'kudu'