[kudu-CR] MiniKdc for C++

2016-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: MiniKdc for C++ .. Patch Set 1: (39 comments) http://gerrit.cloudera.org:8080/#/c/4752/1/CMakeLists.txt File CMakeLists.txt: Line 1054: # Google util libraries

[kudu-CR] KUDU-1696. Daemons should dump their version info to the INFO log at startup

2016-10-18 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1696. Daemons should dump their version info to the INFO log at startup .. Patch Set 3: (5 comments)

[kudu-CR] MiniKdc for C++

2016-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: MiniKdc for C++ .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4752/1/src/kudu/security/mini_kdc.h File src/kudu/security/mini_kdc.h: PS1, Line

[kudu-CR] MiniKdc for C++

2016-10-18 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4752 to review the following change. Change subject: MiniKdc for C++ .. MiniKdc for C++

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [util] added Subprocess::GetExitStatus() .. [util] added Subprocess::GetExitStatus() The Subprocess::GetExitStatus() method allows to retrive exit

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4648 To unsubscribe, visit

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4648 To unsubscribe, visit

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-18 Thread Alexey Serbin (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4648 to look at the new patch set (#12). Change subject: [util] added Subprocess::GetExitStatus() ..

[kudu-CR] KUDU-1696. Daemons should dump their version info to the INFO log at startup

2016-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1696. Daemons should dump their version info to the INFO log at startup .. Patch Set 3: (9 comments)

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() .. Patch Set 10: (6 comments) Thank you for the review! Will post new version in a moment.

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-18 Thread Alexey Serbin (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4648 to look at the new patch set (#11). Change subject: [util] added Subprocess::GetExitStatus() ..

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() .. Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/4648/10/src/kudu/util/subprocess.cc File

[kudu-CR] KUDU-1696. Daemons should dump their version info to the INFO log at startup

2016-10-18 Thread Maxim Smyatkin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4733 to look at the new patch set (#3). Change subject: KUDU-1696. Daemons should dump their version info to the INFO log at startup

[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section

2016-10-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. Patch Set 10: > (1 comment) NP -- To view, visit

[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section

2016-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. Patch Set 8: (1 comment)

[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section

2016-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section .. [web-ui] KUDU-1588 /tablets page should separate out

[kudu-CR] KUDU-1692: tie various reader memtrackers to the tablet tracker

2016-10-18 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4708 to look at the new patch set (#4). Change subject: KUDU-1692: tie various reader memtrackers to the tablet tracker

[kudu-CR] KUDU-1692: tie various reader memtrackers to the tablet tracker

2016-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1692: tie various reader memtrackers to the tablet tracker .. Patch Set 3: (1 comment)

[kudu-CR] consensus: remove bits of dead code

2016-10-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: remove bits of dead code .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4712 To unsubscribe, visit

[kudu-CR] consensus: move ReplicaTransactionFactory into RaftConsensus

2016-10-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: move ReplicaTransactionFactory into RaftConsensus .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4711 To

[kudu-CR] consensus: move more logic from ReplicaState to RaftConsensus

2016-10-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: move more logic from ReplicaState to RaftConsensus .. Patch Set 3: (3 comments)

[kudu-CR] consensus queue: make methods non-virtual

2016-10-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus_queue: make methods non-virtual .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4710 To unsubscribe, visit