[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 16: (2 comments) I also massaged COMMIT_MSG to a good extent and couple of

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-23 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6066 to look at the new patch set (#17). Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .

[kudu-CR] Use unique ptr instead of gscoped ptr for blocks, CFileReader

2017-03-23 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6467 to review the following change. Change subject: Use unique_ptr instead of gscoped_ptr for blocks, CFileReader .. Use un

[kudu-CR] cfile set: reduce memory usage of reader map

2017-03-23 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6466 to look at the new patch set (#2). Change subject: cfile_set: reduce memory usage of reader map .. cfil

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 16: (34 comments) http://gerrit.cloudera.org:8080/#/c/6066/16/src/kudu/cons

[kudu-CR] cfile set: reduce memory usage of reader map

2017-03-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: cfile_set: reduce memory usage of reader map .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6466/1/src/kudu/tablet/cfile_set.cc File src/kudu/ta

[kudu-CR] cfile set: reduce memory usage of reader map

2017-03-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cfile_set: reduce memory usage of reader map .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6466/1/src/kudu/tablet/cfile_set.cc File src/kudu/tab

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/6451/10/src/kudu/consensus/consensus_queue-test.cc

[kudu-CR] cfile set: reduce memory usage of reader map

2017-03-23 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6466 to review the following change. Change subject: cfile_set: reduce memory usage of reader map .. cfile_set: reduce memor

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/c/6451/10/src/kudu/consensus/consensus.proto File sr

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 16: (34 comments) I did one quick nit pass for everything except tests. I ca

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 10: Code-Review+2 Leaving open in case mike wants to take a look. -- To view, visit http://ge

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/6451/9/src/kudu/consensus/consensus_queue.cc File

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#10). Change subject: [consensus] Add consensus op-level lag metrics .. [consensus] A

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/6451/9/src/kudu/consensus/consensus_queue.

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#9). Change subject: [consensus] Add consensus op-level lag metrics .. [consensus] Ad

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 15: (5 comments) TFTR Mike/David again. We could follow up TimeManager frie

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-23 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6066 to look at the new patch set (#16). Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/6066/14/src/kudu/consens

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/6066/14/src/kud

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/6066/14/src/kudu/consen

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6451/8/src/kudu/consensus/consensus_queue.cc File s

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/6066/15/src/kudu/consen

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/6451/7/src/kudu/consensus/consensus.proto File src

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#8). Change subject: [consensus] Add consensus op-level lag metrics .. [consensus] Ad

[kudu-CR] Spark ITBLL

2017-03-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Spark ITBLL .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6419/1/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinked

[kudu-CR] Spark ITBLL

2017-03-23 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6419 to look at the new patch set (#2). Change subject: Spark ITBLL .. Spark ITBLL This adds a new end-to-end test for

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/6451/7/src/kudu/consensus/consensus.proto

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 6: (3 comments) As you guys in the above comments, since this doesn't address time, I've changed the

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#7). Change subject: [consensus] Add consensus op-level lag metrics .. [consensus] Ad

[kudu-CR] kudu-mapreduce: tweak poms

2017-03-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: kudu-mapreduce: tweak poms .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6418/1//COMMIT_MSG Commit Message: Line 22: fat jar containing kudu-cl

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-23 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6066 to look at the new patch set (#15). Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 14: (16 comments) http://gerrit.cloudera.org:8080/#/c/6066/14/src/kudu/cons