Mike Percy has posted comments on this change.
Change subject: Add tablet state summary metrics
..
Patch Set 5:
(4 comments)
Looking pretty good, just a couple nits.
Mike Percy has submitted this change and it was merged.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't exist at
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2137: protect against concurrent schema version change and
tablet drop
..
Patch Set 1: Code-Review+2
LGTM, but perhaps you would want to hear from Dan or
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 9: Code-Review+2
--
To view, visit
Andrew Wong has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 9: Code-Review+1
(2 comments)
lgtm; Alexey may want to take another
Hao Hao has posted comments on this change.
Change subject: Add a simple benchmark to create 1M blocks and reopen LBM
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8006/1/src/kudu/fs/block_id.h
File
Mike Percy has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 7:
(2 comments)
Mike Percy has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 8:
(3 comments)
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7988
to look at the new patch set (#9).
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
Andrew Wong has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 8:
(5 comments)
Mike Percy has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 7:
(9 comments)
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7988
to look at the new patch set (#8).
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
Alexey Serbin has posted comments on this change.
Change subject: [tests] fix flakes in delete_table-itest
..
Patch Set 3:
(1 comment)
Andrew Wong has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 7:
(7 comments)
Alexey Serbin has posted comments on this change.
Change subject: [tests] fix flakes in delete_table-itest
..
Patch Set 3:
(1 comment)
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 7: Code-Review+2
(3 comments)
> (6 comments)
>
> > (7
Mike Percy has posted comments on this change.
Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric
..
Patch Set 15:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6968/13/src/kudu/consensus/consensus_meta.h
Hello Dan Burkert, Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8002
to look at the new patch set (#2).
Change subject: ref_counted: fix move constructors to actually move
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8010
to review the following change.
Change subject: WIP: pb_util: avoid repeated stat() calls reading files
..
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8008
to review the following change.
Change subject: log_block_manager: use move semantics to fill in the block map
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8006
to review the following change.
Change subject: Add a simple benchmark to create 1M blocks and reopen LBM
Todd Lipcon has abandoned this change.
Change subject: block_id: use a better hash function
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/8001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8007
to review the following change.
Change subject: log_block_manager: switch from google::sparse_hash_map to
sparsepp
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8009
to review the following change.
Change subject: Avoid a few allocations while reading PBC files
..
Avoid
Mike Percy has posted comments on this change.
Change subject: [tests] fix flakes in delete_table-itest
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7972/3/src/kudu/integration-tests/delete_table-itest.cc
Todd Lipcon has submitted this change and it was merged.
Change subject: web ui: fix "percentage consumed" calculation
..
web ui: fix "percentage consumed" calculation
There was a misplaced cast, so the division of consumption
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2137: protect against concurrent schema version change and
tablet drop
..
Patch Set 1:
> Just FYI: to me, the test reliably fails with 1/512 ratio if
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2137: protect against concurrent schema version change and
tablet drop
..
Patch Set 1:
Just FYI: to me, the test reliably fails with 1/512 ratio if built
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7988
to look at the new patch set (#7).
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
Mike Percy has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 6:
(6 comments)
> (7 comments)
>
> I have the following question:
Mike Percy has submitted this change and it was merged.
Change subject: KUDU-2134: Defer block transaction commit to the end of a
tablet copy
..
KUDU-2134: Defer block transaction commit to the end of a tablet copy
KUDU-2131
Mike Percy has posted comments on this change.
Change subject: KUDU-2134: Defer block transaction commit to the end of a
tablet copy
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7966
To
Todd Lipcon has posted comments on this change.
Change subject: block_id: use a better hash function
..
Patch Set 1:
I tried making a unit test and weirdly in my unit test environment, the new
hash was actually worse than the
Mike Percy has posted comments on this change.
Change subject: KUDU-2138 delete failed replicas in tablet report
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7992
To unsubscribe, visit
Mike Percy has submitted this change and it was merged.
Change subject: KUDU-2138 delete failed replicas in tablet report
..
KUDU-2138 delete failed replicas in tablet report
When a Kudu master processes a replica's tablet
Hello Mike Percy, Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7992
to look at the new patch set (#5).
Change subject: KUDU-2138 delete failed replicas in tablet report
Andrew Wong has posted comments on this change.
Change subject: KUDU-2138 delete failed replicas in tablet report
..
Patch Set 5:
(3 comments)
Mike Percy has posted comments on this change.
Change subject: KUDU-2138 delete failed replicas in tablet report
..
Patch Set 4: Code-Review+1
(3 comments)
looks good, just a couple nits
Mike Percy has submitted this change and it was merged.
Change subject: Rename tombstoned_voting-itest to tombstoned_voting-imc-itest
..
Rename tombstoned_voting-itest to tombstoned_voting-imc-itest
tombstoned_voting-itest
Mike Percy has submitted this change and it was merged.
Change subject: Fix flakiness of ts_tablet_manager_itest
TestFailedTabletsAreReplaced
..
Fix flakiness of ts_tablet_manager_itest TestFailedTabletsAreReplaced
Mike Percy has posted comments on this change.
Change subject: Fix flakiness of ts_tablet_manager_itest
TestFailedTabletsAreReplaced
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7993
To
Alexey Serbin has posted comments on this change.
Change subject: Rename tombstoned_voting-itest to tombstoned_voting-imc-itest
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7991
To
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7988
to look at the new patch set (#6).
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7991
to look at the new patch set (#2).
Change subject: Rename tombstoned_voting-itest to tombstoned_voting-imc-itest
..
Mike Percy has posted comments on this change.
Change subject: Rename tombstoned_voting-itest to tombstoned_voting-test
..
Patch Set 1:
(2 comments)
> tombstoned_voting-itest.cc --> tombstoned_voting-imc-itest.cc ?
Done
Alexey Serbin has submitted this change and it was merged.
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
..
[iwyu] kudu-specific mappings for std::tr1 entities
Added Kudu-specific IWYU mappings for
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7988
to look at the new patch set (#5).
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
Dan Burkert has posted comments on this change.
Change subject: KUDU-2134: Defer block transaction commit to the end of a
tablet copy
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7966
To
Dan Burkert has posted comments on this change.
Change subject: KUDU-2134: Defer block transaction commit to the end of a
tablet copy
..
Patch Set 5:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: KUDU-2134: Defer block transaction commit to the end of a
tablet copy
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7966
To
Adar Dembo has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 3:
(8 comments)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7656
to look at the new patch set (#5).
Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups
of blocks
Hello Dan Burkert, Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7966
to look at the new patch set (#6).
Change subject: KUDU-2134: Defer block transaction commit to the end of a
tablet copy
Hao Hao has posted comments on this change.
Change subject: KUDU-2055[part 1]: Coalesce hole punching when deleting groups
of blocks
..
Patch Set 4:
The failed test TestCopyFromCrashedSource is a known flaky test (KUDU-2109).
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7988
to look at the new patch set (#4).
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
Mike Percy has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 3:
(11 comments)
Adar Dembo has posted comments on this change.
Change subject: block_id: use a better hash function
..
Patch Set 1:
Would be great if you could synthesize a unit test that exhibits the
improvement too, so that if we wanted to
Adar Dembo has posted comments on this change.
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7998/2/.gitignore
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7985
to look at the new patch set (#3).
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7998
to look at the new patch set (#3).
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7998/2/.gitignore
File .gitignore:
Line
Adar Dembo has posted comments on this change.
Change subject: KUDU-2138 delete failed replicas in tablet report
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7992
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7998/2/.gitignore
File .gitignore:
Line 33:
Dan Burkert has posted comments on this change.
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7998
To unsubscribe, visit
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8002
to review the following change.
Change subject: ref_counted: fix move constructors to actually move
..
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8001
to review the following change.
Change subject: block_id: use a better hash function
..
block_id: use a
Hao Hao has posted comments on this change.
Change subject: KUDU-2134: Defer block transaction commit to the end of a
tablet copy
..
Patch Set 5:
(1 comment)
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7998/1/README.adoc
File README.adoc:
Line
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
..
[iwyu] kudu-specific mappings for std::tr1 entities
Added Kudu-specific IWYU mappings for
Andrew Wong has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 3:
(2 comments)
Dan Burkert has posted comments on this change.
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7998/1/README.adoc
File README.adoc:
Line
Alexey Serbin has posted comments on this change.
Change subject: Fix typo in partitioning error message
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7997
To unsubscribe, visit
Alexey Serbin has submitted this change and it was merged.
Change subject: Fix typo in partitioning error message
..
Fix typo in partitioning error message
Change-Id: I5502956e7947a67dba3e68e5add529c7b9e26866
Reviewed-on:
Alexey Serbin has posted comments on this change.
Change subject: Rename tombstoned_voting-itest to tombstoned_voting-test
..
Patch Set 1:
(2 comments)
I though the '-itest' suffix stood for 'integration test'.
Maybe, rename
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7998/1/README.adoc
File README.adoc:
Line
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7992
to look at the new patch set (#4).
Change subject: KUDU-2138 delete failed replicas in tablet report
..
Andrew Wong has posted comments on this change.
Change subject: KUDU-2138 delete failed replicas in tablet report
..
Patch Set 4:
Just fixed IWYU failure, still good for review.
--
To view, visit
Dan Burkert has posted comments on this change.
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7998/1/README.adoc
File README.adoc:
Line
Dan Burkert has posted comments on this change.
Change subject: KUDU-2134: Defer block transaction commit to the end of a
tablet copy
..
Patch Set 5: Code-Review+1
(2 comments)
Looks good, I like how this makes the code a
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 3:
(9 comments)
Just some nits for a while -- will take a deeper
Hello Hao Hao, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7997
to look at the new patch set (#2).
Change subject: Fix typo in partitioning error message
..
Fix typo in
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
..
Patch Set 1: Verified+1
Unrelated flake in RaftConsensusITest.TestTombstonedVoteAfterFailedTabletCopy
--
Alexey Serbin has posted comments on this change.
Change subject: Fix typo in partitioning error message
..
Patch Set 1:
It seems src/kudu/master/master-test.cc should be also updated.
--
To view, visit
Hao Hao has posted comments on this change.
Change subject: Fix typo in partitioning error message
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7997
To unsubscribe, visit
Mike Percy has posted comments on this change.
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
..
Patch Set 2:
(4 comments)
Hao Hao has posted comments on this change.
Change subject: Fix flakiness of ts_tablet_manager_itest
TestFailedTabletsAreReplaced
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7993
To
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7988
to look at the new patch set (#3).
Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't
exist at startup
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7998
Change subject: [iwyu] kudu-specific mappings for std::tr1 entities
..
[iwyu] kudu-specific mappings for std::tr1 entities
Added
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7997
to review the following change.
Change subject: Fix typo in partitioning error message
..
Fix typo in partitioning
Will Berkeley has posted comments on this change.
Change subject: KUDU-2044 Tombstoned tablets show up in /metrics
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7981/3//COMMIT_MSG
Commit Message:
PS3, Line
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7981
to look at the new patch set (#4).
Change subject: KUDU-2044 Tombstoned tablets show up in /metrics
..
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7980
to look at the new patch set (#5).
Change subject: Add tablet state summary metrics
..
Add tablet
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7996
to review the following change.
Change subject: KUDU-2137: protect against concurrent schema version change and
tablet drop
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7995
to review the following change.
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
Adar Dembo has posted comments on this change.
Change subject: Fix flakiness of ts_tablet_manager_itest
TestFailedTabletsAreReplaced
..
Patch Set 2: Code-Review+1
Will defer to Mike.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: rename suicide_on_eio flag to crash_on_eio
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7994
To unsubscribe, visit
Andrew Wong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7994
Change subject: rename suicide_on_eio flag to crash_on_eio
..
rename suicide_on_eio flag to crash_on_eio
The name `suicide_on_eio` seems
Andrew Wong has posted comments on this change.
Change subject: docs: update disk failure recovery notes
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7984/1/docs/administration.adoc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7984
to look at the new patch set (#2).
Change subject: docs: update disk failure recovery notes
..
docs: update disk
Andrew Wong has posted comments on this change.
Change subject: KUDU-2138 delete failed replicas in tablet report
..
Patch Set 2:
(2 comments)
1 - 100 of 114 matches
Mail list logo