Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5901
to look at the new patch set (#3).
Change subject: [sys_catalog] make visitor's code more generic
..
[sys_catalog]
Adar Dembo has posted comments on this change.
Change subject: [thirdparty] Make Boost a regular dependency
..
Patch Set 5:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/5818/5//COMMIT_MSG
Commit Message:
PS5, Line 9:
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5899
to review the following change.
Change subject: WIP: client: add master's CA cert as trusted on the client
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5871
to look at the new patch set (#4).
Change subject: master: issue authentication tokens and CA certs to clients
Alexey Serbin has posted comments on this change.
Change subject: [sys_catalog] make visitor's code more generic
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5901/1/src/kudu/master/sys_catalog.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5901
to look at the new patch set (#2).
Change subject: [sys_catalog] make visitor's code more generic
..
[sys_catalog]
Dan Burkert has posted comments on this change.
Change subject: master: issue authentication tokens and CA certs to clients
..
Patch Set 4: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5871/4/src/kudu/master
Todd Lipcon has posted comments on this change.
Change subject: master: issue authentication tokens and CA certs to clients
..
Patch Set 4:
(1 comment)
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 6:
(2 comments)
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5899
to look at the new patch set (#2).
Change subject: client: trust master's cert, adopt authn token
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 6:
> Uploaded patch set 6.
I just had to #include
The util/random library
Adar Dembo has posted comments on this change.
Change subject: [sys_catalog] make visitor's code more generic
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5901/1/src/kudu/master/sys_catalog.cc
File
Dan Burkert has posted comments on this change.
Change subject: master: issue authentication tokens and CA certs to clients
..
Patch Set 4:
(1 comment)
Hello Mike Percy, Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5903
to review the following change.
Change subject: flume sink: use the same hadoop.version as everyone else
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5892
to review the following change.
Change subject: master_rpc: pass back more details from ConnectToCluster
Alexey Serbin has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 6: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5845/4/src/kudu/security
Adar Dembo has posted comments on this change.
Change subject: master_rpc: pass back more details from ConnectToCluster
..
Patch Set 1:
(3 comments)
Callback chains make my brain hurt...
Hello Mike Percy, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5885
to review the following change.
Change subject: [tools] Add missing help text from few tools
..
[tools
Todd Lipcon has submitted this change and it was merged.
Change subject: client: rename various function calls and classes to
ConnectToCluster
..
client: rename various function calls and classes to ConnectToCluster
This is a
Todd Lipcon has posted comments on this change.
Change subject: tablet copy: Include local peer UUID in TabletCopyService log
messages
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5873
Todd Lipcon has submitted this change and it was merged.
Change subject: tablet copy: Include local peer UUID in TabletCopyService log
messages
..
tablet copy: Include local peer UUID in TabletCopyService log messages
Also,
Adar Dembo has posted comments on this change.
Change subject: KUDU-1856: always truncate containers when they get full
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5852/1//COMMIT_MSG
Commit Message:
PS1,
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5869
to look at the new patch set (#3).
Change subject: Add new ConnectToMaster RPC, implement client fallback
Adar Dembo has posted comments on this change.
Change subject: Add new ConnectToMaster RPC, implement client fallback
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5869
To unsubscribe, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5857
to look at the new patch set (#2).
Change subject: thirdparty: patch cmake on SLES 12 SP0 to avoid hanging
..
Todd Lipcon has posted comments on this change.
Change subject: thirdparty: patch cmake on SLES 12 SP0 to avoid hanging
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5857
To unsubscribe
Dan Burkert has posted comments on this change.
Change subject: [security] add channel binding to krpc
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5884/3/src/kudu/security/cert.cc
File
Dan Burkert has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5845
To unsubscribe, visit http
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed
..
Patch Set 5:
(6 comments)
@Todd: Thanks, I got the ASAN build working. Aside from the code
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5793/11/src/kudu/master/catalog_manager.cc
Todd Lipcon has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 15: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5793
To unsubscribe, visit
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5899
to look at the new patch set (#3).
Change subject: client: trust master's cert, adopt authn token
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5871
to look at the new patch set (#5).
Change subject: master: issue authentication tokens and CA certs to clients
Todd Lipcon has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 12:
(1 comment)
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 11:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/5793/11/src/kudu/master/master.proto
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#13).
Change subject: [master] store CA information in the system table
..
[master]
Todd Lipcon has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 11:
(1 comment)
Alexey Serbin has posted comments on this change.
Change subject: master: issue authentication tokens and CA certs to clients
..
Patch Set 4:
(4 comments)
Todd Lipcon has submitted this change and it was merged.
Change subject: [sys_catalog] make visitor's code more generic
..
[sys_catalog] make visitor's code more generic
Minor refactoring on sys_catalog.{cc,h}: the
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 16: Verified+1
I think the test failure in
Alexey Serbin has submitted this change and it was merged.
Change subject: [master] store CA information in the system table
..
[master] store CA information in the system table
The certificate authority information (private
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#12).
Change subject: [master] store CA information in the system table
..
[master]
Adar Dembo has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5793/14/src/kudu/master/catalog_manager.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#15).
Change subject: [master] store CA information in the system table
..
[master]
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5793/14/src/kudu/master/catalog_manager.cc
Adar Dembo has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 15: Code-Review+2
Looks good to me, leaving open for Todd though.
--
To view, visit http
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 11:
(1 comment)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#14).
Change subject: [master] store CA information in the system table
..
[master]
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#16).
Change subject: [master] store CA information in the system table
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5793/15/src/kudu/master/catalog_manager.cc
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5907
Change subject: KUDU-1864 Thirdparty squeasel build fails on macOS 10.12
..
KUDU-1864 Thirdparty squeasel build fails on macOS 10.12
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5805
to look at the new patch set (#14).
Change subject: [security] sign/verify data using RSA key pair
..
Alexey Serbin has posted comments on this change.
Change subject: [security] sign/verify data using RSA key pair
..
Patch Set 13:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5805/13//COMMIT_MSG
Commit Message:
PS13,
Todd Lipcon has posted comments on this change.
Change subject: [security] method to extract public part of an RSA key
..
Patch Set 14: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5783
To unsubscribe
Alexey Serbin has posted comments on this change.
Change subject: [security] do actual token signing/verification
..
Patch Set 11: Verified+1
Unrelated breakage:
19:15:06 CMake Error at CMakeLists.txt:917 (find_package):
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5849
to review the following change.
Change subject: [security] Add negotiation test with TLS + GSSAPI
..
[security] Add
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5852
to review the following change.
Change subject: KUDU-1856: always truncate containers when they get full
..
KUDU-1856
Todd Lipcon has posted comments on this change.
Change subject: [security] do actual token signing/verification
..
Patch Set 11:
I think I blew away the workspace that was causing that error (it bit me on a
couple builds too)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5812
to look at the new patch set (#11).
Change subject: [security] do actual token signing/verification
..
[security]
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5808
to look at the new patch set (#5).
Change subject: WIP: tls: hook up internal PKI system to TlsContext
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1856: always truncate containers when they get full
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5852/1//COMMIT_MSG
Commit Message:
Alexey Serbin has posted comments on this change.
Change subject: tls: hook up internal PKI system to TlsContext
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5808/2/src/kudu/security/tls_context.cc
File
Todd Lipcon has posted comments on this change.
Change subject: tls: move setting of verification modes into TlsHandshake
..
Patch Set 2:
I've got this rebased on top of Alexey's change that moves everything to new
files,
Todd Lipcon has submitted this change and it was merged.
Change subject: Upgrade Snappy to 1.1.4
..
Upgrade Snappy to 1.1.4
In my random perusal of github, I noticed that we are a few point
releases out of date on Snappy. The
Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5843
to review the following change.
Change subject: [security] avoid crashing when importing invalid TSKs
Alexey Serbin has posted comments on this change.
Change subject: tls: move setting of verification modes into TlsHandshake
..
Patch Set 1:
(1 comment)
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5783
to look at the new patch set (#14).
Change subject: [security] method to extract public part of an RSA key
Alexey Serbin has posted comments on this change.
Change subject: [security] method to extract public part of an RSA key
..
Patch Set 13:
(2 comments)
Dan Burkert has posted comments on this change.
Change subject: [security] avoid crashing when importing invalid TSKs
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5843/1/src/kudu/security/token-test.cc
Alexey Serbin has posted comments on this change.
Change subject: [security] avoid crashing when importing invalid TSKs
..
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5843/1/src/kudu/security
Alexey Serbin has submitted this change and it was merged.
Change subject: [security] sign/verify data using RSA key pair
..
[security] sign/verify data using RSA key pair
Added functionality to make a signature of a data
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5853
to review the following change.
Change subject: openssl_util: avoid non-POD vector in static storage
Dan Burkert has posted comments on this change.
Change subject: [security] sign/verify data using RSA key pair
..
Patch Set 13:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5805/13//COMMIT_MSG
Commit Message:
PS13, Line
Dan Burkert has posted comments on this change.
Change subject: [security] do actual token signing/verification
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc
Alexey Serbin has posted comments on this change.
Change subject: [security] avoid crashing when importing invalid TSKs
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5843/1/src/kudu/security/token-test.cc
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5845
to review the following change.
Change subject: Allow configuring TlsContext with key wrappers
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5808
to look at the new patch set (#3).
Change subject: WIP: tls: hook up internal PKI system to TlsContext
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5844
to review the following change.
Change subject: Extract a static function to generate a self-signed CA
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5839
to look at the new patch set (#3).
Change subject: tls: move setting of verification modes into TlsHandshake
Todd Lipcon has submitted this change and it was merged.
Change subject: [security] method to extract public part of an RSA key
..
[security] method to extract public part of an RSA key
Added a method to get the public part of
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5846
to review the following change.
Change subject: security: simplify CertSigner interface
..
security
Alexey Serbin has submitted this change and it was merged.
Change subject: [security] introduced crypto-test
..
[security] introduced crypto-test
The new crypto-test module is for test scenarios involving common
non-CA crypto
Todd Lipcon has posted comments on this change.
Change subject: Extract a static function to generate a self-signed CA
..
Patch Set 1:
(1 comment)
Alexey Serbin has submitted this change and it was merged.
Change subject: [security] avoid crashing when importing invalid TSKs
..
[security] avoid crashing when importing invalid TSKs
Kudu typically tries to avoid crashing
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5812
to look at the new patch set (#10).
Change subject: [security] do actual token signing/verification
..
[security]
Todd Lipcon has posted comments on this change.
Change subject: [security] do actual token signing/verification
..
Patch Set 11: Code-Review+2
(3 comments)
Just a couple nits, feel free to commit after fixing.
http
Alexey Serbin has posted comments on this change.
Change subject: [security] do actual token signing/verification
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc
Hello Dan Burkert, Alexey Serbin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5844
to look at the new patch set (#2).
Change subject: Extract a static function to generate a self-signed CA
Hello Dan Burkert, Alexey Serbin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5846
to look at the new patch set (#2).
Change subject: security: simplify CertSigner interface
..
Todd Lipcon has posted comments on this change.
Change subject: security: simplify CertSigner interface
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5846/2/src/kudu/security/ca/cert_management-test.cc
File
Todd Lipcon has posted comments on this change.
Change subject: [security] Add negotiation test with TLS + GSSAPI
..
Patch Set 1:
Just in case you missed it on slack, here's what I said:
> @dan my patch as it is doesn't fix
Dan Burkert has posted comments on this change.
Change subject: [security] method to extract public part of an RSA key
..
Patch Set 14: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5783
To unsubscribe
Dan Burkert has posted comments on this change.
Change subject: [security] introduced crypto-test
..
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5798
To unsubscribe, visit http
Dan Burkert has posted comments on this change.
Change subject: [security] sign/verify data using RSA key pair
..
Patch Set 14: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5805
To unsubscribe, visit http
Alexey Serbin has posted comments on this change.
Change subject: [security] do actual token signing/verification
..
Patch Set 11:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5812/11/src/kudu/security/token_signing_key.h
Hello Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5812
to look at the new patch set (#12).
Change subject: [security] do actual token signing/verification
..
[security]
Alexey Serbin has posted comments on this change.
Change subject: [security] do actual token signing/verification
..
Patch Set 12: Code-Review+2
Propagating +2 from Todd's review to this version (comment updates).
--
To view
Alexey Serbin has submitted this change and it was merged.
Change subject: [security] do actual token signing/verification
..
[security] do actual token signing/verification
Replaced temporary stub sign/verify calls with calls
Will Berkeley has posted comments on this change.
Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates
..
Patch Set 3:
(26 comments)
New tests parameterized over column encodings probably needs some
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5439
to look at the new patch set (#3).
Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates
..
901 - 1000 of 72280 matches
Mail list logo