[kudu-CR] [util] clean up on BlockingQueue

2020-06-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16063 ) Change subject: [util] clean up on BlockingQueue .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16063/1//COMMIT_MSG Co

[kudu-CR] KUDU-1802: Avoid call to master when deserializing scan tokens

2020-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16031 ) Change subject: KUDU-1802: Avoid call to master when deserializing scan tokens .. Patch Set 3: One potential concern here -- the list of

[kudu-CR] KUDU-1457 p1: krpc supports for IPv6

2020-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15996 ) Change subject: KUDU-1457 p1: krpc supports for IPv6 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15996/2/src/kudu/u

[kudu-CR] [consensus] use std::atomic in raft consensus.{cc,h}

2020-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16035 ) Change subject: [consensus] use std::atomic in raft_consensus.{cc,h} .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16

[kudu-CR] [tserver] add 'runtime' tag for scanner ttl ms

2020-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16028 ) Change subject: [tserver] add 'runtime' tag for scanner_ttl_ms .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [tserver] add 'runtime' tag for scanner ttl ms

2020-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16028 ) Change subject: [tserver] add 'runtime' tag for scanner_ttl_ms .. [tserver] add 'runtime' tag for scanner_ttl_ms The --scanner_t

[kudu-CR] KUDU-1457 p1: krpc supports for IPv6

2020-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15996 ) Change subject: KUDU-1457 p1: krpc supports for IPv6 .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/15996/2/src/kudu/

[kudu-CR] transaction: avoid locking for TransactionState::timestamp

2020-05-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15791 ) Change subject: transaction: avoid locking for TransactionState::timestamp_ .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] transaction: avoid locking for TransactionState::timestamp

2020-05-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15791 ) Change subject: transaction: avoid locking for TransactionState::timestamp_ .. transaction: avoid locking for TransactionState::t

[kudu-CR] transaction: avoid locking for TransactionState::timestamp

2020-05-27 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Hao Hao, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15791 to look at the new patch set (#5). Change subject: transaction: avoid locking for TransactionState::timestamp_

[kudu-CR] tablet: avoid locking for Tablet::state checks

2020-05-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15792 ) Change subject: tablet: avoid locking for Tablet::state checks .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15792/1/

[kudu-CR] transaction: avoid locking for TransactionState::timestamp

2020-05-27 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Hao Hao, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15791 to look at the new patch set (#2). Change subject: transaction: avoid locking for TransactionState::timestamp_

[kudu-CR] tablet: avoid locking for Tablet::state checks

2020-05-27 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15792 to look at the new patch set (#2). Change subject: tablet: avoid locking for Tablet::state checks ..

[kudu-CR] [rpc] small cleanup on RemoteMethod, RpcContext

2020-05-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15989 ) Change subject: [rpc] small cleanup on RemoteMethod, RpcContext .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[kudu-CR] Support columnar layout row format flag and result set iteration in Java client.

2020-05-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15983 ) Change subject: Support columnar layout row format flag and result set iteration in Java client. .. Patch Set 3: (1 comment) http://ge

[kudu-CR] KUDU-1865 (part 1): reduce some cross-thread allocations

2020-05-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/5905 ) Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations .. Patch Set 7: Without positive (statistically significant) per

[kudu-CR] KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread

2020-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15899 ) Change subject: KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread .. Patch Set 2: > Patch Set 1: > >

[kudu-CR] KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread

2020-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15899 ) Change subject: KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread .. Patch Set 1: One further note I

[kudu-CR] KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread

2020-05-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15899 ) Change subject: KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread .. Patch Set 1: Code-Review-1 (1 c

[kudu-CR] add a warning for insecure TrustManager

2020-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15853 ) Change subject: add a warning for insecure TrustManager .. Patch Set 1: What's this supposed to accomplish? This is an internal class, n

[kudu-CR] tablet: rename "transactions" to "ops"

2020-05-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15870 ) Change subject: tablet: rename "transactions" to "ops" .. Patch Set 1: woohoo! i'm in favor of this patch series (though I didn't look a

[kudu-CR] [master-test] added GetTableSchema() microbenchmarks

2020-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15828 ) Change subject: [master-test] added GetTableSchema() microbenchmarks .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15

[kudu-CR] Refactor rowwise serialization to calculate projection once vs per-batch

2020-04-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15805 Change subject: Refactor rowwise serialization to calculate projection once vs per-batch .. Refactor rowwise serialization to calculate p

[kudu-CR] Move rowwise serialization to a new .cc file

2020-04-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15804 Change subject: Move rowwise serialization to a new .cc file .. Move rowwise serialization to a new .cc file Change-Id: Ib6240d38fb6bdee8

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-04-24 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15801 to look at the new patch set (#3). Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct ..

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-04-24 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15802 to look at the new patch set (#3). Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena .

[kudu-CR] row serialization: dedupe string columns

2020-04-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15806 Change subject: row_serialization: dedupe string columns .. row_serialization: dedupe string columns This adds a small hashtable which av

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-04-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15802 ) Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena .. Patch Set 2: (1 comment) http://gerrit.cloudera

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-04-24 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15801 to look at the new patch set (#2). Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct ..

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-04-24 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15802 to look at the new patch set (#2). Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena .

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-04-24 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15802 to review the following change. Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena .

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-04-24 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15800 to review the following change. Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. KUDU-2844 (1/3): mak

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-04-24 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15801 to review the following change. Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct ..

[kudu-CR] tablet: set up RowSetKeyProbe fields in initialization list

2020-04-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15790 ) Change subject: tablet: set up RowSetKeyProbe fields in initialization list .. tablet: set up RowSetKeyProbe fields in initializa

[kudu-CR] tablet: set up RowSetKeyProbe fields in initialization list

2020-04-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15790 ) Change subject: tablet: set up RowSetKeyProbe fields in initialization list .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] tablet: avoid locking for Tablet::state checks

2020-04-23 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15792 to review the following change. Change subject: tablet: avoid locking for Tablet::state checks .. tablet: avoid locki

[kudu-CR] tablet: set up RowSetKeyProbe fields in initialization list

2020-04-23 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15790 to review the following change. Change subject: tablet: set up RowSetKeyProbe fields in initialization list .. tablet

[kudu-CR] transaction: avoid locking for TransactionState::timestamp

2020-04-23 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15791 to review the following change. Change subject: transaction: avoid locking for TransactionState::timestamp_ .. transa

[kudu-CR](branch-1.12.x) client: fix extra construction of ColumnSchema

2020-04-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15788 ) Change subject: client: fix extra construction of ColumnSchema .. Patch Set 1: I dunno, I think known regressions with trivial fixes sho

[kudu-CR](branch-1.12.x) client: fix extra construction of ColumnSchema

2020-04-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15788 ) Change subject: client: fix extra construction of ColumnSchema .. Patch Set 1: Hey Hao. If you haven't already cut a new RC for 1.12 I t

[kudu-CR](branch-1.12.x) client: fix extra construction of ColumnSchema

2020-04-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15788 Change subject: client: fix extra construction of ColumnSchema .. client: fix extra construction of ColumnSchema The VARCHAR patches intr

[kudu-CR] client: fix extra construction of ColumnSchema

2020-04-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15787 ) Change subject: client: fix extra construction of ColumnSchema .. client: fix extra construction of ColumnSchema The VARCHAR pat

[kudu-CR] client: fix extra construction of ColumnSchema

2020-04-22 Thread Todd Lipcon (Code Review)
Hello Attila Bukor, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15787 to review the following change. Change subject: client: fix extra construction of ColumnSchema .. client: fix extra

[kudu-CR] [mac] Fix compilation on MacOS

2020-04-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15771 ) Change subject: [mac] Fix compilation on MacOS .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15771 To

[kudu-CR] rpc: add support for passing an open file descriptor across a unix socket

2020-04-17 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Andrew Wong, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15706 to look at the new patch set (#6). Change subject: rpc: add support for passing an open file descriptor across a unix socket ...

[kudu-CR] rpc: add support for passing an open file descriptor across a unix socket

2020-04-17 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Andrew Wong, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15706 to look at the new patch set (#5). Change subject: rpc: add support for passing an open file descriptor across a unix socket ...

[kudu-CR] rpc: add support for passing an open file descriptor across a unix socket

2020-04-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15706 ) Change subject: rpc: add support for passing an open file descriptor across a unix socket .. Patch Set 4: (18 comments) http://gerrit.

[kudu-CR] WIP: support keys not at the front of a schema

2020-04-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15748 Change subject: WIP: support keys not at the front of a schema .. WIP: support keys not at the front of a schema Change-Id: I4d34776db26e

[kudu-CR] rpc: add support for passing an open file descriptor across a unix socket

2020-04-16 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15706 to look at the new patch set (#4). Change subject: rpc: add support for passing an open file descriptor across a unix socket ..

[kudu-CR] WIP/test: enable kerberos by default for all tests

2020-04-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/6217 ) Change subject: WIP/test: enable kerberos by default for all tests .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6217 To unsubscrib

[kudu-CR] tserver: add locking around an RPC's usage of a Scanner

2020-04-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15677 ) Change subject: tserver: add locking around an RPC's usage of a Scanner .. tserver: add locking around an RPC's usage of a Scanne

[kudu-CR] tserver: add locking around an RPC's usage of a Scanner

2020-04-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: tserver: add locking around an RPC's usage of a Scanner .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15677 To unsubs

[kudu-CR] tserver: add locking around an RPC's usage of a Scanner

2020-04-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15677 ) Change subject: tserver: add locking around an RPC's usage of a Scanner .. Patch Set 3: Verified+1 test was unrelaed (chrony) -- To vi

[kudu-CR] tserver: add locking around an RPC's usage of a Scanner

2020-04-16 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15677 to look at the new patch set (#3). Change subject: tserver: add locking around an RPC's usage of a Scanner .

[kudu-CR] tserver: add locking around an RPC's usage of a Scanner

2020-04-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15677 ) Change subject: tserver: add locking around an RPC's usage of a Scanner .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15701 ) Change subject: client/tserver: add support for connecting over unix domain sockets .. client/tserver: add support for connectin

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15678 ) Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization .. Avoid calling Schema::find_co

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15678 ) Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization .. Patch Set 3: Verified+1 (2 comments)

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15679 ) Change subject: columnar_serialization: avoid preallocating 8MB per column .. columnar_serialization: avoid preallocating 8MB per

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15679 ) Change subject: columnar_serialization: avoid preallocating 8MB per column .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080

[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15701 to look at the new patch set (#5). Change subject: client/tserver: add support for connecting over unix do

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15691 ) Change subject: Add basic support for UNIX domain sockets .. Patch Set 9: Code-Review+2 Forwarding Andrew's +2 -- To view, visit http:

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15678 to look at the new patch set (#2). Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization .

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15679 to look at the new patch set (#3). Change subject: columnar_serialization: avoid preallocating 8MB per column

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15678 to look at the new patch set (#3). Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization .

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15691 ) Change subject: Add basic support for UNIX domain sockets .. Add basic support for UNIX domain sockets This adds support to Sock

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, Volodymyr Verovkin, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#9). Change subject: Add basic support for UNIX domain s

[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15701 to look at the new patch set (#4). Change subject: client/tserver: add support for connecting over unix domain sock

[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15701 ) Change subject: client/tserver: add support for connecting over unix domain sockets .. Patch Set 3: (9 comments) > Patch Set 3: > > Cl

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, Volodymyr Verovkin, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#8). Change subject: Add basic support for UNIX domain s

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15691 ) Change subject: Add basic support for UNIX domain sockets .. Patch Set 7: (10 comments) http://gerrit.cloudera.org:8080/#/c/15691/7/src

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-14 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#7). Change subject: Add basic support for UNIX domain sockets .

[kudu-CR] rpc: add support for passing an open file descriptor across a unix socket

2020-04-14 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15706 to look at the new patch set (#3). Change subject: rpc: add support for passing an open file descriptor across a unix socket ..

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. net: make Sockaddr more generic for other address f

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-14 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Andrew Wong, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#6). Change subject: Add basic support for UNIX domain sockets ..

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15691 ) Change subject: Add basic support for UNIX domain sockets .. Patch Set 5: (10 comments) http://gerrit.cloudera.org:8080/#/c/15691/4/src

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-14 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Andrew Wong, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#5). Change subject: Add basic support for UNIX domain sockets ..

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-14 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15690 to look at the new patch set (#4). Change subject: net: make Sockaddr more generic for other addr

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/1571

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15716 ) Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately .. rpc: avoid an extra epoll cycle when data c

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15716 ) Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately .. Patch Set 3: Verified+1 Test failures look unrelat

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-13 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15716 to look at the new patch set (#3). Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately ..

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-13 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15716 to look at the new patch set (#2). Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately .

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-11 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15716 to review the following change. Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately ..

[kudu-CR] WIP: rpc: add support for passing an open file descriptor across a unix socket

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15706 to look at the new patch set (#2). Change subject: WIP: rpc: add support for passing an open file descriptor across a unix socket .

[kudu-CR] WIP: rpc: add support for passing an open file descriptor across a unix socket

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15706 to review the following change. Change subject: WIP: rpc: add support for passing an open file descriptor across a unix socket .

[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15701 to look at the new patch set (#2). Change subject: client/tserver: add support for connecting over unix domain sockets ...

[kudu-CR] Add basic support for unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#4). Change subject: Add basic support for unix domain sockets ...

[kudu-CR] Use unix domain socket for local client/server communication

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/957 ) Change subject: Use unix domain socket for local client/server communication .. Abandoned took a new approach of this here: https://gerrit.cloudera.

[kudu-CR] Add basic support for unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#3). Change subject: Add basic support for unix domain sockets ...

[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15701 to review the following change. Change subject: client/tserver: add support for connecting over unix domain sockets .

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15690 to look at the new patch set (#3). Change subject: net: make Sockaddr more generic for other address families

[kudu-CR] Add basic support for unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#2). Change subject: Add basic support for unix domain sockets .

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:808

[kudu-CR] WIP: Remove limit on number of sidecar slices

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/5895 ) Change subject: WIP: Remove limit on number of sidecar slices .. Abandoned I ended up implementing this in a4b28812f43e6b8a85e1d61b48a2dbba70d56d1b

[kudu-CR] WIP: Add basic support for unix sockets

2020-04-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15691 Change subject: WIP: Add basic support for unix sockets .. WIP: Add basic support for unix sockets so far can't seem to reproduce any rea

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15690 to look at the new patch set (#2). Change subject: net: make Sockaddr more generic for other address families ...

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15690 to review the following change. Change subject: net: make Sockaddr more generic for other address families .

<    1   2   3   4   5   6   7   8   9   10   >