[kudu-CR] Fix typo in ASAN cmake command

2018-12-14 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12098 ) Change subject: Fix typo in ASAN cmake command .. Removed reviewer Kudu Jenkins. -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] [webui] drop 'Last status' column for tombstoned tablets

2018-12-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11972 ) Change subject: [webui] drop 'Last status' column for tombstoned tablets .. Patch Set 1: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] [webui] drop 'Last status' column for tombstoned tablets

2018-12-14 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11972 ) Change subject: [webui] drop 'Last status' column for tombstoned tablets .. [webui] drop 'Last status' column for tombstoned ta

[kudu-CR] KUDU-2618 Factor the amount of data into time-based flush decisions

2018-12-06 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12048 Change subject: KUDU-2618 Factor the amount of data into time-based flush decisions .. KUDU-2618 Factor the amount of data into time-ba

[kudu-CR] [tools] ksck output could be filtered by sections

2018-12-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12038 ) Change subject: [tools] ksck output could be filtered by sections .. Patch Set 1: (13 comments) Thanks for posting this! It looks goo

[kudu-CR] [test] Break up test output per test case.

2018-12-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12031 ) Change subject: [test] Break up test output per test case. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] [test] Break up test output per test case.

2018-12-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12031 ) Change subject: [test] Break up test output per test case. .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12031/1//

[kudu-CR] [tools] Add tool to dump memtrackers

2018-11-29 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11975 ) Change subject: [tools] Add tool to dump memtrackers .. [tools] Add tool to dump memtrackers This adds a new tool, `kudu diagn

[kudu-CR] [tools] Add tool to dump memtrackers

2018-11-29 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11975 to look at the new patch set (#5). Change subject: [tools] Add tool to dump memtrackers

[kudu-CR] [tools] Add tool to dump memtrackers

2018-11-29 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11975 to look at the new patch set (#4). Change subject: [tools] Add tool to dump memtrackers

[kudu-CR] [WIP] [tools] ksck auto-repair

2018-11-29 Thread Will Berkeley (Code Review)
Will Berkeley has abandoned this change. ( http://gerrit.cloudera.org:8080/10648 ) Change subject: [WIP] [tools] ksck auto-repair .. Abandoned This has stopped being a significant problem in later versions. -- To view, visit h

[kudu-CR] [tools] Add tool to dump memtrackers

2018-11-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11975 ) Change subject: [tools] Add tool to dump memtrackers .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/11975/3/src/kud

[kudu-CR] [tools] Add tool to dump memtrackers

2018-11-27 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11975 to look at the new patch set (#3). Change subject: [tools] Add tool to dump memtrackers ..

[kudu-CR] [tools] Add a tool to recover master data from tablet servers

2018-11-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9490 ) Change subject: [tools] Add a tool to recover master data from tablet servers .. Patch Set 4: Oh also this needs to be tested against a

[kudu-CR] [tools] Add a tool to recover master data from tablet servers

2018-11-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9490 ) Change subject: [tools] Add a tool to recover master data from tablet servers .. Patch Set 4: I'm looking at this again because I actua

[kudu-CR] [tools] Add tool to dump memtrackers

2018-11-27 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11975 to look at the new patch set (#2). Change subject: [tools] Add tool to dump memtrackers ..

[kudu-CR] [tools] Add tool to dump memtrackers

2018-11-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11975 ) Change subject: [tools] Add tool to dump memtrackers .. Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/11975/1/src/ku

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-26 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. [compaction] KUDU-1

[kudu-CR] [webui] fixed build and corrected a typo

2018-11-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 ) Change subject: [webui] fixed build and corrected a typo .. Patch Set 5: > No problem -- I submitted a small update, cleaning up a few

[kudu-CR] [webui] fixed build and corrected a typo

2018-11-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 ) Change subject: [webui] fixed build and corrected a typo .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] [webui] fixed build and corrected a typo

2018-11-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 ) Change subject: [webui] fixed build and corrected a typo .. Patch Set 4: Uh oh. I didn't mean to upload a new patch set for this. I te

[kudu-CR] [webui] fixed build and corrected a typo

2018-11-21 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#4) to the change originally created by Alexey Serbin. ( http://gerrit.cloudera.org:8080/11973 ) Change subject: [webui] fixed build and corrected a typo .. [webui] fixed build and cor

[kudu-CR] [tools] Add tool to dump memtrackers

2018-11-21 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11975 Change subject: [tools] Add tool to dump memtrackers .. [tools] Add tool to dump memtrackers This adds a new tool, `kudu diagnose dump_

[kudu-CR] [webui] fixed build and corrected a typo

2018-11-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 ) Change subject: [webui] fixed build and corrected a typo .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] [webui] fixed build and corrected a typo

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 ) Change subject: [webui] fixed build and corrected a typo .. Patch Set 1: Code-Review+2 I removed those because IWYU told me to. -.-

[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11968 ) Change subject: [webui] Fancy table for /mem-trackers and sortable tables .. [webui] Fancy table for /mem-trackers and sortable

[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables

2018-11-20 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11968 to look at the new patch set (#3). Change subject: [webui] Fancy table for /mem-trackers and sortable tables .

[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables

2018-11-20 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11968 to look at the new patch set (#2). Change subject: [webui] Fancy table for /mem-trackers and sortable tables .

[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11968 ) Change subject: [webui] Fancy table for /mem-trackers and sortable tables .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:808

[kudu-CR] [docs] note on unavailable tservers during rebalancing

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11966 ) Change subject: [docs] note on unavailable tservers during rebalancing .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] [docs] note on unavailable tservers during rebalancing

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11966 ) Change subject: [docs] note on unavailable tservers during rebalancing .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#

[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11968 Change subject: [webui] Fancy table for /mem-trackers and sortable tables .. [webui] Fancy table for /mem-trackers and sortable tables

[kudu-CR] [docs] Add note that it is safe to stop and restart the rebalancer

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11963 ) Change subject: [docs] Add note that it is safe to stop and restart the rebalancer .. [docs] Add note that it is safe to stop

[kudu-CR] [docs] Add note that it is safe to stop and restart the rebalancer

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11963 ) Change subject: [docs] Add note that it is safe to stop and restart the rebalancer .. Patch Set 1: Verified+1 Doc-only change so givi

[kudu-CR] [docs] Add note that it is safe to stop and restart the rebalancer

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11963 ) Change subject: [docs] Add note that it is safe to stop and restart the rebalancer .. Removed reviewer Kudu Jenkins. -- To vie

[kudu-CR] [docs] Add note that it is safe to stop and restart the rebalancer

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11963 Change subject: [docs] Add note that it is safe to stop and restart the rebalancer .. [docs] Add note that it is safe to stop and resta

[kudu-CR] [tools] Don't count tombstoned replicas in `kudu remote replica check`

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11962 ) Change subject: [tools] Don't count tombstoned replicas in `kudu remote_replica check` .. [tools] Don't count tombstoned repli

[kudu-CR] [tools] ksck: Add information about replica counts to plain ksck output

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11958 ) Change subject: [tools] ksck: Add information about replica counts to plain ksck output .. [tools] ksck: Add information about

[kudu-CR] [tools] ksck: Add information about replica counts to plain ksck output

2018-11-20 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11958 to look at the new patch set (#4). Change subject: [tools] ksck: Add information about replica counts

[kudu-CR] [tools] ksck: Add information about replica counts to plain ksck output

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11958 ) Change subject: [tools] ksck: Add information about replica counts to plain ksck output .. Patch Set 3: (1 comment) http://gerrit.cl

[kudu-CR] [tools] Don't count tombstoned replicas in `kudu remote replica check`

2018-11-20 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11962 Change subject: [tools] Don't count tombstoned replicas in `kudu remote_replica check` .. [tools] Don't count tombstoned replicas in `k

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 4: (1 comment)

[kudu-CR] [tools] ksck: Add information about replica counts to plain ksck output

2018-11-19 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11958 to look at the new patch set (#3). Change subject: [tools] ksck: Add information about replica counts

[kudu-CR] [tools] ksck: Add information about replica counts to plain ksck output

2018-11-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11958 ) Change subject: [tools] ksck: Add information about replica counts to plain ksck output .. Patch Set 1: (4 comments) http://gerrit.c

[kudu-CR] [tools] ksck: Add information about replica counts to plain ksck output

2018-11-19 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11958 to look at the new patch set (#2). Change subject: [tools] ksck: Add information about replica counts

[kudu-CR] [util] more information on fault injection

2018-11-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11960 ) Change subject: [util] more information on fault injection .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] [tools] ksck: Add information about replica counts to plain ksck output

2018-11-19 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11958 Change subject: [tools] ksck: Add information about replica counts to plain ksck output .. [tools] ksck: Add information about replica

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-16 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11869 to look at the new patch set (#5). Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 4: (14 comments)

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 ) Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Patch Set 2: > Do I understand correctly that l

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-07 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11885 ) Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Limit number of rowsets in compaction se

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 ) Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Patch Set 2: > Where did that 256KB figure come

[kudu-CR] [rebalancer] location-aware rebalancer (part 9/n)

2018-11-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11862 ) Change subject: [rebalancer] location-aware rebalancer (part 9/n) .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR] [tools] reference comparison mode for rebalancing algo tests

2018-11-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11870 ) Change subject: [tools] reference comparison mode for rebalancing algo tests .. Patch Set 3: Code-Review+2 -- To view, visit http://g

[kudu-CR] Disable rowset compaction in TestUndoDeltaBlockGc

2018-11-06 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11884 ) Change subject: Disable rowset compaction in TestUndoDeltaBlockGc .. Disable rowset compaction in TestUndoDeltaBlockGc In a fo

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 ) Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Patch Set 2: Todd mentioned offline that it mig

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-06 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11885 to look at the new patch set (#2). Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 ) Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Patch Set 1: (1 comment) http://gerrit.clouder

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 ) Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Patch Set 1: (2 comments) http://gerrit.cloude

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-05 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11885 Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Limit number of rowsets in compaction selection t

[kudu-CR] Disable rowset compaction in TestUndoDeltaBlockGc

2018-11-05 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11884 Change subject: Disable rowset compaction in TestUndoDeltaBlockGc .. Disable rowset compaction in TestUndoDeltaBlockGc In a follow-up t

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 3: > I'm not sur

[kudu-CR] Add TS UUID to alter table-randomized-test "restart TS" step

2018-11-05 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11877 ) Change subject: Add TS UUID to alter_table-randomized-test "restart TS" step .. Add TS UUID to alter_table-randomized-test "res

[kudu-CR] Add TS UUID to alter table-randomized-test "restart TS" step

2018-11-05 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11877 Change subject: Add TS UUID to alter_table-randomized-test "restart TS" step .. Add TS UUID to alter_table-randomized-test "restart TS"

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 3: The alter tab

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 3: I'm not sure

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 3: > I need to

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 3: The tablet hi

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 3: (1 comment)

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11869 to look at the new patch set (#3). Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11869 to look at the new patch set (#2). Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11869 Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. [compaction] KUDU-1400: Impr

[kudu-CR] [examples] Add basic Spark example (scala)

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 12: Code-Review+1 LGTM -- To view, visit http://gerrit.cloud

[kudu-CR] [examples] Add basic Spark example (scala)

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 11: (9 comments) http://gerrit.cloudera.org:8080/#/c/11788/11

[kudu-CR] [rebalancer] location-aware rebalancer (part 9/n)

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11862 ) Change subject: [rebalancer] location-aware rebalancer (part 9/n) .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11827 ) Change subject: [compaction] Cleanup of compaction policy code .. [compaction] Cleanup of compaction policy code I'm reading o

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11827 ) Change subject: [compaction] Cleanup of compaction policy code .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11827/

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-02 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11827 to look at the new patch set (#6). Change subject: [compaction] Cleanup of compaction policy code

[kudu-CR] [examples] Add basic Spark example (scala)

2018-11-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 10: (15 comments) I tested this locally with a multimaster cl

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11827 to look at the new patch set (#5). Change subject: [compaction] Cleanup of compaction policy code

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11827 to look at the new patch set (#4). Change subject: [compaction] Cleanup of compaction policy code

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11827 ) Change subject: [compaction] Cleanup of compaction policy code .. Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/1182

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-31 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11748 ) Change subject: [rebalancer] location-aware rebalancer (part 7/n) .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)

2018-10-31 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)

2018-10-31 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-31 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11748 ) Change subject: [rebalancer] location-aware rebalancer (part 7/n) .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-10-31 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11827 to look at the new patch set (#3). Change subject: [compaction] Cleanup of compaction policy code

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-10-31 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11827 to look at the new patch set (#2). Change subject: [compaction] Cleanup of compaction policy code

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-30 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. [location_awareness] Add location info in ksck report

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-10-30 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11827 Change subject: [compaction] Cleanup of compaction policy code .. [compaction] Cleanup of compaction policy code I'm reading over the c

[kudu-CR] Stop using client-test-util in tools

2018-10-30 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11821 ) Change subject: Stop using client-test-util in tools .. Stop using client-test-util in tools The `kudu hms` and `kudu table` t

[kudu-CR] Stop using client-test-util in tools

2018-10-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11821 ) Change subject: Stop using client-test-util in tools .. Patch Set 4: IWYU -.- -- To view, visit http://gerrit.cloudera.org:8080/1182

[kudu-CR] Stop using client-test-util in tools

2018-10-30 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11821 to look at the new patch set (#5). Change subject: Stop using client-test-util in tools ...

[kudu-CR] Stop using client-test-util in tools

2018-10-30 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11821 to look at the new patch set (#4). Change subject: Stop using client-test-util in tools ...

[kudu-CR] Stop using client-test-util in tools

2018-10-30 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11821 to look at the new patch set (#3). Change subject: Stop using client-test-util in tools ...

[kudu-CR] Stop using client-test-util in tools

2018-10-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11821 ) Change subject: Stop using client-test-util in tools .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11821/2/src/kud

[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.or

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11748 ) Change subject: [rebalancer] location-aware rebalancer (part 7/n) .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR] [rebalancer] location-aware rebalancer (part 6/n)

2018-10-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11747 ) Change subject: [rebalancer] location-aware rebalancer (part 6/n) .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloud

<    2   3   4   5   6   7   8   9   10   11   >