[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11360 to look at the new patch set (#6). Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list".

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-05 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11360 to look at the new patch set (#8). Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list".

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and discard string copying while querying

2018-09-07 Thread helifu (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11381 to look at the new patch set (#4). Change subject: KUDU-2566: Enhance rowset tree pruning and discard string copying while querying

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and discard string copying while querying

2018-09-06 Thread helifu (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11381 to look at the new patch set (#3). Change subject: KUDU-2566: Enhance rowset tree pruning and discard string copying while querying

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and discard string copying while querying

2018-09-07 Thread helifu (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11381 to look at the new patch set (#5). Change subject: KUDU-2566: Enhance rowset tree pruning and discard string copying while querying

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and stop coping string while querying

2018-09-09 Thread helifu (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11381 to look at the new patch set (#6). Change subject: KUDU-2566: Enhance rowset tree pruning and stop coping string while querying

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and stop copying strings

2018-09-10 Thread helifu (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11381 to look at the new patch set (#7). Change subject: KUDU-2566: Enhance rowset tree pruning and stop copying strings

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and stop copying strings

2018-09-10 Thread helifu (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11381 to look at the new patch set (#8). Change subject: KUDU-2566: Enhance rowset tree pruning and stop copying strings

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-04 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11360 to look at the new patch set (#7). Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list".

[kudu-CR] KUDU-2529 add a "-tables=" flag to the "kudu table list".

2018-08-30 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11360 Change subject: KUDU-2529 add a "-tables=" flag to the "kudu table list". .. KUDU-2529 add a "-tables=" flag to the "kudu table list".

[kudu-CR](branch-1.4.x) * two improvements: 1) support open-ended intervals; 2) end up fetching one more rowset for the upper bound which is exclusive;

2018-07-10 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10917 Change subject: * two improvements: 1) support open-ended intervals; 2) end up fetching one more rowset for the upper bound which is exclusive;

[kudu-CR](branch-1.4.x) * two improvements: 1) support open-ended intervals; 2) end up fetching one more rowset for the upper bound which is exclusive;

2018-07-10 Thread helifu (Code Review)
helifu has abandoned this change. ( http://gerrit.cloudera.org:8080/10917 ) Change subject: * two improvements: 1) support open-ended intervals; 2) end up fetching one more rowset for the upper bound which is exclusive; ..

[kudu-CR] KUDU-2038: Support bitmap indexing

2018-10-19 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11722 to look at the new patch set (#2). Change subject: KUDU-2038: Support bitmap indexing ..

[kudu-CR] KUDU-2038: Support bitmap indexing

2018-10-18 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11722 Change subject: KUDU-2038: Support bitmap indexing .. KUDU-2038: Support bitmap indexing One DRS has a set of bitmap info independently, one

[kudu-CR] KUDU-2038: Support bitmap indexing

2018-10-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/11722 ) Change subject: KUDU-2038: Support bitmap indexing .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11722/1//COMMIT_MSG

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and stop copying strings

2018-10-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/11381 ) Change subject: KUDU-2566: Enhance rowset tree pruning and stop copying strings .. Patch Set 9: (47 comments) thanks to Adar and Will.

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-10-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/11360 ) Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list". .. Patch Set 9: (17 comments) sorry for the late reply, i

[kudu-CR] KUDU-2038: Support bitmap index

2018-11-13 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11722 to look at the new patch set (#5). Change subject: KUDU-2038: Support bitmap index ..

[kudu-CR] KUDU-2038: Support bitmap index

2018-11-13 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11722 to look at the new patch set (#3). Change subject: KUDU-2038: Support bitmap index ..

[kudu-CR] KUDU-2038: Support bitmap index

2018-11-13 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11722 to look at the new patch set (#4). Change subject: KUDU-2038: Support bitmap index ..

[kudu-CR] KUDU-2038: Support bitmap index

2018-11-13 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11722 to look at the new patch set (#6). Change subject: KUDU-2038: Support bitmap index ..

[kudu-CR] KUDU-2038: Support bitmap index

2018-11-13 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/11722 ) Change subject: KUDU-2038: Support bitmap index .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/11722/1//COMMIT_MSG Commit

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11360 to look at the new patch set (#5). Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list".

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-08-31 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11373 Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list". .. KUDU-2529: Add a "-tables=" flag to the "kudu table list".

[kudu-CR] KUDU-2529 add a "-tables=" flag to the "kudu table list".

2018-08-31 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11360 to look at the new patch set (#2). Change subject: KUDU-2529 add a "-tables=" flag to the "kudu table list".

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-02 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11360 to look at the new patch set (#4). Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list".

[kudu-CR] KUDU-2529 add a "-tables=" flag to the "kudu table list".

2018-09-02 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11360 to look at the new patch set (#3). Change subject: KUDU-2529 add a "-tables=" flag to the "kudu table list".

[kudu-CR] KUDU-2566:

2018-09-03 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11381 Change subject: KUDU-2566: .. KUDU-2566: two improvements: 1) support open-ended intervals; 2) end up fetching one more rowset for the upper

[kudu-CR] KUDU-2566: fix two todo list

2018-09-04 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11381 to look at the new patch set (#2). Change subject: KUDU-2566: fix two todo list .. KUDU-2566: fix two

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-05 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#8). Change subject: KUDU-2636: LBM supports deleting dead and full containers

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-04 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 4: (1 comment)

[kudu-CR] [fs]: LBM moves half-present containers out of the way

2019-01-20 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12239 ) Change subject: [fs]: LBM moves half-present containers out of the way .. Patch Set 1: (6 comments)

[kudu-CR] [fs]: delete the (orphaned) metadata file when repairing

2019-01-21 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12239 to look at the new patch set (#2). Change subject: [fs]: delete the (orphaned) metadata file when repairing

[kudu-CR] [fs]: delete the (orphaned) metadata file when repairing

2019-01-21 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12239 to look at the new patch set (#3). Change subject: [fs]: delete the (orphaned) metadata file when repairing

[kudu-CR] [fs]: LBM moves half-present containers out of the way

2019-01-20 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12239 ) Change subject: [fs]: LBM moves half-present containers out of the way .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. Patch Set 1: (1 comment)

[kudu-CR] [fs]: delete the (orphaned) metadata file when repairing

2019-01-22 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12239 to look at the new patch set (#4). Change subject: [fs]: delete the (orphaned) metadata file when repairing

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. Patch Set 1: Code-Review+1 Reread the ThreadPool code, it seems that

[kudu-CR] KUDU-2665: deflake block manager-stress-test

2019-01-22 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12254 ) Change subject: KUDU-2665: deflake block_manager-stress-test .. Patch Set 1: my preference 2) is not safe because we can't be sure when the

[kudu-CR] [fs]: delete the (orphaned) metadata file when repairing

2019-01-23 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12239 ) Change subject: [fs]: delete the (orphaned) metadata file when repairing .. Patch Set 4: (12 comments)

[kudu-CR] [fs]: delete the (orphaned) metadata file when repairing

2019-01-23 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12239 to look at the new patch set (#5). Change subject: [fs]: delete the (orphaned) metadata file when repairing

[kudu-CR] [fs]: delete the (orphaned) metadata file when repairing

2019-01-23 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12239 ) Change subject: [fs]: delete the (orphaned) metadata file when repairing .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-12 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 1: (3 comments) Thanks for your comments.@adar

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-12 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#2). Change subject: KUDU-2636: LBM supports deleting dead and full containers

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-12 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12075 Change subject: KUDU-2636: LBM supports deleting dead and full containers .. KUDU-2636: LBM supports deleting dead and full containers LBM

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-17 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 4: (6 comments)

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-18 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#5). Change subject: KUDU-2636: LBM supports deleting dead and full containers

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-18 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-18 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-21 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#7). Change subject: KUDU-2636: LBM supports deleting dead and full containers

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2018-12-26 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12121 to look at the new patch set (#2). Change subject: [fs]: wrapping up containers in scoped_refptr .. [fs]: wrapping

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2018-12-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 3: I compiled the kudu code on debian 8.9 locally, and the unit

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-13 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#3). Change subject: KUDU-2636: LBM supports deleting dead and full containers

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-13 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-17 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#4). Change subject: KUDU-2636: LBM supports deleting dead and full containers

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-17 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 3: (11 comments) thanks for your detailed comments.

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-08 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 6: Here is a tserver node of our online cluster, and it has been

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-08 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 11: (3 comments) Thank you very much :) And here are

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-09 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#13). Change subject: KUDU-2636: LBM supports deleting dead and full containers

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-09 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 12: (6 comments)

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-10 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 13: Wow, ASAN fails again. -- To view, visit

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-10 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#14). Change subject: KUDU-2636: LBM supports deleting dead containers

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-07 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12121 to look at the new patch set (#5). Change subject: [fs]: wrapping up containers in scoped_refptr

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-07 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#10). Change subject: KUDU-2636: LBM supports deleting dead and full containers

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-07 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 4: (1 comment)

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12121 to look at the new patch set (#4). Change subject: [fs]: wrapping up containers in scoped_refptr ..

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-04 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-10 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 14: (2 comments)

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-10 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#15). Change subject: KUDU-2636: LBM supports deleting dead containers

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 15: I'm sorry to have omitted this case! :( -- To view,

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#16). Change subject: KUDU-2636: LBM supports deleting dead containers

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 15: All the tests passed locally except ASAN. Failing on an

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 17: (1 comment)

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#18). Change subject: KUDU-2636: LBM supports deleting dead containers

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#17). Change subject: KUDU-2636: LBM supports deleting dead containers

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-09 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 11: All right, calling 'SyncDir()' has been removed.

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-09 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#12). Change subject: KUDU-2636: LBM supports deleting dead and full containers

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-18 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 5: (5 comments)

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-18 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#6). Change subject: KUDU-2636: LBM supports deleting dead and full containers

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-19 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 6: (11 comments) There are more than one LogBlock

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-19 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 6: maybe that is not enough. please take a look at

[kudu-CR] java: ColumnSchema supports storing column comment

2019-04-02 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java: ColumnSchema supports storing column comment .. Patch Set 1: (14 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-02 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#2). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-02 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 2: (3 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#3). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 4: Sorry for quickly retriggering the builder :( -- To

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#4). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 4: (3 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#6). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#5). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] KUDU-2750: Add create and alter timestamp to tables

2019-03-25 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12842 ) Change subject: KUDU-2750: Add create and alter timestamp to tables .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-25 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12849 Change subject: KUDU-1711: ColumnSchema supports storing column comment .. KUDU-1711: ColumnSchema supports storing column comment This patch

[kudu-CR] KUDU-2750: Add create and alter timestamp to tables

2019-03-25 Thread helifu (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12842 to look at the new patch set (#2). Change subject: KUDU-2750: Add create and alter timestamp to tables

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#4). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#5). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-26 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 1: (10 comments) @adar,the table will be created

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-26 Thread helifu (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#2). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-26 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#3). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-26 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 2: (1 comment) ok, let me try again.

  1   2   3   4   >