[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Cleanup/refactor tracking of consensus watermarks .. Cleanup/refactor tracking of consensus watermarks This is a fairly invasive cleanup/refactor to conse

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 8: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/3267/ -- To view, visit http://g

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4133 To unsubscribe, visit http:/

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4133 to look at the new patch set (#8). Change subject: Cleanup/refactor tracking of consensus watermarks ..

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/3266/ -- To view, visit http://gerrit.clou

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 7: Code-Review+1 (1 comment) lgtm, just a syntax nit http://gerrit.cloudera.org:8080/#/c/4133/7/src

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4133 To unsubscribe, vis

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4133/7/src/kudu/consensus/consensus_queu

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4133/7/src/kudu/consensus/consensus_queue.cc Fil

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4133/6/src/kudu/consensus/consensus_que

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3257/ -- To view, visit http://gerrit.clou

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4133 to look at the new patch set (#7). Change subject: Cleanup/refactor tracking of consensus watermarks ..

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/4133/6/src/kudu/consensus/consensus_queue.cc Fi

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/4133/6/src/kudu/consensus/consensus_que

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3252/ -- To view, visit http://gerrit.clou

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-06 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4133 to look at the new patch set (#6). Change subject: Cleanup/refactor tracking of consensus watermarks ..

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4133/5/src/kudu/consensus/consensus_queue.cc Fi

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/4133/5//COMMIT_MSG Commit Message: Line 45: Th

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/4133/5//COMMIT_MSG Commit Message: Line 45: The

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4133 To unsubscribe, vis

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/4133/4/src/kudu/consensus/consensus_que

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-08-31 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4133 to look at the new patch set (#5). Change subject: Cleanup/refactor tracking of consensus watermarks .. Cleanup/ref

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3183/ -- To view, visit http://gerrit.clou

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-08-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 4: (23 comments) http://gerrit.cloudera.org:8080/#/c/4133/4/src/kudu/consensus/consensus.proto File

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-08-31 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 4: (17 comments) http://gerrit.cloudera.org:8080/#/c/4133/4/src/kudu/consensus/consensus_qu

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-08-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 4: (4 comments) I am still working my way through this patch. There are several TODOs, not sure if

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-08-29 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4133 to look at the new patch set (#4). Change subject: Cleanup/refactor tracking of consensus watermarks .. Cleanup/ref

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3145/ -- To view, visit http://gerrit.clou