[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 12: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. [metrics] Merge metrics by the same attribute This patch merge m

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-15 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#12). Change subject: [metrics] Merge metrics by the same attribute ..

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/13580/

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-15 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#11). Change subject: [metrics] Merge metrics by the same attribute ..

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 10: > It'd be great to get another review from someone more fa

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 10: (4 comments) It'd be great to get another review from som

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/c/13580/

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-12 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#10). Change subject: [metrics] Merge metrics by the same attribute ...

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 9: (9 comments) Mostly cosmetic feedback from me. http://ge

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 9: Anybody help to review this patch? -- To view, visit ht

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-13 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#9). Change subject: [metrics] Merge metrics by the same attribute

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c/13580/8

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/13580/8/sr

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 8: (8 comments) http://gerrit.cloudera.org:8080/#/c/13580/8/s

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-12 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#8). Change subject: [metrics] Merge metrics by the same attribute

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-12 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#7). Change subject: [metrics] Merge metrics by the same attribute

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/13580/6

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/13580/6/s

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-11 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 6: (37 comments) http://gerrit.cloudera.org:8080/#/c/13580/

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-11 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#6). Change subject: [metrics] Merge metrics by the same attribute

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 5: (37 comments) I didn't review metrics-test.cc yet. http:/

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-06-22 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/13580/4

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-06-22 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#5). Change subject: [metrics] Merge metrics by the same attribute

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-06-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 4: (8 comments) Didn't review the whole thing yet, but left

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-06-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 4: Verified+1 Unrelated flake: TestLeaderStepDown.TestLeaderS

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-06-14 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [metrics] Merge metrics by the same attribute .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13580 To unsubscribe, vis

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-06-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13580/3

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-06-13 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#4). Change subject: [metrics] Merge metrics by the same attribute