[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-30 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. KUDU-1755 Part 1: Improve tablet on disk size metric This adds bloomfile, ad hoc index, and

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6967 To unsubscribe, visit

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#9). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6967/7/src/kudu/tablet/tablet_metadata.cc

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6967/7/src/kudu/tablet/tablet_metadata.cc

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/6967/6/src/kudu/tablet/cfile_set.h File

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#8). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 7: Code-Review+1 (1 comment)

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/6967/6/src/kudu/tablet/cfile_set.h File

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-26 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#7). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 6: Unrelated failure in spark tests. I'm looking into the failure. -- To view, visit

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6967/5/src/kudu/tablet/rowset.h File

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#6). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#5). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ..

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/6967/4/src/kudu/tablet/cfile_set.cc File

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 4: (14 comments) http://gerrit.cloudera.org:8080/#/c/6967/4/src/kudu/tablet/cfile_set.cc File

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 3: Actually I'm switching to "Tablet total size on disk" and "Tablet data size on disk" --

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#3). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ..

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 2: > Also, I wonder if we shouldn't introduce an additional metric which > would capture

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 2: (4 comments) I changed the names to - Remove the word "Estimate" because they aren't

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 2: Also, I wonder if we shouldn't introduce an additional metric which would capture these

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 2: (4 comments) I sort of have a problem with referring to it as "compaction size" because

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-24 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#2). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ..

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-23 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. Patch Set 1: I just want a Jenkins run. -- To view, visit http://gerrit.cloudera.org:8080/6967 To

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-23 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/6967 Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric .. KUDU-1755 Part 1: Improve tablet on disk size metric This adds