[kudu-CR] Do not run (g)addr2line translator on MacOS X

Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3360 to look at the new patch set (#2). Change subject: Do not run (g)addr2line translator on MacOS X .. Do

[kudu-CR] Do not run (g)addr2line translator on MacOS X

Alexey Serbin has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 1: (2 comments) > (2 comments) > > My understanding is that sanitizer-enabled Kudu builds on Mac

[kudu-CR] Do not run (g)addr2line translator on MacOS X

Alexey Serbin has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 2: > Thanks for making those changes. Looks good to me, though > ultimately I'll defer to someone

[kudu-CR] Do not run (g)addr2line translator on MacOS X

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3360 Change subject: Do not run (g)addr2line translator on MacOS X .. Do not run (g)addr2line translator on MacOS X When running tests on

[kudu-CR] client.h: doxygen comments for C++ API

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#5). Change subject: client.h: doxygen comments for C++ API .. client.h: doxygen

[kudu-CR] async background flush provision for C++ client

Alexey Serbin has posted comments on this change. Change subject: async background flush provision for C++ client .. Patch Set 2: (59 comments) Thank you for review. I addressed most of the comments, and I'm working on

[kudu-CR] Doxygen for C++ client API

Alexey Serbin has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 12: (42 comments) http://gerrit.cloudera.org:8080/#/c/3619/12/src/kudu/client/client.h File src/kudu/client/client.h:

[kudu-CR] Doxygen for C++ client API

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#13). Change subject: Doxygen for C++ client API .. Doxygen for C++

[kudu-CR] client.h: doxygen comments for C++ API

Alexey Serbin has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3619/5/CMakeLists.txt File CMakeLists.txt: Line 963:

[kudu-CR] client/sample.cc: fixed a couple of crashes

Alexey Serbin has posted comments on this change. Change subject: client/sample.cc: fixed a couple of crashes .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3685/1//COMMIT_MSG Commit Message: Line 11: while

[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master

Alexey Serbin has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/3667/2//COMMIT_MSG

[kudu-CR] async background flush provision for C++ client

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3668 Change subject: async background flush provision for C++ client .. async background flush provision for C++ client Implemented

[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492

Alexey Serbin has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492 .. Patch Set 1:

[kudu-CR] async background flush provision for C++ client

Alexey Serbin has posted comments on this change. Change subject: async background flush provision for C++ client .. Patch Set 1: > What was the rationale behind using a dedicated thread to manage > background flushing? I

[kudu-CR] doxygen for C++ client API

Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 9: (1 comment) > One thing we should add to this (it can be a follow-up commit). > > It needs to be integrated into

[kudu-CR] Doxygen for C++ client API

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#12). Change subject: Doxygen for C++ client API .. Doxygen for C++ client API If

[kudu-CR] Doxygen for C++ client API

Alexey Serbin has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/3619/9/src/kudu/client/client.h File src/kudu/client/client.h: >

[kudu-CR] C++ client: fix on KuduSession::GetPendingErrors()

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3677 Change subject: C++ client: fix on KuduSession::GetPendingErrors() .. C++ client: fix on KuduSession::GetPendingErrors() If re-using

[kudu-CR] doxygen for C++ client API

Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 9: (64 comments) http://gerrit.cloudera.org:8080/#/c/3619/9/src/kudu/client/client.h File src/kudu/client/client.h:

[kudu-CR] doxygen for C++ client API

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#10). Change subject: doxygen for C++ client API .. doxygen for C++ client API If

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

Alexey Serbin has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 13: (11 comments)

[kudu-CR] Doxygen for C++ client API

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#11). Change subject: Doxygen for C++ client API .. Doxygen for C++ client API If

[kudu-CR] doxygen for C++ client API

Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (6 comments) Thank you for review! http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt File CMakeLists.txt:

[kudu-CR] doxygen for C++ client API

Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (4 comments) Please see the responses in-line. Once the questions are cleared, I'll post the next version.

[kudu-CR] client.h: doxygen comments for C++ API

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#2). Change subject: client.h: doxygen comments for C++ API .. client.h: doxygen

[kudu-CR] client.h: doxygen comments for C++ API

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3619 Change subject: client.h: doxygen comments for C++ API .. client.h: doxygen comments for C++ API To generate the Doxygen docs from

[kudu-CR] doxygen for C++ client API

Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (2 comments) Will send an update shortly. http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt File

[kudu-CR] doxygen for C++ client API

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#9). Change subject: doxygen for C++ client API .. doxygen for C++ client API If

[kudu-CR] doxygen for C++ client API

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#8). Change subject: doxygen for C++ client API .. doxygen for C++ client API If

[kudu-CR] Add ComputeIfAbsent methods to map-util

Alexey Serbin has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3593/5/src/kudu/gutil/map-util.h File

[kudu-CR] Add ComputeIfAbsent methods to map-util

Alexey Serbin has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/3593/5/src/kudu/gutil/map-util.h File

[kudu-CR] Add a FindPointeeOrNull method to map-util

Alexey Serbin has posted comments on this change. Change subject: Add a FindPointeeOrNull method to map-util .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3594/2/src/kudu/gutil/map-util.h File

[kudu-CR] Add a EraseKeyReturnSmartPtrValue to map-util

Alexey Serbin has posted comments on this change. Change subject: Add a EraseKeyReturnSmartPtrValue to map-util .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/3595/1/src/kudu/gutil/map-util.h File

[kudu-CR] Add a EraseKeyReturnSmartPtrValue to map-util

Alexey Serbin has posted comments on this change. Change subject: Add a EraseKeyReturnSmartPtrValue to map-util .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3595/3/src/kudu/gutil/map-util.h File

[kudu-CR] Add ComputeIfAbsent methods to map-util

Alexey Serbin has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3593/7/src/kudu/gutil/map-util.h File