[kudu-CR] [java-client] disconnect all tablets in TestAsyncKuduSession.disconnectAndWait
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java-client] disconnect all tablets in TestAsyncKuduSession.disconnectAndWait .. [java-client] disconnect all tablets in TestAsyncKuduSession.disconnectAndWait The testDisconnect test creates a single tablet table, scans the table, disconnects a random tablet client, and then waits until the client has no tablet clients. Since the Java client considers the master a tablet, this lasts until the remaining tablet client times out. This commit changes the test to instead disconnect all tablet clients, which shaves about 10 seconds off the runtime. There are also a few drive-by fixups, including renaming AsyncKuduClient.getTableClients to getTabletClients. The test fix exposed an existing race condition in the TabletClient disconnect/reconnect handling which would cause an RPC to be 'lost' and never be sent (eventually causing a timeout). Change-Id: I00b2530c63d70b37cc7143de9f6190f0fbf349de Reviewed-on: http://gerrit.cloudera.org:8080/3329 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java M java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/kududb/client/ITClient.java M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduSession.java 6 files changed, 17 insertions(+), 25 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00b2530c63d70b37cc7143de9f6190f0fbf349de Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3309/5//COMMIT_MSG Commit Message: PS5, Line 13: It's still a mystery why the Java tests Can't get a regression test in C++? -- To view, visit http://gerrit.cloudera.org:8080/3309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e24f6035f4d778995ea3f295396f5fbd760d6c6 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas
Jean-Daniel Cryans has posted comments on this change. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. Patch Set 3: Todd was also +2 on PS2. -- To view, visit http://gerrit.cloudera.org:8080/3308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I116e0bd8ec9d7abbe830d1d0ea4e35465d990a28 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas WaitForReplicasAndUpdateLocations() is called by many itests during test setup. The context is almost always the same: 1. Start a mini cluster, waiting for all tservers to heartbeat. 2. Create a client. 3. Create a table using the client, waiting for table creation to finish. 4. Using WaitForReplicasAndUpdateLocations(), create a tablet to tserver multimap via direct GetTableLocations() RPCs. 5. Send RPCs directly to specific tablets using the map built in step 4. Today's implementation of GetTableLocations() also guarantees that step #4 only completes when all replicas have finished bootstrapping. I have a patch outstanding that removes that guarantee. Why? Because it's not terribly useful outside of testing (a tserver can restart at any time, so clients must always be prepared for TABLET_NOT_RUNNING responses) and because it simplifies master state. To keep these itests working, we need to find another way to provide the guarantee. So here's the fix: use ExternalMiniCluster::WaitForTabletsRunning() to ensure that all tablets on every server are actually running. But first we must augment it to wait for a specific tablet count, otherwise it may return despite a tserver working on a slow CreateTablet() RPC. Change-Id: I116e0bd8ec9d7abbe830d1d0ea4e35465d990a28 Reviewed-on: http://gerrit.cloudera.org:8080/3308 Tested-by: Adar Dembo Reviewed-by: Jean-Daniel Cryans --- M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/external_mini_cluster.h M src/kudu/integration-tests/ts_itest-base.h M src/kudu/integration-tests/ts_recovery-itest.cc 5 files changed, 50 insertions(+), 14 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/3308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I116e0bd8ec9d7abbe830d1d0ea4e35465d990a28 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon
[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas
Jean-Daniel Cryans has posted comments on this change. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I116e0bd8ec9d7abbe830d1d0ea4e35465d990a28 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java client] Fix a race in TabletClient cleanup
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3340 Change subject: [java client] Fix a race in TabletClient cleanup .. [java client] Fix a race in TabletClient cleanup Dan noticed some weird things going on after fixing TestAsyncKuduClient#testDisconnect, we're either not handling some RPCs or doing it twice. The reason is that we add to rpcs_inflight directly without caring for the state of TabletClient (if it's connected or not). Later, we try to detect if we got disconnected but there was no easy way to tell if our RPC was already retried for us or not. This patch tries to make it clear whether the RPC at the end of TabletClient#sendRpc is already handled or not: if the TabletClient is dead, and the rpcs_inflight list is empty, then it got taken care of. If it's not empty, then it means the RPC needs to be sent back to the AsyncKuduClient. This patch fixes flakiness in the test mentioned above. Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7 --- M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java 1 file changed, 32 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/3340/1 -- To view, visit http://gerrit.cloudera.org:8080/3340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans
[kudu-CR] KUDU-1353: remove per-tablet replica locations cache
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/2887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6376b5307f75f5d505b33a5ff4262da619cd1d8d Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3309/5//COMMIT_MSG Commit Message: PS5, Line 13: It's still a mystery why the Java tests > Ah. I had changed the commit description in PS4 (via gerrit) then blew it a Alright good enough. -- To view, visit http://gerrit.cloudera.org:8080/3309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e24f6035f4d778995ea3f295396f5fbd760d6c6 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e24f6035f4d778995ea3f295396f5fbd760d6c6 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java client] Fix a race in TabletClient cleanup
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java client] Fix a race in TabletClient cleanup
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3340/1/java/kudu-client/src/main/java/org/kududb/client/TabletClient.java
File java/kudu-client/src/main/java/org/kududb/client/TabletClient.java:
Line 186: LOG.debug("rpcs_inflight is empty and this TabletClient is
dead, will assume that whis " +
> Use {} substitution instead of string concat.
Done
--
To view, visit http://gerrit.cloudera.org:8080/3340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [java client] Fix a race in TabletClient cleanup
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3340 to look at the new patch set (#2). Change subject: [java client] Fix a race in TabletClient cleanup .. [java client] Fix a race in TabletClient cleanup Dan noticed some weird things going on after fixing TestAsyncKuduClient#testDisconnect, we're either not handling some RPCs or doing it twice. The reason is that we add to rpcs_inflight directly without caring for the state of TabletClient (if it's connected or not). Later, we try to detect if we got disconnected but there was no easy way to tell if our RPC was already retried for us or not. This patch tries to make it clear whether the RPC at the end of TabletClient#sendRpc is already handled or not: if the TabletClient is dead, and the rpcs_inflight list is empty, then it got taken care of. If it's not empty, then it means the RPC needs to be sent back to the AsyncKuduClient. This patch fixes flakiness in the test mentioned above. Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7 --- M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java 1 file changed, 32 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/3340/2 -- To view, visit http://gerrit.cloudera.org:8080/3340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](gh-pages) Add 0.9.0 release and refresh docs
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3355 Change subject: Add 0.9.0 release and refresh docs .. Add 0.9.0 release and refresh docs Change-Id: Ib04c111bd40181f6cbe3978dc87d65a63b01b3ba --- M apidocs/allclasses-frame.html M apidocs/allclasses-noframe.html M apidocs/constant-values.html M apidocs/deprecated-list.html M apidocs/help-doc.html M apidocs/index-all.html M apidocs/index.html M apidocs/org/kududb/ColumnSchema.html M apidocs/org/kududb/Schema.html M apidocs/org/kududb/Type.html M apidocs/org/kududb/annotations/InterfaceAudience.html M apidocs/org/kududb/annotations/InterfaceStability.html M apidocs/org/kududb/annotations/class-use/InterfaceAudience.html M apidocs/org/kududb/annotations/class-use/InterfaceStability.html M apidocs/org/kududb/annotations/package-frame.html M apidocs/org/kududb/annotations/package-summary.html M apidocs/org/kududb/annotations/package-tree.html M apidocs/org/kududb/annotations/package-use.html M apidocs/org/kududb/class-use/ColumnSchema.html M apidocs/org/kududb/class-use/Schema.html M apidocs/org/kududb/class-use/Type.html M apidocs/org/kududb/client/AbstractKuduScannerBuilder.html M apidocs/org/kududb/client/AlterTableOptions.html M apidocs/org/kududb/client/AlterTableResponse.html A apidocs/org/kududb/client/AsyncKuduClient.AsyncKuduClientBuilder.html M apidocs/org/kududb/client/AsyncKuduClient.html A apidocs/org/kududb/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html M apidocs/org/kududb/client/AsyncKuduScanner.ReadMode.html M apidocs/org/kududb/client/AsyncKuduScanner.html M apidocs/org/kududb/client/AsyncKuduSession.html M apidocs/org/kududb/client/ColumnRangePredicate.html M apidocs/org/kududb/client/ConnectionResetException.html M apidocs/org/kududb/client/CreateTableOptions.html M apidocs/org/kududb/client/Delete.html M apidocs/org/kududb/client/DeleteTableResponse.html M apidocs/org/kududb/client/ExternalConsistencyMode.html M apidocs/org/kududb/client/HasFailedRpcException.html M apidocs/org/kududb/client/Insert.html M apidocs/org/kududb/client/InvalidResponseException.html M apidocs/org/kududb/client/IsAlterTableDoneResponse.html A apidocs/org/kududb/client/KuduClient.KuduClientBuilder.html M apidocs/org/kududb/client/KuduClient.html M apidocs/org/kududb/client/KuduException.html M apidocs/org/kududb/client/KuduPredicate.ComparisonOp.html M apidocs/org/kududb/client/KuduPredicate.html A apidocs/org/kududb/client/KuduScanToken.KuduScanTokenBuilder.html A apidocs/org/kududb/client/KuduScanToken.html M apidocs/org/kududb/client/KuduScanner.KuduScannerBuilder.html M apidocs/org/kududb/client/KuduScanner.html M apidocs/org/kududb/client/KuduServerException.html M apidocs/org/kududb/client/KuduSession.html M apidocs/org/kududb/client/KuduTable.html M apidocs/org/kududb/client/ListTablesResponse.html M apidocs/org/kududb/client/ListTabletServersResponse.html M apidocs/org/kududb/client/LocatedTablet.Replica.html M apidocs/org/kududb/client/LocatedTablet.html M apidocs/org/kududb/client/MasterErrorException.html M apidocs/org/kududb/client/NoLeaderMasterFoundException.html M apidocs/org/kududb/client/NonRecoverableException.html M apidocs/org/kududb/client/Operation.html M apidocs/org/kududb/client/OperationResponse.html M apidocs/org/kududb/client/PartialRow.html M apidocs/org/kududb/client/PleaseThrottleException.html M apidocs/org/kududb/client/RecoverableException.html M apidocs/org/kududb/client/RowError.html M apidocs/org/kududb/client/RowErrorsAndOverflowStatus.html M apidocs/org/kududb/client/RowResult.html M apidocs/org/kududb/client/RowResultIterator.html M apidocs/org/kududb/client/SessionConfiguration.FlushMode.html M apidocs/org/kududb/client/SessionConfiguration.html A apidocs/org/kududb/client/Statistics.Statistic.html A apidocs/org/kududb/client/Statistics.html M apidocs/org/kududb/client/Status.html M apidocs/org/kududb/client/TabletServerErrorException.html M apidocs/org/kududb/client/Update.html A apidocs/org/kududb/client/Upsert.html M apidocs/org/kududb/client/class-use/AbstractKuduScannerBuilder.html M apidocs/org/kududb/client/class-use/AlterTableOptions.html M apidocs/org/kududb/client/class-use/AlterTableResponse.html A apidocs/org/kududb/client/class-use/AsyncKuduClient.AsyncKuduClientBuilder.html M apidocs/org/kududb/client/class-use/AsyncKuduClient.html A apidocs/org/kududb/client/class-use/AsyncKuduScanner.AsyncKuduScannerBuilder.html M apidocs/org/kududb/client/class-use/AsyncKuduScanner.ReadMode.html M apidocs/org/kududb/client/class-use/AsyncKuduScanner.html M apidocs/org/kududb/client/class-use/AsyncKuduSession.html M apidocs/org/kududb/client/class-use/ColumnRangePredicate.html M apidocs/org/kududb/client/class-use/ConnectionResetException.html M apidocs/org/kududb/client/class-use/CreateTableOptions.html M apidocs/org/kududb/client/class-use/Delete.html M apidocs/org/kududb/client/class-use/DeleteTableRe
[kudu-CR](gh-pages) Blog post for 0.9.0 release
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3357 Change subject: Blog post for 0.9.0 release .. Blog post for 0.9.0 release Change-Id: I70b4be74e350232110e580844d4f71e012fa813f --- A _posts/2016-06-10-apache-kudu-0-9-0-released.md 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/3357/1 -- To view, visit http://gerrit.cloudera.org:8080/3357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I70b4be74e350232110e580844d4f71e012fa813f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans
[kudu-CR](gh-pages) Blog post for 0.9.0 release
Jean-Daniel Cryans has posted comments on this change. Change subject: Blog post for 0.9.0 release .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3357/1/_posts/2016-06-10-apache-kudu-0-9-0-released.md File _posts/2016-06-10-apache-kudu-0-9-0-released.md: Line 14: * Read the detailed [Kudu 0.9.0 release notes](http://getkudu.io/releases/0.9.0/docs/release_notes.html) These won't work until https://gerrit.cloudera.org/#/c/3355/ is pushed. -- To view, visit http://gerrit.cloudera.org:8080/3357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70b4be74e350232110e580844d4f71e012fa813f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Blog post for 0.9.0 release
Jean-Daniel Cryans has uploaded a new patch set (#2). Change subject: Blog post for 0.9.0 release .. Blog post for 0.9.0 release Change-Id: I70b4be74e350232110e580844d4f71e012fa813f --- A _posts/2016-06-10-apache-kudu-0-9-0-released.md 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/3357/2 -- To view, visit http://gerrit.cloudera.org:8080/3357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I70b4be74e350232110e580844d4f71e012fa813f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones
[kudu-CR] [java client] Fix a race in TabletClient cleanup
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java client] Fix a race in TabletClient cleanup
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3340/2/java/kudu-client/src/main/java/org/kududb/client/TabletClient.java
File java/kudu-client/src/main/java/org/kududb/client/TabletClient.java:
Line 203: if (tryAgain) {
> Given the flow of L177-197, there's no way that both failRpc and tryAgain c
Ended up like that after a series of edits, I'll put it back together.
Line 678: rpcs = pending_rpcs == null ? new
ArrayList>(rpcs_inflight.size()) : pending_rpcs;
> Nit: can you use "new ArrayList<>(...)" here?
It confuses my IDE.
Line 685: if (rpcs != null) {
> Doesn't seem like rpcs could ever be non-null. Maybe you mean to check if i
My bad.
--
To view, visit http://gerrit.cloudera.org:8080/3340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [java client] Fix a race in TabletClient cleanup
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3340 to look at the new patch set (#3). Change subject: [java client] Fix a race in TabletClient cleanup .. [java client] Fix a race in TabletClient cleanup Dan noticed some weird things going on after fixing TestAsyncKuduClient#testDisconnect, we're either not handling some RPCs or doing it twice. The reason is that we add to rpcs_inflight directly without caring for the state of TabletClient (if it's connected or not). Later, we try to detect if we got disconnected but there was no easy way to tell if our RPC was already retried for us or not. This patch tries to make it clear whether the RPC at the end of TabletClient#sendRpc is already handled or not: if the TabletClient is dead, and the rpcs_inflight list is empty, then it got taken care of. If it's not empty, then it means the RPC needs to be sent back to the AsyncKuduClient. This patch fixes flakiness in the test mentioned above. Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7 --- M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java 1 file changed, 32 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/3340/3 -- To view, visit http://gerrit.cloudera.org:8080/3340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](gh-pages) Blog post for 0.9.0 release
Jean-Daniel Cryans has posted comments on this change. Change subject: Blog post for 0.9.0 release .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3357/2/_posts/2016-06-10-apache-kudu-0-9-0-released.md File _posts/2016-06-10-apache-kudu-0-9-0-released.md: Line 9: This latest version adds basic UPSERT functionality and a new Spark Data Source > How about "a new high-performance Spark Data Source" I'll go with "improved" -- To view, visit http://gerrit.cloudera.org:8080/3357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70b4be74e350232110e580844d4f71e012fa813f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Blog post for 0.9.0 release
Hello Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3357 to look at the new patch set (#3). Change subject: Blog post for 0.9.0 release .. Blog post for 0.9.0 release Change-Id: I70b4be74e350232110e580844d4f71e012fa813f --- A _posts/2016-06-10-apache-kudu-0-9-0-released.md 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/3357/3 -- To view, visit http://gerrit.cloudera.org:8080/3357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I70b4be74e350232110e580844d4f71e012fa813f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones
[kudu-CR](gh-pages) Blog post for 0.9.0 release
Jean-Daniel Cryans has posted comments on this change. Change subject: Blog post for 0.9.0 release .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70b4be74e350232110e580844d4f71e012fa813f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR](gh-pages) Blog post for 0.9.0 release
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Blog post for 0.9.0 release .. Blog post for 0.9.0 release Change-Id: I70b4be74e350232110e580844d4f71e012fa813f Reviewed-on: http://gerrit.cloudera.org:8080/3357 Reviewed-by: Jean-Daniel Cryans Tested-by: Jean-Daniel Cryans --- A _posts/2016-06-10-apache-kudu-0-9-0-released.md 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/3357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70b4be74e350232110e580844d4f71e012fa813f Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones
[kudu-CR](gh-pages) Add 0.9.0 release and refresh docs
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add 0.9.0 release and refresh docs .. Add 0.9.0 release and refresh docs Change-Id: Ib04c111bd40181f6cbe3978dc87d65a63b01b3ba Reviewed-on: http://gerrit.cloudera.org:8080/3355 Reviewed-by: Misty Stanley-Jones Reviewed-by: Adar Dembo Reviewed-by: Mike Percy Tested-by: Jean-Daniel Cryans --- M apidocs/allclasses-frame.html M apidocs/allclasses-noframe.html M apidocs/constant-values.html M apidocs/deprecated-list.html M apidocs/help-doc.html M apidocs/index-all.html M apidocs/index.html M apidocs/org/kududb/ColumnSchema.html M apidocs/org/kududb/Schema.html M apidocs/org/kududb/Type.html M apidocs/org/kududb/annotations/InterfaceAudience.html M apidocs/org/kududb/annotations/InterfaceStability.html M apidocs/org/kududb/annotations/class-use/InterfaceAudience.html M apidocs/org/kududb/annotations/class-use/InterfaceStability.html M apidocs/org/kududb/annotations/package-frame.html M apidocs/org/kududb/annotations/package-summary.html M apidocs/org/kududb/annotations/package-tree.html M apidocs/org/kududb/annotations/package-use.html M apidocs/org/kududb/class-use/ColumnSchema.html M apidocs/org/kududb/class-use/Schema.html M apidocs/org/kududb/class-use/Type.html M apidocs/org/kududb/client/AbstractKuduScannerBuilder.html M apidocs/org/kududb/client/AlterTableOptions.html M apidocs/org/kududb/client/AlterTableResponse.html A apidocs/org/kududb/client/AsyncKuduClient.AsyncKuduClientBuilder.html M apidocs/org/kududb/client/AsyncKuduClient.html A apidocs/org/kududb/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html M apidocs/org/kududb/client/AsyncKuduScanner.ReadMode.html M apidocs/org/kududb/client/AsyncKuduScanner.html M apidocs/org/kududb/client/AsyncKuduSession.html M apidocs/org/kududb/client/ColumnRangePredicate.html M apidocs/org/kududb/client/ConnectionResetException.html M apidocs/org/kududb/client/CreateTableOptions.html M apidocs/org/kududb/client/Delete.html M apidocs/org/kududb/client/DeleteTableResponse.html M apidocs/org/kududb/client/ExternalConsistencyMode.html M apidocs/org/kududb/client/HasFailedRpcException.html M apidocs/org/kududb/client/Insert.html M apidocs/org/kududb/client/InvalidResponseException.html M apidocs/org/kududb/client/IsAlterTableDoneResponse.html A apidocs/org/kududb/client/KuduClient.KuduClientBuilder.html M apidocs/org/kududb/client/KuduClient.html M apidocs/org/kududb/client/KuduException.html M apidocs/org/kududb/client/KuduPredicate.ComparisonOp.html M apidocs/org/kududb/client/KuduPredicate.html A apidocs/org/kududb/client/KuduScanToken.KuduScanTokenBuilder.html A apidocs/org/kududb/client/KuduScanToken.html M apidocs/org/kududb/client/KuduScanner.KuduScannerBuilder.html M apidocs/org/kududb/client/KuduScanner.html M apidocs/org/kududb/client/KuduServerException.html M apidocs/org/kududb/client/KuduSession.html M apidocs/org/kududb/client/KuduTable.html M apidocs/org/kududb/client/ListTablesResponse.html M apidocs/org/kududb/client/ListTabletServersResponse.html M apidocs/org/kududb/client/LocatedTablet.Replica.html M apidocs/org/kududb/client/LocatedTablet.html M apidocs/org/kududb/client/MasterErrorException.html M apidocs/org/kududb/client/NoLeaderMasterFoundException.html M apidocs/org/kududb/client/NonRecoverableException.html M apidocs/org/kududb/client/Operation.html M apidocs/org/kududb/client/OperationResponse.html M apidocs/org/kududb/client/PartialRow.html M apidocs/org/kududb/client/PleaseThrottleException.html M apidocs/org/kududb/client/RecoverableException.html M apidocs/org/kududb/client/RowError.html M apidocs/org/kududb/client/RowErrorsAndOverflowStatus.html M apidocs/org/kududb/client/RowResult.html M apidocs/org/kududb/client/RowResultIterator.html M apidocs/org/kududb/client/SessionConfiguration.FlushMode.html M apidocs/org/kududb/client/SessionConfiguration.html A apidocs/org/kududb/client/Statistics.Statistic.html A apidocs/org/kududb/client/Statistics.html M apidocs/org/kududb/client/Status.html M apidocs/org/kududb/client/TabletServerErrorException.html M apidocs/org/kududb/client/Update.html A apidocs/org/kududb/client/Upsert.html M apidocs/org/kududb/client/class-use/AbstractKuduScannerBuilder.html M apidocs/org/kududb/client/class-use/AlterTableOptions.html M apidocs/org/kududb/client/class-use/AlterTableResponse.html A apidocs/org/kududb/client/class-use/AsyncKuduClient.AsyncKuduClientBuilder.html M apidocs/org/kududb/client/class-use/AsyncKuduClient.html A apidocs/org/kududb/client/class-use/AsyncKuduScanner.AsyncKuduScannerBuilder.html M apidocs/org/kududb/client/class-use/AsyncKuduScanner.ReadMode.html M apidocs/org/kududb/client/class-use/AsyncKuduScanner.html M apidocs/org/kududb/client/class-use/AsyncKuduSession.html M apidocs/org/kududb/client/class-use/ColumnRangePredicate.html M apidocs/org/kududb/client/class-use/ConnectionResetException.html M apidocs/org/kududb/client/cla
[kudu-CR](gh-pages) Add 0.9.0 release and refresh docs
Jean-Daniel Cryans has posted comments on this change. Change subject: Add 0.9.0 release and refresh docs .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib04c111bd40181f6cbe3978dc87d65a63b01b3ba Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR](gh-pages) Fix branding in 0.9.0's blog post
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3361 Change subject: Fix branding in 0.9.0's blog post .. Fix branding in 0.9.0's blog post Change-Id: I440f88de7fb2ac6d6b52cd6c08ef43abe066b4bd --- M _posts/2016-06-10-apache-kudu-0-9-0-released.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/3361/1 -- To view, visit http://gerrit.cloudera.org:8080/3361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I440f88de7fb2ac6d6b52cd6c08ef43abe066b4bd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans
[kudu-CR](gh-pages) Fix branding in 0.9.0's blog post
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix branding in 0.9.0's blog post .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I440f88de7fb2ac6d6b52cd6c08ef43abe066b4bd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-HasComments: No
[kudu-CR](gh-pages) Fix branding in 0.9.0's blog post
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Fix branding in 0.9.0's blog post .. Fix branding in 0.9.0's blog post Change-Id: I440f88de7fb2ac6d6b52cd6c08ef43abe066b4bd Reviewed-on: http://gerrit.cloudera.org:8080/3361 Reviewed-by: Jean-Daniel Cryans Tested-by: Jean-Daniel Cryans --- M _posts/2016-06-10-apache-kudu-0-9-0-released.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/3361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I440f88de7fb2ac6d6b52cd6c08ef43abe066b4bd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests
Jean-Daniel Cryans has posted comments on this change. Change subject: Use RaftConsensus instead of LocalConsensus in tests .. Patch Set 2: > Overriding Jenkins due to super flaky Java test > org.kududb.client.TestAsyncKuduClient.testDisconnect() Gonna be fixed as soon as we get this in https://gerrit.cloudera.org/#/c/3340/ ! -- To view, visit http://gerrit.cloudera.org:8080/3346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e94d7e78e3428a8d9696737e07b8e8f7489d49 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Add release notes and docs for UPSERT
Jean-Daniel Cryans has posted comments on this change. Change subject: Add release notes and docs for UPSERT .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3362/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: Line 923: === `UPSERT` Impala doesn't have it though. -- To view, visit http://gerrit.cloudera.org:8080/3362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf129915883cf183580ab2cdc8987df2d55a626 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Misty Stanley-Jones Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Add release notes and docs for UPSERT
Jean-Daniel Cryans has posted comments on this change. Change subject: Add release notes and docs for UPSERT .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3362/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: Line 923: === `UPSERT` > Oh ok, that's important to know. I don't really have API examples in the ma Yeah, unfortunate. -- To view, visit http://gerrit.cloudera.org:8080/3362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf129915883cf183580ab2cdc8987df2d55a626 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Misty Stanley-Jones Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Add release notes and docs for UPSERT
Jean-Daniel Cryans has posted comments on this change. Change subject: Add release notes and docs for UPSERT .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf129915883cf183580ab2cdc8987df2d55a626 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Misty Stanley-Jones Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add release notes and docs for UPSERT
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add release notes and docs for UPSERT .. Add release notes and docs for UPSERT Change-Id: Ibdf129915883cf183580ab2cdc8987df2d55a626 Reviewed-on: http://gerrit.cloudera.org:8080/3362 Reviewed-by: Jean-Daniel Cryans Tested-by: Jean-Daniel Cryans --- M docs/release_notes.adoc 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/3362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdf129915883cf183580ab2cdc8987df2d55a626 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Misty Stanley-Jones Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add release notes and docs for UPSERT
Jean-Daniel Cryans has posted comments on this change. Change subject: Add release notes and docs for UPSERT .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf129915883cf183580ab2cdc8987df2d55a626 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Misty Stanley-Jones Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Hotfix the 0.9.0 release notes to add UPSERT
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3363 Change subject: Hotfix the 0.9.0 release notes to add UPSERT .. Hotfix the 0.9.0 release notes to add UPSERT Change-Id: I0eee88dc83096677205695aca9c6aa99a8d590e3 --- M docs/release_notes.html M releases/0.9.0/docs/release_notes.html 2 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/3363/1 -- To view, visit http://gerrit.cloudera.org:8080/3363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0eee88dc83096677205695aca9c6aa99a8d590e3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans
[kudu-CR](gh-pages) Hotfix the 0.9.0 release notes to add UPSERT
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Hotfix the 0.9.0 release notes to add UPSERT .. Hotfix the 0.9.0 release notes to add UPSERT Change-Id: I0eee88dc83096677205695aca9c6aa99a8d590e3 Reviewed-on: http://gerrit.cloudera.org:8080/3363 Reviewed-by: Misty Stanley-Jones Tested-by: Jean-Daniel Cryans --- M docs/release_notes.html M releases/0.9.0/docs/release_notes.html 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Jean-Daniel Cryans: Verified Misty Stanley-Jones: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eee88dc83096677205695aca9c6aa99a8d590e3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones
[kudu-CR](gh-pages) Hotfix the 0.9.0 release notes to add UPSERT
Jean-Daniel Cryans has posted comments on this change. Change subject: Hotfix the 0.9.0 release notes to add UPSERT .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eee88dc83096677205695aca9c6aa99a8d590e3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR] Fix variable name typo in ITBLL
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix variable name typo in ITBLL .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I606d0e2eb931fb355d58cb43ef7f0e471371326e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](gh-pages) Add weekly update for 06/13
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3375 Change subject: Add weekly update for 06/13 .. Add weekly update for 06/13 Change-Id: I41c02b33c47b7cb4bdb2798c4203fcd1e0cf4014 --- A _posts/2016-06-13-weekly-update.md 1 file changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/3375/1 -- To view, visit http://gerrit.cloudera.org:8080/3375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I41c02b33c47b7cb4bdb2798c4203fcd1e0cf4014 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans
[kudu-CR](gh-pages) Add weekly update for 06/13
Jean-Daniel Cryans has posted comments on this change. Change subject: Add weekly update for 06/13 .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/3375/1/_posts/2016-06-13-weekly-update.md File _posts/2016-06-13-weekly-update.md: Line 9: > This is just general feedback. I hate these MORE links. Why hide all of the I'm just copying what Todd did for the previous blog posts. Line 11: If you find this post useful, please let us know by emailing the > Do you really want emails that say "This post is useful"? I don't get it. Ideally yes? :) Line 19: * The IPMC vote for 0.9.0 RC1 passed and it is now > and Kudu 0.9 is now officially released (not the vote). Done Line 24: * Adar Dembo has been cleaning up and improving the Master process' code. Last week he > Master process's code Done Line 25: [finished](https://gerrit.cloudera.org/#/c/2887/) removing the per-tablet replica locations cache. > last week he removed the per-tablet replica locations cache. He didn't actually do it last week, but it was pushed last week. Does my wording makes more sense? Line 27: * Alexey Serbin got his first contribution in last week by [fixing](https://gerrit.cloudera.org/#/c/3360/) > contributed his first patch last week Done Line 30: * Sameer Abhyankar has been working on adding "in-list" predicates and it's getting close to completion, > Sameer is nearly finished adding support for "in-list" predicates... Done Line 39: * Todd Lipcon presented Kudu at Berlin Buzzwords earlier this month, it was recorded and made available > earlier this month. The recording is available available at . Done, but not doing the double "available" :) -- To view, visit http://gerrit.cloudera.org:8080/3375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41c02b33c47b7cb4bdb2798c4203fcd1e0cf4014 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add weekly update for 06/13
Jean-Daniel Cryans has uploaded a new patch set (#2). Change subject: Add weekly update for 06/13 .. Add weekly update for 06/13 Change-Id: I41c02b33c47b7cb4bdb2798c4203fcd1e0cf4014 --- A _posts/2016-06-13-weekly-update.md 1 file changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/3375/2 -- To view, visit http://gerrit.cloudera.org:8080/3375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I41c02b33c47b7cb4bdb2798c4203fcd1e0cf4014 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones
[kudu-CR](gh-pages) Add weekly update for 06/13
Jean-Daniel Cryans has posted comments on this change. Change subject: Add weekly update for 06/13 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41c02b33c47b7cb4bdb2798c4203fcd1e0cf4014 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR](gh-pages) Add weekly update for 06/13
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add weekly update for 06/13 .. Add weekly update for 06/13 Change-Id: I41c02b33c47b7cb4bdb2798c4203fcd1e0cf4014 Reviewed-on: http://gerrit.cloudera.org:8080/3375 Reviewed-by: Misty Stanley-Jones Tested-by: Jean-Daniel Cryans --- A _posts/2016-06-13-weekly-update.md 1 file changed, 40 insertions(+), 0 deletions(-) Approvals: Jean-Daniel Cryans: Verified Misty Stanley-Jones: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41c02b33c47b7cb4bdb2798c4203fcd1e0cf4014 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones
[kudu-CR] Fix variable name typo in ITBLL
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Fix variable name typo in ITBLL .. Fix variable name typo in ITBLL Change-Id: I606d0e2eb931fb355d58cb43ef7f0e471371326e Reviewed-on: http://gerrit.cloudera.org:8080/3367 Reviewed-by: Jean-Daniel Cryans Tested-by: Kudu Jenkins --- M java/kudu-client-tools/src/main/java/org/kududb/mapreduce/tools/IntegrationTestBigLinkedList.java 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I606d0e2eb931fb355d58cb43ef7f0e471371326e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] create-demo-table must specify partition columns
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: create-demo-table must specify partition columns .. create-demo-table must specify partition columns This is a recent API change that didn't make it into this dev tool. Change-Id: I894214bbd9f8198909344c249780711058d5398d Reviewed-on: http://gerrit.cloudera.org:8080/3368 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M src/kudu/tools/create-demo-table.cc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I894214bbd9f8198909344c249780711058d5398d Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-0.9.x) Document advice about max columns and record size
Jean-Daniel Cryans has abandoned this change. Change subject: Document advice about max columns and record size .. Abandoned Not making it into 0.9.0. -- To view, visit http://gerrit.cloudera.org:8080/3252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I70a82d59c431f69246128acc19227af3194fa15a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Misty Stanley-Jones Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] ITBLL: Specify all possible columns to partition on
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: ITBLL: Specify all possible columns to partition on .. ITBLL: Specify all possible columns to partition on key2 may be used as a partitioning column as well, if more than one tablet is specified. Change-Id: Ibf18771f7d2dc6e070a792ccfdd1f4069a3b0d91 Reviewed-on: http://gerrit.cloudera.org:8080/3380 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans --- M java/kudu-client-tools/src/main/java/org/kududb/mapreduce/tools/IntegrationTestBigLinkedList.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf18771f7d2dc6e070a792ccfdd1f4069a3b0d91 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] ITBLL: Specify all possible columns to partition on
Jean-Daniel Cryans has posted comments on this change. Change subject: ITBLL: Specify all possible columns to partition on .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf18771f7d2dc6e070a792ccfdd1f4069a3b0d91 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java client] Fix GetTableLocations error handling
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Fix GetTableLocations error handling .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3295/3/java/kudu-client/src/main/java/org/kududb/client/ListTabletsResponse.java File java/kudu-client/src/main/java/org/kududb/client/ListTabletsResponse.java: Line 24: @InterfaceAudience.Public I would mark it private since we're not exposing anyway of using it. PS3, Line 39: sL nit: Tablet* -- To view, visit http://gerrit.cloudera.org:8080/3295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d246a83e9f0071063a23fb9a8d4b4c0220e507 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Binglin Chang Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] Update Java client for new master GetTableLocations semantics
Jean-Daniel Cryans has posted comments on this change.
Change subject: Update Java client for new master GetTableLocations semantics
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3303/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:
Line 1134: if (response.getError().getCode() ==
Master.MasterErrorPB.Code.TABLET_NOT_RUNNING) {
IIUC you're relying on existing tests to pass to verify this new check?
http://gerrit.cloudera.org:8080/#/c/3303/2/java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java
File java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java:
Line 203:new byte[]
{ (byte) 0x80, 0x00, 0x00, 0x32 },
Got some long lines here and below.
Line 249: assertTrue("unreachable", false);
use fail()
--
To view, visit http://gerrit.cloudera.org:8080/3303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80bf5661aed1ba435800211411b3273874e5bbcf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [java-client] use tablet cache for locateTablet calls
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java-client] use tablet cache for locateTablet calls
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3386/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 63: Applications are
: encouraged to use the scan tokens API instead of these methods
in the future.
Seems like you could also add that in KuduTable's javadoc for the methods above.
http://gerrit.cloudera.org:8080/#/c/3386/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:
Line 1128: // If the partition key location isn't cached, then kick off a
new tablet
Odd comment placement.
Line 1927: synchronized (replicas) {
Pretty sure this needs to be under the synchronized block above, else
concurrent metadata refreshes might leave you in a weird state.
--
To view, visit http://gerrit.cloudera.org:8080/3386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78b5d400778547a9ee090111663677901dbadd98
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Update Java client for new master GetTableLocations semantics
Jean-Daniel Cryans has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3303/3/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: PS3, Line 666: . to the leader master instance *since it's also handled like a tablet. http://gerrit.cloudera.org:8080/#/c/3303/3/java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java File java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java: Line 155: } Remind me why you don't need all those tests you previously were adding? -- To view, visit http://gerrit.cloudera.org:8080/3303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80bf5661aed1ba435800211411b3273874e5bbcf Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1309: [java client] support tables with non-covering
partition-key ranges
..
Patch Set 1:
(23 comments)
http://gerrit.cloudera.org:8080/#/c/3388/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:
Line 154:* Map of table ID to non-covered range cache.
Can you describe the lifecycle of items the get into this cache? Going through
the code it doesn't seem like we invalidate it.
Line 684: // TODO: should this throw instead?
Unit test it and see what happens? :)
Line 1371: if (locations.isEmpty()) {
How does this happen? Remove all the tablets?
PS1, Line 1376: then
the*
http://gerrit.cloudera.org:8080/#/c/3388/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java:
Line 443: //LOG.info("Scan.open is returning rows: " +
resp.data.getNumRows());
woops, we've been carrying this for a while. Please remove? :)
http://gerrit.cloudera.org:8080/#/c/3388/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java:
PS1, Line 121: AUTO_FLUSH_BACKGROUND
I thought it was only for manual flush?
http://gerrit.cloudera.org:8080/#/c/3388/1/java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java
File java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java:
PS1, Line 84: .
nit: don't end with period here.
Line 86: boolean partitionKeyOrNext() {
I was expecting this to be used for scans, but it's not overrode anywhere?
http://gerrit.cloudera.org:8080/#/c/3388/1/java/kudu-client/src/main/java/org/kududb/client/KuduScanner.java
File java/kudu-client/src/main/java/org/kududb/client/KuduScanner.java:
Line 57: RowResultIterator i = d.join(asyncScanner.scanRequestTimeout);
Why was this this necessary?
http://gerrit.cloudera.org:8080/#/c/3388/1/java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeCache.java
File java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeCache.java:
Line 1: package org.kududb.client;
License.
PS1, Line 23: AsyncKuduClient
Using that on purpose?
Line 26: private final ConcurrentNavigableMap
nonCoveredRanges =
Another case where we don't seem to invalidate the cache. In fact, we don't
seem to be able to override it either.
Line 30:*
Finish the javadoc.
Line 45: public void addNonCoveredRange(byte[] startPartitionKey, byte[]
endPartitionKey) {
Add javadoc.
http://gerrit.cloudera.org:8080/#/c/3388/1/java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeException.java
File
java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeException.java:
Line 1: package org.kududb.client;
License.
Line 6: public class NonCoveredRangeException extends KuduException {
Missing interface audience.
http://gerrit.cloudera.org:8080/#/c/3388/1/java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java
File java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java:
Line 79: return new RowResultIterator(0, null, null, null, null);
Should we consider keeping a single static instance? I don't think it's
possible to modify them once they return null, so they're safe to reuse?
http://gerrit.cloudera.org:8080/#/c/3388/1/java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java:
Line 239: public static CreateTableOptions
getBasicTableOptionsWithNonCoveredRange() {
Put in the javadoc a quick representation of what the table ends up looking
like.
http://gerrit.cloudera.org:8080/#/c/3388/1/java/kudu-client/src/test/java/org/kududb/client/TestFlexiblePartitioning.java
File
java/kudu-client/src/test/java/org/kududb/client/TestFlexiblePartitioning.java:
Line 249: @Test
Add timeouts here and below.
http://gerrit.cloudera.org:8080/#/c/3388/1/java/kudu-client/src/test/java/org/kududb/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/kududb/client/TestKuduClient.java:
PS1, Line 412: .
remove period.
Line 467: assertEquals(0, countRowsForTestScanNonCoveredTable(table, null,
-1));
I'm not sure looking at this if we're expecting 0 rows because none are
inserted in that range or if we're in non-covered space. Also, not sure if
you're testing a scan that starts in non-covered territory.
http://gerrit.cloudera.org:8080/#/c/3388/1/java/kudu-client/src/test/java/org/kududb/client/TestKuduSession.java
File java/kudu-client/src/test/java/org/kududb/client/TestKuduSession.java:
Line 221: String tableName = TABLE_NAME_PREFIX +
"-manual-flush-non-covered-range";
Seems like those first lines can be refactored out in all tests.
Line 290:
No nega
[kudu-CR] [java-client] use tablet cache for locateTablet calls
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] use tablet cache for locateTablet calls .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78b5d400778547a9ee090111663677901dbadd98 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Update Java client for new master GetTableLocations semantics
Jean-Daniel Cryans has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80bf5661aed1ba435800211411b3273874e5bbcf Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] use tablet cache for locateTablet calls
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java-client] use tablet cache for locateTablet calls
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3386/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:
Line 1876: private final List replicas = new
ArrayList<>();
> Would it be safe to use a CopyOnWriteArrayList here, and in doing so avoid
I don't think the tradeoff is worth it. Maybe we should document this, but
replicas here would only be used when getting a list of locations. It's not a
common thing to do, and it's not typically done in conjunction with normal
inserts/scans.
Using CopyOnWriteArrayList means taking a hit under the lock while refreshing
the tablet clients, which happens a lot more often than getting the replicas.
Line 2047: List getReplicas() {
> Nit: may want to name it "getImmutableReplicas" so that callers know they c
Quickly looking through the code, looks like we don't do it, and I'm not sure
we even have occasions to do it. I like it too.
--
To view, visit http://gerrit.cloudera.org:8080/3386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78b5d400778547a9ee090111663677901dbadd98
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1309: [java client] support tables with non-covering
partition-key ranges
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3388/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:
Line 576: Deferred openScanner(final
AsyncKuduScanner scanner) {
> Do we need to preserve this indirection due to class/method visibility? If
True, this can be removed.
http://gerrit.cloudera.org:8080/#/c/3388/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java:
Line 279: if (!operationsInLookup.isEmpty()) {
> Deferreds are weird, man. I've read the code in the two branches here over
Yeah it's a tricky one. A lot of what's happening is implied.
http://gerrit.cloudera.org:8080/#/c/3388/2/java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java
File java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java:
Line 35: private static final RowResultIterator EMPTY = new
RowResultIterator(0, null, null, null, null);
> If this is for tests only, perhaps make it more visible, annotate it with @
It's not, we return it if your end key on the scan is in non-covered range. We
could document this.
--
To view, visit http://gerrit.cloudera.org:8080/3388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Add more helpful CHECK message at master startup
Jean-Daniel Cryans has posted comments on this change. Change subject: Add more helpful CHECK message at master startup .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b5c9d9553b251c289b51bddfe3f84beaa489e9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Jean-Daniel Cryans has posted comments on this change. Change subject: Add blog post about removing LocalConsensus .. Patch Set 1: (3 comments) I really enjoyed reading this, just minor nits. http://gerrit.cloudera.org:8080/#/c/3398/1/_posts/2016-06-17-raft-consensus-single-node.md File _posts/2016-06-17-raft-consensus-single-node.md: PS1, Line 15: even nit: I'd remove that word. PS1, Line 59: strong Is that normal parlance in Raft? PS1, Line 75: a Raft that Feels like you're missing a word, maybe a "Raft implementation"? Or "Without a consensus implementation that" -- To view, visit http://gerrit.cloudera.org:8080/3398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Jean-Daniel Cryans has posted comments on this change. Change subject: Add blog post about removing LocalConsensus .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about removing LocalConsensus
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add blog post about removing LocalConsensus .. Add blog post about removing LocalConsensus Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4 Reviewed-on: http://gerrit.cloudera.org:8080/3398 Reviewed-by: David Ribeiro Alves Tested-by: Mike Percy Reviewed-by: Jean-Daniel Cryans --- A _posts/2016-06-17-raft-consensus-single-node.md 1 file changed, 94 insertions(+), 0 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Jean-Daniel Cryans: Looks good to me, approved Mike Percy: Verified -- To view, visit http://gerrit.cloudera.org:8080/3398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I571de0cbf4d73511f17bd57d374fed9e8ca302e4 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy
[kudu-CR] [java-client] use tablet cache for locateTablet calls
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java-client] use tablet cache for locateTablet calls .. [java-client] use tablet cache for locateTablet calls This simplifies and improves the performance of AsyncKuduClient::locateTable by using the client's existing tablet cache. This change is motivated by an upcoming fix to the locate table logic, which will be easier without the code duplication. The public KuduTable::locateTable methods have been deprecated since they rely on callers having knowledge of the private internals of Kudu's partitioning implementation. Additionally, the methods have been changed to take an exclusive end partition key instead of an inclusive end partition key. Whether the key was inclusive or exclusive was previously undocumented, and the only known caller (the internal ScanToken implementation) was using it as exclusive. Users of these methods are encouraged to use the ScanToken API instead, since it's easier to use and does not leak internal Kudu implementation details. Change-Id: I78b5d400778547a9ee090111663677901dbadd98 Reviewed-on: http://gerrit.cloudera.org:8080/3386 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans --- M docs/release_notes.adoc M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/KuduTable.java M java/kudu-client/src/main/java/org/kududb/client/LocatedTablet.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduTable.java 5 files changed, 134 insertions(+), 93 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78b5d400778547a9ee090111663677901dbadd98 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java-client] use tablet cache for locateTablet calls
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] use tablet cache for locateTablet calls .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78b5d400778547a9ee090111663677901dbadd98 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Update Java client for new master GetTableLocations semantics
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Update Java client for new master GetTableLocations semantics .. Update Java client for new master GetTableLocations semantics The Java client was relying on the master returning an empty tablet locations response when the table was still in the process of being created. Now, the master returns a specific error. This code fixes the table locations lookup code in AsyncKuduClient for look for that specific error code. This change isn't tested since the locateTablets codepath is well covered by existing tests. Change-Id: I80bf5661aed1ba435800211411b3273874e5bbcf Reviewed-on: http://gerrit.cloudera.org:8080/3303 Reviewed-by: Jean-Daniel Cryans Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java 2 files changed, 45 insertions(+), 29 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80bf5661aed1ba435800211411b3273874e5bbcf Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](gh-pages) Add weekly update for 06/21
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3415 Change subject: Add weekly update for 06/21 .. Add weekly update for 06/21 Change-Id: I2d048380922f072e676e990ca23fb2b62da6aa62 --- A _posts/2016-06-21-weekly-update.md 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/3415/1 -- To view, visit http://gerrit.cloudera.org:8080/3415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2d048380922f072e676e990ca23fb2b62da6aa62 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans
[kudu-CR] [java client] Fix GetTableLocations error handling
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Fix GetTableLocations error handling .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d246a83e9f0071063a23fb9a8d4b4c0220e507 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Binglin Chang Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java client] Fix GetTableLocations error handling
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Fix GetTableLocations error handling .. [java client] Fix GetTableLocations error handling When GetTableLocations get an error, e.g. table not found, in some scenario the callback will silently drop the error, not notifying the RPC which triggered this GetTableLocations call, causing the RPC to hang. This usually happens when user is inserting data, but underlying table is deleted and recreated. Change-Id: I79d246a83e9f0071063a23fb9a8d4b4c0220e507 Reviewed-on: http://gerrit.cloudera.org:8080/3295 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java A java/kudu-client/src/main/java/org/kududb/client/ListTabletsRequest.java A java/kudu-client/src/main/java/org/kududb/client/ListTabletsResponse.java M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduSession.java 4 files changed, 157 insertions(+), 4 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79d246a83e9f0071063a23fb9a8d4b4c0220e507 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Binglin Chang Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](gh-pages) Add weekly update for 06/21
Jean-Daniel Cryans has posted comments on this change. Change subject: Add weekly update for 06/21 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d048380922f072e676e990ca23fb2b62da6aa62 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Add weekly update for 06/21
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add weekly update for 06/21 .. Add weekly update for 06/21 Change-Id: I2d048380922f072e676e990ca23fb2b62da6aa62 Reviewed-on: http://gerrit.cloudera.org:8080/3415 Reviewed-by: Todd Lipcon Tested-by: Jean-Daniel Cryans --- A _posts/2016-06-21-weekly-update.md 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: Jean-Daniel Cryans: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d048380922f072e676e990ca23fb2b62da6aa62 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR](branch-0.9.x) Bump version to 0.9.1-SNAPSHOT
Jean-Daniel Cryans has posted comments on this change. Change subject: Bump version to 0.9.1-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I472c2999c0b13a2c046366a9e1ad7474eedf68d0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](branch-0.9.x) [java-client] RPC timeout may sometimes be reported as max attempts violation
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3457 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](branch-0.9.x) Release notes for 0.9.1
Jean-Daniel Cryans has posted comments on this change. Change subject: Release notes for 0.9.1 .. Patch Set 1: (1 comment) Are you going to post a patch for master too? http://gerrit.cloudera.org:8080/#/c/3463/1/docs/release_notes.adoc File docs/release_notes.adoc: PS1, Line 73: Consensus nit: I thought we were writing either "our Raft consensus implementation" or just "RaftConsensus". -- To view, visit http://gerrit.cloudera.org:8080/3463 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I797980d105e0e1000420aedf58e094f9505053c6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR](branch-0.9.x) Release notes for 0.9.1
Jean-Daniel Cryans has posted comments on this change. Change subject: Release notes for 0.9.1 .. Patch Set 1: > Does this belong on the branch or on master? wasn't sure Doh saw this after writing my review. It should be both I think. -- To view, visit http://gerrit.cloudera.org:8080/3463 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I797980d105e0e1000420aedf58e094f9505053c6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-0.9.x) Release notes for 0.9.1
Jean-Daniel Cryans has posted comments on this change. Change subject: Release notes for 0.9.1 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3463 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I797980d105e0e1000420aedf58e094f9505053c6 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Release notes for 0.9.1
Jean-Daniel Cryans has posted comments on this change. Change subject: Release notes for 0.9.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I797980d105e0e1000420aedf58e094f9505053c6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR](branch-0.9.x) Bump version to 0.9.1
Jean-Daniel Cryans has posted comments on this change. Change subject: Bump version to 0.9.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied911c99b45f9bdae20d14f0ecbe2ae9010f1476 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Allow for reserving disk space for non-Kudu processes
Jean-Daniel Cryans has posted comments on this change. Change subject: Allow for reserving disk space for non-Kudu processes .. Patch Set 9: Hey Mike, are you planning on doing a follow-up patch with some documentation? Also, what does it take so that we don't default this to 0? I think it's desirable to have it enabled. -- To view, visit http://gerrit.cloudera.org:8080/3135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd0451d4dbddc1783019a53302de0263080939c7 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Allow for reserving disk space for non-Kudu processes
Jean-Daniel Cryans has posted comments on this change. Change subject: Allow for reserving disk space for non-Kudu processes .. Patch Set 9: Code-Review+1 > JD: > > I'm happy to add docs as a follow up. I've actually not written > much documentation so I'll poke around for examples. Drop a section in http://kudu.apache.org/docs/administration.html, can do a follow-up patch since this looks ready to go. > > In terms of non-zero defaults, I'm not sure what kinds of defaults > would be widely applicable, to be honest. I looked at Hadoop, it defaults to 0 (thought it was some other number), so we should just recommend setting that configuration to something in the docs. -- To view, visit http://gerrit.cloudera.org:8080/3135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd0451d4dbddc1783019a53302de0263080939c7 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add required Debian version to installation page
Jean-Daniel Cryans has posted comments on this change. Change subject: Add required Debian version to installation page .. Patch Set 1: > JD, are you ok with pushing this now with your recent deb 8 > testing? Yes. -- To view, visit http://gerrit.cloudera.org:8080/3389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65cef323648d7934cb140046cf391d56867eeb56 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about multi-master support in Kudu 1.0
Jean-Daniel Cryans has posted comments on this change. Change subject: Add blog post about multi-master support in Kudu 1.0 .. Patch Set 1: Code-Review+2 Good stuff! -- To view, visit http://gerrit.cloudera.org:8080/3476 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40a513f6a616ed0d947837fd9f33f64f755465ff Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about multi-master support in Kudu 1.0
Jean-Daniel Cryans has posted comments on this change. Change subject: Add blog post about multi-master support in Kudu 1.0 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3476 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40a513f6a616ed0d947837fd9f33f64f755465ff Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about multi-master support in Kudu 1.0
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add blog post about multi-master support in Kudu 1.0 .. Add blog post about multi-master support in Kudu 1.0 I also fixed the placement of the tag in this week's update. Change-Id: I40a513f6a616ed0d947837fd9f33f64f755465ff Reviewed-on: http://gerrit.cloudera.org:8080/3476 Reviewed-by: Jean-Daniel Cryans Tested-by: Jean-Daniel Cryans --- M _posts/2016-06-21-weekly-update.md A _posts/2016-06-24-multi-master-1-0-0.md 2 files changed, 107 insertions(+), 2 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/3476 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40a513f6a616ed0d947837fd9f33f64f755465ff Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Fix syntax highlighting on new Jekyll
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Fix syntax highlighting on new Jekyll .. Fix syntax highlighting on new Jekyll When we moved from github to our own Jekyll build, the syntax highlighting of code snippets on blog posts changed. Now we need to use the Liquid template syntax instead of the '```' markdown syntax. Change-Id: Ib3763d74037cd9d25aac72f82123af51ec049dec Reviewed-on: http://gerrit.cloudera.org:8080/3479 Reviewed-by: Jean-Daniel Cryans Tested-by: Jean-Daniel Cryans --- M _posts/2016-04-19-kudu-0-8-0-predicate-improvements.md M _posts/2016-06-02-no-default-partitioning.md M css/kudu.css 3 files changed, 75 insertions(+), 11 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/3479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3763d74037cd9d25aac72f82123af51ec049dec Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR](gh-pages) Fix syntax highlighting on new Jekyll
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix syntax highlighting on new Jekyll .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3763d74037cd9d25aac72f82123af51ec049dec Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-HasComments: No
[kudu-CR](gh-pages) Fix .gitignore
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3480 Change subject: Fix .gitignore .. Fix .gitignore Not having untracked files now matters more with 'site_tool publish'. In my case I switch between 'gh-pages' and 'master' at lot so I have untracked files. Change-Id: I266cde97d338783485a8e5c426f8168f639fcb67 --- M .gitignore 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/3480/1 -- To view, visit http://gerrit.cloudera.org:8080/3480 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I266cde97d338783485a8e5c426f8168f639fcb67 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans
[kudu-CR](gh-pages) Fix .gitignore
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix .gitignore .. Patch Set 1: > this seems kind of fragile.. why not just use a different checkout > for this branch? I'd argue that site_tool is fragile. -- To view, visit http://gerrit.cloudera.org:8080/3480 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I266cde97d338783485a8e5c426f8168f639fcb67 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Fix .gitignore
Jean-Daniel Cryans has abandoned this change. Change subject: Fix .gitignore .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/3480 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I266cde97d338783485a8e5c426f8168f639fcb67 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [java-client] refactor AsyncKuduSession
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java-client] refactor AsyncKuduSession
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/3477/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:
PS1, Line 1400: locateTablet
How does this related to the other locateTablet() method? It seems to be doing
something different, so at least it shouldn't be called the same?
http://gerrit.cloudera.org:8080/#/c/3477/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java:
PS1, Line 396: Must not be concurrently accessed
It already is it seems though, the client can call it with a flusher task fires.
Line 705: private List operations = new ArrayList<>();
final
PS1, Line 725: it's
its
PS1, Line 725: (
not closing the parenthesis in the comment
http://gerrit.cloudera.org:8080/#/c/3477/1/java/kudu-client/src/main/java/org/kududb/client/RowError.java
File java/kudu-client/src/main/java/org/kududb/client/RowError.java:
Line 87: ", tablet=" + (operation.getTablet() == null ? null :
Just put getTablet there directly, RemoteTablet has toString.
http://gerrit.cloudera.org:8080/#/c/3477/1/java/kudu-client/src/main/java/org/kududb/util/AsyncUtil.java
File java/kudu-client/src/main/java/org/kududb/util/AsyncUtil.java:
Line 54:* Workaround for {@link Deferred#addBoth}'s failure to use generics
correctly.
Can you be more clear regarding what this does and why someone should use it?
--
To view, visit http://gerrit.cloudera.org:8080/3477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee6d029b1a56e254bfb9a870917883abeadb6b8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [java-client] refactor AsyncKuduSession
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3477/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java: PS2, Line 396: Must not be concurrently accessed I'm still thrown off by this comment. Maybe: * @param buffer the buffer to flush, must not be modified once passed to this method -- To view, visit http://gerrit.cloudera.org:8080/3477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee6d029b1a56e254bfb9a870917883abeadb6b8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add 6/27 weekly update
Jean-Daniel Cryans has posted comments on this change. Change subject: Add 6/27 weekly update .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3515/1/_posts/2016-06-27-weekly-update.md File _posts/2016-06-27-weekly-update.md: PS1, Line 24: replication replicating? -- To view, visit http://gerrit.cloudera.org:8080/3515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ce4bf6e02a5481bf3e032d3345d7afc93c244a2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add 6/27 weekly update
Jean-Daniel Cryans has posted comments on this change. Change subject: Add 6/27 weekly update .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ce4bf6e02a5481bf3e032d3345d7afc93c244a2 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-HasComments: No
[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3516 Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. KUDU-1496. NoLeaderMasterFoundException are mishandled This is a regression from 0c8f72b4c5d637dba4c0c0da4f55ea918c287d88. Once we have multi-master unit tests re-enabled, we'll have this covered. Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/3516/1 -- To view, visit http://gerrit.cloudera.org:8080/3516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans
[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. Patch Set 1: (1 comment) > Oops. > > Outside of multi-master, this only manifests when the sole master > is booting up, right? That would explain why it happens often in > our unit tests. Yup, I just didn't want to write tests that we already have. http://gerrit.cloudera.org:8080/#/c/3516/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 814: return d; > is it important that the getDeferred call happen before delayedSendRpcToTab If by some chance the RPC completed before the return is done, we'd be sending back a new Deferred. Almost impossible to run into, but hey... -- To view, visit http://gerrit.cloudera.org:8080/3516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. KUDU-1496. NoLeaderMasterFoundException are mishandled This is a regression from 0c8f72b4c5d637dba4c0c0da4f55ea918c287d88. Once we have multi-master unit tests re-enabled, we'll have this covered. Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5 Reviewed-on: http://gerrit.cloudera.org:8080/3516 Reviewed-by: Adar Dembo Reviewed-by: Dan Burkert Tested-by: Jean-Daniel Cryans --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Jean-Daniel Cryans: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. Patch Set 1: Verified+1 Forcing +1 due to current messed up workspace. -- To view, visit http://gerrit.cloudera.org:8080/3516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-HasComments: No
[kudu-CR] tablet: change default bloom filter FP rate to 0.01%
Jean-Daniel Cryans has posted comments on this change. Change subject: tablet: change default bloom filter FP rate to 0.01% .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99bdd6298349a5be5f1fc3a666fe04305699e293 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] tablet: change default bloom filter FP rate to 0.01%
Jean-Daniel Cryans has posted comments on this change. Change subject: tablet: change default bloom filter FP rate to 0.01% .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3517/2//COMMIT_MSG Commit Message: PS2, Line 25: https://gist.github.com/toddlipcon/1ab9b36b7fbae10b635d3a905e1fe55a interesting how the changed graph seems to have a second life towards the end. -- To view, visit http://gerrit.cloudera.org:8080/3517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99bdd6298349a5be5f1fc3a666fe04305699e293 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java-client] refactor AsyncKuduSession
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3477/3/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java: Line 409: Deferred> batchResponses = new Deferred<>(); > Nit: not really a fan of sometimes using Deferred.fromResult() and other ti Here is not a case with a result though, it's just creating a Deferred. -- To view, visit http://gerrit.cloudera.org:8080/3477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee6d029b1a56e254bfb9a870917883abeadb6b8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3388/4/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java: Line 327: operation.callback(response); > Does this invoke the user callback eventually? If so, why do it before addi It will do it right here, since it's the operation's callback were invoking. Good question regarding the ordering. Actually, aren't we missing a check on AUTO_FLUSH_BACKGROUND before adding it to the error collector here? But for the ordering it doesn't really matter IMO, the user either rely on the callback or the collector, not both. -- To view, visit http://gerrit.cloudera.org:8080/3388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Update links to kudu.apache.org
Jean-Daniel Cryans has posted comments on this change. Change subject: Update links to kudu.apache.org .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0523a4840196c92c739aeae5c0de6d52cb1a72a8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-HasComments: No
[kudu-CR](gh-pages) Update version numbers on releases page to say incubating
Jean-Daniel Cryans has posted comments on this change. Change subject: Update version numbers on releases page to say incubating .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id62cc81f5045d73df6164fae950efd64fa4b5758 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-HasComments: No
[kudu-CR] build: adjust boost location check slightly
Jean-Daniel Cryans has posted comments on this change. Change subject: build: adjust boost location check slightly .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac7ba5b803d04736d9ed0e1f9dc5093bef1051da Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
