Re: Review Request 36389: [WIP] Enable remote execution of arbitrary command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36389/ --- (Updated July 14, 2015, 5:16 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36389: [WIP] Enable remote execution of arbitrary command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36389/#review91587 --- Patch looks great! Reviews applied: [36389] All tests passed. - M

Re: Review Request 36424: Created a command executor helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/ --- (Updated July 14, 2015, 4:21 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 14, 2015, 4:09 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36389: [WIP] Enable remote execution of arbitrary command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36389/ --- (Updated July 14, 2015, 3:54 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36472: Update submitting-a-patch.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36472/#review91584 --- Patch looks great! Reviews applied: [36472] All tests passed. - M

Re: Review Request 36472: Update submitting-a-patch.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36472/ --- (Updated July 14, 2015, 3 a.m.) Review request for mesos. Repository: mesos

Review Request 36472: Update submitting-a-patch.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36472/ --- Review request for mesos. Repository: mesos Description --- When develop

Re: Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/ --- (Updated July 14, 2015, 2:53 a.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 36470: Updated scheduler driver to send TEARDOWN call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36470/#review91576 --- Patch looks great! Reviews applied: [36461, 36462, 36463, 36464, 36

Review Request 36461: Added FutureMessageType, DropMessagesType and ExpectNoFutureMessagesType.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36461/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2913 https://issues.ap

Re: Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/ --- (Updated July 14, 2015, 12:38 a.m.) Review request for mesos, Ian Downes, Jie Y

Review Request 36462: Added FUTURE_CALL, DROP_CALL, DROP_CALLS and EXPECT_NO_FUTURE_CALLS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36462/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2913 https://issues.ap

Review Request 36470: Updated scheduler driver to send TEARDOWN call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36470/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2913 https://issues.ap

Review Request 36469: Updated scheduler driver to send MESSAGE call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36469/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2913 https://issues.ap

Review Request 36466: Updated scheduler driver to send RECONCILE call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36466/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2913 https://issues.ap

Review Request 36463: Updated scheduler driver to send Kill Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36463/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2913 https://issues.ap

Review Request 36467: Updated scheduler driver to send ACKNOWLEDGE call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36467/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2913 https://issues.ap

Review Request 36464: Updated scheduler driver to send ACCEPT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36464/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2913 https://issues.ap

Review Request 36465: Updated scheduler driver to send REVIVE call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36465/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2913 https://issues.ap

Re: Review Request 36466: Updated scheduler driver to send RECONCILE call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36466/#review91568 --- Patch looks great! Reviews applied: [36461, 36462, 36463, 36464, 36

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review91550 --- Patch looks great! Reviews applied: [36424, 36425] All tests passe

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

> On July 13, 2015, 8:18 p.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, lines 108-110 > > > > > > Why not also add an Endpoint message to capture this part? Or a URL/I? > > > > message Endpoint

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

> On July 13, 2015, 8:18 p.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, lines 108-110 > > > > > > Why not also add an Endpoint message to capture this part? Or a URL/I? > > > > message Endpoint

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/#review91537 --- Thanks for doing this! Please ping me when this gets committed (in c

Re: Review Request 36425: Enabling IP Discovery script

> On July 13, 2015, 9:12 p.m., Cody Maloney wrote: > > Generally looks reasonable to me. I haven't integration tested yet inside > > DCOS, will work on that before too long. > > Marco Massenzio wrote: > > reasonable > > not exactly a ringing endorsement :) but I guess I'll take it.

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36380/#review91532 --- Patch looks great! Reviews applied: [36424, 36378, 36380] All test

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/ --- (Updated July 13, 2015, 9:35 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36425: Enabling IP Discovery script

> On July 13, 2015, 9:12 p.m., Cody Maloney wrote: > > Generally looks reasonable to me. I haven't integration tested yet inside > > DCOS, will work on that before too long. > reasonable not exactly a ringing endorsement :) but I guess I'll take it... care to give me a Ship it? > On July 13,

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review91518 --- Generally looks reasonable to me. I haven't integration tested yet i

Re: Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review91526 --- Ship it! Ship It! src/linux/cgroups.cpp (line 2022)

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36380/ --- (Updated July 13, 2015, 9:05 p.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/ --- (Updated July 13, 2015, 9:04 p.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/ --- (Updated July 13, 2015, 9:02 p.m.) Review request for mesos, Ben Mahler, Chi Zh

Re: Review Request 36453: Ignored subsequent calls to 'resourceOffers' in 'ReservationTest.CompatibleCheckpointedResources' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36453/#review91523 --- Patch looks great! Reviews applied: [36453] All tests passed. - M

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/#review91520 --- include/mesos/mesos.proto (lines 108 - 110)

Re: Review Request 36453: Ignored subsequent calls to 'resourceOffers' in 'ReservationTest.CompatibleCheckpointedResources' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36453/ --- (Updated July 13, 2015, 8:18 p.m.) Review request for mesos, Ben Mahler and Jie

Re: Review Request 36425: Enabling IP Discovery script

> On July 13, 2015, 6:14 p.m., Anand Mazumdar wrote: > > src/master/main.cpp, line 211 > > > > > > Can we remove the reference here ? > > > > strings::trim(...) returns a temporary that would be destroyed a

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

> On July 10, 2015, 9:43 p.m., Ian Downes wrote: > > src/tests/perf_tests.cpp, line 159 > > > > > > Do you need to keep all the logging of the context on failed > > expectations after the test has been correctly wr

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review91513 --- Patch looks great! Reviews applied: [36424, 36425] All tests passe

Re: Review Request 36453: Ignored subsequent calls to 'resourceOffers' in 'ReservationTest.CompatibleCheckpointedResources' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36453/#review91511 --- Ship it! src/tests/reservation_tests.cpp (line 928)

Review Request 36453: Ignored subsequent calls to 'resourceOffers' in 'ReservationTest.CompatibleCheckpointedResources' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36453/ --- Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-3034 https://i

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/ --- (Updated July 13, 2015, 7:25 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36425: Enabling IP Discovery script

> On July 13, 2015, 6:14 p.m., Anand Mazumdar wrote: > > a few fly-by general comments. thanks! > On July 13, 2015, 6:14 p.m., Anand Mazumdar wrote: > > src/master/main.cpp, line 205 > > > > > > Can we align this

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review91508 --- LGTM modulo Alex's reviews. Fix them and I'll commit this for you.

Re: Review Request 36425: Enabling IP Discovery script

> On July 13, 2015, 5:46 p.m., Cody Maloney wrote: > > src/master/main.cpp, line 35 > > > > > > unused include how did you find out? (I really miss IntelliJ highlighting that for me in Java...) > On July 13, 2015,

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/#review91506 --- LGTM. Will wait for the test before giving shipit. - Vinod Kone O

Re: Review Request 36326: containerizer: added cgroups based statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 13, 2015, 6:41 p.m.) Review request for Timothy Chen. Changes -

Re: Review Request 34141: AppC provsioning backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34141/#review91338 --- src/slave/containerizer/provisioners/appc/backend.hpp (lines 25 - 2

Re: Review Request 36450: Added an Address protobuf message for consistent address information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/#review91501 --- Patch looks great! Reviews applied: [36450] All tests passed. - M

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review91496 --- a few fly-by general comments. src/master/main.cpp (line 93)

Review Request 36450: Added an Address protobuf message for consistent address information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/ --- Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. Bugs: MESOS

Re: Review Request 36440: Update comments for mesos master cpp file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review91494 --- Ship it! Ship It! - Marco Massenzio On July 13, 2015, 5:42 a.m.,

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review91492 --- docs/configuration.md (line 92)

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 749 > > > > > > I think reserve is too abstract and may collide with future actions > > (think quota). How about `/dynamic/rese

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review91489 --- Patch looks great! Reviews applied: [36424, 36425] All tests passe

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review91472 --- A high level question: do you think rescinding offers is a big deal

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 749 > > > > > > I think reserve is too abstract and may collide with future actions > > (think quota). How about `/dynamic/rese

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/ --- (Updated July 13, 2015, 4:35 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36441: Update message when master is sending offer(s)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36441/#review91439 --- Patch looks great! Reviews applied: [36441] All tests passed. - M

Re: Review Request 35687: Added capabilities to state.json

> On June 20, 2015, 10:50 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp, line 124 > > > > > > Let's make it `foreachvalue` for consistency. > > Aditi Dixit wrote: > Hi, > I'm sorry, but I'm unable t

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review91436 --- src/master/http.cpp (line 124)