---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36810/#review93239
---
Did you test this with java enabled as well? What about without
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review93240
---
Did you test this with java enabled as well? What about without
On July 24, 2015, 7:23 p.m., Benjamin Hindman wrote:
3rdparty/libprocess/src/tests/ssl_tests.cpp, line 1020
https://reviews.apache.org/r/36757/diff/4/?file=1021132#file1021132line1020
Do you want to check that this payload and content-type actually make
their way to the socket by
On July 26, 2015, 4:21 p.m., Joris Van Remoortere wrote:
3rdparty/libprocess/src/tests/ssl_tests.cpp, lines 1025-1029
https://reviews.apache.org/r/36757/diff/4/?file=1021132#file1021132line1025
You're going to get rid of this anyway, but for future reference:
please use full
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/
---
(Updated July 27, 2015, 2:52 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/
---
(Updated July 27, 2015, 1:56 p.m.)
Review request for mesos, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36774/#review93112
---
Ship it!
Ship It!
- Till Toenshoff
On July 24, 2015, 3:33 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93132
---
Patch looks great!
Reviews applied: [36773]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93124
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 27, 2015, 12:19
On July 24, 2015, 2:14 p.m., Joerg Schad wrote:
src/slave/containerizer/fetcher.cpp, line 997
https://reviews.apache.org/r/36773/diff/1/?file=1020832#file1020832line997
This new behavior should be reflected in the documentation. AFAIK there
are two markdown files which would need
On July 26, 2015, 9:37 p.m., Jojy Varghese wrote:
src/master/http.cpp, line 339
https://reviews.apache.org/r/36720/diff/3/?file=1021869#file1021869line339
complexity of a function is measured by the nested if condition in it.
Maybe we accomplish the same using simple small
On July 26, 2015, 4:21 p.m., Joris Van Remoortere wrote:
3rdparty/libprocess/src/tests/ssl_tests.cpp, lines 1025-1029
https://reviews.apache.org/r/36757/diff/4/?file=1021132#file1021132line1025
You're going to get rid of this anyway, but for future reference:
please use full
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36839/#review93139
---
Ship it!
Thanks!
- Jie Yu
On July 27, 2015, 6:09 a.m., haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/#review93141
---
thanks for doing this!
(this may also fix a long-standing issue of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36754/#review93140
---
Ship it!
Ship It!
- Jie Yu
On July 26, 2015, 6:49 p.m., Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36829/#review93144
---
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 12:11 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93146
---
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 12:19 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36830/#review93145
---
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 12:17 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36845/#review93142
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36755/#review93055
---
Ship it!
src/tests/containerizer_tests.cpp (line 311)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36617/#review93147
---
Ship it!
Thanks Jan! I've made the updates from the feedback and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36822/#review93161
---
src/examples/long_lived_executor.cpp (lines 79 - 80)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36831/#review93152
---
Ship it!
src/tests/containerizer/isolator_tests.cpp (line 964)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36828/#review93167
---
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp (line 107)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36823/#review93160
---
src/tests/containerizer/cgroups_tests.cpp (line 817)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review93169
---
Oh, yes, thanks!
But I'm confused by your approach, can you please
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36825/#review93163
---
Ship it!
Ship It!
- Benjamin Hindman
On July 26, 2015, 7:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36826/#review93164
---
Ship it!
Ship It!
- Benjamin Hindman
On July 26, 2015, 7:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36824/#review93162
---
src/tests/containerizer/ns_tests.cpp (line 165)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36799/#review93151
---
Ship it!
Ship It!
- Benjamin Hindman
On July 26, 2015, 6:49
On July 27, 2015, 7:19 p.m., Benjamin Hindman wrote:
3rdparty/libprocess/src/libevent.cpp, lines 197-199
https://reviews.apache.org/r/36827/diff/2/?file=104#file104line197
Why not just:
#error Libevent must be compiled with either ...
For the cases
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36822/
---
(Updated July 27, 2015, 8:18 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36824/
---
(Updated July 27, 2015, 8:48 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/#review93187
---
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 2:15 p.m.,
On July 27, 2015, 7:21 p.m., Benjamin Hindman wrote:
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp, line 142
https://reviews.apache.org/r/36828/diff/2/?file=106#file106line142
Same comments here as previous reviews: use Latch instead of condition
variables here.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36733/#review93186
---
Ship it!
Ship It!
- Ben Mahler
On July 25, 2015, 2:11 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36823/
---
(Updated July 27, 2015, 8:35 p.m.)
Review request for mesos, Benjamin Hindman,
On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote:
A high level question: do you think rescinding offers is a big deal for now?
I don't believe it's a big deal for now because frameworks need to deal with
rescinded offers regardless, and I imagine the frequency of operators using
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36845/
---
(Updated July 27, 2015, 9:05 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/
---
(Updated July 27, 2015, 9:15 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36827/
---
(Updated July 27, 2015, 9:14 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36824/
---
(Updated July 27, 2015, 8:34 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36828/
---
(Updated July 27, 2015, 8:45 p.m.)
Review request for mesos, Benjamin Hindman,
On July 2, 2015, 3:39 p.m., Alexander Rukletsov wrote:
A high level question: do operators have the possibility to get a list of
all dynamic reservations? I think about a situation, when a framework made
some reservations and then quit, an operator wants to clean up those
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/#review93190
---
Patch looks great!
Reviews applied: [36822, 36823, 36824, 36825,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated July 27, 2015, 11:30 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36862/#review93197
---
Ship it!
Ship It!
- Jie Yu
On July 27, 2015, 10:30 p.m., Niklas
On July 16, 2015, 2:54 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, line 447
https://reviews.apache.org/r/35702/diff/9/?file=994080#file994080line447
Not directly related to endpoints, but to dynamic reservations in
general. Do you think it makes sense to bookkeep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/#review93200
---
Ship it!
Looks good modulo some minor indentation issues. I will
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36862/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-3159
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36862/
---
(Updated July 27, 2015, 3:30 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36862/#review93196
---
Patch looks great!
Reviews applied: [36862]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32961/#review93199
---
src/master/master.cpp (line 1850)
On July 16, 2015, 3:04 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, lines 1325-1332
https://reviews.apache.org/r/35983/diff/1/?file=994085#file994085line1325
Why do we need to recover resources for unreserve?
If reserved resources are offered, we need to recover the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36429/#review93143
---
Please do a rebase first since quite a lot of the stuff have been
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36870/#review93218
---
Patch looks great!
Reviews applied: [36868, 36869, 36870]
All
On July 27, 2015, 7:29 p.m., Marco Massenzio wrote:
configure.ac, lines 1093-1096
https://reviews.apache.org/r/36811/diff/1/?file=1021876#file1021876line1093
did you really mean to move and then comment out these lines? shouldn't
they be uncommented here?
Sorry for upload the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36318/#review93165
---
Nice work Anand!
I left feedback here, but it is all addressed in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36831/
---
(Updated July 27, 2015, 8:02 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36799/
---
(Updated July 27, 2015, 8:02 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36755/
---
(Updated July 27, 2015, 8:02 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93207
---
Bad patch!
Reviews applied: [36867]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36869/
---
Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36870/
---
Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/
---
(Updated July 28, 2015, 1:25 a.m.)
Review request for mesos, Adam B, Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/
---
(Updated July 28, 2015, 1:25 a.m.)
Review request for mesos, Adam B, Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93224
---
Patch looks great!
Reviews applied: [36867]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36831/
---
(Updated July 27, 2015, 11:45 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36845/#review93230
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93225
---
Ni
src/tests/fault_tolerance_tests.cpp (lines 1841 - 1844)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36318/
---
(Updated July 28, 2015, 3:47 a.m.)
Review request for mesos, Benjamin Hindman,
On July 27, 2015, 11:54 p.m., Ben Mahler wrote:
Nice work Anand!
I left feedback here, but it is all addressed in the diff I sent you over
email. With the diff applied this patch looks like a shippable step to me.
Note that per the comments, I also fenced off addFramework for http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36825/#review93082
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 26, 2015, 12:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36824/#review93083
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 26, 2015, 12:02
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36820/#review93085
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 26, 2015, 9:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36823/
---
(Updated July 27, 2015, 6:57 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36839/
---
Review request for mesos and Adam B.
Bugs: MESOS-3087
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36826/#review93081
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 26, 2015, 12:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36828/#review93080
---
Ship it!
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36823/#review93084
---
Ship it!
src/tests/containerizer/cgroups_tests.cpp (line 807)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36840/
---
Review request for mesos.
Bugs: MESOS-3150
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36841/#review93091
---
Ship it!
Ship It!
- haosdent huang
On July 27, 2015, 6:48 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36840/#review93092
---
Ship it!
Ship It!
- haosdent huang
On July 27, 2015, 6:47 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36827/
---
(Updated July 27, 2015, 7:01 a.m.)
Review request for mesos, Benjamin Hindman,
On July 23, 2015, 5:42 p.m., Timothy Chen wrote:
src/linux/cgroups.cpp, line 1696
https://reviews.apache.org/r/36620/diff/10/?file=1019693#file1019693line1696
Seems like we can just a lambda instead of a new fail method, then we
don't even need to store chain variable right?
We
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36828/
---
(Updated July 27, 2015, 7:04 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36839/#review93095
---
Patch looks great!
Reviews applied: [36839]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36841/#review93096
---
Bad patch!
Reviews applied: [36840]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36845/
---
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93099
---
Patch looks great!
Reviews applied: [36822, 36823, 36824, 36825,
On July 27, 2015, 5:43 a.m., Artem Harutyunyan wrote:
3rdparty/libprocess/configure.ac, lines 97-101
https://reviews.apache.org/r/36830/diff/1/?file=1022111#file1022111line97
Are you planning a follow-up patch to introduce this to the
configure.ac of Mesos as well?
Yep. Just
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36830/
---
(Updated July 27, 2015, 7:17 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/
---
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/#review93102
---
Patch looks great!
Reviews applied: [36822, 36823, 36824, 36825,
94 matches
Mail list logo
