Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review112792 --- Bad patch! Reviews applied: [39060] Failed command:

Re: Review Request 35711: Disallow special characters in role name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review112788 --- Looks good. My biggest question is whether `class Roles` needs to

Review Request 41878: Consistently used fixed width types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41878/ --- Review request for mesos, Michael Park and Jan Schlicht. Bugs: MESOS-4275

Re: Review Request 41920: Aligned the format of log for recoverResources().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41920/#review112795 --- Ship it! Ship It! - Adam B On Jan. 4, 2016, 11:59 p.m.,

Review Request 41879: Removed constructor which uses restricted width.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41879/ --- Review request for mesos, Michael Park and Jan Schlicht. Bugs: MESOS-4275

Re: Review Request 39060: Create master detector per url & not per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Jan. 5, 2016, 9:01 a.m.) Review request for mesos and Joris Van

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/#review112799 --- Ship it! The change itself looks great. My only concern is that

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 5, 2016, 10:23 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 41567: Clarified a comment that occurs in several test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41567/#review112807 --- Ship it! Ship It! - Guangya Liu On 十二月 18, 2015, 9:30 p.m.,

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/ --- (Updated Jan. 5, 2016, 10:18 a.m.) Review request for mesos and Benjamin

Re: Review Request 41594: Added support for `jsonify` result to `OK` response in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41594/ --- (Updated Jan. 5, 2016, 10:19 a.m.) Review request for mesos and Benjamin

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review112810 --- Ship it! Ship It! - Bernd Mathiske On Jan. 5, 2016, 2:34 a.m.,

Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md

> On Jan. 4, 2016, 6:35 p.m., Vinod Kone wrote: > > docs/oversubscription.md, line 204 > > > > > > s/controller/the `load` qos controller/ > > Guangya Liu wrote: > s/controller/, the load qos controller/?

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 5, 2016, 11:34 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/#review112802 --- 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp

Re: Review Request 41911: Added a test case for corrupt packets

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41911/#review112805 --- Bad patch! Reviews applied: [41158, 41911] Failed command:

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Jan. 5, 2016, 8:48 a.m.) Review request for mesos and Joris Van

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/#review112801 --- Patch looks great! Reviews applied: [41613] Passed command:

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 5, 2016, 10:39 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 5, 2016, 10:19 a.m.) Review request for mesos and Benjamin

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review112808 --- src/examples/test_http_authenticator_module.cpp (line 35)

Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41042/#review112850 --- Bad patch! Reviews applied: [40617] Failed command:

Re: Review Request 41593: Added `jsonify` function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/#review112845 --- Pretty clever code, it would be nice if some of the techniques

Review Request 41935: Added persistent volume HTTP endpoint authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41935/ --- Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht. Bugs:

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

> On Jan. 4, 2016, 10:30 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [41002, 41003, 41004, 41061, 4, 41166, 41167, 41169, > > 41560, 41294, 41370, 41378, 41779] > > > > Failed command: ./support/apply-review.sh -n -r 41779 > > > > Error: > > 2016-01-05 06:30:37

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 5, 2016, 5:17 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41550/#review112866 --- Bad patch! Reviews applied: [41546] Failed command:

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 5, 2016, 5:20 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Jan. 5, 2016, 1:57 p.m., Bernd Mathiske wrote: > > src/master/master.cpp, line 528 > > > > > > Isn't there a version of BasicAuthenticatorFactory::create() that takes > > credentials instead of parameters?

Re: Review Request 41780: Changed ContainerLogger and Fetcher to not duplicate FDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41780/ --- (Updated Jan. 5, 2016, 9:32 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41779: Extended Subprocess::IO::FD to optionally not duplicate the given FD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41779/ --- (Updated Jan. 5, 2016, 9:32 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41781: Logger Module: Add test for the rotating container logger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41781/ --- (Updated Jan. 5, 2016, 9:32 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review112865 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Review Request 41934: Added `DEFAULT_CREDENTIAL_2` to the tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41934/ --- Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht. Bugs:

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.

> On Jan. 5, 2016, 1:59 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 1259 > > > > > > This test almost entirely includes `AuthorizedQuotaSetRequest`. See > > below my suggestion

Re: Review Request 35711: Disallow special characters in role name.

> On Jan. 5, 2016, 8:16 a.m., Adam B wrote: > > Looks good. My biggest question is whether `class Roles` needs to exist, or > > whether we can just use freestanding `roles::validate()` functions. Thank you very much. I use vector instead. Could you help review again? - haosdent

Re: Review Request 41879: Removed constructor which uses restricted width.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41879/#review112855 --- Ship it! Ship It! - Jan Schlicht On Jan. 5, 2016, 9:27 a.m.,

Re: Review Request 41878: Consistently used fixed width types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41878/#review112854 --- Ship it! Ship It! - Jan Schlicht On Jan. 5, 2016, 9:23 a.m.,

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41550/ --- (Updated Jan. 5, 2016, 4:13 p.m.) Review request for mesos, Alexander

Re: Review Request 41927: Changed `Statistics` to only provide total CPU usage.

> On Jan. 5, 2016, 1:41 p.m., Till Toenshoff wrote: > > Ship It! Thanks for describing your testing that well! - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41927/#review112846

Re: Review Request 41927: Changed `Statistics` to only provide total CPU usage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41927/#review112846 --- Ship it! Ship It! - Till Toenshoff On Jan. 5, 2016, 1:14 p.m.,

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 5, 2016, 1:41 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 5, 2016, 1:42 p.m.) Review request for mesos, Adam B, Neil

Review Request 41933: Updated master help message for acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41933/ --- Review request for mesos and Adam B. Bugs: MESOS-4293

Re: Review Request 41878: Consistently used fixed width types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41878/#review112851 --- Ship it! Ship It! - Till Toenshoff On Jan. 5, 2016, 8:23 a.m.,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review112860 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094,

Re: Review Request 41879: Removed constructor which uses restricted width.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41879/#review112852 --- Ship it! Ship It! - Till Toenshoff On Jan. 5, 2016, 8:27 a.m.,

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 5, 2016, 1:40 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 35711: Disallow special characters in role name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated Jan. 5, 2016, 3:19 p.m.) Review request for mesos, Adam B, Jie Yu,

Review Request 41936: Required role in set quota request explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41936/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.

Review Request 41939: Simplified quota tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41939/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.

Review Request 41938: Cleaned up quota tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41938/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.

Review Request 41937: Factored out parsing `QuotaInfo` from JSON into a function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41937/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.

Re: Review Request 41549: [4/5] Quota Authorization: Documented quota removal authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41549/#review112888 --- Ship it! docs/authorization.md (line 50)

Re: Review Request 41622: Removed unnecessary std namespaces from registrar tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41622/#review112895 --- Ship it! Ship It! - Gilbert Song On Jan. 5, 2016, 10:54 a.m.,

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.

> On Jan. 5, 2016, 4:51 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [41546] > > > > Failed command: ./support/apply-review.sh -n -r 41546 > > > > Error: > > 2016-01-05 16:51:32 URL:https://reviews.apache.org/r/41546/diff/raw/ > > [946/946] -> "41546.patch" [1] > >

Re: Review Request 41933: Updated master help message for acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41933/#review112902 --- Patch looks great! Reviews applied: [41933] Passed command:

Re: Review Request 41891: Renaming offers to outstanding offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41891/#review112890 --- Ship it! Ship It! - Vinod Kone On Jan. 5, 2016, 1:35 a.m.,

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41896/#review112882 --- Ship it! LGTM! (modulo the remaining TODO)

Review Request 41622: Removed unnecessary std namespaces from registrar tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41622/ --- Review request for mesos. Repository: mesos Description --- Removed

Re: Review Request 41622: Removed unnecessary std namespaces from registrar tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41622/ --- (Updated Jan. 5, 2016, 7:10 p.m.) Review request for mesos. Changes ---

Re: Review Request 41548: [3/5] Quota Authorization: Implemented quota remove authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41548/#review112884 --- src/master/master.hpp (lines 1009 - 1010)

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/ --- (Updated Jan. 5, 2016, 11:05 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 38117: Export per container SNMP statistics

> On Dec. 15, 2015, 9:18 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, lines > > 1131-1173 > > > > > > Can you please pull the parsing code out into a function and

Re: Review Request 35711: Disallow special characters in role name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review112878 --- Patch looks great! Reviews applied: [35711] Passed command:

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.

> On Jan. 5, 2016, 4:51 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [41546] > > > > Failed command: ./support/apply-review.sh -n -r 41546 > > > > Error: > > 2016-01-05 16:51:32 URL:https://reviews.apache.org/r/41546/diff/raw/ > > [946/946] -> "41546.patch" [1] > >

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.

> On Jan. 5, 2016, 6:51 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, lines 1118-1124 > > > > > > Let's insert blank lines between ACL blocks for readability. Had the same thought while

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41550/#review112893 --- src/tests/authorization_tests.cpp (line 765)

Re: Review Request 41547: [2/5] Quota Authorization: Implemented authorization of "remove quota" requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41547/#review112876 --- Ship it! include/mesos/authorizer/authorizer.hpp (line 191)

Re: Review Request 41665: Tests: Use 'in_memory' registry by default for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41665/#review112873 --- Same general questions as AlexR. src/tests/master_tests.cpp

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review112877 --- src/master/master.cpp (line 505)

Re: Review Request 39923: Cleaned up configuration.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/ --- (Updated Jan. 5, 2016, 6:52 p.m.) Review request for mesos, Jojy Varghese,

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41550/#review112889 --- src/tests/master_quota_tests.cpp (lines 1118 - 1124)

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.

> On Jan. 5, 2016, 12:59 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 1380 > > > > > > Again, I think this one can be merged with > > `AuthorizedQuotaRemoveRequest` (you can use

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/ --- (Updated Jan. 5, 2016, 7:01 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 39923: Cleaned up configuration.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/ --- (Updated Jan. 5, 2016, 7:53 p.m.) Review request for mesos, Jojy Varghese,

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Jan. 5, 2016, 7:53 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 41622: Removed unnecessary std namespaces from registrar tests.

> On Jan. 5, 2016, 7:49 p.m., Till Toenshoff wrote: > > src/tests/registrar_tests.cpp, line 909 > > > > > > Seems `std::set` also can lose that namespace. > > Greg Mann wrote: > I originally got rid of `std::`

Re: Review Request 41622: Removed unnecessary std namespaces from registrar tests.

> On Jan. 5, 2016, 7:49 p.m., Till Toenshoff wrote: > > src/tests/registrar_tests.cpp, line 909 > > > > > > Seems `std::set` also can lose that namespace. > > Greg Mann wrote: > I originally got rid of `std::`

Re: Review Request 41935: Added persistent volume HTTP endpoint authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41935/#review112924 --- Patch looks great! Reviews applied: [41934, 41935] Passed

Re: Review Request 41593: Added `jsonify` function to stout.

> On Jan. 5, 2016, 2:56 p.m., Alexander Rojas wrote: > > Pretty clever code, it would be nice if some of the techniques were at > > least explained in a blog post with a link in the code. I'm mostly > > concerend about the use of C++17 functions (`std::rank`). Does that mean we > > are

Re: Review Request 41961: Added an HTTP decode response method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/#review113009 --- Patch looks great! Reviews applied: [41956, 41957, 41960, 41961]

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41787/#review113016 --- Patch looks great! Reviews applied: [41787] Passed command:

Re: Review Request 41953: Exposed docker v1/v2 spec protobuf and headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41953/#review113005 --- Bad patch! Reviews applied: [41953] Failed command:

Re: Review Request 41952: Added recommendations for programming with persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41952/#review113002 --- Patch looks great! Reviews applied: [41952] Passed command:

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41892/#review113019 --- src/docker/docker.cpp (lines 410 - 420)

Re: Review Request 41946: Added a `Representation` abstraction to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41946/ --- (Updated Jan. 6, 2016, 2:48 a.m.) Review request for mesos and Benjamin

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/ --- (Updated Jan. 6, 2016, 2:48 a.m.) Review request for mesos and Benjamin

Re: Review Request 41933: Updated master help message for acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41933/ --- (Updated 一月 6, 2016, 3:37 a.m.) Review request for mesos and Adam B. Changes

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41787/ --- (Updated 一月 6, 2016, 7:43 a.m.) Review request for mesos and Alexander

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review112944 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094,

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41896/ --- (Updated Jan. 5, 2016, 10:43 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41945: Fixed remaining flakiness in MasterMaintenanceTest.InverseOffersFilters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41945/#review112940 --- Ship it! LGTM ! - Anand Mazumdar On Jan. 5, 2016, 9:23 p.m.,

Re: Review Request 41593: Added `jsonify` function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 5, 2016, 10:38 p.m.) Review request for mesos and Benjamin

Review Request 41946: Added a `Representation` abstraction to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41946/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

> On Dec. 21, 2015, 5:04 a.m., Michael Park wrote: > > src/master/http.cpp, lines 134-150 > > > > > > @benh: How does this pattern look to you? If you're ok with it, we > > should find a better home for it.

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/ --- (Updated Jan. 5, 2016, 10:39 p.m.) Review request for mesos and Benjamin

Re: Review Request 39923: Cleaned up configuration.md.

> On Dec. 7, 2015, 9:42 p.m., Neil Conway wrote: > > What is the status of this patch -- can someone (Till) commit it? > > Greg Mann wrote: > Looks like this is in need of a rebase, I'll update it. Sry, did not have it on my radar -- it's always a good idea to add me as a reviewer for

Re: Review Request 41622: Removed unnecessary std namespaces from registrar tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41622/#review112908 --- Ship it! src/tests/registrar_tests.cpp (line 19)

Re: Review Request 41622: Removed unnecessary std namespaces from registrar tests.

> On Jan. 5, 2016, 7:49 p.m., Till Toenshoff wrote: > > Thanks Till! > On Jan. 5, 2016, 7:49 p.m., Till Toenshoff wrote: > > src/tests/registrar_tests.cpp, line 909 > > > > > > Seems `std::set` also can lose that

  1   2   3   >