Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.

2016-01-27 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/ --- (Updated Jan. 27, 2016, 10:29 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 40851: Windows:[1/2] Add patch for Windows ZK version.

2016-01-27 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40851/#review116638 --- Ship it! Ship It! - Alex Clemmer On Jan. 27, 2016, 10:29

Review Request 42888: Used absolute paths for excludes paths in posix disk isolator.

2016-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42888/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.

Re: Review Request 42890: Allocator Performance: Simplified Sorter's 'CalculateShare'.

2016-01-27 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42890/ --- (Updated Jan. 28, 2016, 1:44 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 42794: URL query string order is defined.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/#review116635 --- Patch looks great! Reviews applied: [42794] Passed command:

Review Request 42876: Disallowed non-`const` iteration over `Resources`.

2016-01-27 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42876/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-4534

Re: Review Request 42866: Disabled the test RegistryClientTest.BadTokenServerAddress.

2016-01-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42866/#review116651 --- Ship it! Ship It! - Anand Mazumdar On Jan. 27, 2016, 8:38

Re: Review Request 42881: Updated release guide to include running the benchmarks.

2016-01-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42881/#review116662 --- Ship it! Ship It! - Vinod Kone On Jan. 28, 2016, 12:11

Re: Review Request 42872: Relaxed the subsystem check for net_cls.

2016-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42872/#review116672 --- Fix it, then Ship it!

Re: Review Request 42603: Added an http::Authenticator factory.

2016-01-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/#review116641 --- Fix it, then Ship it!

Re: Review Request 42865: Fixed LogrotateContainerLogger's FD ownership.

2016-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42865/#review116657 --- src/slave/container_loggers/lib_logrotate.cpp (line 107)

Re: Review Request 42865: Fixed LogrotateContainerLogger's FD ownership.

2016-01-27 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42865/ --- (Updated Jan. 27, 2016, 4:11 p.m.) Review request for mesos, Benjamin Hindman

Review Request 42881: Updated release guide to include running the benchmarks.

2016-01-27 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42881/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 42866: Disabled the test RegistryClientTest.BadTokenServerAddress.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42866/#review116664 --- Patch looks great! Reviews applied: [42866] Passed command:

Review Request 42887: Fixed a flaky test in disk quota tests.

2016-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42887/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Review Request 42873: Enhanced the NetClsIsolatorTest filter.

2016-01-27 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42873/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4530

Re: Review Request 40851: Windows:[1/2] Add patch for Windows ZK version.

2016-01-27 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40851/ --- (Updated Jan. 27, 2016, 10:29 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 42773: Added utility function to compute SHA512 digest.

2016-01-27 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/ --- (Updated Jan. 27, 2016, 10:29 p.m.) Review request for mesos. Changes

Re: Review Request 42865: Fixed LogrotateContainerLogger's FD ownership.

2016-01-27 Thread Joseph Wu
> On Jan. 27, 2016, 4:02 p.m., Benjamin Hindman wrote: > > src/slave/container_loggers/lib_logrotate.cpp, line 149 > > > > > > Is this supposed to be `outfds` or `errfds`? Do we need the `cloexec` > > at all? If

Re: Review Request 42865: Fixed LogrotateContainerLogger's FD ownership.

2016-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42865/#review116663 --- Ship it! Ship It! - Benjamin Hindman On Jan. 28, 2016,

Re: Review Request 42615: mesos: Cleaned up usage of namespace-qualified identifiers.

2016-01-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42615/ --- (Updated Jan. 28, 2016, 12:56 a.m.) Review request for mesos and Michael Park.

Re: Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.

2016-01-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/ --- (Updated Jan. 28, 2016, 12:56 a.m.) Review request for mesos and Michael Park.

Re: Review Request 42888: Used absolute paths for excludes paths in posix disk isolator.

2016-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42888/ --- (Updated Jan. 28, 2016, 1:14 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/#review116676 --- Patch looks great! Reviews applied: [39850, 39851, 39852, 39888,

Re: Review Request 42878: Fixed the NetClsIsolatorTest to correctly learn the net_cls hierarchy.

2016-01-27 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42878/ --- (Updated Jan. 28, 2016, 1:48 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42876: Disallowed non-`const` iteration over `Resources`.

2016-01-27 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42876/#review116661 --- Ship it! Ship It! - Klaus Ma On Jan. 28, 2016, 6:50 a.m.,

Re: Review Request 42876: Disallowed non-`const` iteration over `Resources`.

2016-01-27 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42876/ --- (Updated Jan. 27, 2016, 10:50 p.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 42880: Add test for LogrotateContainerLogger's FD management.

2016-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42880/#review116654 --- Fix it, then Ship it! src/tests/container_logger_tests.cpp

Re: Review Request 42876: Disallowed non-`const` iteration over `Resources`.

2016-01-27 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42876/#review116656 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 27, 2016,

Re: Review Request 42880: Add test for LogrotateContainerLogger's FD management.

2016-01-27 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42880/ --- (Updated Jan. 27, 2016, 4:09 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Benjamin Bannier
> On Jan. 27, 2016, 8:44 p.m., Benjamin Bannier wrote: > > Looks mostly good to me. A few things were unclear to me: > > > > * Would it make sense to add an `installcheck` target? My expectation for > > that would be for it to invoke the installed tests and adding the > > (in)correct

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116652 --- Fix it, then Ship it! src/Makefile.am (line 1999)

Re: Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests.

2016-01-27 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/#review116670 --- Ship it! Ship It! - Klaus Ma On Jan. 28, 2016, 6:56 a.m.,

Re: Review Request 42662: Added common command utils file.

2016-01-27 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42662/#review116665 --- src/common/command_utils.cpp (line 17)

Review Request 42890: Allocator Performance: Simplified Sorter's 'CalculateShare'.

2016-01-27 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42890/ --- Review request for mesos, Jie Yu and Michael Park. Repository: mesos

Review Request 42872: Relaxed the subsystem check for net_cls.

2016-01-27 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42872/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4530

Re: Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests.

2016-01-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/ --- (Updated Jan. 27, 2016, 10:56 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 28, 2016, 12:49 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42887: Fixed a flaky test in disk quota tests.

2016-01-27 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42887/#review116683 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 28, 2016,

Review Request 42878: Fixed the NetClsIsolatorTest to correctly learn the net_cls hierarchy.

2016-01-27 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42878/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4530

Re: Review Request 42648: Moved http authenticator initialization to main.

2016-01-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42648/#review116648 --- src/master/main.cpp (line 112)

Re: Review Request 42878: Fixed the NetClsIsolatorTest to correctly learn the net_cls hierarchy.

2016-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42878/#review116677 --- Fix it, then Ship it!

Re: Review Request 42890: Allocator Performance: Simplified Sorter's 'CalculateShare'.

2016-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42890/#review116692 --- Ship it! Ship It! - Jie Yu On Jan. 28, 2016, 1:44 a.m.,

Re: Review Request 42662: Added common command utils file.

2016-01-27 Thread Jie Yu
> On Jan. 28, 2016, 12:52 a.m., Klaus Ma wrote: > > src/common/command_utils.cpp, line 17 > > > > > > Move to line 28. > > Jojy Varghese wrote: > According to google style guide >

Re: Review Request 42860: Add paths::sameParent to find out the same root of a path list.

2016-01-27 Thread haosdent huang
> On Jan. 27, 2016, 9:06 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 68 > > > > > > I am extremely confused about the expected semantics of this function > >

Re: Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/#review116719 --- Bad patch! Reviews applied: [42615] Failed command:

Re: Review Request 42890: Allocator Performance: Simplified Sorter's 'CalculateShare'.

2016-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42890/#review116696 --- src/master/allocator/sorter/drf/sorter.cpp (line 358)

Re: Review Request 42662: Added common command utils file.

2016-01-27 Thread Jojy Varghese
> On Jan. 28, 2016, 12:52 a.m., Klaus Ma wrote: > > src/tests/common/command_utils_tests.cpp, line 71 > > > > > > Add a case for `tar/untar` failure. > > Jojy Varghese wrote: > Will add a TODO. > > Jie Yu

Re: Review Request 42860: Add paths::sameParent to find out the same root of a path list.

2016-01-27 Thread haosdent huang
> On Jan. 27, 2016, 9:06 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 68 > > > > > > I am extremely confused about the expected semantics of this function > >

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation.

2016-01-27 Thread Avinash sridharan
> On Jan. 19, 2016, 10:37 a.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 253 > > > > > > Could we check for 0.2 CPU here? > > Avinash sridharan wrote: > This makes sense. Will modify the

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation.

2016-01-27 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 28, 2016, 2:20 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 42662: Added common command utils file.

2016-01-27 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42662/ --- (Updated Jan. 28, 2016, 2:21 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42860: Add paths::sameParent to find out the same root of a path list.

2016-01-27 Thread Benjamin Bannier
> On Jan. 27, 2016, 10:06 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 68 > > > > > > I am extremely confused about the expected semantics of this function > >

Re: Review Request 42888: Used absolute paths for excludes paths in posix disk isolator.

2016-01-27 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42888/#review116700 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 28, 2016,

Re: Review Request 42890: Allocator Performance: Simplified Sorter's 'CalculateShare'.

2016-01-27 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42890/#review116710 --- Ship it! Ship It! - Michael Park On Jan. 28, 2016, 2:59

Re: Review Request 42589: Added test case for allocator recover with Quota.

2016-01-27 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/#review116725 --- ping AlexR/Joris, can you help to review this test case for

Re: Review Request 42890: Allocator Performance: Simplified Sorter's 'CalculateShare'.

2016-01-27 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42890/ --- (Updated Jan. 28, 2016, 2:59 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 40851: Windows:[1/2] Add patch for Windows ZK version.

2016-01-27 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40851/ --- (Updated Jan. 28, 2016, 4:59 a.m.) Review request for Alex Naparu, Dario

Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.

2016-01-27 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/ --- (Updated Jan. 28, 2016, 4:58 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-01-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated Jan. 28, 2016, 2:12 a.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 42860: Add paths::sameParent to find out the same root of a path list.

2016-01-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/ --- (Updated Jan. 28, 2016, 2:12 a.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 42835: Updated the allocator to not offer unreserved resources beyond quota.

2016-01-27 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42835/#review116695 --- src/master/allocator/mesos/hierarchical.cpp (line 1341)

Re: Review Request 42662: Added common command utils file.

2016-01-27 Thread Jojy Varghese
> On Jan. 28, 2016, 12:52 a.m., Klaus Ma wrote: > > src/common/command_utils.cpp, line 17 > > > > > > Move to line 28. According to google style guide

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116707 --- Patch looks great! Reviews applied: [42530, 42362] Passed

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116714 --- Patch looks great! Reviews applied: [39780, 39781, 39782, 40553]

Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.

2016-01-27 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/#review116640 --- Ship it! Ship It! - Alex Clemmer On Jan. 27, 2016, 10:29

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 27, 2016, 11:03 p.m.) Review request for mesos, Alexander

Re: Review Request 42865: Fixed LogrotateContainerLogger's FD ownership.

2016-01-27 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42865/ --- (Updated Jan. 27, 2016, 3:20 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116649 --- Fix it, then Ship it! LGTM.

Review Request 42880: Add test for LogrotateContainerLogger's FD management.

2016-01-27 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42880/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs:

Re: Review Request 42603: Added an http::Authenticator factory.

2016-01-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/ --- (Updated Jan. 27, 2016, 4:38 p.m.) Review request for mesos, Alexander

Re: Review Request 42603: Added an http::Authenticator factory.

2016-01-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/#review116591 --- Could you separate changes due to `http::Authenticator` and for

Review Request 42900: Fixed some typos.

2016-01-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42900/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 42901: Fixed a few typos in the HA framework guide.

2016-01-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42901/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review116731 --- Patch looks great! Reviews applied: [42860, 42861] Passed

Review Request 42860: Add paths::sameParent to find out the same root of a path list.

2016-01-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-4521

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 27, 2016, 6:24 p.m.) Review request for mesos, Alexander

Re: Review Request 42839: WIP: Appc cache redesign.

2016-01-27 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42839/ --- (Updated Jan. 27, 2016, 5:01 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42841: WIP: Introducing appc image fetcher.

2016-01-27 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/ --- (Updated Jan. 27, 2016, 5:02 p.m.) Review request for mesos and Jie Yu.

Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-01-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-4521

Re: Review Request 42841: WIP: Introducing appc image fetcher.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/#review116599 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

2016-01-27 Thread Zhitao Li
> On Jan. 15, 2016, 12:03 a.m., Zhitao Li wrote: > > src/docker/docker.cpp, lines 410-420 > > > > > > (Sorry I just got time to come back to this). > > > > I don't exactly understand your suggestion about

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

2016-01-27 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41892/#review116595 --- src/docker/executor.cpp (line 136)

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 27, 2016, 5:54 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42860: Add paths::sameParent to find out the same root of a path list.

2016-01-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/ --- (Updated Jan. 27, 2016, 6:36 p.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

2016-01-27 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/ --- (Updated Jan. 27, 2016, 6:47 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-01-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated Jan. 27, 2016, 6:36 p.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

2016-01-27 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- (Updated Jan. 27, 2016, 6:44 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

2016-01-27 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- (Updated Jan. 27, 2016, 6:44 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 42648: Moved http authenticator initialization to main.

2016-01-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42648/ --- (Updated Jan. 27, 2016, 7:50 p.m.) Review request for mesos, Alexander

Re: Review Request 42794: URL query string order is defined.

2016-01-27 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/ --- (Updated Jan. 27, 2016, 7:07 p.m.) Review request for mesos, Kapil Arya and

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

2016-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/#review116609 --- Fix it, then Ship it!

Re: Review Request 42662: Added common command utils file.

2016-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42662/#review116600 --- Fix it, then Ship it! This is looking good! Some nits and

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116608 --- Patch looks great! Reviews applied: [39780, 39781, 39782, 40553]

Re: Review Request 42839: WIP: Appc cache redesign.

2016-01-27 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42839/ --- (Updated Jan. 27, 2016, 8:25 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42841: WIP: Introducing appc image fetcher.

2016-01-27 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/ --- (Updated Jan. 27, 2016, 8:26 p.m.) Review request for Jie Yu. Changes

Re: Review Request 42662: Added common command utils file.

2016-01-27 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42662/ --- (Updated Jan. 27, 2016, 8:29 p.m.) Review request for mesos and Jie Yu.

Review Request 42866: Disabled the test RegistryClientTest.BadTokenServerAddress.

2016-01-27 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42866/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116610 --- Looks mostly good to me. A few things were unclear to me: *

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

2016-01-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Jan. 27, 2016, 11:55 a.m.) Review request for mesos, Artem

  1   2   >