Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

> On April 18, 2016, 5:03 p.m., Ben Mahler wrote: > > src/authorizer/local/authorizer.cpp, line 204 > > > > > > We generally avoid 'default' cases in enum switches because they allow > > the code to compile when a n

Re: Review Request 46564: Fixed a typo in Docker containerizer.

> On April 25, 2016, 1:48 a.m., Timothy Chen wrote: > > Can you rebase your patch? Thanks! > > Qian Zhang wrote: > Sorry, I do not quite understand. I think the file I updated in this > patch was not updated by others after I posted this patch, so there should be > no conflict, right? :-)

Re: Review Request 46564: Fixed a typo in Docker containerizer.

> On April 25, 2016, 9:48 a.m., Timothy Chen wrote: > > Can you rebase your patch? Thanks! Sorry, I do not quite understand. I think the file I updated in this patch was not updated by others after I posted this patch, so there should be no conflict, right? :-) - Qian -

Review Request 46624: Added support to mesos to work with flag alias.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46624/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-5271 https://issues.ap

Review Request 46623: Updated libprocess to work with flag alias.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46623/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-5271 https://issues.ap

Review Request 46622: Added tests for flag aliases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46622/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-5271 https://issues.ap

Review Request 46621: Add alias support for flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-5271 https://issues.ap

Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-5271 https://issues.ap

Re: Review Request 46617: Update HttpDockerExecutor with v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46617/#review130344 --- Patch looks great! Reviews applied: [46615, 46616, 46617] Passed

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46618/ --- (Updated 四月 25, 2016, 5:26 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 45671: Added version checking for dvdcli.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45671/#review130343 --- Patch looks great! Reviews applied: [45671] Passed command: expo

Review Request 46618: Enhanced the log message when there are duplicate volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46618/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Descript

Review Request 46617: Update HttpDockerExecutor with v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46617/ --- Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone. Bugs

Review Request 46616: Add --http_docker_executor flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46616/ --- Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone. Bugs

Review Request 46615: Add HTTP docker executor to Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46615/ --- Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone. Bugs

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review130342 --- src/files/files.cpp (line 362)

Re: Review Request 45671: Added version checking for dvdcli.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45671/ --- (Updated 四月 25, 2016, 3:17 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

Thank you for you quick reply! `src/linux/fs.cpp` only effective under Linux, so I think @Tomasz's patch should be fine. I verify add ``` #include ``` works on Ubuntu 14.04, CentOS 6, CentOS 7. Anyway, let's see what others concerns after @Tomasz find a shepherd. Thank you all! On Mon, Apr 25

Re: Review Request 46564: Fixed a typo in Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46564/#review130341 --- Can you rebase your patch? Thanks! - Timothy Chen On April 22,

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

> On 四月 24, 2016, 5:49 p.m., Gilbert Song wrote: > > This patch looks good to me. Almost ship it! > > > > Just one concern: > > > > Should we move the ref count logic out if we decide the future default > > behavior without ref count? then, add ref count logic together with the > > agent fla

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

Hi @idownes and @chenzhiwei. @Tomasz proposal to add the correct header file `` for pivot_root syscall. According my understand, we could drop these workaround code: ``` #elif __x86_64__ // A workaround for systems that have an old glib but have a new // kernel. The magic number '155' is the s

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

> On April 24, 2016, 12:40 p.m., haosdent huang wrote: > > > > haosdent huang wrote: > In additional, could you add @chenzhiwei and @vinodkone in reviewers? I > think powerpc could drop > > ``` > #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__ > // A workaround

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

> On April 24, 2016, 12:40 p.m., haosdent huang wrote: > > > > haosdent huang wrote: > In additional, could you add @chenzhiwei and @vinodkone in reviewers? I > think powerpc could drop > > ``` > #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__ > // A workaround

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

> On April 24, 2016, 12:40 p.m., haosdent huang wrote: > > > > haosdent huang wrote: > In additional, could you add @chenzhiwei and @vinodkone in reviewers? I > think powerpc could drop > > ``` > #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__ > // A workaround

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

> On 四月 24, 2016, 5:47 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 418-419 > > > > > > containerDir contains the containerId, right? Yes, but seems sp

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

> On 四月 24, 2016, 5:49 p.m., Gilbert Song wrote: > > This patch looks good to me. Almost ship it! > > > > Just one concern: > > > > Should we move the ref count logic out if we decide the future default > > behavior without ref count? then, add ref count logic together with the > > agent fla

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

> On April 24, 2016, 12:40 p.m., haosdent huang wrote: > > > > haosdent huang wrote: > In additional, could you add @chenzhiwei and @vinodkone in reviewers? I > think powerpc could drop > > ``` > #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__ > // A workaround

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

> On April 24, 2016, 12:40 p.m., haosdent huang wrote: > > > > haosdent huang wrote: > In additional, could you add @chenzhiwei and @vinodkone in reviewers? I > think powerpc could drop > > ``` > #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__ > // A workaround

Re: Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/#review130324 --- Bad patch! Reviews applied: [46613] Failed command: ./support/ap

Re: Review Request 45265: Plugged in docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45265/#review130323 --- Ship it! Ship It! - Jie Yu On April 23, 2016, 8:49 a.m., Gua

Re: Review Request 44609: Enabled sequene when unmount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44609/#review130322 --- Ship it! Ship It! - Jie Yu On April 23, 2016, 8:47 a.m., Gua

Re: Review Request 44454: Enabled Sequence mount for prepare().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/#review130321 --- Ship it! Ship It! - Jie Yu On April 24, 2016, 9:56 a.m., Gua

Re: Review Request 45674: Implemented recover() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/#review130320 --- Ship it! Ship It! - Jie Yu On April 23, 2016, 8:20 a.m., Gua

Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- Review request for mesos, Adam B and Alexander Rojas. Bugs: MESOS-5169 http

Re: Review Request 45265: Plugged in docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45265/#review130319 --- Ship it! Ship It! - Gilbert Song On April 23, 2016, 1:49 a.m

Re: Review Request 45674: Implemented recover() for dvd isolator.

> On April 24, 2016, 5:52 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 133-134 > > > > > > Let's quote the containerId. We don't quote containerId beca

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130316 --- Ship it! Ship It! - Jie Yu On April 24, 2016, 9:50 a.m., Gua

Re: Review Request 45674: Implemented recover() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/#review130315 --- src/slave/containerizer/mesos/isolators/docker/volume/isolator.cp

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130314 --- This patch looks good to me. Almost ship it! Just one concern:

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130313 --- src/slave/containerizer/mesos/isolators/docker/volume/isolator.cp

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130312 --- src/slave/containerizer/mesos/isolators/docker/volume/isolator.cp

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review130311 --- Ship it! Ship It! - Jie Yu On April 24, 2016, 9:44 a.m., Gua

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46610/#review130305 --- Patch looks great! Reviews applied: [46610] Passed command: expo

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

> On April 24, 2016, 12:40 p.m., haosdent huang wrote: > > In additional, could you add @chenzhiwei and @vinodkone in reviewers? I think powerpc could drop ``` #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__ // A workaround for powerpc. The magic number '203' is the syscall // n

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46610/#review130303 --- src/linux/fs.cpp (line 442)

Review Request 46610: Fix 'pivot_root is not available' error on ARM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46610/ --- Review request for mesos and haosdent huang. Repository: mesos Description --

Re: Review Request 44454: Enabled Sequence mount for prepare().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/ --- (Updated 四月 24, 2016, 9:56 a.m.) Review request for mesos, David vonThenen, Gil

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 24, 2016, 6:29 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 174-188 > > > > > > Let's not create any side effect at this moment. Let's do that after

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/ --- (Updated 四月 24, 2016, 9:50 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 24, 2016, 9:44 a.m.) Review request for mesos, David vonThenen, Gil

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 24, 2016, 6:29 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 174-188 > > > > > > Let's not create any side effect at this moment. Let's do that after

Re: Review Request 45377: Ignored docker volume when updating container volume path.

> On 四月 24, 2016, 5:29 a.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3826-3831 > > > > > > Can you adjust the comments here? It's not just for docker volumes. For > > other volume source types we'll add in the

Re: Review Request 45377: Ignored docker volume when updating container volume path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 24, 2016, 8:08 a.m.) Review request for mesos, David vonThenen, Gil

Re: Review Request 46609: [WIP] Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46609/#review130298 --- Bad patch! Reviews applied: [46609, 46204, 46188] Failed command

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 24, 2016, 7:02 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, lines > > 65-70 > > > > > > Also, I realized that we don't need this struct. We just need the mount

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 24, 2016, 6:29 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 174-188 > > > > > > Let's not create any side effect at this moment. Let's do that after

Re: Review Request 45377: Ignored docker volume when updating container volume path.

> On 四月 24, 2016, 5:29 a.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3826-3831 > > > > > > Can you adjust the comments here? It's not just for docker volumes. For > > other volume source types we'll add in the

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review130293 --- src/slave/containerizer/mesos/isolators/docker/volume/isolator.cp

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On April 24, 2016, 7:02 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, lines > > 65-70 > > > > > > Also, I realized that we don't need this struct. We just need the mou

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On April 24, 2016, 7:02 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, lines > > 65-70 > > > > > > Also, I realized that we don't need this struct. We just need the mou

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On April 24, 2016, 6:29 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 174-188 > > > > > > Let's not create any side effect at this moment. Let's do that aft

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review130287 --- src/slave/containerizer/mesos/isolators/docker/volume/isolator.hp