Re: Review Request 53715: Define docker `--entrypoint` for `Windows`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53715/ --- (Updated Nov. 23, 2016, 6:59 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 52190: Removed deprecated compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/ --- (Updated Nov. 23, 2016, 6:56 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 53949: Added test helper to obtain unused port.

> On Nov. 23, 2016, 3:20 a.m., haosdent huang wrote: > > src/tests/utils.cpp, line 82 > > > > > > Should we move the comment > > > > ``` > > // Bind to port 0 to obtain a random unused port. > > ```

Re: Review Request 54021: Updated a Docker containerizer test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54021/#review156705 --- Fix it, then Ship it! Looks good, just fix the comment.

Re: Review Request 52972: Replaced POSIX `int` with `int_fd` abstraction in `stout` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52972/ --- (Updated Nov. 23, 2016, 6:31 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 52625: Replaced POSIX `int` with `int_fd` abstraction in `libprocess` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52625/ --- (Updated Nov. 23, 2016, 6:31 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 53706: Implemented `os::user' on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53706/ --- (Updated Nov. 23, 2016, 6:30 a.m.) Review request for mesos, Alex Naparu,

Review Request 54021: Updated a Docker containerizer test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54021/ --- Review request for mesos, Adam B, Kevin Klues, and Vinod Kone. Bugs:

Re: Review Request 54001: Addes status method to DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54001/#review156704 --- Patch looks great! Reviews applied: [54001] Passed command:

Re: Review Request 54014: Fixed missing protobuf java package definition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54014/ --- (Updated Nov. 23, 2016, 5:46 a.m.) Review request for mesos and Anand

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/ --- (Updated Nov. 23, 2016, 5:46 a.m.) Review request for mesos, Anand Mazumdar

Review Request 54019: Modernized code to use `foreachpair` with LinkedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54019/ --- Review request for mesos and Michael Park. Bugs: MESOS-6626

Review Request 54018: Enhanced LinkedHashMap to support `foreachpair` and friends.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54018/ --- Review request for mesos and Michael Park. Bugs: MESOS-6626

Review Request 54017: Changed implementation of LinkedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54017/ --- Review request for mesos and Michael Park. Bugs: MESOS-6626

Review Request 54016: Fixed a few places to use `foreachkey` / `foreachvalue`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54016/ --- Review request for mesos and Michael Park. Bugs: MESOS-6626

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > Nice first patch and welcome to the community! > > > > - Can you update the Testing Done section with details on testing? > > - We also support Python bindings. Do you mind adding these protos to our > > python build too in a follow up

Review Request 54014: Fixed missing protobuf java package definition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54014/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-6597

Review Request 54015: Added V1 API protos to python bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54015/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-6597

Re: Review Request 53610: Added health checks documentation.

> On Nov. 9, 2016, 5:32 p.m., haosdent huang wrote: > > docs/health-checks.md, line 29 > > > > > > s/functionality/functionalities/g > > Alexander Rukletsov wrote: > I believe it is fine to use singular here.

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/ --- (Updated Nov. 23, 2016, 4:31 a.m.) Review request for mesos, Anand Mazumdar

Review Request 54013: Added user doc for nested container and task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and Vinod

Re: Review Request 54007: Printed complete health check configuration on task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/#review156700 --- src/health-check/health_checker.cpp (line 213)

Re: Review Request 53974: Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53974/#review156698 --- Bad patch! Reviews applied: [53974, 53939, 53837, 53938, 53936,

Re: Review Request 54004: Renamed functions in HealthChecker for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54004/#review156697 --- Ship it! Ship It! - haosdent huang On Nov. 23, 2016, 12:29

Re: Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/#review156694 --- Patch looks great! Reviews applied: [53877] Passed command:

Re: Review Request 53938: Added helper to get the io switchboard server address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53938/ --- (Updated Nov. 23, 2016, 2:45 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53837: Added a per container io switchboard server process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53837/ --- (Updated Nov. 23, 2016, 2:45 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53704: Added a level of indirection for logger through an IO Switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53704/ --- (Updated Nov. 23, 2016, 2:40 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 53950: Avoided hardcoding ports in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53950/#review156693 --- Ship it! Ship It! - haosdent huang On Nov. 22, 2016, 7:49

Re: Review Request 53929: Improved performance for `getQuotaRoleAllocatedResources` in allocator.

> On 十一月 21, 2016, 7:27 p.m., Benjamin Mahler wrote: > > I pushed the change since this is cleaner and it looks like you ran the > > benchmark. Any reason you didn't include the results? > > > > Do we have benchmark coverage of the quota code paths? If not, did you > > write a small custom

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/#review156691 --- Fix it, then Ship it! Ship It! src/tests/utils.cpp (line 82)

Re: Review Request 54001: Addes status method to DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54001/#review156682 --- Ship it! Ship It! - Adam B On Nov. 22, 2016, 1:51 p.m., Jie

Re: Review Request 53803: Added a new libprocess HTTP test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53803/#review156677 --- Thanks for taking on this issue and testing it!

Re: Review Request 53546: Added stub classes for rest cgroups subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53546/#review156681 --- Hi Haosdent! I think the subsystem name for PIDs is `pids`

Re: Review Request 53614: Updated the markdown style guide with headings capitalization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53614/#review156680 --- Bad patch! Reviews applied: [53614, 53613, 53612, 53611, 53610]

Re: Review Request 53546: Added stub classes for rest cgroups subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53546/#review156678 --- src/CMakeLists.txt (line 173)

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

> On Oct. 21, 2016, 7:35 p.m., Benjamin Mahler wrote: > > src/health-check/health_checker.cpp, line 188 > > > > > > Isn't this going to lead to some slightly confusing logging where we > > say "Rescheduling" for

Re: Review Request 54007: Printed complete health check configuration on task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/ --- (Updated Nov. 23, 2016, 1:11 a.m.) Review request for mesos, Gastón Kleiman

Review Request 54007: Printed complete health check configuration on task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/ --- Review request for mesos, Gastón Kleiman and haosdent huang. Repository: mesos

Re: Review Request 52871: Ensured default executor ignores health updates for terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52871/ --- (Updated Nov. 23, 2016, 1:06 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 53308: Added new hook for modifying the executor environment.

> On Nov. 10, 2016, 7:19 a.m., Kapil Arya wrote: > > Before doing full review, I am wondering if we can create a new protobuf > > called `DockerExecutorPrepareInfo` or something similar with the idea that > > we can pass on not only environment variables, but also volumes (and any > > other

Re: Review Request 53998: Fixed hook to allow for executor environment modifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53998/#review156674 --- Fix it, then Ship it! This change looks fine to me too.

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/ --- (Updated Nov. 23, 2016, 12:58 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/ --- (Updated Nov. 23, 2016, 12:54 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 52872: Used callback instead of `send()` for health status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52872/ --- (Updated Nov. 23, 2016, 12:52 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52873: Cleaned up private members in HealthChecker class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52873/ --- (Updated Nov. 23, 2016, 12:52 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/ --- (Updated Nov. 23, 2016, 12:52 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 52868: Health checks may be stopped on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52868/ --- (Updated Nov. 23, 2016, 12:51 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/ --- (Updated Nov. 23, 2016, 12:50 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52871: Ensured default executor ignores health updates for terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52871/ --- (Updated Nov. 23, 2016, 12:50 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52869: Ensured command executor stops health checking terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52869/ --- (Updated Nov. 23, 2016, 12:48 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52870: Ensured docker executor stops health checking terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/ --- (Updated Nov. 23, 2016, 12:48 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52868: Added pause/resume functionality to HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52868/ --- (Updated Nov. 23, 2016, 12:45 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52867/ --- (Updated Nov. 23, 2016, 12:44 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 53313: Windows: Disable persistent state for Windows master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53313/ --- (Updated Nov. 22, 2016, 4:30 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/ --- (Updated Nov. 23, 2016, 12:30 a.m.) Review request for mesos, Gastón Kleiman

Review Request 54004: Renamed functions in HealthChecker for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54004/ --- Review request for mesos, Gastón Kleiman and haosdent huang. Repository: mesos

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/ --- (Updated Nov. 23, 2016, 12:28 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/#review156652 --- 3rdparty/libprocess/src/libevent_ssl_socket.cpp (lines 246 -

Re: Review Request 53974: Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53974/ --- (Updated Nov. 22, 2016, 11:07 p.m.) Review request for mesos, Benjamin

Re: Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/#review156658 --- Fix it, then Ship it! Looks great! src/docker/docker.cpp

Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53995/#review156655 --- Patch looks great! Reviews applied: [53994, 53995] Passed

Re: Review Request 53704: Added a level of indirection for logger through an IO Switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53704/#review156386 --- Fix it, then Ship it! src/CMakeLists.txt (line 329)

Re: Review Request 53997: Fix SSL downgrade pathway for temporary/persistent sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53997/ --- (Updated Nov. 22, 2016, 2:01 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/ --- (Updated Nov. 22, 2016, 10:01 p.m.) Review request for mesos, Adam B, Gastón

Re: Review Request 53997: Fix SSL downgrade pathway for temporary/persistent sockets.

> On Nov. 22, 2016, 1:19 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2476-2477 > > > > > > Do you want an else if here to match the close logic? Otherwise, maybe > > add back the

Re: Review Request 53997: Fix SSL downgrade pathway for temporary/persistent sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53997/ --- (Updated Nov. 22, 2016, 2:01 p.m.) Review request for mesos, Benjamin Mahler

Review Request 54001: Addes status method to DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54001/ --- Review request for mesos, Kevin Klues and Vinod Kone. Bugs: MESOS-6625

Re: Review Request 53975: Moved server socket deletion in 'process::finalize()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53975/#review156645 --- Ship it! Ship It! - Joseph Wu On Nov. 21, 2016, 10:53 p.m.,

Re: Review Request 53998: Fixed hook to allow for executor environment modifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53998/#review156631 --- LGTM. A reasonable change (to have the hook modify both the

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > Nice first patch and welcome to the community! > > > > - Can you update the Testing Done section with details on testing? > > - We also support Python bindings. Do you mind adding these protos to our > > python build too in a follow up

Re: Review Request 53990: Added POSIX socket shutdown types to Windows header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53990/#review156642 --- Ship it! Ship It! - Benjamin Mahler On Nov. 22, 2016, 6:20

Re: Review Request 53611: Improved comments around health checks in mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53611/#review156638 --- Fix it, then Ship it! include/mesos/mesos.proto (line 414)

Re: Review Request 53610: Added health checks documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53610/#review156640 --- docs/health-checks.md (line 155)

Re: Review Request 53491: Disabled tests relying on filtering HTTP events.

> On Nov. 22, 2016, 8:35 p.m., Benjamin Mahler wrote: > > This didn't have a ship it, I was expecting the test filter changes to be > > in place before we committed the changes. Are you working on these now? > > Anand Mazumdar wrote: > Looks like there is some disconnect. We had an offline

Re: Review Request 53610: Added health checks documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53610/#review156637 --- docs/health-checks.md (line 159)

Re: Review Request 53614: Updated the markdown style guide with headings capitalization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53614/#review156635 --- Ship it! Ship It! - Neil Conway On Nov. 9, 2016, 5:08 p.m.,

Re: Review Request 53613: Fixed style issues in quota.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53613/#review156634 --- Fix it, then Ship it! docs/quota.md (line 357)

Re: Review Request 53491: Disabled tests relying on filtering HTTP events.

> On Nov. 22, 2016, 8:35 p.m., Benjamin Mahler wrote: > > This didn't have a ship it, I was expecting the test filter changes to be > > in place before we committed the changes. Are you working on these now? Looks like there is some disconnect. We had an offline discussion at MesosCon China

Re: Review Request 53612: Fixed minor style issues in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53612/#review156633 --- Ship it! Ship It! - Neil Conway On Nov. 9, 2016, 5:05 p.m.,

Re: Review Request 53997: Fix SSL downgrade pathway for temporary/persistent sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53997/#review156632 --- Ship it! 3rdparty/libprocess/src/process.cpp (lines 2476 -

Re: Review Request 53991: Added master API call for `UPDATE_QUOTA`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53991/#review156628 --- Patch looks great! Reviews applied: [52284, 53679, 53691, 52103,

Re: Review Request 53877: Added temporary file environment passing towards docker.

> On Nov. 22, 2016, 7:57 p.m., Kapil Arya wrote: > > src/docker/docker.cpp, line 535 > > > > > > Minor nit: Should we change `file` to something like > > `environmentVariables` or `environment` because it's a

Re: Review Request 53491: Disabled tests relying on filtering HTTP events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53491/#review156625 --- This didn't have a ship it, I was expecting the test filter

Re: Review Request 53610: Added health checks documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53610/#review156617 --- docs/health-checks.md (line 9)

Re: Review Request 53950: Avoided hardcoding ports in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53950/#review156623 --- Ship it! Ship It! - Gastón Kleiman On Nov. 22, 2016, 7:49

Re: Review Request 53998: Fixed hook to allow for executor environment modifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53998/ --- (Updated Nov. 22, 2016, 8:26 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/#review156622 --- src/docker/docker.cpp (line 535)

Review Request 53997: Fix SSL downgrade pathway for temporary/persistent sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53997/ --- Review request for mesos, Benjamin Mahler and Joris Van Remoortere. Bugs:

Review Request 53998: Fixed hook to allow for executor environment modifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53998/ --- Review request for mesos, Adam B, Jie Yu, Kapil Arya, and Joseph Wu. Bugs:

Re: Review Request 53758: CMake: Added test sources to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53758/ --- (Updated Nov. 22, 2016, noon) Review request for mesos, Alex Clemmer and Joris

Re: Review Request 53805: Updated libprocess test to use new 'Socket::shutdown' parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53805/ --- (Updated Nov. 22, 2016, 7:57 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53877: Added temporary file environment passing towards docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/#review156618 --- Ship it! src/docker/docker.cpp (line 535)

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Nov. 22, 2016, 7:56 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 50969: Made use of SSL flags to determine scheduler/executor scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50969/ --- (Updated Nov. 22, 2016, 7:56 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/ --- (Updated Nov. 22, 2016, 7:56 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51065/ --- (Updated Nov. 22, 2016, 7:55 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/ --- (Updated Nov. 22, 2016, 7:55 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53817: Added missing cleanup to libprocess 'finalize()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53817/ --- (Updated Nov. 22, 2016, 7:54 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 53610: Added health checks documentation.

> On Nov. 9, 2016, 5:32 p.m., haosdent huang wrote: > > docs/health-checks.md, line 8 > > > > > > `misbehave, or become unresponsive` should be `misbehave or become > > unresponsive`? I think this is better as-is

  1   2   >