Re: Review Request 58361: Updated LICENSE information for protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58361/#review172318 --- Bad patch! Reviews applied: [58361, 58360, 58359, 58515, 58514,

Re: Review Request 58515: Update 3rdparty build to support protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58515/#review172316 --- Ship it! Ship It! - Anand Mazumdar On April 18, 2017, 6:24

Re: Review Request 58514: Update related tests in stout to support protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58514/#review172315 --- Ship it! Ship It! - Anand Mazumdar On April 18, 2017, 6:23

Re: Review Request 58513: Remove unnecessary patch after protobuf upgrade to 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58513/#review172314 --- Ship it! Ship It! - Anand Mazumdar On April 18, 2017, 10:48

Re: Review Request 58358: Update vendored protobuf tar.gz to 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58358/#review172313 --- Ship it! Ship It! - Anand Mazumdar On April 18, 2017, 6:22

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review172312 --- Patch looks great! Reviews applied: [58303, 58304, 58305]

Re: Review Request 58512: Avoid a crash in HTTP decoder.

> On April 19, 2017, 12:12 a.m., James Peach wrote: > > AFAICT the same problem can occur in other places (eg. > > ``StreamingResponseDecoderon_headers_complete``). James, the patch seems to address both the streaming request/response decoders. - Anand

Re: Review Request 58512: Avoid a crash in HTTP decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/#review172304 --- Looks good! Thanks for reporting the issue and also fixing it.

Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/ --- (Updated April 19, 2017, 11:38 a.m.) Review request for mesos, Adam B,

Re: Review Request 58097: Added a test to check framework filtering in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58097/ --- (Updated April 19, 2017, 11:38 a.m.) Review request for mesos, Adam B,

Re: Review Request 58096: Added authorization for frameworks in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58096/ --- (Updated April 19, 2017, 11:37 a.m.) Review request for mesos, Adam B,

Re: Review Request 58095: Refactored functions that render /roles and GetRoles endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated April 19, 2017, 11:36 a.m.) Review request for mesos, Adam B,

Re: Review Request 58487: Fix allocation quantities when shared resources are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58487/ --- (Updated April 19, 2017, 2:50 a.m.) Review request for mesos, James Peach and

Re: Review Request 58485: Avoid a corruption while rescinding offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58485/ --- (Updated April 19, 2017, 2:49 a.m.) Review request for mesos, James Peach and

Re: Review Request 58486: Fixed a race in `updateAllocation()` on DESTORY of a shared volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58486/ --- (Updated April 19, 2017, 2:50 a.m.) Review request for mesos, James Peach and

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review172303 --- Patch looks great! Reviews applied: [58517, 58224] Passed

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/ --- (Updated April 19, 2017, 1:10 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 58428: Added tests for failed executor authorization.

> On April 19, 2017, 12:33 a.m., Vinod Kone wrote: > > While these tests are good I'm wondering if they are realistic, because the > > assumption is that someone knows the agent's secret key but doesn't know > > the container id of the executor they want to attack. In reality it's the > >

Re: Review Request 58255: Added implicit authorization to the agent executor API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58255/ --- (Updated April 19, 2017, 12:34 a.m.) Review request for mesos, Adam B,

Re: Review Request 58458: Enabled authorization in default executor check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58458/#review172296 --- Ship it! Ship It! - Vinod Kone On April 14, 2017, 4:08

Re: Review Request 58428: Added tests for failed executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58428/#review172293 --- Fix it, then Ship it! While these tests are good I'm wondering

Re: Review Request 58258: Added a new agent authorization test which runs a task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58258/#review172292 --- Ship it! Ship It! - Vinod Kone On April 13, 2017, 8:19

Re: Review Request 58512: Avoid a crash in HTTP decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/#review172291 --- AFAICT the same problem can occur in other places (eg.

Re: Review Request 58255: Added implicit authorization to the agent executor API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58255/#review172290 --- src/slave/http.cpp Lines 629-650 (patched)

Re: Review Request 58355: Removed unnecessary Registry copying.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58355/#review172286 --- Patch looks great! Reviews applied: [58355] Passed command:

Re: Review Request 58361: Updated LICENSE information for protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58361/ --- (Updated April 18, 2017, 10:48 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58513: Remove unnecessary patch after protobuf upgrade to 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58513/ --- (Updated April 18, 2017, 10:48 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58254: Added implicit executor authorization to the agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58254/#review172279 --- Ship it! Ship It! - Vinod Kone On April 14, 2017, 9:14

Re: Review Request 58507: Added a TODO for implicit scheduler authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58507/#review172278 --- Ship it! Ship It! - Vinod Kone On April 18, 2017, 3:19

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 18, 2017, 10:22 p.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58304: Remove unnecessary hashmap lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58304/ --- (Updated April 18, 2017, 10:15 p.m.) Review request for mesos, Adam B, Mesos

Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58303/ --- (Updated April 18, 2017, 10:14 p.m.) Review request for mesos, Adam B, Mesos

Re: Review Request 58485: Avoid a corruption while rescinding offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58485/#review172274 --- Fix it, then Ship it! src/master/master.cpp Lines 4334-4335

Re: Review Request 58355: Removed unnecessary Registry copying.

> On April 18, 2017, 12:21 a.m., Benjamin Mahler wrote: > > Thanks for taking this on Ilya! Just a few suggestions below per our > > offline discussion. It would be great to update the description to include > > the context, mainly that we avoid the `protobuf::State` wrapper in favor of > >

Re: Review Request 58355: Removed unnecessary Registry copying.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58355/ --- (Updated April 18, 2017, 10:11 p.m.) Review request for mesos and Benjamin

Re: Review Request 58517: Update SlaveRecoveryTest to send libprocess messages from a real UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58517/ --- (Updated April 18, 2017, 9:11 p.m.) Review request for mesos and Mesos

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ --- (Updated April 18, 2017, 9:11 p.m.) Review request for mesos and Mesos

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ --- (Updated April 18, 2017, 9:02 p.m.) Review request for mesos and Mesos

Re: Review Request 58517: Update SlaveRecoveryTest to send libprocess messages from a real UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58517/ --- (Updated April 18, 2017, 8:58 p.m.) Review request for mesos and Mesos

Review Request 58517: Update SlaveRecoveryTest to send libprocess messages from a real UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58517/ --- Review request for mesos. Repository: mesos Description --- Update

Re: Review Request 58512: Avoid a crash in HTTP decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/#review172265 --- Patch looks great! Reviews applied: [58512] Passed command:

Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58448/#review172263 --- Big change, but important for us. I'd like you to comment on

Re: Review Request 58446: Windows: Set CMake generator for Protobuf correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58446/#review172261 --- This looks okay. But again: You didn't fill out anything for

Re: Review Request 58447: CMake: Cleaned up 3rdparty dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58447/#review172260 --- I'd like to understand the tests that you ran before you posted

Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/#review172258 --- Ship it! Ship It! - Jeff Coffler On April 14, 2017, 2:10

Re: Review Request 58255: Added implicit authorization to the agent executor API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58255/ --- (Updated April 18, 2017, 7:58 p.m.) Review request for mesos, Adam B,

Re: Review Request 58255: Added implicit authorization to the agent executor API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58255/ --- (Updated April 18, 2017, 7:29 p.m.) Review request for mesos, Adam B,

Re: Review Request 58510: Added two tests for hierarchical reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58510/#review172249 --- Bad review! Reviews applied: [58510, 58509, 58508, 57516, 57254,

Re: Review Request 58357: Added more language support in test-upgrade script.

> On April 18, 2017, 5:20 p.m., Greg Mann wrote: > > support/test-upgrade.py > > Lines 76-85 (patched) > > > > > > A high level comment: insteads of parametrizing the framework by > > "language", perhaps we could

Re: Review Request 58357: Added more language support in test-upgrade script.

> On April 18, 2017, 5:20 p.m., Greg Mann wrote: > > support/test-upgrade.py > > Lines 76-85 (patched) > > > > > > A high level comment: insteads of parametrizing the framework by > > "language", perhaps we could

Re: Review Request 58357: Added more language support in test-upgrade script.

> On April 18, 2017, 5:20 p.m., Greg Mann wrote: > > support/test-upgrade.py > > Lines 164 (patched) > > > > > > Perhaps the default should be to run all of the available test > > frameworks, rather than just one?

Re: Review Request 58359: Update Mesos build library to use protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58359/ --- (Updated April 18, 2017, 6:25 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58361: Updated LICENSE information for protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58361/ --- (Updated April 18, 2017, 6:25 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58360: Added a test for evolving large protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58360/ --- (Updated April 18, 2017, 6:25 p.m.) Review request for mesos and Anand

Review Request 58515: Update 3rdparty build to support protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58515/ --- Review request for mesos, Anand Mazumdar and Joseph Wu. Bugs: MESOS-7228

Review Request 58514: Update related tests in stout to support protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58514/ --- Review request for mesos, Anand Mazumdar and Joseph Wu. Bugs: MESOS-7228

Review Request 58513: Remove unnecessary patch after protobuf upgrade to 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58513/ --- Review request for mesos, Anand Mazumdar and Joseph Wu. Bugs: MESOS-7228

Re: Review Request 58358: Update vendored protobuf tar.gz to 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58358/ --- (Updated April 18, 2017, 6:22 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58507: Added a TODO for implicit scheduler authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58507/#review172230 --- Patch looks great! Reviews applied: [58507] Passed command:

Review Request 58512: Avoid a crash in HTTP decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/ --- Review request for mesos, James Peach and Jiang Yan Xu. Bugs: MESOS-7400

Re: Review Request 58357: Added more language support in test-upgrade script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58357/#review172226 --- Thanks for this, Zhitao! Glad to see this script getting some new

Re: Review Request 58361: Updated LICENSE information for protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58361/ --- (Updated April 18, 2017, 4:33 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58358: Upgrade vendored 3rdparty protobuf to 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58358/ --- (Updated April 18, 2017, 4:32 p.m.) Review request for mesos, Anand Mazumdar

Review Request 58511: Update vendored protobuf tar.gz to 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58511/ --- Review request for mesos. Repository: mesos Description --- The content

Re: Review Request 58506: Updated the high availability doc about ZK session timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58506/#review172216 --- Patch looks great! Reviews applied: [58421, 58506] Passed

Review Request 58510: Added two tests for hierarchical reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58510/ --- Review request for mesos and Michael Park. Bugs: MESOS-7149

Review Request 58509: Enabled allocator to handle hierarchical reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58509/ --- Review request for mesos and Michael Park. Bugs: MESOS-7149

Review Request 58508: Introduced method `Resources::inheritable` to aggregate reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58508/ --- Review request for mesos and Michael Park. Bugs: MESOS-7149

Review Request 42937: Added helper which returns flag map to 'FlagsBase'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42937/ --- Review request for mesos. Repository: mesos Description --- Added

Review Request 42938: Added automatic generation of the config flag docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42938/ --- Review request for mesos. Repository: mesos Description --- Added

Review Request 58507: Added a TODO for implicit scheduler authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58507/ --- Review request for mesos, Alexander Rojas and Vinod Kone. Bugs: MESOS-7399

Re: Review Request 58255: Added implicit authorization to the agent executor API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58255/ --- (Updated April 18, 2017, 3:17 p.m.) Review request for mesos, Adam B,

Re: Review Request 58196: Implemented TCP check support in command and default executors.

> On April 7, 2017, 1:58 a.m., Vinod Kone wrote: > > src/checks/checker.cpp > > Lines 1081 (patched) > > > > > > Does this work even when executor is running with its own file system? > > Alexander Rukletsov

Review Request 58506: Updated the high availability doc about ZK session timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58506/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-7387

Re: Review Request 58503: Removed containerizer flag logging to prevent leak of sensitive data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58503/#review172204 --- Ship it! Ship It! - Benjamin Bannier On April 18, 2017,

Re: Review Request 58502: Removed containerizer flag logging to prevent leak of sensitive data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58502/#review172203 --- Ship it! Ship It! - Benjamin Bannier On April 18, 2017,

Re: Review Request 57474: Added test for authorization of hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/#review172202 --- Bad review! Reviews applied: [57474, 57473, 58292, 57166, 56805,

Re: Review Request 58503: Removed containerizer flag logging to prevent leak of sensitive data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58503/ --- (Updated April 18, 2017, 2:06 p.m.) Review request for mesos, Adam B,

Re: Review Request 58421: Passed `--zk_session_timeout` to ZK master contender and detector.

> On April 14, 2017, 6:45 p.m., Vinod Kone wrote: > > Can you update one of the tests in master_contender_detector_tests to use a > > configured session timeout value rather than the constant? Done. Modified `ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork` to use a

Re: Review Request 58421: Passed `--zk_session_timeout` to ZK master contender and detector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58421/ --- (Updated April 18, 2017, 3 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 58502: Removed containerizer flag logging to prevent leak of sensitive data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58502/ --- (Updated April 18, 2017, 1:50 p.m.) Review request for mesos, Adam B,

Re: Review Request 58505: Added MESOS-7265 to 1.0.4 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58505/#review172197 --- Ship it! Ship It! - Benjamin Bannier On April 18, 2017,

Re: Review Request 58504: Added MESOS-7265 to 1.1.2 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58504/#review172196 --- Ship it! Ship It! - Benjamin Bannier On April 18, 2017,

Review Request 58505: Added MESOS-7265 to 1.0.4 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58505/ --- Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.

Review Request 58504: Added MESOS-7265 to 1.1.2 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58504/ --- Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.

Re: Review Request 57474: Added test for authorization of hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/ --- (Updated April 18, 2017, 3:28 p.m.) Review request for mesos, Adam B and

Review Request 58503: Removed containerizer flag logging to prevent leak of sensitive data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58503/ --- Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.

Review Request 58502: Removed containerizer flag logging to prevent leak of sensitive data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58502/ --- Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.

Re: Review Request 58502: Removed containerizer flag logging to prevent leak of sensitive data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58502/ --- (Updated April 18, 2017, 1:10 p.m.) Review request for mesos, Adam B,

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

> On April 18, 2017, 1:56 p.m., Jan Schlicht wrote: > > Because I need to implement similar filters for tests in `libprocess`, > > wouldn't it have been better to create a `Filter` abstraction in stout and > > using that here as well as in Mesos instead of copy-pasting the > > implementation

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review172188 --- Because I need to implement similar filters for tests in

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

> On April 17, 2017, 11:09 p.m., Jay Guo wrote: > > src/master/allocator/sorter/drf/sorter.cpp > > Line 333 (original), 509 (patched) > > > > > > In case of `dirty`, how about insert logic of `listClients` there to

Re: Review Request 58021: Added storage-related offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58021/#review172176 --- src/common/protobuf_utils.cpp Lines 435-448 (original), 435-452

Re: Review Request 58463: Overwriting Symbolic Links with Files in Copy Provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58463/#review172170 --- Ship it! Ship It! - Jie Yu On April 17, 2017, 9:52 p.m.,

Re: Review Request 58408: Overwriting Directories with Files in Copy Provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58408/#review172169 --- Fix it, then Ship it!