Review Request 58910: [WIP] Updated all tests that use Containerizer::launch(...).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58910/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7304 and MESOS-7449

Review Request 58909: Added test helpers to tranlate to ContainerConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58909/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7449

Review Request 58908: Updated test mocks per interface changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58908/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7304 and MESOS-7449

Review Request 58907: Refactored Docker containerizer launch path per interface changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58907/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7449

Review Request 58906: Removed extranous sandbox initialization in Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58906/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7449

Review Request 58905: Changed naming of Docker containers to the pre-0.23 scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58905/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7449

Review Request 58903: Combined Mesos containerizer's launch methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58903/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7449

Review Request 58904: Combined launch paths in ComposingContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58904/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7449

Review Request 58902: Changed containerizer->launch callsites to new interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58902/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7449

Review Request 58899: Combined containerizer interface's launch methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58899/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7449

Review Request 58901: Removed `Fetcher::recover` static method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58901/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7304

Review Request 58900: Changed the default fetcher cache directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7304

Re: Review Request 58897: Added a test case for numify in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58897/#review173545 --- Ship it! Good to know! - Benjamin Mahler On May 1, 2017,

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review173536 --- Can you pull the test changes out into a separate patch? Overall

Re: Review Request 58762: Use SecretFetcher to fetch secret executor environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58762/#review173537 --- src/slave/slave.cpp Lines 2740 (patched)

Re: Review Request 55362: Support asynchronous fetching of URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55362/ --- (Updated May 2, 2017, 12:08 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 58898: Send task kill for non-Partition Aware frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58898/ --- (Updated May 1, 2017, 11:58 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 58517: Update SlaveRecoveryTest to send libprocess messages from a real UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58517/#review173535 --- src/tests/slave_recovery_tests.cpp Lines 2348-2349 (original),

Review Request 58898: Send task kill for non-Partition Aware frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58898/ --- Review request for mesos, Neil Conway and Jiang Yan Xu. Bugs: MESOS-7215

Re: Review Request 58778: Supported GCE container registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/ --- (Updated May 1, 2017, 11:47 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 58709: Prevent old Mesos agents from registering or re-registering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58709/ --- (Updated May 1, 2017, 11:45 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58707/ --- (Updated May 1, 2017, 11:45 p.m.) Review request for mesos, Benjamin Mahler

Review Request 58897: Added a test case for numify in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58897/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 58517: Update SlaveRecoveryTest to send libprocess messages from a real UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58517/#review173532 --- Ship it! This review seems to suggest that `process::post`

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

> On April 26, 2017, 11:16 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/version.hpp > > Lines 66-71 (original), 139-182 (patched) > > > > > > These are made public but I can't see how these would be

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review173526 --- I'm a bit lost, is there a visual change here? If so, can you

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58872/#review173525 --- Thanks for tackling this!

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/#review173522 --- Fix it, then Ship it! src/tests/persistent_volume_tests.cpp

Re: Review Request 58778: Supported GCE container registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/#review173524 --- Patch looks great! Reviews applied: [58753, 58725, 58778]

Re: Review Request 57963: Metrics for used resources should incorporate shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57963/#review173028 --- Fix it, then Ship it! src/master/master.cpp Lines 8950

Re: Review Request 58889: Remove FlagsFileTest.JSONFile from Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58889/#review173518 --- 3rdparty/stout/include/stout/flags/parse.hpp Lines 98 (patched)

Re: Review Request 58761: Added --secret-fetcher flag for agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58761/#review173517 --- Fix it, then Ship it! src/slave/main.cpp Line 234 (original),

Re: Review Request 58760: Added default secret fetcher module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/#review173515 --- Ship it! Ship It! - Vinod Kone On April 28, 2017, 6:50

Re: Review Request 58759: Introduced SecretFetcher module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/#review173514 --- include/mesos/secret/secretfetcher.hpp Lines 27 (patched)

Review Request 58587: Clarified comments about resource operations through operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58587/ --- Review request for mesos, Anindya Sinha and Michael Park. Repository: mesos

Review Request 58892: Added C++11 scoped enumeration to style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58892/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/ --- (Updated May 1, 2017, 9:01 p.m.) Review request for mesos, Andrew

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58872/#review173504 --- Fix it, then Ship it! I tested it and it fixes the issue. I

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/ --- (Updated May 1, 2017, 8:42 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 58766: Fixed coding style issues in ProvisionerDockerBackendTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58766/#review173507 --- Patch looks great! Reviews applied: [58764, 58766] Passed

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review173499 --- Fix it, then Ship it! Nice usability improvement.

Re: Review Request 58889: Remove FlagsFileTest.JSONFile from Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58889/ --- (Updated May 1, 2017, 8 p.m.) Review request for mesos, Andrew Schwartzmeyer,

Review Request 58889: Remove FlagsFileTest.JSONFile from Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58889/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li

Review Request 58778: Supported GCE container registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7431

Re: Review Request 58880: Added Secret to Image::Docker in v1/mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58880/#review173489 --- Ship it! Ship It! - Chun-Hung Hsiao On April 30, 2017,

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58725/#review173488 --- Patch looks great! Reviews applied: [58753, 58725] Passed

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

> On April 27, 2017, 12:46 a.m., Jie Yu wrote: > > Do you know if an old registry (< 2.3) will be OK with this header that it > > does not understand? Can you confirm? > > Ilya Pronin wrote: > Shall we include all content types that we currently support? (Can be > splitted into multiple

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

> On April 27, 2017, 12:46 a.m., Jie Yu wrote: > > Do you know if an old registry (< 2.3) will be OK with this header that it > > does not understand? Can you confirm? > > Ilya Pronin wrote: > Shall we include all content types that we currently support? (Can be > splitted into multiple

Re: Review Request 58766: Fixed coding style issues in ProvisionerDockerBackendTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58766/ --- (Updated May 1, 2017, 6:14 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58725/ --- (Updated May 1, 2017, 5:24 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

> On April 27, 2017, 12:46 a.m., Jie Yu wrote: > > Do you know if an old registry (< 2.3) will be OK with this header that it > > does not understand? Can you confirm? > > Ilya Pronin wrote: > Shall we include all content types that we currently support? (Can be > splitted into multiple