Re: Review Request 58778: Supported GCE container registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/#review175061 --- Ship it! LGTM! Ship it! - Gilbert Song On May 15, 2017,

Re: Review Request 58778: Supported GCE container registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/#review175060 --- src/uri/fetchers/docker.cpp Line 660 (original), 715 (patched)

Re: Review Request 59286: Updated Mesos 1.3.0 CHANGELOG for removal of hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59286/#review175059 --- Patch looks great! Reviews applied: [59285, 59286] Passed

Re: Review Request 58486: Update the allocator on a per offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58486/#review175055 --- Patch looks great! Reviews applied: [59194, 59195, 58486]

Re: Review Request 58906: Removed extranous sandbox initialization in Docker containerizer.

> On May 11, 2017, 6:29 a.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp > > Line 285 (original) > > > > > > Hum, can you point to me where do we mkdir for the sandbox? The callstack is roughly: *

Re: Review Request 58778: Supported GCE container registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/ --- (Updated May 16, 2017, 12:50 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58778: Supported GCE container registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/#review175043 --- Fix it, then Ship it! src/uri/fetchers/docker.cpp Lines 449

Review Request 59302: Simplified master logic for agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59302/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 59107: [WIP] Added extra debugging statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59107/ --- (Updated May 15, 2017, 11:27 p.m.) Review request for mesos, Alexander

Re: Review Request 59216: Fixed some inaccurate comments.

> On May 12, 2017, 9:37 p.m., Benjamin Mahler wrote: > > include/mesos/master/master.proto > > Lines 380-381 (original), 380-381 (patched) > > > > > > Just to clarify the intent of this comment, our deprecation

Re: Review Request 59216: Fixed some inaccurate comments.

> On May 12, 2017, 9:37 p.m., Benjamin Mahler wrote: > > include/mesos/master/master.proto > > Line 382 (original), 382 (patched) > > > > > > Why not add the deprecation tag here and for tasks? > > > > ```

Review Request 59301: Marked a few deprecated proto fields with the "deprecated" option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59301/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 59259: Cleaned up master code to check for PARTITION_AWARE capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59259/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 59216: Fixed some inaccurate comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59216/ --- (Updated May 15, 2017, 11:16 p.m.) Review request for mesos and Benjamin

Re: Review Request 59214: Removed code for handling missing FrameworkInfo of a running task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59214/ --- (Updated May 15, 2017, 11:13 p.m.) Review request for mesos and Benjamin

Review Request 59300: Updated documentation for `registrar/log/network_size`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59300/ --- Review request for mesos, Anindya Sinha and Benjamin Mahler. Repository: mesos

Review Request 59290: Added '/log/network_size' metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59290/ --- Review request for mesos, Anindya Sinha and Benjamin Mahler. Bugs: MESOS-7507

Review Request 59289: Refactored log Metrics into separate files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59289/ --- Review request for mesos, Anindya Sinha and Jie Yu. Bugs: MESOS-7507

Re: Review Request 59297: Fix autotools to include ip.hpp & mac.hpp in stout/{posix|windows}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59297/ --- (Updated May 15, 2017, 10:43 p.m.) Review request for mesos, Andrew

Review Request 59297: Fix autotools to include ip.hpp & mac.hpp in stout/{posix|windows}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59297/ --- Review request for mesos. Repository: mesos Description --- Required

Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59194/#review175033 --- Ship it! Ship It! - Jiang Yan Xu On May 15, 2017, 11:01

Re: Review Request 59279: Uses temp dir for docker and appc stores in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59279/#review175025 --- Fix it, then Ship it! src/tests/mesos.cpp Lines 180 (patched)

Review Request 59294: Optionally scale egress bandwidth with CPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/ --- Review request for mesos, Dmitry Zhuk, Ilya Pronin, Jie Yu, and Santhosh Kumar

Review Request 59293: Windows: Fixed apply-reviews.py to retain line feeds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59293/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 58778: Supported GCE container registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/#review175018 --- Patch looks great! Reviews applied: [58778] Passed command:

Review Request 59286: Updated Mesos 1.3.0 CHANGELOG for removal of hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59286/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 59285: Disabled support for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59285/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 59279: Uses temp dir for docker and appc stores in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59279/ --- Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 59195: Ensure that allocator can be updated before committing changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59195/ --- (Updated May 15, 2017, 6:01 p.m.) Review request for mesos, James Peach and

Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`.

> On May 15, 2017, 5:41 a.m., Jiang Yan Xu wrote: > > src/tests/resources_tests.cpp > > Lines 2577 (patched) > > > > > > `__total`? That is a left over from the original version. Fixed it. - Anindya

Re: Review Request 58486: Update the allocator on a per offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58486/ --- (Updated May 15, 2017, 6:01 p.m.) Review request for mesos, James Peach and

Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59194/ --- (Updated May 15, 2017, 6:01 p.m.) Review request for mesos, James Peach and

Re: Review Request 58778: Supported GCE container registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/ --- (Updated May 15, 2017, 5:39 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/#review174988 --- Fix it, then Ship it! I can fix this up before committing.

Re: Review Request 58889: Remove FlagsFileTest.JSONFile from Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58889/#review174990 --- Fix it, then Ship it! I can fix this up before committing.

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59116/#review174987 --- Ship it! I can fixup the few comments before committing.

Re: Review Request 59157: Windows: Fixed toolset handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59157/#review174557 --- Fix it, then Ship it! I'll delete the below before committing.

Re: Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59156/#review174986 --- Ship it! Ship It! - Joseph Wu On May 10, 2017, 1:34 p.m.,

Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59155/#review174985 --- Ship it! Ship It! - Joseph Wu On May 10, 2017, 1:59 p.m.,

Re: Review Request 58778: Supported GCE container registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/#review174975 --- This patch looks good. Need to take aother look at the

Re: Review Request 59001: Added volume secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/#review174945 --- src/slave/containerizer/mesos/isolators/volume/secret.hpp Lines

Re: Review Request 59000: Added environment secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/#review174942 --- src/slave/containerizer/mesos/isolators/environment_secret.hpp

Re: Review Request 59088: Implemented QuotaTree structure to be used by allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59088/#review174943 --- src/master/quota.hpp Lines 56 (patched)

Re: Review Request 59088: Implemented QuotaTree structure to be used by allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59088/#review174941 --- src/master/quota.hpp Lines 56 (patched)

Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58349/ --- (Updated May 15, 2017, 2:05 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 58999: Added --secret_resolver flag to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58999/#review174918 --- src/slave/flags.cpp Lines 961-964 (patched)

Re: Review Request 58350: Updated GMock/GTest in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58350/ --- (Updated May 15, 2017, 12:28 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58349/ --- (Updated May 15, 2017, 12:28 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58349/ --- (Updated May 15, 2017, 12:27 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58347/ --- (Updated May 15, 2017, 12:25 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 58348: Fixed use of 'GTEST_IS_THREADSAFE'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58348/ --- (Updated May 15, 2017, 12:24 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58347/ --- (Updated May 15, 2017, 12:24 p.m.) Review request for mesos, Neil Conway and