Re: Review Request 59578: Made MasterTest.MaxCompletedTasksPerFrameworkFlag less fragile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59578/#review176179 --- Patch looks great! Reviews applied: [59578] Passed command:

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/#review176178 --- Patch looks great! Reviews applied: [59454, 59413] Passed

Re: Review Request 59584: Introduced executor reconnect retries on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59584/#review176167 --- src/slave/flags.cpp Lines 355 (patched)

Re: Review Request 59594: Minor logging cleanup to put open/close quotes on the same line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59594/#review176177 --- Ship it! Ship It! - Vinod Kone On May 26, 2017, 1:05 a.m.,

Re: Review Request 59592: Added logging of executor re-registration messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59592/#review176175 --- Ship it! Ship It! - Vinod Kone On May 26, 2017, 1:04 a.m.,

Re: Review Request 59593: Avoided use of [] operator for read only map access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59593/#review176176 --- Ship it! Ship It! - Vinod Kone On May 26, 2017, 1:05 a.m.,

Re: Review Request 59591: Removed a use of the 'default' switch case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59591/#review176174 --- Ship it! Ship It! - Vinod Kone On May 26, 2017, 1:03 a.m.,

Re: Review Request 59589: Don't crash when re-registering executor from an unknown framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59589/#review176172 --- Ship it! Ship It! - Vinod Kone On May 26, 2017, 1:01 a.m.,

Re: Review Request 59590: Don't crash the agent when an unknown executor re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59590/#review176173 --- Ship it! Ship It! - Vinod Kone On May 26, 2017, 1:02 a.m.,

Re: Review Request 59587: Added a test for ignoring executor re-registrations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59587/#review176171 --- Ship it! src/tests/slave_tests.cpp Lines 7174 (patched)

Re: Review Request 59586: Added a test for shutting down executors that re-register.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59586/#review176170 --- Ship it! src/tests/slave_tests.cpp Lines 7069-7074 (patched)

Re: Review Request 59585: Added a test for the optional executor reconnect retry in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59585/#review176169 --- Fix it, then Ship it! src/tests/slave_recovery_tests.cpp

Re: Review Request 59584: Introduced executor reconnect retries on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59584/#review176168 --- src/slave/slave.cpp Lines 5956 (patched)

Re: Review Request 59353: Enabled DOCKER and ROOT filter flags on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59353/#review176136 --- Fix it, then Ship it! Mostly just white-space issues, so I'll

Re: Review Request 59578: Made MasterTest.MaxCompletedTasksPerFrameworkFlag less fragile.

> On May 26, 2017, 12:03 a.m., Kevin Klues wrote: > > src/tests/master_tests.cpp > > Lines 5635-5636 (patched) > > > > > > Is this something standard we've been doing recently to fix flaky > > tests? I'm not

Review Request 59601: Removed an unused declaration in type_utils.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59601/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, Jan

Review Request 59600: Added `--resource_providers` flag to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59600/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, and Jan

Re: Review Request 59596: Renamed the ifdef guard for v1 resource provider header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59596/#review176163 --- Fix it, then Ship it!

Review Request 59599: Added 'type' and 'name' fields to ResourceProviderInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59599/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, and Jan

Review Request 59598: Added registration logic to storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59598/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, and Jan

Review Request 59594: Minor logging cleanup to put open/close quotes on the same line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59594/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Review Request 59593: Avoided use of [] operator for read only map access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59593/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Review Request 59592: Added logging of executor re-registration messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59592/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Review Request 59591: Removed a use of the 'default' switch case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59591/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Review Request 59590: Don't crash the agent when an unknown executor re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59590/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Review Request 59596: Renamed the ifdef guard for v1 resource provider header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59596/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, and Jan

Review Request 59589: Don't crash when re-registering executor from an unknown framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59589/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Re: Review Request 59584: Introduced executor reconnect retries on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59584/ --- (Updated May 26, 2017, 12:56 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/#review176162 --- Patch looks great! Reviews applied: [59454, 59413] Passed

Review Request 59584: Introduced executor reconnect retries on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59584/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone. Bugs:

Review Request 59586: Added a test for shutting down executors that re-register.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59586/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone.

Review Request 59587: Added a test for ignoring executor re-registrations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59587/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone.

Review Request 59585: Added a test for the optional executor reconnect retry in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59585/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone.

Re: Review Request 59233: Updated v6 address for containers running on host network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59233/#review176161 --- Fix it, then Ship it! src/slave/slave.cpp Lines 4424

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review176160 --- Ship it! Ship It! - James Peach On May 25, 2017, 11:30

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/#review176159 --- Ship it! Ship It! - James Peach On May 25, 2017, 6:13 p.m.,

Re: Review Request 59128: Added initialization logic in Mesos agent for IPv6 flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59128/#review176158 --- Ship it! Ship It! - Benjamin Hindman On May 10, 2017, 7:04

Re: Review Request 59127: Added IPv6 flags for Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59127/#review176157 --- Ship it! Ship It! - Benjamin Hindman On May 10, 2017, 7:03

Re: Review Request 49571: Added a benchmark test for allocations.

> On May 24, 2017, 11:35 p.m., James Peach wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 4995 (patched) > > > > > > I found that this output wasn't very helpful. How about running through > >

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59130/#review176155 --- 3rdparty/libprocess/src/process.cpp Lines 119 (patched)

Re: Review Request 59578: Made MasterTest.MaxCompletedTasksPerFrameworkFlag less fragile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59578/#review176154 --- src/tests/master_tests.cpp Lines 5635-5636 (patched)

Re: Review Request 59129: Introduced `inet6::Address` to handle IPv6 addresses in `libprocess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59129/#review176149 --- 3rdparty/libprocess/include/process/address.hpp Line 152

Re: Review Request 59537: Fixed a bug in 'ComposingContainerizerProcess::wait()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59537/#review176153 --- Bad patch! Reviews applied: [59537] Failed command: python

Re: Review Request 59555: A prototype to move sample collection into async sampling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59555/#review176152 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176151 --- Patch looks great! Reviews applied: [58719, 58720] Passed

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated May 25, 2017, 11:30 p.m.) Review request for mesos, James Peach and

Re: Review Request 49571: Added a benchmark test for allocations.

> On May 24, 2017, 11:35 p.m., James Peach wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 4972 (patched) > > > > > > Why do we need to loop that many times? I don't think you'd expect the > >

Re: Review Request 59186: Additional linux/capabilities isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59186/#review176145 --- Patch looks great! Reviews applied: [59547, 59548, 59549, 59550,

Review Request 59583: Added a test to verify executor driver message dropping behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59583/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.

Review Request 59582: Made the executor driver drop some messages when not connected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59582/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.

Re: Review Request 59556: Windows: Updated build documentation.

> On May 25, 2017, 9:20 p.m., Joseph Wu wrote: > > docs/windows.md > > Lines 10-13 (original), 10-11 (patched) > > > > > > These double-newlines are part of the markdown style guidelines we use > > in Mesos docs.

Review Request 59581: Resolved a TODO that depended on a newer version of gtest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59581/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 59500: Added Windows ReviewBot launch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59500/ --- (Updated May 25, 2017, 10:20 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 59500: Added Windows ReviewBot launch script.

> On May 25, 2017, 9:35 p.m., Joseph Wu wrote: > > support/mesos-reviewbot.ps1 > > Lines 1 (patched) > > > > > > Need one of these at the top: > > ``` > > # Licensed to the Apache Software Foundation (ASF)

Re: Review Request 59500: Added Windows ReviewBot launch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59500/#review176134 --- support/mesos-reviewbot.ps1 Lines 1 (patched)

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/#review176133 --- Ship it! Ship It! - Joseph Wu On May 24, 2017, 12:13 p.m.,

Re: Review Request 59556: Windows: Updated build documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59556/#review176128 --- Ship it! I can make some of these tweaks before committing.

Re: Review Request 59353: Enabled DOCKER and ROOT filter flags on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59353/#review176126 --- Ship it! Ship It! - Li Li On May 17, 2017, 9:35 p.m., John

Re: Review Request 59353: Enabled DOCKER and ROOT filter flags on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59353/#review176125 --- Ship it! Ship It! - Li Li On May 17, 2017, 9:35 p.m., John

Re: Review Request 59557: Windows: Bumped required CMake version to 3.8.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59557/#review176124 --- Ship it! There's no particular reason to require `3.8.1`

Re: Review Request 59545: Added a test to verify the agent flag 'executor_reregistration_timeout'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59545/ --- (Updated May 25, 2017, 7:27 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/#review176117 --- Patch looks great! Reviews applied: [59536] Passed command:

Review Request 59579: Fixed flakiness in MasterTest.EndpointsForHalfRemovedSlave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59579/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Review Request 59578: Made MasterTest.MaxCompletedTasksPerFrameworkFlag less fragile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59578/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 59541: Fixed flakiness in MasterAllocatorTest.FrameworkExited.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59541/#review176115 --- Ship it! LGTM! - Anand Mazumdar On May 25, 2017, 6:36 p.m.,

Re: Review Request 59541: Fixed flakiness in MasterAllocatorTest.FrameworkExited.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59541/ --- (Updated May 25, 2017, 6:36 p.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 59541: Fixed flakiness in MasterAllocatorTest.FrameworkExited.

> On May 25, 2017, 3:58 a.m., Anand Mazumdar wrote: > > src/tests/master_allocator_tests.cpp > > Lines 719-720 (patched) > > > > > > hmm, not immediately clear to me what guarrantees that this method is > > invoked

Re: Review Request 59545: Added a test to verify the agent flag 'executor_reregistration_timeout'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59545/#review176111 --- Fix it, then Ship it! src/tests/slave_tests.cpp Line 7069

Re: Review Request 58515: Update 3rdparty build to support protobuf 3.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58515/ --- (Updated May 25, 2017, 6:15 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/ --- (Updated May 25, 2017, 6:13 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 59556: Windows: Updated build documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59556/#review176108 --- Ship it! Ship It! - Li Li On May 24, 2017, 11:38 p.m.,

Re: Review Request 59545: Added a test to verify the agent flag 'executor_reregistration_timeout'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59545/ --- (Updated May 25, 2017, 6:01 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/ --- (Updated May 25, 2017, 4:42 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 59537: Fixed a bug in 'ComposingContainerizerProcess::wait()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59537/ --- (Updated May 25, 2017, 4:33 p.m.) Review request for mesos, Alexander

Re: Review Request 59556: Windows: Updated build documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59556/#review176085 --- Ship it! Ship It! - Jeff Coffler On May 24, 2017, 11:38

Re: Review Request 59560: Replaced "!(x == y)" with "x != y" when comparing SlaveIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59560/#review176084 --- Ship it! Ship It! - Vinod Kone On May 25, 2017, 12:37 a.m.,

Re: Review Request 59559: Replaced `.get().` with `->` in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59559/#review176083 --- Ship it! Thanks for the sweep! - Vinod Kone On May 25,

Re: Review Request 59558: Replaced `.get().` with `->` for access to `Master::leader`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59558/#review176082 --- Ship it! Ship It! - Vinod Kone On May 25, 2017, 12:37 a.m.,

Re: Review Request 59545: Added a test to verify the agent flag 'executor_reregistration_timeout'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59545/#review176080 --- src/tests/slave_tests.cpp Lines 7077 (patched)

Re: Review Request 59537: Fixed a bug in 'ComposingContainerizerProcess::wait()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59537/#review176078 --- Fix it, then Ship it! src/slave/containerizer/composing.cpp

Re: Review Request 59555: A prototype to move sample collection into async sampling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59555/#review176075 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 59545: Added a test to verify the agent flag 'executor_reregistration_timeout'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59545/#review176073 --- Patch looks great! Reviews applied: [59545] Passed command:

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 25, 2017, 9:08 a.m.) Review request for mesos and Kevin Klues.