Review Request 64197: Tracked layers in memory for provisioned containers.

2017-11-29 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64197/ --- Review request for mesos, Gilbert Song and Jason Lai. Bugs: MESOS-8280

Re: Review Request 64158: Used helper functions instead of switches for resource extraction.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64158/#review192238 --- Ship it! Ship It! - Jie Yu On Nov. 29, 2017, 1:52 p.m., Jan

Re: Review Request 64188: Fixed Windows `HealthCheckTest.HealthyTaskViaTCP` test failure.

2017-11-29 Thread Andrew Schwartzmeyer
> On Nov. 29, 2017, 7:45 p.m., Andrew Schwartzmeyer wrote: > > Ship It! This is committed: commit 5574681dd (HEAD -> master, apache/master, apache/HEAD) Author: Akash Gupta Date: Wed Nov 29 19:45:02 2017 -0800 Fixed Windows `HealthCheckTest.HealthyTaskViaTCP`

Re: Review Request 64188: Fixed Windows `HealthCheckTest.HealthyTaskViaTCP` test failure.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64188/#review192234 --- Ship it! Ship It! - Andrew Schwartzmeyer On Nov. 29, 2017,

Re: Review Request 64181: Windows: Fixed `os::rmdir` bugs.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64181/ --- (Updated Nov. 29, 2017, 7:25 p.m.) Review request for mesos, Akash Gupta, John

Re: Review Request 64181: Windows: Fixed `os::rmdir` bugs.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64181/ --- (Updated Nov. 29, 2017, 7:18 p.m.) Review request for mesos, Akash Gupta, John

Re: Review Request 63817: Windows: Enabled more agent tests.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63817/ --- (Updated Nov. 29, 2017, 7:17 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 64151: Added an agent endpoint to list resource providers.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64151/#review192232 --- src/slave/slave.cpp Lines 804 (patched)

Re: Review Request 64168: Introduced a 'OperationUUID' type.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64168/#review192230 --- include/mesos/mesos.proto Lines 2186 (patched)

Re: Review Request 63997: Added a new allocator method to add resources to agents.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63997/#review192229 --- Ship it! Ship It! - Jie Yu On Nov. 29, 2017, 4:27 p.m.,

Re: Review Request 64136: Introduced an allocator helper function to track used resources.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64136/#review192227 --- Ship it! Ship It! - Jie Yu On Nov. 29, 2017, 4:27 p.m.,

Re: Review Request 64028: Removed duplicate resources conversions.

2017-11-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64028/#review192226 --- Ship it! Ship It! - Benjamin Mahler On Nov. 28, 2017, 5:41

Re: Review Request 63817: Windows: Enabled more agent tests.

2017-11-29 Thread Andrew Schwartzmeyer
> On Nov. 29, 2017, 5:38 p.m., Akash Gupta wrote: > > src/tests/slave_tests.cpp > > Lines 678 (patched) > > > > > > Think you can do the same as the isolater flags by wrapping these > > `#ifdef` in a function,

Re: Review Request 64181: Windows: Fixed `os::rmdir` bugs.

2017-11-29 Thread Andrew Schwartzmeyer
> On Nov. 29, 2017, 5:36 p.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/os/windows/rmdir.hpp > > Lines 43 (patched) > > > > > > I think it makes sense to wrap `RemoveFileW` and `RemoveDirectoryW` > > with

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-29 Thread Jie Yu
> On Nov. 29, 2017, 3:09 a.m., Jie Yu wrote: > > src/tests/slave_tests.cpp > > Lines 8900-8923 (patched) > > > > > > It'll be nice to move this logic here to > > MockResourceProvider::operationFailed and call

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/#review192223 --- Ship it! Ship It! - Jie Yu On Nov. 29, 2017, 4:27 p.m.,

Re: Review Request 64086: Removed currently unneeded 'AWAIT_READY's in 'MockResourceProvider'.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64086/#review192221 --- Ship it! Ship It! - Jie Yu On Nov. 29, 2017, 4:27 p.m.,

Re: Review Request 63732: Reconciled offer operations between agent and master.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/#review192214 --- Fix it, then Ship it! src/master/master.cpp Lines 7426

Re: Review Request 64187: Included `stout/os/realpath.hpp` in `flags.hpp`.

2017-11-29 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64187/#review192218 --- Ship it! Ship It! - Akash Gupta On Nov. 30, 2017, 1:18

Re: Review Request 64182: Windows: Cleaned up `os::exists`.

2017-11-29 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64182/#review192217 --- Ship it! Ship It! - Akash Gupta On Nov. 29, 2017, 10:45

Review Request 64195: Updated the tests to use MULTI_ROLE frameworks by default.

2017-11-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64195/ --- Review request for mesos and Michael Park. Bugs: MESOS-8237

Review Request 64194: Stripped AllocationInfo from offers to non-MULTI_ROLE schedulers.

2017-11-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64194/ --- Review request for mesos, James DeFelice and Michael Park. Bugs: MESOS-8237

Re: Review Request 63810: Windows: Added internal `fullpath` API to normalize paths.

2017-11-29 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63810/#review192216 --- Ship it! Ship It! - Akash Gupta On Nov. 29, 2017, 10:47

Re: Review Request 63817: Windows: Enabled more agent tests.

2017-11-29 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63817/#review192215 --- src/tests/slave_tests.cpp Lines 678 (patched)

Re: Review Request 64181: Windows: Fixed `os::rmdir` bugs.

2017-11-29 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64181/#review192213 --- 3rdparty/stout/include/stout/os/windows/rmdir.hpp Lines 43

Re: Review Request 63842: Allowed removing non-terminal offer operations.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/#review192211 --- src/master/master.cpp Lines 10952-10961 (patched)

Re: Review Request 63811: Windows: Added internal `get_handle_follow` which follows symlinks.

2017-11-29 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63811/#review192210 --- Ship it! Ship It! - Akash Gupta On Nov. 29, 2017, 10:47

Re: Review Request 64187: Included `stout/os/realpath.hpp` in `flags.hpp`.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64187/ --- (Updated Nov. 29, 2017, 5:18 p.m.) Review request for mesos, Akash Gupta, John

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review192205 --- Fix it, then Ship it! src/slave/slave.cpp Lines 6812

Re: Review Request 64180: Windows: Fixed `fs::symlink` to support relative and broken paths.

2017-11-29 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64180/#review192208 --- Ship it! Ship It! - Akash Gupta On Nov. 29, 2017, 10:44

Re: Review Request 63809: Windows: Fixed `fs::symlink` to not need admin privileges.

2017-11-29 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63809/#review192207 --- Ship it! Ship It! - Akash Gupta On Nov. 29, 2017, 10:46

Re: Review Request 64188: Fixed Windows `HealthCheckTest.HealthyTaskViaTCP` test failure.

2017-11-29 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64188/#review192206 --- Ship it! Ship It! - Gaston Kleiman On Nov. 29, 2017, 4:41

Review Request 64188: Fixed Windows `HealthCheckTest.HealthyTaskViaTCP` test failure.

2017-11-29 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64188/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Re: Review Request 63842: Allowed removing non-terminal offer operations.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/#review192204 --- Fix it, then Ship it! src/master/master.cpp Lines 10953

Re: Review Request 64183: Fixed Windows (and maybe clang) build break.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64183/#review192202 --- Ship it! Ship It! - Andrew Schwartzmeyer On Nov. 29, 2017,

Re: Review Request 64008: Activated AGENT_UPDATE master capability.

2017-11-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64008/#review192199 --- src/master/constants.cpp Lines 25-34 (original), 25-36 (patched)

Re: Review Request 64183: Fixed Windows (and maybe clang) build break.

2017-11-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64183/#review192198 --- Ship it! We'll commit this quick fix first. When

Review Request 64187: Included `stout/os/realpath.hpp` in `flags.hpp`.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64187/ --- Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu.

Re: Review Request 64176: Added a test for ContainerDaemon.

2017-11-29 Thread Jie Yu
> On Nov. 29, 2017, 9:59 p.m., Joseph Wu wrote: > > src/tests/CMakeLists.txt > > Lines 87 (patched) > > > > > > Most of Chun's code is not included in the CMake build, so adding this > > line will probably not

Re: Review Request 64177: Added a test in ContainerDaemon for testing failed authorization.

2017-11-29 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64177/#review192194 --- Ship it! Ship It! - Chun-Hung Hsiao On Nov. 29, 2017, 10:03

Re: Review Request 64177: Added a test in ContainerDaemon for testing failed authorization.

2017-11-29 Thread Jie Yu
> On Nov. 29, 2017, 11:39 p.m., Chun-Hung Hsiao wrote: > > src/tests/container_daemon_tests.cpp > > Lines 244 (patched) > > > > > > Isn't it true that the secret generator will always be nonnull? > > Jie Yu wrote:

Re: Review Request 64177: Added a test in ContainerDaemon for testing failed authorization.

2017-11-29 Thread Jie Yu
> On Nov. 29, 2017, 11:39 p.m., Chun-Hung Hsiao wrote: > > src/tests/container_daemon_tests.cpp > > Lines 244 (patched) > > > > > > Isn't it true that the secret generator will always be nonnull? If SSL is not

Re: Review Request 62636: Generated authentication tokens for local resource providers.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62636/#review192191 --- Two tests has been added: https://reviews.apache.org/r/64176

Re: Review Request 62637: Added an object approver to authorize requests from resource providers.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62637/#review192190 --- Two tests has been added: https://reviews.apache.org/r/64176

Re: Review Request 64177: Added a test in ContainerDaemon for testing failed authorization.

2017-11-29 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64177/#review192189 --- src/tests/container_daemon_tests.cpp Lines 244 (patched)

Re: Review Request 64171: Fixed the multi taskgroup shared pid ns test due to slowness.

2017-11-29 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64171/#review192188 --- Ship it! Ship It! - Qian Zhang On Nov. 30, 2017, 3:19 a.m.,

Re: Review Request 64183: Fixed Windows (and maybe clang) build break.

2017-11-29 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64183/ --- (Updated Nov. 29, 2017, 11:15 p.m.) Review request for mesos and Andrew

Review Request 64183: Fixed Windows (and maybe clang) build break.

2017-11-29 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64183/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-11-29 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review192185 --- Ship it! Committing with some small tweaks below and for the

Re: Review Request 64163: Made sure only non-terminal operations use resources.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64163/#review192187 --- Ship it! Ship It! - Jie Yu On Nov. 29, 2017, 4:27 p.m.,

Re: Review Request 64018: Added tests for the d_type support validation.

2017-11-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64018/#review192186 --- Ship it! Ship It! - James Peach On Nov. 29, 2017, 4:24

Re: Review Request 63652: Added d_type check in containerizer backend validation.

2017-11-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/#review192184 --- Ship it! Ship It! - James Peach On Nov. 19, 2017, 11:49

Re: Review Request 63817: Windows: Enabled more agent tests.

2017-11-29 Thread Andrew Schwartzmeyer
> On Nov. 27, 2017, 6:18 p.m., Akash Gupta wrote: > > src/tests/slave_tests.cpp > > Lines 339 (patched) > > > > > > Should the #ifdef be inside a function / variable instead of copy + > > pasting into multiple

Re: Review Request 63817: Windows: Enabled more agent tests.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63817/ --- (Updated Nov. 29, 2017, 2:49 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 63815: Windows: Fixed environment priorities in `shell.hpp`.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63815/ --- (Updated Nov. 29, 2017, 2:48 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 63813: Windows: Fixed name of default executor.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63813/ --- (Updated Nov. 29, 2017, 2:48 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 63816: Windows: Fixed MESOS-6816 to enable `ExecutorEnvironmentVariables`.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63816/ --- (Updated Nov. 29, 2017, 2:48 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 63812: Windows: Fixed `os::realpath` to behave like POSIX version.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63812/ --- (Updated Nov. 29, 2017, 2:48 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 63814: Windows: Fixed `os::host_default_path()`.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63814/ --- (Updated Nov. 29, 2017, 2:48 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 63811: Windows: Added internal `get_handle_follow` which follows symlinks.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63811/ --- (Updated Nov. 29, 2017, 2:47 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 63810: Windows: Added internal `fullpath` API to normalize paths.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63810/ --- (Updated Nov. 29, 2017, 2:47 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 63809: Windows: Fixed `fs::symlink` to not need admin privileges.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63809/ --- (Updated Nov. 29, 2017, 2:46 p.m.) Review request for mesos, Akash Gupta, Jie

Review Request 64182: Windows: Cleaned up `os::exists`.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64182/ --- Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu.

Review Request 64181: Windows: Fixed `os::rmdir` bugs.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64181/ --- Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu.

Review Request 64180: Windows: Fixed `fs::symlink` to support relative and broken paths.

2017-11-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64180/ --- Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. Bugs:

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review192183 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 1402

Re: Review Request 63971: Defined a module interface for translating volume profiles.

2017-11-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/ --- (Updated Nov. 29, 2017, 2:34 p.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 64177: Added a test in ContainerDaemon for testing failed authorization.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64177/ --- Review request for mesos, Chun-Hung Hsiao and Joseph Wu. Repository: mesos

Re: Review Request 64176: Added a test for ContainerDaemon.

2017-11-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64176/#review192172 --- Fix it, then Ship it! LGTM. src/tests/CMakeLists.txt Lines

Re: Review Request 64095: Added a generic actor to be used by status update managers.

2017-11-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/#review192171 --- src/status_update_manager/status_update_manager_process.hpp

Review Request 64176: Added a test for ContainerDaemon.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64176/ --- Review request for mesos, Chun-Hung Hsiao and Joseph Wu. Repository: mesos

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

2017-11-29 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- (Updated Nov. 29, 2017, 8:52 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 64169: Add checks for slave gone.

2017-11-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64169/#review192162 --- Ship it! Ship It! - Vinod Kone On Nov. 29, 2017, 6:29 p.m.,

Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation.

2017-11-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64012/#review192160 --- src/slave/slave.cpp Lines 6336 (patched)

Re: Review Request 63823: Initialized and subscribed storage local resource provider.

2017-11-29 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63823/ --- (Updated Nov. 29, 2017, 7:49 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 62636: Generated authentication tokens for local resource providers.

2017-11-29 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62636/ --- (Updated Nov. 29, 2017, 7:35 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 64171: Fixed the multi taskgroup shared pid ns test due to slowness.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64171/#review192161 --- Ship it! Ship It! - Jie Yu On Nov. 29, 2017, 7:19 p.m.,

Review Request 64171: Fixed the multi taskgroup shared pid ns test due to slowness.

2017-11-29 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64171/ --- Review request for mesos, Jie Yu and Qian Zhang. Repository: mesos

Re: Review Request 64101: Skip registry update if SlaveInfo didn't change.

2017-11-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64101/ --- (Updated Nov. 29, 2017, 7:11 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation.

2017-11-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64012/ --- (Updated Nov. 29, 2017, 7:10 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64008: Activated AGENT_UPDATE master capability.

2017-11-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64008/ --- (Updated Nov. 29, 2017, 7:09 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192157 --- Ship it! Ship It! - Vinod Kone On Nov. 29, 2017, 6:27 p.m.,

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192151 --- src/master/master.cpp Lines 6913 (patched)

Re: Review Request 64170: Fall back to binding devices if mknod fails.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64170/#review192156 --- Ship it! Ship It! - Jie Yu On Nov. 29, 2017, 6:40 p.m.,

Review Request 64170: Fall back to binding devices if mknod fails.

2017-11-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64170/ --- Review request for mesos and Jie Yu. Bugs: MESOS-8272

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Benno Evers
> On Nov. 23, 2017, 12:52 a.m., Vinod Kone wrote: > > src/master/master.cpp > > Line 6672 (original), 6609 (patched) > > > > > > Reject if agent is being marked gone or already marked gone. Can you do > > this and

Review Request 64169: Add checks for slave gone.

2017-11-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64169/ --- Review request for mesos. Repository: mesos Description --- Add checks

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Benno Evers
> On Nov. 23, 2017, 12:52 a.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 6323 (patched) > > > > > > Can you file a JIRA for this? https://issues.apache.org/jira/browse/MESOS-8273 - Benno

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Nov. 29, 2017, 6:27 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

2017-11-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/#review192147 --- Ship it! Ship It! - Vinod Kone On Nov. 29, 2017, 6:17 p.m.,

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

2017-11-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/ --- (Updated Nov. 29, 2017, 6:17 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64009: Added new UpdateSlave registry operation.

2017-11-29 Thread Vinod Kone
> On Nov. 29, 2017, 4:30 p.m., Michael Park wrote: > > I think the fact that `UpdateSlave` gets a `SlaveInfo` in the old format is > > due > > to the fact that we don't upgrade those resources in the master until we > > get to > > the `Slave` struct ctors, as well as the fact that the agents

Re: Review Request 64009: Added new UpdateSlave registry operation.

2017-11-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/ --- (Updated Nov. 29, 2017, 6:06 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64007: Added infrastructure to support master capabilities.

2017-11-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64007/#review192144 --- Ship it! Ship It! - Vinod Kone On Nov. 29, 2017, 6:05 p.m.,

Re: Review Request 64007: Added infrastructure to support master capabilities.

2017-11-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64007/ --- (Updated Nov. 29, 2017, 6:05 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64006: Moved registry operations into separate header.

2017-11-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64006/#review192143 --- Ship it! Ship It! - Vinod Kone On Nov. 29, 2017, 6:04 p.m.,

Re: Review Request 64006: Moved registry operations into separate header.

2017-11-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64006/ --- (Updated Nov. 29, 2017, 6:04 p.m.) Review request for mesos and Vinod Kone.

Review Request 64145: Added status update acknowledgement to resource provider manager.

2017-11-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64145/ --- Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu. Bugs:

Re: Review Request 64146: Added offer operation update acknowledgement to the agent.

2017-11-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64146/ --- (Updated Nov. 29, 2017, 5:56 p.m.) Review request for mesos, Chun-Hung Hsiao,

Review Request 64146: Added offer operation update acknowledgement to the agent.

2017-11-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64146/ --- Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu. Bugs:

  1   2   >