Re: Review Request 68018: Added `SeccompFilter` class.

> On Jan. 14, 2019, 4:31 p.m., Qian Zhang wrote: > > src/linux/seccomp/seccomp.cpp > > Lines 137-139 (patched) > > > > > > Will this affect the task run by Mesos? E.g., a task may want to run a > > program which

Re: Review Request 69726: Fixed flakiness in MasterAPITest.OperationUpdatesUponOfferGone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69726/#review212044 --- Patch looks great! Reviews applied: [69726] Passed command:

Re: Review Request 69158: Added an integration test for resource provider removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69158/#review212042 --- PASS: Mesos patch 69158 was successfully built and tested.

Re: Review Request 68021: Added `linux/seccomp` isolator.

> On Jan. 15, 2019, 11:02 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp > > Lines 17-18 (patched) > > > > > > A newline between. > > Andrei Budnik wrote: > >

Re: Review Request 69588: Removed outdated authorization logic for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69588/#review212040 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69755: Moved flags and constants in MesosContainerLaunch into header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69755/#review212039 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review212038 --- Ship it! Ship It! - Joseph Wu On Jan. 15, 2019, 3:13 p.m.,

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/ --- (Updated Jan. 15, 2019, 11:13 p.m.) Review request for mesos, Benjamin

Review Request 69752: Split scheduler::Call validation into a separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69752/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Repository:

Review Request 69754: CMake: Changed mesos-execute to link against a smaller library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69754/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Repository:

Review Request 69755: Moved flags and constants in MesosContainerLaunch into header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69755/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Repository:

Review Request 69753: CMake: Split part of libmesos into several smaller libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69753/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Repository:

Review Request 69751: CMake: Disabled "local" clusters in the scheduler libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69751/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Repository:

Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into smaller tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69721/#review212036 --- Ship it! Ship It! - Till Toenshoff On Jan. 14, 2019, 7:54

Re: Review Request 69720: Made `SSLTest` an unparameterized test suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69720/#review212037 --- Ship it! Ship It! - Till Toenshoff On Jan. 14, 2019, 7:54

Re: Review Request 69750: CMake: Changed linkage of mesos-tcp-connect.

> On Jan. 15, 2019, 12:53 p.m., Benjamin Bannier wrote: > > Is this something we should create a JIRA for? I am asking since it could > > have a noticable impact on check performance due to faster loading and a > > candidate for (future) backporting. Assuming we use the CMake build when

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

> On Jan. 15, 2019, 8:29 p.m., Benjamin Bannier wrote: > > 3rdparty/grpc-1.10.0.patch > > Lines 33 (patched) > > > > > > Not related to this patch, but I wonder how this was needed given that > > we didn't patch

Re: Review Request 69750: CMake: Changed linkage of mesos-tcp-connect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69750/#review212033 --- Ship it! Is this something we should create a JIRA for? I am

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review212032 --- Fix it, then Ship it! LGTM. 3rdparty/grpc-1.10.0.patch Lines

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

> On Jan. 14, 2019, 11:55 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 823-832 (original), 827-836 (patched) > > > > > > How about moving this snippt to the end of this function, so

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/#review212031 --- PASS: Mesos patch 69719 was successfully built and tested.

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

> On Jan. 14, 2019, 11:55 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 1004-1005 (patched) > > > > > > How about the following, to make it consistent with, e.g., > >

Review Request 69749: CMake: Cleaned up a block of platform-specific sources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69749/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Repository:

Review Request 69750: CMake: Changed linkage of mesos-tcp-connect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69750/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Repository:

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review212028 --- Ship it! Ship It! - Gilbert Song On Nov. 8, 2018, 7:23

Re: Review Request 69588: Removed outdated authorization logic for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69588/#review212027 --- src/master/master.cpp Lines 3604-3605 (original), 3604-3605

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212026 --- Should we be surfacing a close EINTR as an error or let that be

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 14, 2019, 11:38 p.m., Gilbert Song wrote: > > include/mesos/seccomp/seccomp.proto > > Lines 21-28 (patched) > > > > > > This is my fault. Sorry, Andrei! > > > > Would you mind moving this .proto

Re: Review Request 68147: Added agent support to remove local resource providers.

> On Aug. 17, 2018, 10:29 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 8195 (patched) > > > > > > Let's validate that there is no task using the resources provided by > > this RP before doing the

Re: Review Request 68147: Added agent support to remove local resource providers.

> On Jan. 15, 2019, 5:53 a.m., Chun-Hung Hsiao wrote: > > src/tests/api_tests.cpp > > Lines 7857 (patched) > > > > > > ``` > > Owned detector = master.get()->createDetector(); > > ``` > > And > >

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 15, 2019, 2:39 a.m., Gilbert Song wrote: > > include/mesos/mesos.proto > > Lines 3158-3159 (patched) > > > > > > Seems like this was added recently. > > > > Is this field only used when there is

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 15, 2019, 8:41 a.m., Qian Zhang wrote: > > include/mesos/seccomp/seccomp.proto > > Lines 79 (patched) > > > > > > So the value must be numeric? Do we support other types (like string > > value)? > So the

Re: Review Request 68020: Added Seccomp-related flags to the agent.

> On Jan. 15, 2019, 2:31 a.m., Qian Zhang wrote: > > src/slave/flags.cpp > > Lines 1399 (patched) > > > > > > Path or name? Well.. technically it is a path. For example, if

Re: Review Request 68021: Added `linux/seccomp` isolator.

> On Jan. 15, 2019, 3:02 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp > > Lines 17-18 (patched) > > > > > > A newline between.

Re: Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/ --- (Updated Jan. 15, 2019, 4:03 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69687: Fixed flakiness of resource provider ContainerTerminationMetric test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69687/#review212018 --- PASS: Mesos patch 69687 was successfully built and tested.

Re: Review Request 69158: Added an integration test for resource provider removal.

> On Jan. 15, 2019, 7:08 a.m., Chun-Hung Hsiao wrote: > > src/tests/slave_tests.cpp > > Lines 10609 (patched) > > > > > > Maybe move this to > > `AgentAPITest.OperationStatusUpdateUponResourceProviderGone`? We

Re: Review Request 69158: Added an integration test for resource provider removal.

> On Jan. 15, 2019, 6:58 a.m., Chun-Hung Hsiao wrote: > > src/tests/slave_tests.cpp > > Lines 10625-10626 (patched) > > > > > > ``` > > Owned detector = master.get()->createDetector(); > > Try> slave =

Re: Review Request 69158: Added an integration test for resource provider removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69158/ --- (Updated Jan. 15, 2019, 4:03 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68018: Added `SeccompFilter` class.

> On Jan. 3, 2019, 1:58 a.m., Gilbert Song wrote: > > src/linux/seccomp/seccomp.cpp > > Lines 141-144 (patched) > > > > > > Instead of always set `SCMP_FLTATR_CTL_NNP`. Should we consider to > > check root

[GitHub] dlazarus commented on a change in pull request #324: MESOS-9499 extended URI syntax to support any Zookeeper authentication schemes

dlazarus commented on a change in pull request #324: MESOS-9499 extended URI syntax to support any Zookeeper authentication schemes URL: https://github.com/apache/mesos/pull/324#discussion_r247926266 ## File path: include/mesos/zookeeper/url.hpp ## @@ -101,16 +102,35 @@

Re: Review Request 68018: Added `SeccompFilter` class.

> On Jan. 14, 2019, 8:31 a.m., Qian Zhang wrote: > > src/linux/seccomp/seccomp.cpp > > Lines 137-139 (patched) > > > > > > Will this affect the task run by Mesos? E.g., a task may want to run a > > program which

Re: Review Request 68147: Added agent support to remove local resource providers.

> On Jan. 15, 2019, 6:42 a.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 11248 (patched) > > > > > > Can you add a comment explaining why it is not necessary to call > >

Re: Review Request 68147: Added agent support to remove local resource providers.

> On Jan. 15, 2019, 6:53 a.m., Chun-Hung Hsiao wrote: > > src/tests/api_tests.cpp > > Lines 7857 (patched) > > > > > > ``` > > Owned detector = master.get()->createDetector(); > > ``` > > And > >

Re: Review Request 68147: Added agent support to remove local resource providers.

> On Aug. 18, 2018, 12:29 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 8195 (patched) > > > > > > Let's validate that there is no task using the resources provided by > > this RP before doing the

Re: Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/ --- (Updated Jan. 15, 2019, 3:53 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 15, 2019, 10:39 a.m., Gilbert Song wrote: > > include/mesos/mesos.proto > > Lines 3158-3159 (patched) > > > > > > Seems like this was added recently. > > > > Is this field only used when there

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review212004 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

> On Jan. 15, 2019, 12:55 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 823-832 (original), 827-836 (patched) > > > > > > How about moving this snippt to the end of this function, so

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/ --- (Updated Jan. 15, 2019, 10:27 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69606: Made starting and stopping on CSI plugin containers more verbose.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69606/ --- (Updated Jan. 15, 2019, 9:43 a.m.) Review request for mesos and Chun-Hung

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211942 --- Fix it, then Ship it! include/mesos/seccomp/seccomp.proto

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 15, 2019, 10:39 a.m., Gilbert Song wrote: > > include/mesos/mesos.proto > > Lines 3158-3159 (patched) > > > > > > Seems like this was added recently. > > > > Is this field only used when there

Re: Review Request 69687: Fixed flakiness of resource provider ContainerTerminationMetric test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69687/ --- (Updated Jan. 15, 2019, 9:31 a.m.) Review request for mesos and Chun-Hung