re? We are already comparing two scalar
> > quantities, so is the flatten required?
>
> Anindya Sinha wrote:
> In the case of a `RESERVE` or `UNRESERVE` operation, the `newAllocation`
> and `oldAllocation` varies in distribution of resources across roles.
>
> eg. For `RESERV
ug, but it seems wrong to be activating roles here if the
> > framework was deactivated. Would be good to sync with mpark on this
> > original change. It seems to me that if the framework is deactivated via
> > deactivateFramework, we wouldn't want to be activating thin
d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/15/
Changes: https://reviews.apache.org/r/57818/diff/14-15/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
: https://reviews.apache.org/r/57817/diff/14-15/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/14/
Changes: https://reviews.apache.org/r/57818/diff/13-14/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57817/#review176833
---
On June 2, 2017, 9:29 p.m., Anindya Sinha wrote
> On June 2, 2017, 7:51 p.m., Vinod Kone wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 463 (patched)
> > <https://reviews.apache.org/r/57817/diff/12-13/?file=1736091#file1736091line474>
> >
> > what about new roles that are al
ug, but it seems wrong to be activating roles here if the
> > framework was deactivated. Would be good to sync with mpark on this
> > original change. It seems to me that if the framework is deactivated via
> > deactivateFramework, we wouldn't want to be activating thin
rameworkSorters.at(role)->activate(frameworkId.value());
}
```
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57817/#review176833
-------
On June 2, 2017, 5:49 p.m., Anindya Sinha wrote:
>
>
d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/13/
Changes: https://reviews.apache.org/r/57818/diff/12-13/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
hat have been added, as well as the roles which have moved from suppressed to
non-suppressed mode.
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57817/#review176630
---
.
Thanks,
Anindya Sinha
to ensure that
`update()` returns the same value for all nodes in the path from leaf -> root.
- Anindya
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57935/#review176687
://reviews.apache.org/r/57935/diff/3-4/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
://reviews.apache.org/r/52071/diff/13/
Changes: https://reviews.apache.org/r/52071/diff/12-13/
Testing
---
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
://reviews.apache.org/r/51879/diff/14/
Changes: https://reviews.apache.org/r/51879/diff/13-14/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
which we can do later. For now, I changed the order of the
`JSON::Value` in the test to satisfy the condition.
> On June 1, 2017, 12:42 a.m., Jiang Yan Xu wrote:
> > src/tests/reservation_endpoints_tests.cpp
> > Lines 1784-1791 (original)
> > <https://reviews.apache.
---
This is a followup for RR 55761 (for `gpus` resource).
Diffs
-
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp
c288ad634b856702483b9751f41445308babd0c9
Diff: https://reviews.apache.org/r/59723/diff/1/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
passed.
Thanks,
Anindya Sinha
Diff: https://reviews.apache.org/r/57817/diff/12/
Changes: https://reviews.apache.org/r/57817/diff/11-12/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/12/
Changes: https://reviews.apache.org/r/57818/diff/11-12/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/11/
Changes: https://reviews.apache.org/r/57818/diff/10-11/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
df0c5c88786190be06df7ef3602834aa8985cefe
Diff: https://reviews.apache.org/r/57817/diff/11/
Changes: https://reviews.apache.org/r/57817/diff/10-11/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/10/
Changes: https://reviews.apache.org/r/57818/diff/9-10/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
why you need to have this variable here? Looks
> > like the sorter can be the source of truth of whether a role is activated
> > or not?
>
> Anindya Sinha wrote:
> `FrameworkInfo::roles` indicates all the roles the framework registers
> as, and `Call::Subscribe::suppr
Diff: https://reviews.apache.org/r/57817/diff/10/
Changes: https://reviews.apache.org/r/57817/diff/9-10/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
cative of an actual problem but should help
in diagnosing such conditions.
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53841/#review176110
----------
150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha
end of the test?
I think we should defer this to a future commit to do this for all benchmarks.
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/#review176019
--
: https://reviews.apache.org/r/52071/diff/11-12/
Testing
---
Documentation change only. All tests passed.
Thanks,
Anindya Sinha
.
Thanks,
Anindya Sinha
/13/
Changes: https://reviews.apache.org/r/52002/diff/12-13/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
1bb5d0741c9f9ea59f34e92159a335661019444d
Diff: https://reviews.apache.org/r/51879/diff/13/
Changes: https://reviews.apache.org/r/51879/diff/12-13/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
f90068a50c822aa90b864329ae87c9b5f8bb
Diff: https://reviews.apache.org/r/53842/diff/8/
Changes: https://reviews.apache.org/r/53842/diff/7-8/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
.apache.org/r/53842/#review172952
---
On May 23, 2017, 4:30 p.m., Anindya Sinha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53842/
> -
it:
https://reviews.apache.org/r/53841/#review172540
---
On May 24, 2017, 4:23 a.m., Anindya Sinha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
/r/53841/diff/6-7/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/9/
Changes: https://reviews.apache.org/r/57818/diff/8-9/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
52e78b6b6280a159233b402ce2849448204d4f11
Diff: https://reviews.apache.org/r/57817/diff/9/
Changes: https://reviews.apache.org/r/57817/diff/8-9/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
we do not anticipate the number of roles
to be too many.
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57817/#review175846
/containerizer/mesos/linux_launcher.cpp
1cea04edac8e0c4aea8c1c7d946b5065f3eac931
Diff: https://reviews.apache.org/r/53666/diff/3/
Changes: https://reviews.apache.org/r/53666/diff/2-3/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha
tests passed.
Thanks,
Anindya Sinha
/53842/diff/7/
Changes: https://reviews.apache.org/r/53842/diff/6-7/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
/metrics.cpp
ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1
src/tests/hierarchical_allocator_tests.cpp
6dee2296d5a14185dbf7eee17968b20148839bfd
Diff: https://reviews.apache.org/r/53840/diff/7/
Changes: https://reviews.apache.org/r/53840/diff/6-7/
Testing
---
All tests passed.
Thanks,
Anindya
hat we could re-use the `Call::Suppress` message
> > here instead of re-defining it. That way any changes to suppress would be
> > in sync.
>
> Anindya Sinha wrote:
> Currently, `Call::Suppress` is:
> ```
> message Suppress {
> optional stri
/resource_offers_tests.cpp f0bca1d9e03013ce35215b0ffa6b50b38972dc0c
src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11
Diff: https://reviews.apache.org/r/57817/diff/8/
Changes: https://reviews.apache.org/r/57817/diff/7-8/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/8/
Changes: https://reviews.apache.org/r/57818/diff/7-8/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
Diff: https://reviews.apache.org/r/57815/diff/6/
Changes: https://reviews.apache.org/r/57815/diff/5-6/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
://reviews.apache.org/r/58486/diff/8/
Changes: https://reviews.apache.org/r/58486/diff/7-8/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
/diff/7/
Changes: https://reviews.apache.org/r/58486/diff/6-7/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
://reviews.apache.org/r/59195/diff/3-4/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59300/#review175144
---
Ship it!
Ship It!
- Anindya Sinha
On May 15, 2017, 11:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59290/#review175143
---
Ship it!
Ship It!
- Anindya Sinha
On May 15, 2017, 10:47
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59289/#review175133
---
Ship it!
Ship It!
- Anindya Sinha
On May 15, 2017, 10:46
Diff: https://reviews.apache.org/r/53842/diff/6/
Changes: https://reviews.apache.org/r/53842/diff/5-6/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
/hierarchical_allocator_tests.cpp
08180b9975869de328f0c095dd3cddf0c84fbecf
Diff: https://reviews.apache.org/r/53842/diff/5/
Changes: https://reviews.apache.org/r/53842/diff/4-5/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
://reviews.apache.org/r/53841/diff/5/
Changes: https://reviews.apache.org/r/53841/diff/4-5/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
,
Anindya Sinha
-4/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
ly, visit:
https://reviews.apache.org/r/53841/#review172540
-------
On May 16, 2017, 6:24 a.m., Anindya Sinha wrote:
>
> ---
> This is an automatically generated e-mail.
26b77f578f3235a8792c72d4575d607cdb2c7de7
src/tests/hierarchical_allocator_tests.cpp
08180b9975869de328f0c095dd3cddf0c84fbecf
Diff: https://reviews.apache.org/r/53841/diff/4/
Changes: https://reviews.apache.org/r/53841/diff/3-4/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
src/tests/hierarchical_allocator_tests.cpp
08180b9975869de328f0c095dd3cddf0c84fbecf
Diff: https://reviews.apache.org/r/53840/diff/5/
Changes: https://reviews.apache.org/r/53840/diff/4-5/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
ate an
> > independent test?
Created a separate test for `allocation_run_latency`.
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53840/#review174871
---
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/53840/#review172945
-------
On May 16, 2017, 6:23 a.m., Anindya Sinha wrote:
>
> ---
> This is an automatically generated e
/r/59195/diff/2-3/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
original version. Fixed it.
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59194/#review174924
-------
On May 1
/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
/tests/resources_tests.cpp 4cf320d802a749f1419ac5b9f63b6c73b0c974be
src/v1/resources.cpp cad069defb34d5ccc20a0e083eb88cb80f70e415
Diff: https://reviews.apache.org/r/59194/diff/3/
Changes: https://reviews.apache.org/r/59194/diff/2-3/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
/r/59195/diff/1-2/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
---------
On May 13, 2017, 4:50 a.m., Anindya Sinha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59194/
> -
/resources_tests.cpp 4cf320d802a749f1419ac5b9f63b6c73b0c974be
src/v1/resources.cpp cad069defb34d5ccc20a0e083eb88cb80f70e415
Diff: https://reviews.apache.org/r/59194/diff/2/
Changes: https://reviews.apache.org/r/59194/diff/1-2/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
/diff/2-3/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
; While it's true that no new supposedly destroyed volumes can be offered
> > out due to being removed from `slave.total` in the allocator, the allocator
> > is itself running and the framework's incorrect allocation can cause issue,
> > e.g., fairness, although t
/58486/diff/4/
Changes: https://reviews.apache.org/r/58486/diff/3-4/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
.
Thanks,
Anindya Sinha
/allocator.hpp 4ea722491f63f5ceda5a47228aafddc020f643b0
src/tests/hierarchical_allocator_tests.cpp
08180b9975869de328f0c095dd3cddf0c84fbecf
Diff: https://reviews.apache.org/r/59195/diff/1/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
.
Thanks,
Anindya Sinha
ceee2f4a5d38e0f4200f444769e058d2173de821
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
Diff: https://reviews.apache.org/r/57818/diff/7/
Changes: https://reviews.apache.org/r/57818/diff/6-7/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
33d5c0ea0182e09b3f3f30d20a33d46c23d81697
Diff: https://reviews.apache.org/r/57817/diff/7/
Changes: https://reviews.apache.org/r/57817/diff/6-7/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
of the slave.
src/tests/hierarchical_allocator_tests.cpp
Line 783 (original), 783 (patched)
<https://reviews.apache.org/r/59038/#comment247221>
nitpik: Similar comment as the previous one.
- Anindya Sinha
On May 6, 201
in the `SUBSCRIBE` call.
Diffs
-
src/sched/flags.hpp d19d20bad7dba48c8792783c73115affa1430cbe
src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644
Diff: https://reviews.apache.org/r/57816/diff/4/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
,
Anindya Sinha
hat we could re-use the `Call::Suppress` message
> > here instead of re-defining it. That way any changes to suppress would be
> > in sync.
>
> Anindya Sinha wrote:
> Currently, `Call::Suppress` is:
> ```
> message Suppress {
> optional stri
c7f0bec5c96f2f41344d4261d0696f9fe0421db7
Diff: https://reviews.apache.org/r/57815/diff/4/
Changes: https://reviews.apache.org/r/57815/diff/3-4/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
d42fd18fd5b36f5970e91e60b84e839aeedfc34b
Diff: https://reviews.apache.org/r/57964/diff/4/
Changes: https://reviews.apache.org/r/57964/diff/3-4/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
://reviews.apache.org/r/57963/diff/3-4/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
://reviews.apache.org/r/58487/diff/3/
Changes: https://reviews.apache.org/r/58487/diff/2-3/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
84bb6f302f6ff6f8a93fa891795df9ef7380629f
Diff: https://reviews.apache.org/r/58486/diff/3/
Changes: https://reviews.apache.org/r/58486/diff/2-3/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125
Diff: https://reviews.apache.org/r/58485/diff/3/
Changes: https://reviews.apache.org/r/58485/diff/2-3/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57535/#review173227
---
Ship it!
Ship It!
- Anindya Sinha
On April 25, 2017, 5:30
org/r/57935/#review173081
---
On April 27, 2017, 5:35 p.m., Anindya Sinha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&g
/master/allocator/sorter/drf/sorter.cpp
a8b35c4deac7a4f0725ccae517a8cbca5b8e1ee7
Diff: https://reviews.apache.org/r/57935/diff/2/
Changes: https://reviews.apache.org/r/57935/diff/1-2/
Testing
---
All tests passed.
Thanks,
Anindya Sinha
Description
---
Fix build failure introduced in 8990ebb.
Diffs
-
3rdparty/libprocess/src/process.cpp 6d4c5022b5eef271cd40d131aeef13362209eb3e
Diff: https://reviews.apache.org/r/58765/diff/1/
Testing
---
Tests passed.
Thanks,
Anindya Sinha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58676/#review172960
---
Ship it!
Ship It!
- Anindya Sinha
On April 25, 2017, 5:33
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57534/#review172739
---
Ship it!
Ship It!
- Anindya Sinha
On March 28, 2017, 8:24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57731/#review172738
---
Ship it!
Ship It!
- Anindya Sinha
On March 17, 2017, 3:55
1 - 100 of 734 matches
Mail list logo
