---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36668/#review92532
---
Ship it!
Ship It!
- Benjamin Hindman
On July 21, 2015, 11:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36669/#review92533
---
Ship it!
Ship It!
- Benjamin Hindman
On July 22, 2015, 12:46
regarding parameters of
`synchronized_wait`.
- Benjamin Hindman
On July 22, 2015, 4:07 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673
://reviews.apache.org/r/36673/
---
(Updated July 22, 2015, 4:07 a.m.)
Review request for mesos, Benjamin Hindman and Michael Park.
Bugs: MESOS-3119
https://issues.apache.org/jira/browse/MESOS-3119
Repository: mesos
140 - 141)
https://reviews.apache.org/r/36514/#comment146729
I'll kill spaces before committing.
CMakeLists.txt (line 27)
https://reviews.apache.org/r/36514/#comment146728
This needs to be in the previous review, I'll fix up for you before
committing.
- Benjamin Hindman
On July 21
/synchronized.hpp (line 230)
https://reviews.apache.org/r/36629/#comment146745
Awesome awesome awesome sauce.
- Benjamin Hindman
On July 21, 2015, 1:11 a.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply
of breadcrumbs so someone else doesn't come and try and re-add it.
3rdparty/libprocess/src/tests/ssl_tests.cpp (line 674)
https://reviews.apache.org/r/36656/#comment146740
We missed some! s/openssl/OpenSSL/ ;-) Here and throughout please.
- Benjamin Hindman
On July 21, 2015, 10:51 p.m., Joris Van
and then let's commit. Thanks!
- Benjamin Hindman
On July 21, 2015, 10:51 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36658
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36672/#review92536
---
Ship it!
Ship It!
- Benjamin Hindman
On July 22, 2015, 4:07 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36514/#review92520
---
Ship it!
Ship It!
- Benjamin Hindman
On July 21, 2015, 4:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36618/#review92546
---
Ship it!
Ship It!
- Benjamin Hindman
On July 20, 2015, 2:56 p.m
://reviews.apache.org/r/36574/#comment146658
We should really move this to src/common/protobuf_utils.cpp.
- Benjamin Hindman
On July 21, 2015, 4:45 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
= find.get();` below.
- Benjamin Hindman
On July 21, 2015, 4:45 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36575
and everywhere else in this review and other reviews, the expected
value comes first, and the actual value comes second. Again, since all this
code looks like this we can take care of it in a subsequent clean up review.
- Benjamin Hindman
On July 21, 2015, 4:46 p.m., Kapil Arya wrote
)
https://reviews.apache.org/r/36585/#comment146670
Need to flip expectation and actual.
- Benjamin Hindman
On July 21, 2015, 5:02 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
, to
'os::kill(subprocess.get().pid())' so that we don't have a process that
potentially runs forever.
- Benjamin Hindman
On July 14, 2015, 11:20 p.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit
https://issues.apache.org/jira/browse/MESOS-3079
Repository: mesos
Description
---
See summary.
Diffs
-
src/tests/isolator_tests.cpp b3832b4e2113c07e51dc3c12a62309878b021ca1
Diff: https://reviews.apache.org/r/36601/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
/36600/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
Thanks,
Benjamin Hindman
/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
://reviews.apache.org/r/36527/#comment146232
s/c1/cgroup1/
s/c2/cgroup2/
src/tests/cgroups_tests.cpp (line 402)
https://reviews.apache.org/r/36527/#comment146233
Let's just wrap the `find` lines below like you did in the test above.
- Benjamin Hindman
On July 19, 2015, 4:50 a.m
87f4d6a42a41bae8eec00aa5a9f4173906915a52
Diff: https://reviews.apache.org/r/36600/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
---
On July 19, 2015, 5:38 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36600
::executeCommand? Did you mean process::subprocess here?
src/master/main.cpp (line 208)
https://reviews.apache.org/r/36425/#comment146241
We've tried to consistently wrap things like IPs in single quotes in string
messages.
- Benjamin Hindman
On July 13, 2015, 9:35 p.m., Marco Massenzio wrote
281eed0094faead67dc7f84df6407686aae88b01
Diff: https://reviews.apache.org/r/36605/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
---
On July 19, 2015, 5:54 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36605/
---
(Updated
Diff: https://reviews.apache.org/r/36603/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36450/#review92218
---
Hasn't this been submitted?
- Benjamin Hindman
On July 17, 2015
https://issues.apache.org/jira/browse/MESOS-3079
Repository: mesos
Description
---
See summary.
Diffs
-
src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab
Diff: https://reviews.apache.org/r/36602/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
https://issues.apache.org/jira/browse/MESOS-3079
Repository: mesos
Description
---
See summary.
Diffs
-
src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a
Diff: https://reviews.apache.org/r/36604/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
-add_labels()-CopyFrom(createLabel(foo, bar));
src/tests/slave_tests.cpp (line 2126)
https://reviews.apache.org/r/36574/#comment146215
Once we have a 'createLabel' we can just do
`JSON::Protobuf(createLabel(foo, bar))` here.
- Benjamin Hindman
On July 17, 2015, 7:55 p.m., Kapil Arya
declarations/definitions.
src/tests/fetcher_tests.cpp (line 282)
https://reviews.apache.org/r/35755/#comment146212
We've tried to keep the name of the endpoint the same as the name of the
method (i.e, not 'uri_test' and 'index'). In this case, I recommend just 'test'.
- Benjamin Hindman
Address address = 2;
optional string path = 3;
repeated Parameter query = 4;
optional string fragment = 5;
}
- Benjamin Hindman
On July 13, 2015, 5:55 p.m., Ben Mahler wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23784/#review91212
---
Ship it!
Ship It!
- Benjamin Hindman
On July 8, 2015, 8:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23783/#review91214
---
Ship it!
Ship It!
- Benjamin Hindman
On July 9, 2015, 9:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36273/#review91220
---
Ship it!
Ship It!
- Benjamin Hindman
On July 9, 2015, 4:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36226/#review91223
---
Ship it!
Ship It!
- Benjamin Hindman
On July 8, 2015, 8:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36218/#review91219
---
Ship it!
Ship It!
- Benjamin Hindman
On July 8, 2015, 8:45 p.m
in the future. Thanks!
- Benjamin Hindman
On July 6, 2015, 1:43 p.m., Bernd Mathiske wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36197
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36267/#review90787
---
Ship it!
Ship It!
- Benjamin Hindman
On July 7, 2015, 5:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36277/#review90786
---
Ship it!
Ship It!
- Benjamin Hindman
On July 7, 2015, 8:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36246/#review90788
---
Ship it!
Ship It!
- Benjamin Hindman
On July 7, 2015, 8:04 p.m
.
src/slave/containerizer/docker.cpp (line 1551)
https://reviews.apache.org/r/36282/#comment143921
Newline above this please!
src/slave/containerizer/docker.cpp (line 1552)
https://reviews.apache.org/r/36282/#comment143923
s/the os/the current process/
- Benjamin Hindman
On July
On July 7, 2015, 10:08 p.m., Benjamin Hindman wrote:
Added comment and committed, thanks.
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36275/#review90792
)
https://reviews.apache.org/r/36275/#comment143919
I think a brief comment here and below on why we need to do a `bind` is
helpful.
- Benjamin Hindman
On July 7, 2015, 9:02 p.m., Joris Van Remoortere wrote
July 1, 2015, 12:33 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Artem Harutyunyan.
Bugs: MESOS-2966
https://issues.apache.org/jira/browse/MESOS-2966
Repository: mesos
Description
---
This virtualizes the 'get()' call on Socket
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/#review90546
---
Ship it!
Ship It!
- Benjamin Hindman
On July 6, 2015, 6:46 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review90545
---
Ship it!
Ship It!
- Benjamin Hindman
On July 6, 2015, 6:46 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35285/#review90547
---
Ship it!
Ship It!
- Benjamin Hindman
On July 6, 2015, 6:47 p.m
/3rdparty/stout/tests/strings_tests.cpp
9733b2ec5d68605b694210c66144b8d9f8c36467
Diff: https://reviews.apache.org/r/36189/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
On March 27, 2015, 9:17 a.m., Adam B wrote:
docs/slave-recovery.md, line 71
https://reviews.apache.org/r/32543/diff/2/?file=907123#file907123line71
(If the slave does not come back, each executorDriver shuts itself down
after $MESOS_RECOVERY_TIMEOUT.)
Important
this will be
helpful for folks that are using systemd with just 'posix' isolation.
- Benjamin Hindman
On March 27, 2015, 2:09 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
On July 6, 2015, 2:36 a.m., Benjamin Hindman wrote:
Ship It!
Thanks Joseph! It would be great to follow up this with JIRA + reviews that
eliminate the use of 'value' from a lot of our existing code that uses Path.
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36116/#review90425
---
Ship it!
Ship It!
- Benjamin Hindman
On July 6, 2015, 2:34 a.m
/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
necessary, and if it is, perhaps it needs a comment because it's not
obvious to me!
- Benjamin Hindman
On June 30, 2015, 11:24 p.m., Artem Harutyunyan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
., ROOT_, CGROUPS_,
etc.
- Benjamin Hindman
On July 2, 2015, 8:09 a.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32384
On July 2, 2015, 11:45 a.m., haosdent huang wrote:
configure.ac, line 1121
https://reviews.apache.org/r/32384/diff/2/?file=998167#file998167line1121
Seems other exist checks use AC_CHECK_TOOL, such as
```
AC_CHECK_TOOL([PROTOCOMPILER_TEST], [protoc], [],
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36074/#review90158
---
Ship it!
Ship It!
- Benjamin Hindman
On July 1, 2015, 2:26 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36061/#review90171
---
Ship it!
Ship It!
- Benjamin Hindman
On July 1, 2015, 12:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36078/#review90178
---
Ship it!
Ship It!
- Benjamin Hindman
On July 2, 2015, 12:22 a.m
://reviews.apache.org/r/31207/#comment142763
CHECK_NOTNULL
- Benjamin Hindman
On June 29, 2015, 10:21 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
okay to use
protocol-relative URLs here, thanks!
- Benjamin Hindman
On June 29, 2015, 8:38 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36018
On May 13, 2015, 10:25 p.m., Marco Massenzio wrote:
docs/reservation.md, line 71
https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line71
this seems to imply that in the Request, the `slave_id` is some part of
a form submission:
```
-d, --data data
://reviews.apache.org/r/35855/#comment142362
How about a comment that captures the backwards compatible semantics you're
accounting for here?
- Benjamin Hindman
On June 25, 2015, 1:11 a.m., Vinod Kone wrote:
---
This is an automatically generated
On June 25, 2015, 3:57 a.m., Isabel Jimenez wrote:
src/master/master.cpp, line 1654
https://reviews.apache.org/r/35855/diff/2/?file=991807#file991807line1654
could we have here consistent braces syntax with scheduler.cpp switch
case?
Perhaps for consistency, and safety, we just
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35858/#review89696
---
Ship it!
Ship It!
- Benjamin Hindman
On June 25, 2015, 12:31
by adding line
continuations, i.e., \.
- Benjamin Hindman
On June 28, 2015, 3:33 a.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35857/#review89693
---
Ship it!
Ship It!
- Benjamin Hindman
On June 25, 2015, 1:11 a.m
mutex and actually update all of the data structures
with the new socket. Or alternatively, could we swap the implementation of
a Socket and reuse the same file descriptor?
- Benjamin Hindman
On June 29, 2015, 1:22 a.m., Joris Van Remoortere wrote
.
} else if (...) { // Rule 3.
}
if (ssl) {
accept_SSL_callback(request);
} else {
...;
}
});
- Benjamin Hindman
On June 29, 2015, 1:22 a.m., Joris Van Remoortere wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35962/#review89599
---
Ship it!
Ship It!
- Benjamin Hindman
On June 27, 2015, 1:18 a.m
this 'endif' closes!
- Benjamin Hindman
On June 27, 2015, 1:18 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35889
before commit.
- Benjamin Hindman
On June 24, 2015, 7:57 p.m., Artem Harutyunyan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35843
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35908/#review89468
---
Ship it!
Ship It!
- Benjamin Hindman
On June 26, 2015, 3:55 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35854/#review89470
---
Ship it!
Ship It!
- Benjamin Hindman
On June 26, 2015, 3:55 a.m
://reviews.apache.org/r/35567/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35694/#review88661
---
On June 24, 2015, 10 p.m., Benjamin Hindman wrote:
---
This is an automatically
., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35567/
---
(Updated June 24, 2015, 10:01 p.m.)
Review
4f90d3dcd880b95f22ea13c56a61c7f981eea57d
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
6a26d93a9a68ab18b7c9b25039a96b663a73a309
Diff: https://reviews.apache.org/r/35694/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35622/#review88995
---
Ship it!
Ship It!
- Benjamin Hindman
On June 23, 2015, 3:57 p.m
/35694/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
/os_tests.cpp
62987e0df28f28816c59d7cbad89fa2af41ade04
Diff: https://reviews.apache.org/r/35565/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/#review88568
---
Ship it!
Ship It!
- Benjamin Hindman
On June 19, 2015, 2:31 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35638/#review88573
---
Ship it!
Ship It!
- Benjamin Hindman
On June 19, 2015, 11:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35129/#review88563
---
Ship it!
Ship It!
- Benjamin Hindman
On June 19, 2015, 6:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35635/#review88571
---
Ship it!
Ship It!
- Benjamin Hindman
On June 19, 2015, 12:39
---
On June 15, 2015, 5:52 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34943
://reviews.apache.org/r/35405/diff/
Testing
---
NOT YET
Thanks,
Benjamin Hindman
-mail. To reply, visit:
https://reviews.apache.org/r/34943/#review87996
---
On June 15, 2015, 5:52 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail
protocol buffer: +
masterInfo.error());
- Benjamin Hindman
On June 18, 2015, 2:27 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571
., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35566/
---
(Updated June 17, 2015, 2:28 p.m.)
Review request
this on your own now.
;-)
src/tests/fetcher_cache_tests.cpp (line 563)
https://reviews.apache.org/r/35438/#comment140845
EXPECT_SOME will print the error for you automagically, no need to do it
yourself! Please fix all spots in this review, thanks!
- Benjamin Hindman
On June 15, 2015, 2
80450185f60c5b273face490e0bb9e695b0cb984
Diff: https://reviews.apache.org/r/34943/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
On June 18, 2015, 11:09 a.m., Benjamin Hindman wrote:
src/master/detector.cpp, lines 468-469
https://reviews.apache.org/r/35571/diff/5/?file=986674#file986674line468
You should always know this is an error because you're in the 'else'
branch, so you can just do:
LOG
/
Testing
---
make check and generated doxygen documentation.
Thanks,
Benjamin Hindman
and generated doxygen documentation.
Thanks,
Benjamin Hindman
of ``` so that it renders
correctly when generated via doxygen. I'll make that minor modification and
commit this, thanks Alex!
- Benjamin Hindman
On June 18, 2015, 3:56 p.m., Alexander Rukletsov wrote:
---
This is an automatically
this return path
differs.
- Benjamin Hindman
On June 18, 2015, 5:05 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433
401 - 500 of 602 matches
Mail list logo
