Re: Review Request 47558: Added filter interface to authorizer.

: https://reviews.apache.org/r/47558/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 46613: Introduced filtering relevant actions and acls.

911a2271211249a41c4467f6754e9996f640bf38 src/authorizer/local/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b Diff: https://reviews.apache.org/r/46613/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47490: Moved `Task` to public protobufs.

037c4336276258d671d0b1bf66cdab50b5bf9fb8 src/messages/messages.cpp 41dcdb3996ce173fb0a56704053e4b4e03f6dd63 src/messages/messages.proto 7fd3a2a3540e57bd1ce02a15de54123bf22b074c Diff: https://reviews.apache.org/r/47490/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 47559: Added authorization based filtering to /state-summary.

linux systems Thanks, Joerg Schad

Re: Review Request 47558: Added filter interface to authorizer.

849e656c8b85304cccecc9d7b9d9116884132244 Diff: https://reviews.apache.org/r/47558/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 47558: WIP: Added filter interface to authorizer.

generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/#review134232 ------- On May 21, 2016, 3:47 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r

Re: Review Request 47558: WIP: Added filter interface to authorizer.

849e656c8b85304cccecc9d7b9d9116884132244 Diff: https://reviews.apache.org/r/47558/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

catch, added. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47069/#review134233 --- On May 21, 2016, 8:32

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

/tests/common/http_tests.cpp 300f7cc21239b7d8727f7f0f02963f1af0dc80d7 Diff: https://reviews.apache.org/r/47069/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 46613: Introduced filtering relevant actions and acls.

/authorizer.proto 32492a59ad95df3bb673ec42321518f86c11af59 src/authorizer/local/authorizer.cpp aa1a9d8e5c7fb86b6310015d93aeacb466a307ef Diff: https://reviews.apache.org/r/46613/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 46613: Introduced filtering relevant actions and acls.

include/mesos/authorizer/authorizer.proto 32492a59ad95df3bb673ec42321518f86c11af59 src/authorizer/local/authorizer.cpp aa1a9d8e5c7fb86b6310015d93aeacb466a307ef Diff: https://reviews.apache.org/r/46613/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 46613: Introduced filtering relevant actions and acls.

/mesos/authorizer/authorizer.proto 32492a59ad95df3bb673ec42321518f86c11af59 src/authorizer/local/authorizer.cpp aa1a9d8e5c7fb86b6310015d93aeacb466a307ef Diff: https://reviews.apache.org/r/46613/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47491: Added `environment` field to `Task` protobuf message.

check on a variety of Linux systems on internal CI. Thanks, Joerg Schad

Re: Review Request 47070: Added framework filtering to /state-summary endoint.

e59c11269670a7ed72b780913971b421ee17f33f src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 Diff: https://reviews.apache.org/r/47070/diff/ Testing --- make check (osx) Thanks, Joerg Schad

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

. Diffs (updated) - include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 Diff: https://reviews.apache.org/r/47069/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Review Request 47491: Added `environment` field to `Task` protobuf message.

. Diffs - include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 Diff: https://reviews.apache.org/r/47491/diff/ Testing --- make check OS-X. Thanks, Joerg Schad

Review Request 47490: Moved `Task` to public protobufs.

41dcdb3996ce173fb0a56704053e4b4e03f6dd63 src/messages/messages.proto 5593881229f57a11634357f1f85d697f11f4c827 Diff: https://reviews.apache.org/r/47490/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Review Request 47453: Corrected order of forwards declarations.

. Thanks, Joerg Schad

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

- src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 src/messages/messages.proto e0f1fca92d3ea8c29c095da31653c317873a934c Diff: https://reviews.apache.org/r/47069/diff/ Testing (updated) --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 47401: Corrected using order in authorizer.cpp.

://reviews.apache.org/r/47401/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 47401: Corrected include order in authorizer.cpp.

Rukletsov. Repository: mesos Description (updated) --- Mesos uses case-insensitive ordering of `using`. Diffs - src/authorizer/local/authorizer.cpp e95435327bb3b6f447e814b8657bce8084535346 Diff: https://reviews.apache.org/r/47401/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 47116: Added a missing blank.

g/r/47116/#comment196456> Could you maybe be a little more precise in the summary e.g., "Added a missing blank line to http.cpp". - Joerg Schad On May 9, 2016, 11:54 a.m., Jan Schlicht wrote: > > --- > This is an

Re: Review Request 47068: Added fine-grained filtering master flag.

feel are important to understand for users... - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47068/#review132245 -------

Review Request 47115: Fixed some issues in newbie-guide.md.

5375fb0598766c1c8bcba39ce552df1405f94a39 Diff: https://reviews.apache.org/r/47115/diff/ Testing --- viewed via docker website container. Thanks, Joerg Schad

Review Request 47071: Added framework/task filtering to /state and /tasks endpoint.

4985f24b70a00116caa4bd0335ea51e55d878d19 src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 Diff: https://reviews.apache.org/r/47071/diff/ Testing --- make check (osx) Thanks, Joerg Schad

Review Request 47070: Added framework filtering to /state-summary endoint.

4985f24b70a00116caa4bd0335ea51e55d878d19 src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 Diff: https://reviews.apache.org/r/47070/diff/ Testing --- make check (osx) Thanks, Joerg Schad

Review Request 47069: Added `user` field to `Task` protobuf message.

4f4711d54c471922f1a103310d4d360e41a99870 src/messages/messages.proto e0f1fca92d3ea8c29c095da31653c317873a934c Diff: https://reviews.apache.org/r/47069/diff/ Testing --- tested entire check. Thanks, Joerg Schad

Review Request 47068: Added fine-grained filtering master flag.

docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a src/master/flags.hpp e4cac1f8d688319c804e608b7229f458f779364a src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee Diff: https://reviews.apache.org/r/47068/diff/ Testing --- tested entire chain. Thanks, Joerg

Re: Review Request 46613: Introduced filtering relevant actions and acls.

check (OSX) Thanks, Joerg Schad

Re: Review Request 47019: Fixed include sections style.

that this is not a functional change. Thanks, Joerg Schad

Re: Review Request 47019: Split includes into sections by subfolders.

7fa1b892c1aff7453658c31e534dc272d1759b17 src/slave/containerizer/mesos/provisioner/appc/cache.hpp 7f888cc5f4347780993d41d73e44cbbfcfcea8fb Diff: https://reviews.apache.org/r/47019/diff/ Testing --- make check Note that this is not a functional change. Thanks, Joerg Schad

Review Request 47019: Fixed incorrect include sections.

7f888cc5f4347780993d41d73e44cbbfcfcea8fb Diff: https://reviews.apache.org/r/47019/diff/ Testing --- make check Note that this is not a functional change. Thanks, Joerg Schad

Re: Review Request 47008: Corrected formatting in framework development guide doc.

) <https://reviews.apache.org/r/47008/#comment195845> I am not sure we have an official 80 char limit, it is ok for me to change it to make it more readable but there is afaik no guideline for this... - Joerg Schad On May 5, 2016, 12:19 p.m., Alexander Rukletsov

Re: Review Request 46969: Added (Framework/Executor/Command}Info to authorizer object message.

32492a59ad95df3bb673ec42321518f86c11af59 src/authorizer/local/authorizer.cpp e59c11269670a7ed72b780913971b421ee17f33f Diff: https://reviews.apache.org/r/46969/diff/ Testing --- tested entire chain (see upcoming patches) Thanks, Joerg Schad

Re: Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.

/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Review Request 46969: Added (Framework/Executor/Command}Info to authorizer object message.

c744a16041c2466d3839a37fbee2bf86887bf4e1 Diff: https://reviews.apache.org/r/46969/diff/ Testing --- tested entire chain (see upcoming patches) Thanks, Joerg Schad

Re: Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.

: https://reviews.apache.org/r/46613/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 46901: Regenerated HTTP endpoint docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46901/#review131353 --- Ship it! Ship It! - Joerg Schad On May 2, 2016, 6:34 p.m

Re: Review Request 46900: Updated libprocess HTTP endpoint help strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46900/#review131352 --- Ship it! Ship It! - Joerg Schad On May 2, 2016, 6:33 p.m

Re: Review Request 46872: Updated quota.md and weights.md for set quota and update weight.

95253> see above Could you check whether this is an issue also with other endpoints? - Joerg Schad On May 1, 2016, 6:42 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 46735: Added support for Authorization information to HELP.

1cb0f4a1608e15e28d49793d162b62f326cb31df Diff: https://reviews.apache.org/r/46735/diff/ Testing --- testing with quota endpoint added (see next review). Thanks, Joerg Schad

Re: Review Request 46736: Added authorization description to quota endpoint help.

/ Testing --- make check (OSX) and re-generated endpoint documentation. Thanks, Joerg Schad

Re: Review Request 46735: Added support for Authorization information to HELP.

). Thanks, Joerg Schad

Re: Review Request 46735: Added support for Authorization information to HELP.

review). Thanks, Joerg Schad

Re: Review Request 46735: Added support for Authorization information to HELP.

/ Testing --- testing with quota endpoint added (see next review). Thanks, Joerg Schad

Re: Review Request 46796: Synced endpoint documentation by running generation script.

+ viewed endpoint docs Thanks, Joerg Schad

Re: Review Request 46796: Synced endpoint documentation by running generation script.

(updated) --- make check + viewed endpoint docs Thanks, Joerg Schad

Re: Review Request 46806: Fixed and illustrated process::initialize ordering.

(line 976) <https://reviews.apache.org/r/46806/#comment195023> 2 spaces before 'The' 3rdparty/libprocess/src/process.cpp (line 979) <https://reviews.apache.org/r/46806/#comment195025> the second 'the same group' feels a bit redundant, but not a real issue - Joerg Schad

Re: Review Request 46736: Added authorization description to quota endpoint help.

/ Testing --- make check (OSX) and re-generated endpoint documentation. Thanks, Joerg Schad

Re: Review Request 46796: Synced endpoint documentation by running generation script.

: https://reviews.apache.org/r/46796/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 46735: Added support for Authorization information to HELP.

). Thanks, Joerg Schad

Re: Review Request 46735: Added support for Authorization information to HELP.

). Thanks, Joerg Schad

Re: Review Request 46735: Added support for Authorization information to HELP.

review). Thanks, Joerg Schad

Re: Review Request 46736: Added authorization description to quota endpoint help.

/ Testing --- make check (OSX) and re-generated endpoint documentation. Thanks, Joerg Schad

Review Request 46736: Added authorization description to quota endpoint help.

-generated endpoint documentation. Thanks, Joerg Schad

Review Request 46735: Added support for Authorization information to HELP.

next review). Thanks, Joerg Schad

Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.

/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 46501: Updated authorization.md to reflect current changes.

501/#comment193734> Didn't you want to remove these parts here? - Joerg Schad On April 21, 2016, 5:33 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 46401: Corrected acls protobuf file in documentation and flag.

e6a239c15f52b381a83cc359d8b5a335a5fbd0af Diff: https://reviews.apache.org/r/46401/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 46084: Added needed forward-declaration for InternalServerError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46084/#review128401 --- Ship it! Ship It! - Joerg Schad On April 12, 2016, 1:06 p.m

Re: Review Request 46083: Used already forward-declared process::http::OK.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46083/#review128400 --- Ship it! Ship It! - Joerg Schad On April 12, 2016, 1:48 p.m

Re: Review Request 46085: Added authentication to agent's /monitor/statistics endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46085/#review128394 --- Ship it! Ship It! - Joerg Schad On April 12, 2016, 1:06 p.m

Re: Review Request 46085: Added authentication to agent's /monitor/statistics endpoint.

tps://reviews.apache.org/r/46085/#comment191826> As the .json endpoint is deprecated, I am not sure whether we need to tests those... But just my opinion - Joerg Schad On April 12, 2016, 1:06 p.m., Benjamin Bannier

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

g/r/45381/#comment191824> I believe you should have moved the deprecation comment as well. I added it back with https://reviews.apache.org/r/46091/ - Joerg Schad On April 6, 2016, 6:16 p.m., Jay Guo wrote: > > --- > This is a

Review Request 46091: Added deprecation comment to .json endpoint.

--- This comment was lost with https://reviews.apache.org/r/45381/. Diffs - src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 Diff: https://reviews.apache.org/r/46091/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 45922: Added agent authorization flags.

> On April 12, 2016, 9:31 a.m., Adam B wrote: > > src/slave/flags.cpp, lines 446-449 > > > > > > I'd rather have no example than a confusing/invalid example. We can add > > an example after we have at least one ACL

Re: Review Request 45922: Added agent authorization flags.

t? In that case maybe "Creating default '" << authorizerName << "' authorizer as acls flags are are set"? - Joerg Schad On April 8, 2016, 2:25 p.m., Jan Schlicht wrote: > > --- > This is

Re: Review Request 46034: Avoided globbing in commit message hook.

- Joerg Schad On April 11, 2016, 3:04 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45984/#review128130 --- Ship it! Ship It! - Joerg Schad On April 10, 2016, 6:41 a.m

Re: Review Request 46033: Removed request body from some error responses in quota handler.

hat already has quota"); src/master/quota_handler.cpp (line 267) <https://reviews.apache.org/r/46033/#comment191501> s/ already/already - Joerg Schad On April 11, 2016, 2:49 p.m., Alexander Rukletsov wrote: > > ---

Re: Review Request 45863: Updated error messages in weights handler.

> On April 7, 2016, 11:07 a.m., Joerg Schad wrote: > > src/master/weights_handler.cpp, line 90 > > <https://reviews.apache.org/r/45863/diff/1/?file=1329646#file1329646line90> > > > > Not yours: Above the request.body is included in the output. Feels > &

Re: Review Request 45922: Added agent authorization flags.

g/r/45922/#comment191140> Please also add this to https://github.com/apache/mesos/blob/master/docs/configuration.md - Joerg Schad On April 8, 2016, 8:52 a.m., Jan Schlicht wrote: > > --- > This is an automatically generated e

Re: Review Request 45495: Removed custom clone functions from Mesos [5/5].

3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 src/tests/containerizer/ns_tests.cpp cd668ebb3b9461bee00dc338c288e5df6eb8fe31 Diff: https://reviews.apache.org/r/45495/diff/ Testing --- sudo make check ../configure --with-network-isolator make check Thanks, Joerg Schad

Re: Review Request 45494: Removed clone option from subprocess [4/5].

8a3fe5526f480187441a8aee2c72636bec3e2b2d 3rdparty/libprocess/src/subprocess.cpp bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 Diff: https://reviews.apache.org/r/45494/diff/ Testing --- Tested entire chain see https://reviews.apache.org/r/45495/. Thanks, Joerg Schad

Re: Review Request 45493: Added cloneFlags option to subprocess [3/5].

/. Thanks, Joerg Schad

Re: Review Request 45493: Added namespace option to subprocess [3/5].

eviews.apache.org/r/45493/#review127182 --- On March 31, 2016, 10:22 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 45491: Refactored subprocess options [1/5].

ttps://reviews.apache.org/r/45491/#review127172 --- On April 7, 2016, 4:55 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 45491: Refactored subprocess options [1/5].

--- Tested entire chain see https://reviews.apache.org/r/45495/. Thanks, Joerg Schad

Review Request 45874: Fixed typo in subprocess.hpp.

Description --- Fixed typo in subprocess.hpp. Diffs - 3rdparty/libprocess/include/process/subprocess.hpp 8a3fe5526f480187441a8aee2c72636bec3e2b2d Diff: https://reviews.apache.org/r/45874/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 45492: Used ChildHooks in Mesos [2/5].

--- On March 31, 2016, 10:21 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45492/ > ---

Re: Review Request 45863: Updated error messages in weights handler.

Not yours, still: This feels a little off as it must only exist in the whitelist if there is a whitelist specified. - Joerg Schad On April 7, 2016, 10:50 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically genera

Re: Review Request 45767: Fixed commit message hook to iterate over the lines rather than words.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45767/#review127302 --- Ship it! Thanks! - Joerg Schad On April 5, 2016, 7:48 p.m

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

docker_build.sh (line 91) <https://reviews.apache.org/r/45668/#comment189908> Why is this needed here? - Joerg Schad On April 4, 2016, 6:54 a.m., Juan Larriba wrote: > > --- > This is an automatically gen

Re: Review Request 45582: Fixed Cmake build by adding CNI_SPEC to MESOS_PROTOBUF_SRC.

Thanks, Joerg Schad

Re: Review Request 45577: Updated a note about quota limit in the documentation.

(updated) --- None: Not a functional change. Thanks, Joerg Schad

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

tps://reviews.apache.org/r/45562/#comment189467> Not yours but why isn't that flag in the common master/agent section above? docs/configuration.md (line 361) <https://reviews.apache.org/r/45562/#comment189470> are *only* suitable for short-term? - Joerg Schad On March 31

Re: Review Request 45539: Added Hamburg Mesos User Group to community page.

Rukletsov. Repository: mesos Description (updated) --- See summary. Diffs - site/source/community/user-groups.html.md bf072cd47473dffb38c2f7a159d169db9287133a Diff: https://reviews.apache.org/r/45539/diff/ Testing (updated) --- None: not a functional change. Thanks, Joerg

Re: Review Request 45539: Added Hamburg Mesos User Group to community page.

Rukletsov. Repository: mesos Description --- Added Hamburg Mesos User Group to community page. Diffs - site/source/community/user-groups.html.md bf072cd47473dffb38c2f7a159d169db9287133a Diff: https://reviews.apache.org/r/45539/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 45495: Removed custom clone functions from Mesos [5/5].

3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 src/tests/containerizer/ns_tests.cpp cd668ebb3b9461bee00dc338c288e5df6eb8fe31 Diff: https://reviews.apache.org/r/45495/diff/ Testing --- sudo make check ../configure --with-network-isolator make check Thanks, Joerg Schad

Re: Review Request 45494: Removed clone option from subprocess [4/5].

8a3fe5526f480187441a8aee2c72636bec3e2b2d 3rdparty/libprocess/src/subprocess.cpp bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 Diff: https://reviews.apache.org/r/45494/diff/ Testing --- Tested entire chain see https://reviews.apache.org/r/45495/. Thanks, Joerg Schad

Re: Review Request 45493: Added namespace option to subprocess [3/5].

/libprocess/src/subprocess.cpp bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 Diff: https://reviews.apache.org/r/45493/diff/ Testing --- Tested entire chain see https://reviews.apache.org/r/45495/. Thanks, Joerg Schad

Re: Review Request 45492: Used ChildHooks in Mesos [2/5].

e062daa9fcfc776144b48325daa1f1284c5e59a4 src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 Diff: https://reviews.apache.org/r/45492/diff/ Testing --- Tested entire chain see https://reviews.apache.org/r/45495/. Thanks, Joerg Schad

Re: Review Request 45491: Refactored subprocess options [1/5].

--- Tested entire chain see https://reviews.apache.org/r/45495/. Thanks, Joerg Schad

Review Request 45477: Fixed typo in stout documentation.

Description --- Fixed typo in stout. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp a6e676766be527af48846a7ae6842c5b1465e501 Diff: https://reviews.apache.org/r/45477/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 45231: Removed the use of subprocess setup functions [2/7].

ttps://reviews.apache.org/r/45475/. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45231/#review126031 --- On March 28, 2

Review Request 45475: Fixed typos in isolator test comments.

--- Fixed typos in isolator test comments. Diffs - src/tests/containerizer/isolator_tests.cpp 4dde7292831dd6eab5da1c511a55a34e3bb5a96f Diff: https://reviews.apache.org/r/45475/diff/ Testing --- Thanks, Joerg Schad

Review Request 45438: Moved realm initialization from constructor to initializer list.

--- Moved realm initialization from constructor to initializer list. Diffs - src/files/files.cpp a8b27518bd50b951cc1a6dc077ac21eba07376cd Diff: https://reviews.apache.org/r/45438/diff/ Testing --- sudo make check Thanks, Joerg Schad

Re: Review Request 45423: Added note about preventing resource autodetecting to documentation.

/ee8a6b5a92e71d6bf704 Thanks, Joerg Schad

Re: Review Request 45424: Fixed a typo in "future.hpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45424/#review125857 --- Ship it! Ship It! - Joerg Schad On March 29, 2016, 11:49

Review Request 45423: Added note about preventing resource autodetection to documentation.

://reviews.apache.org/r/45423/diff/ Testing --- Viewed as gist: https://gist.github.com/joerg84/ee8a6b5a92e71d6bf704 Thanks, Joerg Schad

<    1   2   3   4   5   6   7   8   9   10   >