://issues.apache.org/jira/browse/MESOS-5692
Repository: mesos
Description
---
See summary.
Diffs
-
3rdparty/stout/include/stout/path.hpp
3d06ca29ce9d4d133c3ec014aa99a51aa5289bc9
Diff: https://reviews.apache.org/r/49581/diff/
Testing
---
`make check`
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49375/#review140580
---
Ship it!
Ship It!
- Michael Park
On July 1, 2016, 9:47 a.m
ole `R`,
and can only operate on resources to make them transition between `*` and `R`.
I don't see what we would be missing here.
- Michael Park
On July 1, 2016, 9:47 a.m., Neil Conway wrote:
>
> ---
> This is an automatic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49376/#review140579
---
Ship it!
Ship It!
- Michael Park
On July 3, 2016, 8:36 a.m
st below. In the test below, the last check is:
```
AWAIT_READY(offers);
ASSERT_EQ(1u, offers.get().size());
offer = offers.get()[0];
EXPECT_TRUE(Resources(offer.resources()).contains(unreserved));
```
- Michael Park
On July 1, 2016, 9:47 a.m., N
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49442/#review140557
---
Ship it!
Ship It!
- Michael Park
On June 30, 2016, 1 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49503/#review140556
---
Ship it!
Ship It!
- Michael Park
On July 1, 2016, 10:12 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49140/#review140555
---
Ship it!
Ship It!
- Michael Park
On June 26, 2016, 9:46 a.m
gs.hpp (lines 386 - 390)
<https://reviews.apache.org/r/49246/#comment205973>
```
return s.size() >= suffix.size() &&
std::equal(suffix.rbegin(), suffix.rend(), s.rbegin());
```
- Michael Park
On June 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49315/#review140168
---
Ship it!
Ship It!
- Michael Park
On June 28, 2016, 6:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49314/#review139772
---
Ship it!
Ship It!
- Michael Park
On June 28, 2016, 12:45
tps://reviews.apache.org/r/49140/#comment204744>
Let's use `s.front()` rather than `*s.begin()`.
3rdparty/stout/include/stout/strings.hpp (line 388)
<https://reviews.apache.org/r/49140/#comment204745>
Let's use `s.back()` rather than `*s.rbegin()`.
- Michael Park
On J
tps://reviews.apache.org/r/48320/#comment204743>
The trailing whitespaces are giving me issues in applying these patches.
Could you rebase and remove the trailing whitespaces, please?
- Michael Park
On June 15, 2016, 12:55 p.m., Tomasz Janiszewski
tps://reviews.apache.org/r/48728/#comment204742>
The trailing whitespaces are giving me issues in applying these patches.
Could you rebase and remove the trailing whitespaces, please? Here and below.
- Michael Park
On June 15, 2016, 12:49 p.m., Tomasz Janiszewski
)
<https://reviews.apache.org/r/49088/#comment204741>
Let's maintain the formatting here.
- Michael Park
On June 25, 2016, 12:33 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49062/#review139488
---
Ship it!
Ship It!
- Michael Park
On June 25, 2016, 12:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49061/#review139487
---
Ship it!
Ship It!
- Michael Park
On June 25, 2016, 12:31
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49060/#review139486
---
Ship it!
Ship It!
- Michael Park
On June 25, 2016, 12:35
> On June 26, 2016, 7:37 a.m., Michael Park wrote:
> > Could you specify that this only updates `http_tests.cpp`? There are other
> > places in the codebase where we explicitly construct a `std::function`
> > first, but we don't update all of those in this patch.
his fits in one line.
3rdparty/libprocess/src/tests/http_tests.cpp (lines 264 - 266)
<https://reviews.apache.org/r/46687/#comment204739>
Also fits in one line.
- Michael Park
On June 24, 2016, 8:57 a.m., haosdent huang wrote:
>
> --
gt;
```
// Dispatches a callable object returning `R` on a process.
```
3rdparty/libprocess/include/process/dispatch.hpp (line 126)
<https://reviews.apache.org/r/46686/#comment204732>
Same comment as the `void` case.
- Michael Park
On June 24, 2016, 8:56 a.m., haosdent huang wro
/blog/contributing_to_mesos_spring_cleaning.jpg
PRE-CREATION
site/source/blog/2016-06-20-contributing-to-mesos.md PRE-CREATION
Diff: https://reviews.apache.org/r/49003/diff/
Testing
---
Thanks,
Michael Park
/contributing_to_mesos_contributor_diversity.jpg
PRE-CREATION
site/source/assets/img/blog/contributing_to_mesos_spring_cleaning.jpg
PRE-CREATION
site/source/blog/2016-06-20-contributing-to-mesos.md PRE-CREATION
Diff: https://reviews.apache.org/r/49003/diff/
Testing
---
Thanks,
Michael Park
Diff: https://reviews.apache.org/r/48824/diff/
Testing
---
Thanks,
Michael Park
tion to support
`ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.
Diffs
-
src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc
Diff: https://reviews.apache.org/r/48038/diff/
Testing
---
`make check`
Thanks,
Michael Park
0df0d4ccd76379ede6492e595999711e5462f79b
docs/upgrades.md 0d2ad3dd6f089c164136fce6bf89e2a7ebb42dd3
Diff: https://reviews.apache.org/r/48824/diff/
Testing
---
Thanks,
Michael Park
/
Testing
---
Thanks,
Michael Park
tion to support
`ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.
Diffs (updated)
-
src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc
Diff: https://reviews.apache.org/r/48038/diff/
Testing
---
`make check`
Thanks,
Michael Park
23716e70e9acc92a0416
Diff: https://reviews.apache.org/r/48039/diff/
Testing
---
`make check`
Thanks,
Michael Park
`.
Diffs
-
include/mesos/authorizer/authorizer.hpp
02d0d043bd3bf3956709b7c90db8cc4eeb0525ad
include/mesos/authorizer/authorizer.proto
ffbe4d0f2900601427398e3b1fb8ee478343f034
Diff: https://reviews.apache.org/r/48037/diff/
Testing (updated)
---
`make check`
Thanks,
Michael Park
://reviews.apache.org/r/48040/diff/
Testing (updated)
---
`make check`
Thanks,
Michael Park
0e9acc92a0416
Diff: https://reviews.apache.org/r/48039/diff/
Testing (updated)
---
`make check`
Thanks,
Michael Park
`ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.
Diffs
-
src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc
Diff: https://reviews.apache.org/r/48038/diff/
Testing (updated)
---
`make check`
Thanks,
Michael Park
tion to support
`ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.
Diffs
-
src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc
Diff: https://reviews.apache.org/r/48038/diff/
Testing
---
Thanks,
Michael Park
er/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416
Diff: https://reviews.apache.org/r/48039/diff/
Testing
---
Thanks,
Michael Park
7eeb60ed08deb2d7139423716e70e9acc92a0416
Diff: https://reviews.apache.org/r/48039/diff/
Testing
---
Thanks,
Michael Park
://reviews.apache.org/r/48038/diff/
Testing
---
Thanks,
Michael Park
://reviews.apache.org/r/48040/diff/
Testing
---
Thanks,
Michael Park
`QuotaInfo`.
Diffs
-
include/mesos/authorizer/authorizer.hpp
02d0d043bd3bf3956709b7c90db8cc4eeb0525ad
include/mesos/authorizer/authorizer.proto
ffbe4d0f2900601427398e3b1fb8ee478343f034
Diff: https://reviews.apache.org/r/48037/diff/
Testing
---
Thanks,
Michael Park
Rukletsov, Joris Van Remoortere, Vinod
Kone, and Zhitao Li.
Repository: mesos
Description
---
See summary.
Diffs
-
src/tests/authorization_tests.cpp c133f522743bc255c5d891dd8f5f04d5f209bba2
Diff: https://reviews.apache.org/r/48040/diff/
Testing
---
Thanks,
Michael Park
/48039/diff/
Testing
---
Thanks,
Michael Park
Rukletsov, Joris Van Remoortere, Vinod
Kone, and Zhitao Li.
Repository: mesos
Description
---
See summary.
Diffs
-
src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc
Diff: https://reviews.apache.org/r/48038/diff/
Testing
---
Thanks,
Michael Park
Rukletsov, Joris Van Remoortere, Vinod
Kone, and Zhitao Li.
Repository: mesos
Description (updated)
---
See summary.
Diffs
-
src/tests/authorization_tests.cpp c133f522743bc255c5d891dd8f5f04d5f209bba2
Diff: https://reviews.apache.org/r/48040/diff/
Testing
---
Thanks,
Michael
72c60ef74ce57119a97cf8305182340a13c58c42
src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416
Diff: https://reviews.apache.org/r/48039/diff/
Testing
---
Thanks,
Michael Park
Rukletsov, Joris Van Remoortere, Vinod
Kone, and Zhitao Li.
Repository: mesos
Description (updated)
---
See summary.
Diffs
-
src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc
Diff: https://reviews.apache.org/r/48038/diff/
Testing
---
Thanks,
Michael
include/mesos/authorizer/authorizer.proto
ffbe4d0f2900601427398e3b1fb8ee478343f034
Diff: https://reviews.apache.org/r/48037/diff/
Testing
---
Thanks,
Michael Park
02d0d043bd3bf3956709b7c90db8cc4eeb0525ad
include/mesos/authorizer/authorizer.proto
ffbe4d0f2900601427398e3b1fb8ee478343f034
Diff: https://reviews.apache.org/r/48037/diff/
Testing
---
Thanks,
Michael Park
ck, thus we do not claim to set the
`value` field at the public API level.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review135510
-------
On June 16, 2016, 9:45 p.m., Michael
----------
On June 16, 2016, 9:45 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> -
/r/48040/diff/
Testing
---
Thanks,
Michael Park
7eeb60ed08deb2d7139423716e70e9acc92a0416
Diff: https://reviews.apache.org/r/48039/diff/
Testing
---
Thanks,
Michael Park
://reviews.apache.org/r/48038/diff/
Testing
---
Thanks,
Michael Park
://reviews.apache.org/r/48038/diff/
Testing
---
Thanks,
Michael Park
://reviews.apache.org/r/48038/diff/
Testing
---
Thanks,
Michael Park
----
On June 16, 2016, 5:59 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48038/
> ---
r.hpp
02d0d043bd3bf3956709b7c90db8cc4eeb0525ad
include/mesos/authorizer/authorizer.proto
ffbe4d0f2900601427398e3b1fb8ee478343f034
Diff: https://reviews.apache.org/r/48037/diff/
Testing
---
Thanks,
Michael Park
r.hpp
02d0d043bd3bf3956709b7c90db8cc4eeb0525ad
include/mesos/authorizer/authorizer.proto
ffbe4d0f2900601427398e3b1fb8ee478343f034
Diff: https://reviews.apache.org/r/48037/diff/
Testing
---
Thanks,
Michael Park
eviews.apache.org/r/48038/#review135548
---
On June 16, 2016, 5:59 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48038/
> ---
y, visit:
https://reviews.apache.org/r/48038/#review135548
-------
On June 16, 2016, 5:59 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail.
Diff: https://reviews.apache.org/r/48040/diff/
Testing
---
Thanks,
Michael Park
/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416
Diff: https://reviews.apache.org/r/48039/diff/
Testing
---
Thanks,
Michael Park
3c0fe048635abb3a9bea8399050e2ca2d823262d
Diff: https://reviews.apache.org/r/48038/diff/
Testing
---
Thanks,
Michael Park
include/mesos/authorizer/authorizer.proto
ffbe4d0f2900601427398e3b1fb8ee478343f034
Diff: https://reviews.apache.org/r/48037/diff/
Testing
---
Thanks,
Michael Park
I'll revisit this
when I come back next week.
- Michael Park
On June 5, 2016, 8:34 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
uot; refers to the null character
`'\0'` (a.k.a `NUL`), not `NULL`.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48255/#review136203
------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48256/#review136212
---
Ship it!
Ship It!
- Michael Park
On June 5, 2016, 8:25 a.m
30a9674686221d25132368e6c10664daa9cd6dc0
include/mesos/zookeeper/zookeeper.hpp
3b689578ba6efc9547197d5487f8dd15880882f8
Diff: https://reviews.apache.org/r/48253/diff/
Testing (updated)
---
Manual eye test + `make check`
Thanks,
Michael Park
/libprocess/src/tests/shared_tests.cpp
8997c38883ab8941ea687dedb69c7019da295b0d
3rdparty/libprocess/src/time.cpp a6c3f3de69e056544406f4416c2d0aea06adc34d
Diff: https://reviews.apache.org/r/48255/diff/
Testing
---
Manual eye test + `make check`
Thanks,
Michael Park
://reviews.apache.org/r/48254/diff/
Testing
---
Manual eye test + `make check`
Thanks,
Michael Park
/zookeeper.hpp
3b689578ba6efc9547197d5487f8dd15880882f8
Diff: https://reviews.apache.org/r/48253/diff/
Testing
---
`make check`
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review136187
---
Ship it!
Ship It!
- Michael Park
On June 4, 2016, 12:59 p.m
> On June 4, 2016, 7:14 p.m., Michael Park wrote:
> > Could you please split this up into `clang-tidy` and `sed`?
> >
> > This only touches mesos, not libprocess and stout. Is that correct?
> >
> > Are https://reviews.apache.org/r/45482/ and
> > https://
> On June 4, 2016, 7:14 p.m., Michael Park wrote:
> > Could you please split this up into `clang-tidy` and `sed`?
> >
> > This only touches mesos, not libprocess and stout. Is that correct?
> >
> > Are https://reviews.apache.org/r/45482/ and
> > https://
> On June 4, 2016, 7:14 p.m., Michael Park wrote:
> > Could you please split this up into `clang-tidy` and `sed`?
> >
> > This only touches mesos, not libprocess and stout. Is that correct?
> >
> > Are https://reviews.apache.org/r/45482/ and
> > https://
only touches mesos, not libprocess and stout. Is that correct?
Are https://reviews.apache.org/r/45482/ and https://reviews.apache.org/r/45480/
meant to be discarded now?
- Michael Park
On June 4, 2016, 12:59 p.m., Tomasz Janiszewski wrote
ion(
[=](ProcessBase*) {
promise->set(f());
}));
internal::dispatch(pid, f_);
return promise->future();
}
```
- Michael Park
On April 26, 2016, 9:21 a.m., haosdent huang wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48219/#review136100
---
Ship it!
Ship It!
- Michael Park
On June 3, 2016, 7:35 p.m
ent200791>
```c++
- Future > offers;
+ Future> offers;
```
src/tests/master_authorization_tests.cpp (line 1573)
<https://reviews.apache.org/r/48054/#comment200792>
```c++
-Try parse =
JSON::parse(response.get().body);
+Try parse =
JSON::parse
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48053/#review135607
---
Ship it!
Ship It!
- Michael Park
On May 31, 2016, 1:06 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47977/#review135602
---
Ship it!
Ship It!
- Michael Park
On May 31, 2016, 6:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47559/#review135599
---
Ship it!
Ship It!
- Michael Park
On May 31, 2016, 6:20 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47704/#review135600
---
Ship it!
Ship It!
- Michael Park
On May 31, 2016, 6:20 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47736/#review135601
---
Ship it!
Ship It!
- Michael Park
On May 31, 2016, 6:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/#review135598
---
Ship it!
Ship It!
- Michael Park
On May 31, 2016, 6:19 a.m
: mesos
Description
---
See summary.
Diffs
-
src/authorizer/local/authorizer.cpp 547bbdd6c3605eadd23d2d2717a3fd362a616de5
Diff: https://reviews.apache.org/r/48052/diff/
Testing
---
Thanks,
Michael Park
---
Thanks,
Michael Park
/48037/diff/
Testing
---
Thanks,
Michael Park
, and Zhitao Li.
Repository: mesos
Description
---
See summary.
Diffs
-
src/authorizer/local/authorizer.cpp 547bbdd6c3605eadd23d2d2717a3fd362a616de5
Diff: https://reviews.apache.org/r/48038/diff/
Testing
---
Thanks,
Michael Park
, and Zhitao Li.
Repository: mesos
Description
---
See summary.
Diffs
-
src/tests/authorization_tests.cpp 54bfb46a807677f4a4a2bb88dcb78a358cf5121a
Diff: https://reviews.apache.org/r/48040/diff/
Testing
---
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/#review134940
---
Ship it!
Ship It!
- Michael Park
On May 26, 2016, 4:43 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46613/#review134939
---
Ship it!
Ship It!
- Michael Park
On May 26, 2016, 6:46 a.m
--
>
> (Updated May 24, 2016, 9:44 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
>
>
> Bugs: MESOS-5169
> https://issues.apache.org/jira/browse/MESOS-5169
>
>
> Repository: mesos
>
>
> De
`s/& subject/& subject/`
- Michael Park
On May 25, 2016, 5:19 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
/include/stout/windows/os.hpp
71a8c61335e2bce340447e94e855a6bd79c49dec
Diff: https://reviews.apache.org/r/46418/diff/
Testing
---
`make check`
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47671/#review134459
---
Ship it!
Ship It!
- Michael Park
On May 22, 2016, 6:59 a.m
o this now. `matches` and `allows` doesn't even use internal
state and could have been declared `static`. Shouldn't be hard to pull them out.
- Michael Park
On May 22, 2016, 9:25 p.m., Joerg Schad wrote:
>
> ---
>
tps://reviews.apache.org/r/46613/#comment199067>
The `WITH_INFO` doesn't really seem to tell me anything. What's the
intended meaning?
include/mesos/authorizer/authorizer.proto (line 70)
<https://reviews.apache.org/r/46613/#comment199069>
Should this be `VIEW_TASKS`?
tps://reviews.apache.org/r/47069/#comment198941>
This has inconsistent behavior with `void json(JSON::ObjectWriter* writer,
const Task& task);`. I think we want to the behavior in `json` and leave `user`
out if it's not set?
- Michael Park
On May 21, 2016, 8:32 a.m., Jo
==(const Task&,
const Task&);`, and exposing the `user` field in `/state`, etc?
- Michael Park
On May 17, 2016, 9:28 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
tps://reviews.apache.org/r/46613/#comment196241>
Please update to use `foreach`. I've updated the other instances.
src/authorizer/local/authorizer.cpp (line 229)
<https://reviews.apache.org/r/46613/#comment196242>
Please update to use `foreach`. I've updated the other instances.
901 - 1000 of 2049 matches
Mail list logo
