Re: Review Request 71986: Removed redundant calls to `c_str` flagged by mesos-tidy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71986/#review219234 --- Ship it! Ship It! - Till Toenshoff On Jan. 13, 2020, 9:49

Re: Review Request 71985: Properly initialized dummy variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71985/#review219233 --- Ship it! Ship It! - Till Toenshoff On Jan. 13, 2020, 9:48

Re: Review Request 71934: Bumped site's rack to rack-1.16.12.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71934/#review219130 --- Ship it! Ship It! - Till Toenshoff On Dec. 20, 2019, 11:51

Re: Review Request 71663: SSL Wrapper: Windows: Made sure windows.hpp is included before OpenSSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71663/#review218779 --- Ship it! Ship It! - Till Toenshoff On Oct. 23, 2019, 7:37

Re: Review Request 71535: Fixed certificate write functions for windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71535/ --- (Updated Sept. 24, 2019, 12:41 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 71535: Fixed certificate write functions for windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71535/ --- (Updated Sept. 24, 2019, 12:40 a.m.) Review request for mesos, Greg Mann and

Review Request 71535: Fixed certificate write functions for windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71535/ --- Review request for mesos, Greg Mann and Joseph Wu. Repository: mesos

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217884 --- Ship it! Ship It! - Till Toenshoff On Sept. 19, 2019, 2:35

Re: Review Request 71478: Windows: Moved definition out of inline function call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71478/#review217850 --- Ship it! Ship It! - Till Toenshoff On Sept. 12, 2019, 7:35

Re: Review Request 71509: Windows: Fixed AllocationRoleEnvironmentVariable tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71509/#review217836 --- Ship it! Ship It! - Till Toenshoff On Sept. 18, 2019, 10:57

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217787 --- 3rdparty/libprocess/src/openssl.cpp Lines 545-547 (patched)

Re: Review Request 71430: Included new Python CLI in distribution tarball.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71430/#review217789 --- Ship it! Ship It! - Till Toenshoff On Sept. 4, 2019, 7:48

Re: Review Request 71496: Removed an outdated reference to the 'libprocess' hostname validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71496/#review217788 --- Ship it! Ship It! - Till Toenshoff On Sept. 17, 2019, 12:35

Re: Review Request 71395: Implemented snapshot bot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71395/#review217588 --- support/mesos-snapshot.sh Lines 23 (patched)

Re: Review Request 71395: Implemented snapshot bot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71395/#review217587 --- Ship it! Ship It! - Till Toenshoff On Aug. 28, 2019, 4:41

Re: Review Request 71393: Skiped GPG signing during `maven-install` in Makefile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71393/#review217585 --- Ship it! Ship It! - Till Toenshoff On Aug. 28, 2019, 4:40

Re: Review Request 71394: Skipped GPG signing for snapshot builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71394/#review217586 --- Ship it! Ship It! - Till Toenshoff On Aug. 28, 2019, 4:40

Re: Review Request 71392: Improved snapshot script to deduce the Mesos version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71392/#review217582 --- support/snapshot.sh Line 36 (original), 34 (patched)

Re: Review Request 71390: Fixed the snapshot script to be non-interactive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71390/#review217581 --- Ship it! Ship It! - Till Toenshoff On Aug. 28, 2019, 4:38

Re: Review Request 71241: Added a `distcheck` target to the cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71241/#review217580 --- Ship it! Ship It! - Till Toenshoff On Sept. 3, 2019, 2:51

Re: Review Request 71240: Added a `dist` target to the cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71240/#review217579 --- cmake/dist.sh Lines 30 (patched)

Re: Review Request 71240: Added a `dist` target to the cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71240/#review217578 --- cmake/dist.sh Lines 37 (patched)

Re: Review Request 71240: Added a `dist` target to the cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71240/#review217577 --- Ship it! Ship It! - Till Toenshoff On Sept. 3, 2019, 1:52

Re: Review Request 71207: Revert "Updated cpplint.py to be less verbose when there is no linting issue."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71207/#review217441 --- Ship it! - Till Toenshoff On Aug. 20, 2019, 11:49 a.m.,

Re: Review Request 71209: Enabled a number of additional pre-commit checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review217443 --- Ship it! I'ld love to see the commit description to tell us

Re: Review Request 71300: Removed mesos-style transition script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71300/#review217438 --- Ship it! - Till Toenshoff On Aug. 26, 2019, 4:40 p.m.,

Re: Review Request 71208: Revert "Updated cpplint to be compatible with Python 3."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71208/#review217442 --- Ship it! - Till Toenshoff On July 30, 2019, 9:01 p.m.,

Re: Review Request 71206: Removed old mesos-style and references.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71206/#review217444 --- Ship it! - Till Toenshoff On Aug. 20, 2019, 11:49 a.m.,

Re: Review Request 71205: Switched commit hooks to pre-commit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71205/#review217439 --- Fix it, then Ship it! When running the script, I noticed this

Re: Review Request 71299: Added separate script to install developer setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/#review217434 --- Ship it! Excellent structure - pretty much a move code only

Re: Review Request 71204: Added gitlint config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71204/#review217433 --- Ship it! - Till Toenshoff On Aug. 14, 2019, 11:24 a.m.,

Re: Review Request 71203: Added check script to check for license headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71203/#review217432 --- Ship it! support/check-license.py Lines 25-26 (patched)

Re: Review Request 70096: Moved cpplint configuration into dedicated file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70096/#review217431 --- Ship it! bootstrap Lines 84 (patched)

Re: Review Request 71338: Moved OpenSSL-related ifdef to a central location.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71338/#review217353 --- Fix it, then Ship it! Thanks Benno for fixing my ugly patch.

Re: Review Request 71336: Fixed deprecation warning when building against OpenSSL 1.1.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71336/ --- (Updated Aug. 21, 2019, 11:45 a.m.) Review request for mesos, Benno Evers and

Review Request 71336: Fixed deprecation warning when building against OpenSSL 1.1.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71336/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Repository: mesos

Re: Review Request 71232: Renamed cmake parameter for parallel test execution.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71232/#review217050 --- Fix it, then Ship it! cmake/MesosConfigure.cmake Line 49

Review Request 71138: Updated configure.ac to correct openssl/libevent setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71138/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 71123: Made openssl configuration in 'configure.ac' occur earlier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71123/#review216765 --- Ship it! Ship It! - Till Toenshoff On July 19, 2019, 10:49

Re: Review Request 70991: Added ability to pass custom SSL context to `Socket::connect()`.

> On July 4, 2019, 11:53 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Line 806 (original), 807 (patched) > > > > > > s/libprocess/legacy/ Actually, please make sure you dont end up with

Re: Review Request 70991: Added ability to pass custom SSL context to `Socket::connect()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70991/#review216396 --- Fix it, then Ship it! Awesome work Benno - thanks! Can't wait

Re: Review Request 70991: Updated `Socket::connect()` API according to maintainer feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70991/#review216383 --- 3rdparty/libprocess/src/poll_socket.hpp Lines 16-18 (patched)

Re: Review Request 70921: Added OpenSSL-related changes to CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70921/#review216382 --- Fix it, then Ship it! Ship It! CHANGELOG Lines 9 (patched)

Re: Review Request 70993: Added warnings about known problems with libevent epoll backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70993/#review216381 --- Ship it! Ship It! - Till Toenshoff On July 2, 2019, 5:53

Re: Review Request 70933: Moved an inline duration for slow DNS logging into a const variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70933/#review216380 --- Ship it! Ship It! - Till Toenshoff On June 24, 2019, 12:22

Re: Review Request 70797: Added unit tests for hostname validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70797/#review216379 --- Ship it! Ship It! - Till Toenshoff On July 2, 2019, 5:53

Re: Review Request 70797: Added unit tests for hostname validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70797/#review216378 --- 3rdparty/libprocess/src/tests/ssl_tests.cpp Line 318 (original),

Re: Review Request 70992: Recorded Socket API change in CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70992/#review216377 --- Ship it! Ship It! - Till Toenshoff On July 4, 2019, 2:28

Re: Review Request 70795: Updated SSL docs to include new libprocess flag.

> On June 21, 2019, 1:34 a.m., Till Toenshoff wrote: > > docs/ssl.md > > Lines 194 (patched) > > > > > > I wonder if we should already start a deprecation of the `libprocess` > > scheme - that would be: > > -

Re: Review Request 70948: Attempting to get Jenkins pipeline build expiry fixed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70948/ --- (Updated June 26, 2019, 12:16 a.m.) Review request for mesos, Benjamin

Review Request 70948: Attempting to get Jenkins pipeline build expiry fixed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70948/ --- Review request for mesos, Benjamin Bannier, Gilbert Song, and Vinod Kone.

Re: Review Request 70795: Updated SSL docs to include new libprocess flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70795/#review216020 --- Fix it, then Ship it! Great! Please don't forget to update

Re: Review Request 70749: Introduced optional new scheme for hostname validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70749/#review216017 --- 3rdparty/libprocess/src/openssl.cpp Lines 147 (patched)

Re: Review Request 70796: Fixed Mesos unit tests after Address API change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70796/#review216016 --- Ship it! - Till Toenshoff On June 19, 2019, 2:44 p.m., Benno

Re: Review Request 70885: Renamed 'libprocess::network::Address::hostname()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70885/#review216015 --- Ship it! Thanks a bunch - much better signal for a pricy

Re: Review Request 70883: Added optional 'peer_hostname' argument to Socket::connect().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70883/#review216013 --- Ship it! We have discussed this patch a bit out of band and

Re: Review Request 70810: Updated SSL docs with suggested runtime configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70810/#review216011 --- Ship it! Awesome - thanks! - Till Toenshoff On June 20,

Re: Review Request 70748: Changed semantics of some libprocess TLS flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/#review216009 --- Fix it, then Ship it! Great - thanks so much!

Re: Review Request 70747: Updated some flag description for libprocess SSL flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70747/#review215968 --- Ship it! Ship It! - Till Toenshoff On May 29, 2019, 1:50

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/#review215878 --- 3rdparty/libprocess/src/openssl.cpp Line 738 (original), 745

Re: Review Request 70811: Fixed compilation error on Mac OS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215797 --- Ship it! Ship It! - Till Toenshoff On June 7, 2019, 5:21

Re: Review Request 70811: Fixed compilation error on Mac OS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215793 --- src/slave/containerizer/mesos/launch.cpp Line 508 (original),

Review Request 70829: Added logrotate option to force Jenkins into removing older artefacts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70829/ --- Review request for mesos, Benjamin Bannier and Vinod Kone. Repository: mesos

Re: Review Request 70562: Add LIBPROCESS_SSL_ENABLE_TLS_V1_3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70562/#review214949 --- Ship it! Thanks so much Stephane. Looks slick -- Benno will go

Re: Review Request 70563: document LIBPROCESS_SSL_ENABLE_TLS_V1_3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70563/#review214948 --- Ship it! Ship It! - Till Toenshoff On April 29, 2019, 6:43

Re: Review Request 70526: Rearranged 'Downloads' page and updated bintray URL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70526/#review214854 --- Ship it! As discussed out of band, we will try to preserve all

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70489/#review214707 --- docs/container-image.md Lines 188-190 (patched)

Re: Review Request 70323: Bumped nokogiri and rack site dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70323/#review214115 --- Ship it! Ship It! - Till Toenshoff On March 27, 2019, 4:21

Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.

> On March 19, 2019, 11:07 p.m., Joseph Wu wrote: > > 3rdparty/cmake/FindZOOKEEPER.cmake > > Lines 50 (patched) > > > > > > I wonder if it is worth adding a note here, restating bits of the blurb > > here: > >

Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70233/ --- (Updated March 19, 2019, 12:11 a.m.) Review request for mesos, Benjamin

Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70233/ --- (Updated March 19, 2019, 12:03 a.m.) Review request for mesos, Benjamin

Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70233/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-9662

Re: Review Request 70131: Added a comment around recovery for `ContainerLogger`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70131/#review213494 --- Ship it! Ship It! - Till Toenshoff On March 5, 2019, 10:42

Re: Review Request 70047: Updated build specific artefact generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70047/ --- (Updated March 6, 2019, 1:12 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70049: Assured a set USER within RPM build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70049/ --- (Updated March 6, 2019, 1:01 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65116: Getting Started using the Mesos Binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65116/#review213447 --- Ship it! Thanks Senthil! Fixing below while landing

Re: Review Request 70047: Updated build specific artefact generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70047/ --- (Updated March 5, 2019, 6:46 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70089: Removed non-ascii source code characters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70089/#review213369 --- Ship it! Thanks - these keep creeping in. - Till Toenshoff

Re: Review Request 70049: Assured a set USER within RPM build.

> On Feb. 28, 2019, 8:52 p.m., Benjamin Bannier wrote: > > support/packaging/centos/build_rpm.sh > > Lines 29 (patched) > > > > > > What about only setting this if unset? > > > > export

Re: Review Request 70047: Updated build specific artefact generation.

> On Feb. 26, 2019, 8:22 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 630-637 (original), 663-667 (patched) > > > > > > I don't think the CMake build needs to follow the autotools one here.

Re: Review Request 70047: Updated build specific artefact generation.

> On March 1, 2019, 12:02 a.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Lines 630-637 (original), 663-667 (patched) > > > > > > The idea (at least on the autotools side which currently

Re: Review Request 70047: Updated build specific artefact generation.

> On Feb. 26, 2019, 8:22 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 630-637 (original), 663-667 (patched) > > > > > > I don't think the CMake build needs to follow the autotools one here.

Re: Review Request 70047: Updated build specific artefact generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70047/ --- (Updated Feb. 26, 2019, 11:05 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70047: Updated build specific artefact generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70047/ --- (Updated Feb. 26, 2019, 2:20 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70047: Updated build specific artefact generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70047/ --- (Updated Feb. 26, 2019, 2:18 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70055: Output Review Request URL in Reviewbot output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70055/#review213194 --- Ship it! Ship It! - Till Toenshoff On Feb. 25, 2019, 11:44

Re: Review Request 70047: Updated build specific artefact generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70047/ --- (Updated Feb. 25, 2019, 2:35 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70049: Assured a set USER within RPM build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70049/ --- (Updated Feb. 25, 2019, 2:31 a.m.) Review request for mesos, Benjamin Bannier

Review Request 70049: Assured a set USER within RPM build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70049/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-9605

Review Request 70047: Updated build specific artefact generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70047/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-9605

Re: Review Request 70045: Skipped tests when verifying `master` as part of review verification.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70045/#review213126 --- Ship it! Ship It! - Till Toenshoff On Feb. 24, 2019, 10:03

Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/#review212914 --- Fix it, then Ship it! support/verify-reviews.py Lines 182-186

Re: Review Request 69999: Fixed some lint issues in verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review212910 --- Ship it! Ship It! - Till Toenshoff On Feb. 17, 2019, 5:48

Re: Review Request 69998: Reformated verify-reviews.py with yapf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69998/#review212909 --- Ship it! Ship It! - Till Toenshoff On Feb. 17, 2019, 5:48

Re: Review Request 69986: Added a log line for simplified debugging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69986/#review212862 --- Ship it! Ship It! - Till Toenshoff On Feb. 14, 2019, 3:24

Review Request 69931: Empty test commit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69931/ --- Review request for mesos. Repository: mesos Description --- Empty test

Re: Review Request 69697: Reverted cleanup step of `verify-reviews.py`.

> On Jan. 16, 2019, 5:04 p.m., Vinod Kone wrote: > > support/verify-reviews.py > > Line 174 (original), 171 (patched) > > > > > > Do you guys understand why this was failing in the Azure CI in the > > first place?

Re: Review Request 69817: Refactored 'support/verify-reviews.py' to be closer to commit 7412179.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69817/#review212668 --- Ship it! Ship It! - Till Toenshoff On Jan. 23, 2019, 11:47

Re: Review Request 69839: Fixed scheduler library on multiple SUBSCRIBE requests per connection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69839/ --- (Updated Jan. 30, 2019, 4:34 a.m.) Review request for mesos, Alexander

Re: Review Request 69839: Fixed scheduler library on multiple SUBSCRIBE requests per connection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69839/ --- (Updated Jan. 25, 2019, 3:41 p.m.) Review request for mesos, Alexander

  1   2   3   >