Re: Review Request 51493: Add the query parameter in createRequest.

2016-09-11 Thread Yongqiao Wang
sit: https://reviews.apache.org/r/51493/#review148428 --- On 八月 29, 2016, 10:47 p.m., Yongqiao Wang wrote: > > --- > This is an automatically generated

Review Request 51520: Update contributors.yaml for gradywang

2016-08-30 Thread Yongqiao Wang
contributors.yaml for gradywang Diffs - docs/contributors.yaml 0f2a81f8462d30f9546c6084ee315be760a799a1 Diff: https://reviews.apache.org/r/51520/diff/ Testing --- Thanks, Yongqiao Wang

Re: Review Request 51505: Replace http::get with http::request in mesos project.

2016-08-29 Thread Yongqiao Wang
/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650 Diff: https://reviews.apache.org/r/51505/diff/ Testing --- make & make check successfully! Thanks, Yongqiao Wang

Re: Review Request 51505: Replace http::get with http::request in mesos project.

2016-08-29 Thread Yongqiao Wang
/status_update_manager_tests.cpp 38d8913a5b33aa5325d0bc632c0a1d80480eddf8 src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650 Diff: https://reviews.apache.org/r/51505/diff/ Testing --- make & make check successfully! Thanks, Yongqiao Wang

Re: Review Request 51495: Replace http::get with http::request in libprocess project.

2016-08-29 Thread Yongqiao Wang
/ Testing --- make & make check successfully! Thanks, Yongqiao Wang

Review Request 51508: Remove the useless http::get method.

2016-08-29 Thread Yongqiao Wang
://reviews.apache.org/r/51508/diff/ Testing --- Thanks, Yongqiao Wang

Re: Review Request 51508: Remove the useless http::get method.

2016-08-29 Thread Yongqiao Wang
298bd460afdeccd18e201d8a505b961fd4cf3d3e Diff: https://reviews.apache.org/r/51508/diff/ Testing (updated) --- make & make check successfully! Thanks, Yongqiao Wang

Re: Review Request 51505: [2]Replace http::get with http::request.

2016-08-29 Thread Yongqiao Wang
38d8913a5b33aa5325d0bc632c0a1d80480eddf8 src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650 Diff: https://reviews.apache.org/r/51505/diff/ Testing --- make & make check successfully! Thanks, Yongqiao Wang

Re: Review Request 51495: [1]Replace http::get with http::request.

2016-08-29 Thread Yongqiao Wang
anks, Yongqiao Wang

Review Request 51505: Replace http::get with http::request.

2016-08-29 Thread Yongqiao Wang
/51505/diff/ Testing --- make & make check successfully! Thanks, Yongqiao Wang

Review Request 51495: Replace http::get with http::request.

2016-08-29 Thread Yongqiao Wang
/tests/system_tests.cpp 0f4d0424689522337806ba2227ec4330c700e17e Diff: https://reviews.apache.org/r/51495/diff/ Testing --- make & make check successfully! Thanks, Yongqiao Wang

Review Request 51493: Add the query parameter in createRequest.

2016-08-29 Thread Yongqiao Wang
/http.cpp 298bd460afdeccd18e201d8a505b961fd4cf3d3e Diff: https://reviews.apache.org/r/51493/diff/ Testing --- make & make check successfully. Thanks, Yongqiao Wang

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-20 Thread Yongqiao Wang
Test/0 (386 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (396 ms total) [ PASSED ] 1 test. ``` Thanks, Yongqiao Wang

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-20 Thread Yongqiao Wang
eply, visit: https://reviews.apache.org/r/46135/#review128872 --- On April 13, 2016, 3:21 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-20 Thread Yongqiao Wang
you can use > > `Future` instead. > > Yongqiao Wang wrote: > They are different variable type, 'const mesos::Resources' can not > convert to 'const Nothing'. > > Alexander Rukletsov wrote: > You use `Future` together with `FutureSatisfy`. The difference > between `Fu

Re: Review Request 46139: Add positive tests for /weights endpoint.

2016-04-19 Thread Yongqiao Wang
sit: https://reviews.apache.org/r/46139/#review128873 --- On April 13, 2016, 6:10 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-13 Thread Yongqiao Wang
onst mesos::Resources' can not convert to 'const Nothing'. - Yongqiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/#review128640 --- On April 13, 2016, 3:21 a.m., Yongqiao Wang wrote: > >

Review Request 46139: Add positive tests for /weights endpoint.

2016-04-13 Thread Yongqiao Wang
(135 ms) [--] 13 tests from DynamicWeightsTest (659 ms total) [--] Global test environment tear-down [==] 13 tests from 1 test case ran. (669 ms total) [ PASSED ] 13 tests. Thanks, Yongqiao Wang

Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-12 Thread Yongqiao Wang
=] 1 test from 1 test case ran. (396 ms total) [ PASSED ] 1 test. ``` Thanks, Yongqiao Wang

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-10 Thread Yongqiao Wang
104) <https://reviews.apache.org/r/45863/#comment191446> Mesos operator can update weight for mutilple roles at one time, so it is better to show which role's weight is not positive to make this error message more clearly. - Yongqiao Wang On April 7, 2016, 10:50 a.m., Alexander Ruk

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-31 Thread Yongqiao Wang
asterAllocatorTest/0 (1059 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (1070 ms total) [ PASSED ] 1 test. Thanks, Yongqiao Wang

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-31 Thread Yongqiao Wang
enerated e-mail. To reply, visit: https://reviews.apache.org/r/45202/#review126083 --- On March 25, 2016, 9:13 a.m., Yongqiao Wang wrote: > > --- > This is an automati

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-25 Thread Yongqiao Wang
asterAllocatorTest/0 (1059 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (1070 ms total) [ PASSED ] 1 test. Thanks, Yongqiao Wang

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-25 Thread Yongqiao Wang
27.0.0.1:5050/weights Receive an rescind offer, and a new offer received: {"rescind":{"offer_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680 {"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20 {"type":"HEARTBEAT"}20 - Update the weight of role `mesos1` $ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT http://127.0.0.1:5050/weights - The outstanding offer will not be rescinded. Thanks, Yongqiao Wang

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-24 Thread Yongqiao Wang
. make && make check. Thanks, Yongqiao Wang

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-23 Thread Yongqiao Wang
> On March 21, 2016, 9:03 a.m., Adam B wrote: > > Good start, but you're missing a few things. Are these coming in subsequent > > patches? > > - Authentication for GET requests > > - Tests for GETs > > - Documentation updates > > Yongqiao Wang wrote: >

Review Request 45203: Add authentication test for /weights GET request.

2016-03-23 Thread Yongqiao Wang
tRequest [ OK ] DynamicWeightsTest.UnauthenticatedQueryWeightRequest (81 ms) [--] 1 test from DynamicWeightsTest (81 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (91 ms total) [ PASSED ] 1 test. Thanks, Yongqiao Wang

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-23 Thread Yongqiao Wang
e.org/r/44450/#review124509 --- On March 23, 2016, 1:59 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-23 Thread Yongqiao Wang
] 1 test from 1 test case ran. (1070 ms total) [ PASSED ] 1 test. Thanks, Yongqiao Wang

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-22 Thread Yongqiao Wang
ceived: {"rescind":{"offer_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680 {"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20 {"type":"HEARTBEAT"}20 - Update the weight of role `mesos1` $ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT http://127.0.0.1:5050/weights - The outstanding offer will not be rescinded. (TODO) I will add couple of tests for this patch in another JIRA. Thanks, Yongqiao Wang

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-22 Thread Yongqiao Wang
--:-- 0 * Connection #0 to host localhost left intact No JSON object could be decoded ``` - Yongqiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/#review124512

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-22 Thread Yongqiao Wang
tring1 http://localhost:5050/weights | python -mjson.tool [ { "role": "role3", "weight": 3.4 }, { "role": "role2", "weight": 1.0 }, { "role": "role1", "weight": 1.8 } ] Thanks, Yongqiao Wang

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-22 Thread Yongqiao Wang
&& make check. Thanks, Yongqiao Wang

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-21 Thread Yongqiao Wang
:5050/weights Receive an rescind offer, and a new offer received: {"rescind":{"offer_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680 {"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20 {"type":"HEARTBEAT"}20 - Update the weight of role `mesos1` $ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT http://127.0.0.1:5050/weights - The outstanding offer will not be rescinded. (TODO) I will add couple of tests for this patch in another JIRA. Thanks, Yongqiao Wang

Re: Review Request 44888: Fix the typo.

2016-03-16 Thread Yongqiao Wang
, Yongqiao Wang

Review Request 44888: Fix the typo.

2016-03-16 Thread Yongqiao Wang
--- Fix the typo. Diffs - src/webui/master/static/offers.html 25e487193ae5244dde40d1de1d96ce892a7c67b9 Diff: https://reviews.apache.org/r/44888/diff/ Testing --- Thanks, Yongqiao Wang

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-14 Thread Yongqiao Wang
:5050/weights Receive an rescind offer, and a new offer received: {"rescind":{"offer_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680 {"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20 {"type":"HEARTBEAT"}20 - Update the weight of role `mesos1` $ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT http://127.0.0.1:5050/weights - The outstanding offer will not be rescinded. (TODO) I will add couple of tests for this patch in another JIRA. Thanks, Yongqiao Wang

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-14 Thread Yongqiao Wang
ke check. Thanks, Yongqiao Wang

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-14 Thread Yongqiao Wang
[ OK ] Strict/RegistrarTest.UpdateWeights/1 (67 ms) [--] 2 tests from Strict/RegistrarTest (171 ms total) [--] Global test environment tear-down [==] 2 tests from 1 test case ran. (178 ms total) [ PASSED ] 2 tests. make && make check. Thanks, Yongqiao Wang

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-14 Thread Yongqiao Wang
test case ran. (490 ms total) [ PASSED ] 11 tests. Thanks, Yongqiao Wang

Re: Review Request 44584: Improved docs for dynamic weights.

2016-03-09 Thread Yongqiao Wang
g/r/44584/#comment184993> Why adjust this order? `role` is an optional item in `/weights` `PUT` request, and `/weights` is focus on changing the weight, so I put `weight` item firstly. - Yongqiao Wang On March 10, 2016, 7:28 a.m., Neil Conway

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-09 Thread Yongqiao Wang
with `/weights` endpoint. 3. Tests whether the `--weights` flag is ignored and use the registry value instead when Mesos master subsequently starts with `--weights` flag still specified. make && make check. Thanks, Yongqiao Wang

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-09 Thread Yongqiao Wang
case ran. (490 ms total) [ PASSED ] 11 tests. Thanks, Yongqiao Wang

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-09 Thread Yongqiao Wang
---- On March 9, 2016, 5:52 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41790/ > -

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-08 Thread Yongqiao Wang
"infos": [ { "role": "role3", "weight": 3.4 }, { "role": "role2", "weight": 1.0 }, { "role": "role1", "weight": 1.8 } ] } Has updated all tests of /weights endpoint to check the update results with /weights GET request. Thanks, Yongqiao Wang

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-08 Thread Yongqiao Wang
://reviews.apache.org/r/44511/diff/ Testing --- make && make check. Thanks, Yongqiao Wang

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-08 Thread Yongqiao Wang
[==] 11 tests from 1 test case ran. (490 ms total) [ PASSED ] 11 tests. Thanks, Yongqiao Wang

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-08 Thread Yongqiao Wang
cind":{"offer_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680 {"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20 {"type":"HEARTBEAT"}20 - Update the weight of role `mesos1` $ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT http://127.0.0.1:5050/weights - The outstanding offer will not be rescinded. (TODO) I will add couple of tests for this patch in another JIRA. Thanks, Yongqiao Wang

Re: Review Request 42705: Update docs for --weights flag and authorization.

2016-03-08 Thread Yongqiao Wang
docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c src/master/flags.cpp be981ed6155edce18bdb55188c78d73182159418 Diff: https://reviews.apache.org/r/42705/diff/ Testing --- Thanks, Yongqiao Wang

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Yongqiao Wang
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 Diff: https://reviews.apache.org/r/43824/diff/ Testing --- make && make check successfully. Thanks, Yongqiao Wang

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Yongqiao Wang
> 3. Generalize the method and reuse it for the 3rd instance. Thanks very much for your detailed description. - Yongqiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review1

Review Request 44512: Support to get weights info by /weights.

2016-03-08 Thread Yongqiao Wang
{ "role": "role3", "weight": 3.4 }, { "role": "role2", "weight": 1.0 }, { "role": "role1", "weight": 1.8 } ] } (TODO) Add couple of tests in another patch. Thanks, Yongqiao Wang

Review Request 44511: Add registry tests for /weights endpoint.

2016-03-08 Thread Yongqiao Wang
://issues.apache.org/jira/browse/MESOS-4797 Repository: mesos Description --- Add registry tests for /weights endpoint. Diffs - src/tests/dynamic_weights_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44511/diff/ Testing --- make && make check. Thanks, Yongqiao Wang

Re: Review Request 42719: Add doc for weights.

2016-03-08 Thread Yongqiao Wang
uest after addressing #MESOS-4316. - Yongqiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review122488 --- On March 8, 2016

Re: Review Request 43863: Move the implementation of updateWeights out of header.

2016-03-08 Thread Yongqiao Wang
/master/weights_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/43863/diff/ Testing --- make && make check successfully! Thanks, Yongqiao Wang

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-03-08 Thread Yongqiao Wang
"name": "*", "resources": { "cpus": 0, "disk": 0, "mem": 0 }, "weight": 1.0 }, { "frameworks": [], "name": "role1", "resources": { "cpus": 0, "disk": 0, "mem": 0 }, "weight": 1.8 }, { "frameworks": [], "name": "role2", "resources": { "cpus": 0, "disk": 0, "mem": 0 }, "weight": 1.0 }, { "frameworks": [], "name": "role3", "resources": { "cpus": 0, "disk": 0, "mem": 0 }, "weight": 3.4 } ] } Thanks, Yongqiao Wang

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-03-08 Thread Yongqiao Wang
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review122479 --- On March 7, 2016, 12:19 p.m., Yongqiao Wang wrote: > > --- > Th

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Yongqiao Wang
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 Diff: https://reviews.apache.org/r/43824/diff/ Testing --- make && make check successfully. Thanks, Yongqiao Wang

Re: Review Request 42719: Add doc for weights.

2016-03-08 Thread Yongqiao Wang
: https://reviews.apache.org/r/42719/diff/ Testing --- Thanks, Yongqiao Wang

Re: Review Request 43824: Addressed comments of 41672.

2016-03-07 Thread Yongqiao Wang
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 Diff: https://reviews.apache.org/r/43824/diff/ Testing --- make && make check successfully. Thanks, Yongqiao Wang

Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-07 Thread Yongqiao Wang
44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680 {"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20 {"type":"HEARTBEAT"}20 - Update the weight of role `mesos1` $ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT http://127.0.0.1:5050/weights - The outstanding offer will not be rescinded. (TODO) I will add couple of tests for this patch in another JIRA. Thanks, Yongqiao Wang

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-03-07 Thread Yongqiao Wang
;: "*", "resources": { "cpus": 0, "disk": 0, "mem": 0 }, "weight": 1.0 }, { "frameworks": [], "name": "role1", "resources": { "cpus": 0, "disk": 0, "mem": 0 }, "weight": 1.8 }, { "frameworks": [], "name": "role2", "resources": { "cpus": 0, "disk": 0, "mem": 0 }, "weight": 1.0 }, { "frameworks": [], "name": "role3", "resources": { "cpus": 0, "disk": 0, "mem": 0 }, "weight": 3.4 } ] } Thanks, Yongqiao Wang

Re: Review Request 42719: Add doc for weights.

2016-03-07 Thread Yongqiao Wang
/weights.md PRE-CREATION Diff: https://reviews.apache.org/r/42719/diff/ Testing --- Thanks, Yongqiao Wang

Re: Review Request 43824: Addressed comments of 41672.

2016-03-07 Thread Yongqiao Wang
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 Diff: https://reviews.apache.org/r/43824/diff/ Testing --- make && make check successfully. Thanks, Yongqiao Wang

Re: Review Request 43824: Addressed comments of 41672.

2016-03-03 Thread Yongqiao Wang
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 Diff: https://reviews.apache.org/r/43824/diff/ Testing --- make && make check successfully. Thanks, Yongqiao Wang

Re: Review Request 43806: Add comments for rebalance.

2016-03-03 Thread Yongqiao Wang
> On March 2, 2016, 2:07 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1066-1069 > > <https://reviews.apache.org/r/43806/diff/2/?file=1272996#file1272996line1066> > > > > For posterity, we backtick types and variable

Re: Review Request 43806: Add comments for rebalance.

2016-03-03 Thread Yongqiao Wang
-- On Feb. 27, 2016, 12:26 p.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43806/ > --

Re: Review Request 43824: Addressed comments of 41672.

2016-03-03 Thread Yongqiao Wang
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 Diff: https://reviews.apache.org/r/43824/diff/ Testing --- make && make check successfully. Thanks, Yongqiao Wang

Re: Review Request 43824: Addressed comments of 41672.

2016-03-03 Thread Yongqiao Wang
gt; > > See my comment above about how to avoid numeral suffixes. Same comments as above. - Yongqiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review121642 --- On March 1, 20

Re: Review Request 42719: Add doc for weights.

2016-02-29 Thread Yongqiao Wang
: https://reviews.apache.org/r/42719/diff/ Testing --- Thanks, Yongqiao Wang

Re: Review Request 42719: Add doc for weights.

2016-02-29 Thread Yongqiao Wang
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review121129 ------- On Feb. 19, 2016, 7:56 a.m., Yongqiao Wang wrote: > > ---

Re: Review Request 43824: Addressed comments of 41672.

2016-02-29 Thread Yongqiao Wang
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 Diff: https://reviews.apache.org/r/43824/diff/ Testing --- make && make check successfully. Thanks, Yongqiao Wang

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

2016-02-29 Thread Yongqiao Wang
instead. Given there are > > two allocations, there is a guarantee, that there will be no attempts to > > put the same framework into the set twice. > > Yongqiao Wang wrote: > In the current implementation, we only need to check the allocation size > for each framewor

Re: Review Request 43824: Addressed comments of 41672.

2016-02-29 Thread Yongqiao Wang
d e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review121132 --- On Feb. 22, 2016, 7:23 a.m., Yongqiao Wang wrote: > > --- > This is an a

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-02-28 Thread Yongqiao Wang
"name": "*", "resources": { "cpus": 0, "disk": 0, "mem": 0 }, "weight": 1.0 }, { "frameworks": [], "name": "role1", "resources": { "cpus": 0, "disk": 0, "mem": 0 }, "weight": 1.8 }, { "frameworks": [], "name": "role2", "resources": { "cpus": 0, "disk": 0, "mem": 0 }, "weight": 1.0 }, { "frameworks": [], "name": "role3", "resources": { "cpus": 0, "disk": 0, "mem": 0 }, "weight": 3.4 } ] } Thanks, Yongqiao Wang

Re: Review Request 41790: Add tests for /weights endpoint.

2016-02-28 Thread Yongqiao Wang
> On Feb. 27, 2016, 12:21 p.m., Adam B wrote: > > Sorry this took me forever to get to. Looks pretty good except for some > > indentation and some unnecessary lines. > > I'd also like to see a couple of registrar tests, like AlexR suggested. > > Yongqiao Wang

Re: Review Request 41790: Add tests for /weights endpoint.

2016-02-27 Thread Yongqiao Wang
from 1 test case ran. (536 ms total) [ PASSED ] 11 tests. Thanks, Yongqiao Wang

Re: Review Request 41790: Add tests for /weights endpoint.

2016-02-27 Thread Yongqiao Wang
-- On Jan. 25, 2016, 3:47 p.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41790/ > --- &

Re: Review Request 43863: Move the implementation of updateWeights out of header.

2016-02-27 Thread Yongqiao Wang
src/master/weights_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/43863/diff/ Testing --- make && make check successfully! Thanks, Yongqiao Wang

Re: Review Request 43863: Move the implementation of updateWeights out of header.

2016-02-27 Thread Yongqiao Wang
src/master/weights_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/43863/diff/ Testing --- make && make check successfully! Thanks, Yongqiao Wang

Re: Review Request 43863: Move the implementation of updateWeights out of header.

2016-02-27 Thread Yongqiao Wang
https://reviews.apache.org/r/43863/#review121078 ------- On Feb. 23, 2016, 2:18 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 43806: Add comments for rebalance.

2016-02-27 Thread Yongqiao Wang
1b69fa801cd3f08cfcdce71ee3a3ca266b2fde57 Diff: https://reviews.apache.org/r/43806/diff/ Testing --- Thanks, Yongqiao Wang

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-02-22 Thread Yongqiao Wang
You may look > > at maintenance and quota for inspiration : ). > > > > Going further, how about extracting registry part into a separate > > patch? It will make reviewing easier. Also, it would be great to see some > > registry tests as well. > > Yongqia

Review Request 43863: Move the implementation of updateWeights out of header.

2016-02-22 Thread Yongqiao Wang
/ Testing --- make && make check successfully! Thanks, Yongqiao Wang

Review Request 43824: Addressed comments of 41672.

2016-02-21 Thread Yongqiao Wang
&& make check successfully. Thanks, Yongqiao Wang

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

2016-02-21 Thread Yongqiao Wang
ere. Sorry to do not understand your suggestion here, current using hashmap and use frameworkid as it's key, here to check value for allocation number for each framework. - Yongqiao --- This is an automatically generate

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-02-21 Thread Yongqiao Wang
of the header, I will update this patches later. - Yongqiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review119857 ----

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-02-20 Thread Yongqiao Wang
> On Feb. 19, 2016, 9:36 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1068-1070 > > <https://reviews.apache.org/r/41597/diff/54/?file=1241326#file1241326line1068> > > > > Why don't we need to set `rebalanc

Review Request 43806: Add comments for rebalance.

2016-02-20 Thread Yongqiao Wang
, Yongqiao Wang

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-02-19 Thread Yongqiao Wang
hanging it's weight. - Yongqiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review119848 --- On Feb. 14, 2016

Re: Review Request 42719: Add doc for weights.

2016-02-18 Thread Yongqiao Wang
: https://reviews.apache.org/r/42719/diff/ Testing --- Thanks, Yongqiao Wang

Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

2016-02-16 Thread Yongqiao Wang
) - src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 Diff: https://reviews.apache.org/r/43593/diff/ Testing --- Make && Make check. Thanks, Yongqiao Wang

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

2016-02-16 Thread Yongqiao Wang
t: https://reviews.apache.org/r/43593/ Thanks, Yongqiao Wang

Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

2016-02-16 Thread Yongqiao Wang
/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 Diff: https://reviews.apache.org/r/43593/diff/ Testing --- Make && Make check. Thanks, Yongqiao Wang

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

2016-02-16 Thread Yongqiao Wang
mp; Make check Test: https://reviews.apache.org/r/43593/ Thanks, Yongqiao Wang

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

2016-02-16 Thread Yongqiao Wang
an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43041/#review119279 --- On Feb. 16, 2016, 8:52 a.m., Yongqiao Wang wrote: > > --- > This is

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

2016-02-16 Thread Yongqiao Wang
he.org/r/43593/ Thanks, Yongqiao Wang

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

2016-02-16 Thread Yongqiao Wang
&& Make check Test: https://reviews.apache.org/r/43593/ Thanks, Yongqiao Wang

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

2016-02-16 Thread Yongqiao Wang
--- Make && Make check Test: https://reviews.apache.org/r/43593/ Thanks, Yongqiao Wang

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

2016-02-16 Thread Yongqiao Wang
: https://reviews.apache.org/r/43041/diff/ Testing (updated) --- Make && Make check Test: https://reviews.apache.org/r/43593/ Thanks, Yongqiao Wang

  1   2   3   >