Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96738 --- Ship it! Ship It! - Michael Park On Aug. 27, 2015, 4:23 p.m., Ja

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 27, 2015, 6:23 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 27, 2015, 5:14 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 37188: Added std::hash template specializations.

> On Aug. 26, 2015, 9:13 p.m., Joris Van Remoortere wrote: > > @Mpark: For the standard hashers, do we want to follow this pattern? > > ``` > > template <> > > struct hash { > > > > typedef size_t result_type; > > > > typedef T argument_type; > > > > result_type operator()(const

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96672 --- There's an instance of `hash_value` still in `3rdparty/libprocess/3

Re: Review Request 37188: Added std::hash template specializations.

> On Aug. 26, 2015, 11:13 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, line 806 > > > > > > I think we tend to put a new line after an expression that doesn't fit > > on 1 line

Re: Review Request 37188: Added std::hash template specializations.

> On Aug. 26, 2015, 11:13 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/pid.hpp, line 153 > > > > > > there is an extra space hiding here :-) There was another one in line 140, removed th

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 27, 2015, 1:39 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96593 --- @Mpark: For the standard hashers, do we want to follow this pattern?

Re: Review Request 37188: Added std::hash template specializations.

> On Aug. 25, 2015, 2:36 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, lines 677-695 > > > > > > I think this might be the right solution for the scope of the changes > > we're trying t

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96354 --- Ship it! Ship It! - Michael Park On Aug. 25, 2015, 1:15 p.m., Ja

Re: Review Request 37188: Added std::hash template specializations.

> On Aug. 25, 2015, 12:36 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, lines 677-695 > > > > > > I think this might be the right solution for the scope of the changes > > we're trying

Re: Review Request 37188: Added std::hash template specializations.

> On Aug. 25, 2015, 2:36 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, lines 677-695 > > > > > > I think this might be the right solution for the scope of the changes > > we're trying t

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 25, 2015, 3:15 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96329 --- 3rdparty/libprocess/include/process/pid.hpp (lines 154 - 155)

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 11, 2015, 11:57 a.m.) Review request for mesos, Alexander Rojas a

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review94861 --- Looks good overall! One question: why did you decide to leave the `h

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review94858 --- 3rdparty/libprocess/include/process/address.hpp (line 160)

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 10, 2015, 2:25 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 10, 2015, 10:52 a.m.) Review request for mesos, Alexander Rojas a

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 7, 2015, 1:53 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 7, 2015, 12:28 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review94517 --- Ship it! 3rdparty/libprocess/src/tests/http_tests.cpp (lines 677 -

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 7, 2015, 11:45 a.m.) Review request for mesos, Alexander Rojas an