Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/ --- (Updated April 27, 2016, 3:15 a.m.) Review request for mesos and Adam B. Bugs

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

> On April 26, 2016, 6:45 p.m., Alexander Rukletsov wrote: > > src/tests/slave_authorization_tests.cpp, line 251 > > > > > > s/SlaveAuthorizationTest/Endpoint > > > > I'd say it's more descriptive. > > Benj

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/ --- (Updated April 27, 2016, 10:59 a.m.) Review request for mesos and Adam B. Cha

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130666 --- Patch looks great! Reviews applied: [45922, 46318, 46203, 46319,

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

> On April 26, 2016, 6:45 p.m., Alexander Rukletsov wrote: > > src/tests/slave_authorization_tests.cpp, line 251 > > > > > > s/SlaveAuthorizationTest/Endpoint > > > > I'd say it's more descriptive. Right no

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/ --- (Updated April 26, 2016, 8:22 p.m.) Review request for mesos and Adam B. Chan

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130638 --- Fix it, then Ship it! src/tests/slave_authorization_tests.cpp

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130569 --- Patch looks great! Reviews applied: [45922, 46318, 46203, 46319,

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/ --- (Updated April 26, 2016, 9:59 a.m.) Review request for mesos and Adam B. Chan

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

> On April 26, 2016, 9 a.m., Adam B wrote: > > src/tests/slave_authorization_tests.cpp, line 171 > > > > > > s/some agent's endpoint/the specified agent endpoint/ Done. > On April 26, 2016, 9 a.m., Adam B wrote: >

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130548 --- src/tests/slave_authorization_tests.cpp (line 171)

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130452 --- Patch looks great! Reviews applied: [45922, 46318, 46203, 46319,

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/ --- (Updated April 25, 2016, 4:16 p.m.) Review request for mesos and Adam B. Chan

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

> On April 25, 2016, 1:31 p.m., Adam B wrote: > > src/tests/slave_authorization_tests.cpp, line 176 > > > > > > Shouldn't you give this a more generic name now that it can handle any > > (agent) endpoint? Done. -

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130391 --- Fix it, then Ship it! Looks like a great generalization! What m

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/ --- (Updated April 25, 2016, 11:52 a.m.) Review request for mesos and Adam B. Cha