Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139625 --- Fix it, then Ship it! include/mesos/master/master.proto (line

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/ --- (Updated June 27, 2016, 6:17 p.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-27 Thread haosdent huang
> On June 24, 2016, 9:25 p.m., Anand Mazumdar wrote: > > include/mesos/master/master.proto, line 307 > > > > > > hmmm.. we should consider doing a sweep to kill: > > > > `The response for 'Call::GET_X`. > >

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-26 Thread Vinod Kone
> On June 24, 2016, 9:25 p.m., Anand Mazumdar wrote: > > include/mesos/master/master.proto, line 307 > > > > > > hmmm.. we should consider doing a sweep to kill: > > > > `The response for 'Call::GET_X`. > >

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-26 Thread Anand Mazumdar
> On June 24, 2016, 9:25 p.m., Anand Mazumdar wrote: > > include/mesos/master/master.proto, line 307 > > > > > > hmmm.. we should consider doing a sweep to kill: > > > > `The response for 'Call::GET_X`. > >

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-25 Thread haosdent huang
> On June 24, 2016, 9:25 p.m., Anand Mazumdar wrote: > > include/mesos/master/master.proto, line 307 > > > > > > hmmm.. we should consider doing a sweep to kill: > > > > `The response for 'Call::GET_X`. > >

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/ --- (Updated June 25, 2016, 6:44 p.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-25 Thread haosdent huang
> On June 24, 2016, 9:25 p.m., Anand Mazumdar wrote: > > include/mesos/master/master.proto, line 307 > > > > > > hmmm.. we should consider doing a sweep to kill: > > > > `The response for 'Call::GET_X`. > >

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139404 --- include/mesos/master/master.proto (line 150)

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139402 --- Fix it, then Ship it! include/mesos/master/master.proto (line

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-23 Thread haosdent huang
> On June 24, 2016, 12:27 a.m., Vinod Kone wrote: > > include/mesos/master/master.proto, line 319 > > > > > > can you include informaation about which roles weights are listed here? > > for every role listed above?

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/ --- (Updated June 24, 2016, 1:58 a.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/ --- (Updated June 24, 2016, 1:55 a.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-23 Thread zhou xing
> On 六月 24, 2016, 12:27 a.m., Vinod Kone wrote: > > include/mesos/master/master.proto, line 319 > > > > > > can you include informaation about which roles weights are listed here? > > for every role listed above? >

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-23 Thread haosdent huang
> On June 24, 2016, 12:27 a.m., Vinod Kone wrote: > > include/mesos/master/master.proto, line 319 > > > > > > can you include informaation about which roles weights are listed here? > > for every role listed above?

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139312 --- LGTM overall. include/mesos/master/master.proto (line 64)

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-23 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139309 --- include/mesos/master/master.proto (lines 306 - 307)

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139287 --- Patch looks great! Reviews applied: [49157] Passed command: expo

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/ --- (Updated June 23, 2016, 3:47 p.m.) Review request for mesos, Abhishek Dasgupta,

Review Request 49157: Added missing comments for operator API protos.

2016-06-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/ --- Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo,