Re: Review Request 50125: Added mesos-docker-executor support for devices control.

> On 十一月 12, 2016, 1:13 p.m., Guangya Liu wrote: > > Summary > > ``` > > Added '--devices' flag to mesos-docker-executor. > > ``` > > > > Description > > ``` > > Added a new flag '--devices' to mesos-docker-executor which is used to > > control the feature of devices exposition, isolation and

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review155780 --- Summary ``` Added '--devices' flag to mesos-docker-executor. ```

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Nov. 10, 2016, 8:15 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

> On 十一月 4, 2016, 3:28 p.m., Guangya Liu wrote: > > Seems spliting this to two patches is more simple for review: One patch for > > adding a new flag '--devices' to mesos docker executor, and the other is > > passing 'devices' as parameter for `dockerFlags` when launching mesos > > docker

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十一月 7, 2016, 2:04 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review154917 --- Seems spliting this to two patches is more simple for review: One

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Nov. 2, 2016, 7:28 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review154408 --- Fix it, then Ship it! Ship It! src/docker/executor.cpp (line

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Nov. 1, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review154379 --- src/docker/docker.hpp (lines 71 - 96)

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Nov. 1, 2016, 6:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Oct. 31, 2016, 7:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review153842 --- src/docker/docker.hpp (lines 95 - 104)

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Oct. 24, 2016, 5 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 21, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 21, 2016, 6:29 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review153395 --- src/docker/executor.cpp (line 790)

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 20, 2016, 10:01 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 14, 2016, 9:58 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review152516 --- src/docker/docker.hpp (lines 98 - 101)

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 13, 2016, 10:15 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 11, 2016, 8:19 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 九月 22, 2016, 6:21 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 九月 20, 2016, 9:26 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

> On 八月 25, 2016, 6:27 p.m., Kevin Klues wrote: > > src/docker/executor.cpp, line 89 > > > > > > By the time the devices are passed in here they should be of type > > `vector`, not just a string. > > > >

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review146823 --- src/docker/executor.hpp (lines 80 - 83)

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 八月 15, 2016, 7:29 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 八月 10, 2016, 10:33 a.m.) Review request for mesos, Benjamin Mahler,