Re: Review Request 66144: Enforced task launch order on the agent.

> On April 2, 2018, 4:57 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Line 2233 (original), 2274 (patched) > > > > > > We should defer this callback. > > Meng Zhu wrote: > That would change the old behavi

Re: Review Request 66144: Enforced task launch order on the agent.

> On April 2, 2018, 4:57 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Line 2233 (original), 2274 (patched) > > > > > > We should defer this callback. That would change the old behavior i.e. `sendExitedExecuto

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/ --- (Updated April 2, 2018, 5:36 p.m.) Review request for mesos, Chun-Hung Hsiao an

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/#review200329 --- Fix it, then Ship it! src/slave/slave.cpp Line 2233 (original)

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/ --- (Updated April 2, 2018, 11:04 a.m.) Review request for mesos, Chun-Hung Hsiao a

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/#review200256 --- src/slave/slave.hpp Lines 1147-1155 (patched)

Re: Review Request 66144: Enforced task launch order on the agent.

> On March 28, 2018, 11:11 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2261-2268 (patched) > > > > > > I think we want to `return;` at the end of this conditional block? And > > if you make this lambda

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/ --- (Updated March 29, 2018, 11:15 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/#review200133 --- src/slave/slave.cpp Lines 2224 (patched)

Re: Review Request 66144: Enforced task launch order on the agent.

> On March 23, 2018, 1:12 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2906-2910 (patched) > > > > > > In this case, the executor struct exists - do we really want to erase > > the sequence here? ah, t

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/ --- (Updated March 28, 2018, 12:05 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/#review199857 --- src/slave/slave.hpp Lines 1147-1152 (patched)

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/ --- (Updated March 22, 2018, 12:07 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/#review199711 --- src/slave/slave.hpp Lines 1141-1143 (patched)

Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8624 h