On June 22, 2015, 10:20 a.m., Alexander Rukletsov wrote:
Before making a thorough review, let's discuss one high level question.
Here is the problem how I understand it: we reserve for roles, but our code
works mostly with frameworks (allocator methods, Offer protobuf). To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35774/#review88990
---
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 4:26 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35775/#review88991
---
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 4:27 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35131/#review88980
---
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 4:26 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review88985
---
Ship it!
LGTM minus some minor comments. Feel free to ignore/drop
On April 23, 2015, 9:28 a.m., Till Toenshoff wrote:
Ship It!
Till Toenshoff wrote:
When testing your patch, I noticed that it fails for me.
```
../../src/tests/slave_tests.cpp:184: Failure
Value of: status.get().reason()
Actual: 8
Expected:
On April 23, 2015, 9:28 a.m., Till Toenshoff wrote:
Ship It!
Till Toenshoff wrote:
When testing your patch, I noticed that it fails for me.
```
../../src/tests/slave_tests.cpp:184: Failure
Value of: status.get().reason()
Actual: 8
Expected:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88974
---
Would this RR be still relevant after
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35770/#review88986
---
Patch looks great!
Reviews applied: [35769, 35770]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/#review88979
---
Ship it!
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34259/#review88981
---
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 4:26 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35785/#review88993
---
Patch looks great!
Reviews applied: [35785]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35510/#review88964
---
docs/mesos-documentation-guide.md (line 1)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35771/#review88972
---
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 3:17 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35510/
---
(Updated June 23, 2015, 1:30 p.m.)
Review request for mesos and Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35510/
---
(Updated June 23, 2015, 12:53 p.m.)
Review request for mesos and Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35777/#review88957
---
Patch looks great!
Reviews applied: [35777]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35553/#review88960
---
Ship it!
Ship It!
- Bernd Mathiske
On June 17, 2015, 2:22 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35510/#review88968
---
Ship it!
Ship It!
- Bernd Mathiske
On June 23, 2015, 6:30 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35775/#review88965
---
Patch looks great!
Reviews applied: [34256, 35131, 34259, 34260,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review89000
---
Ship it!
LGTM. Modulo missing headers and Kapil's comments.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35622/#review88995
---
Ship it!
Ship It!
- Benjamin Hindman
On June 23, 2015, 3:57
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35773/#review89003
---
Ship it!
Ship It!
- Vinod Kone
On June 23, 2015, 8:29 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35775/#review89005
---
Ship it!
Ship It!
- Vinod Kone
On June 23, 2015, 8:27 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35774/#review89004
---
Ship it!
Ship It!
- Vinod Kone
On June 23, 2015, 8:26 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/#review88998
---
Ship it!
much cleaner. thank you!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35766/#review89034
---
Ship it!
LGTM!
configure.ac (lines 243 - 247)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799/
---
Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
On June 23, 2015, 11:01 a.m., Ian Downes wrote:
Ship It!
For the test error, are we not cleaning out /var/run/mesos/netns (correctly)
between tests so we're trying to symlink container1 repeatedly? We should
probably be storing these symlinks in a directory the test controls?
- Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35586/#review89032
---
src/slave/containerizer/linux_launcher.hpp (line 33)
On June 23, 2015, 4:31 p.m., Niklas Nielsen wrote:
Right now, the executor removed hook will be called implicitly during
shutdown, which (most likely) caused the race in the first place.
Can we split the two concerns by issueing a sched.killTask().
The sched.killTask() doesn't invoke
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35756/#review89046
---
Right now, the executor removed hook will be called implicitly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35766/
---
(Updated June 23, 2015, 5:20 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799/#review89042
---
src/docker/docker.cpp (lines 381 - 382)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/#review89061
---
Couple things:
1) You should write a test for this! Too bad
On June 9, 2015, 12:26 a.m., Till Toenshoff wrote:
3rdparty/libprocess/configure.ac, line 31
https://reviews.apache.org/r/35234/diff/1/?file=980998#file980998line31
Can we switch to `#` prefixed comments here instead?
James Peach wrote:
Originally I used #-comments, but
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35771/#review88956
---
Patch looks great!
Reviews applied: [35771]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/#review89128
---
Patch looks great!
Reviews applied: [35797]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35766/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-1856
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35768/
---
Review request for mesos, Ben Mahler and Till Toenshoff.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35770/
---
Review request for mesos, Ben Mahler and Till Toenshoff.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35766/#review88932
---
Patch looks great!
Reviews applied: [35585, 35586, 35762, 35765,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35766/
---
(Updated June 23, 2015, 2:18 a.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35771/#review88934
---
lgtm - thanks for the fix, much appreciated.
- Till Toenshoff
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35772/#review88935
---
Ship it!
Ship It!
- Till Toenshoff
On June 23, 2015, 7:21 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35773/
---
(Updated June 23, 2015, 8:29 a.m.)
Review request for mesos, Adam B and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/
---
(Updated June 23, 2015, 8:26 a.m.)
Review request for mesos and Cody Maloney.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34259/
---
(Updated June 23, 2015, 8:26 a.m.)
Review request for mesos and Cody Maloney.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35131/
---
(Updated June 23, 2015, 8:26 a.m.)
Review request for mesos and Cody Maloney.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35773/
---
Review request for mesos, Adam B and Vinod Kone.
Bugs: MESOS-1303
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/
---
(Updated June 23, 2015, 8:26 a.m.)
Review request for mesos and Cody Maloney.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35769/#review88944
---
Patch looks great!
Reviews applied: [35769]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35782/
---
Review request for mesos, Adam B and Marco Massenzio.
Bugs: MESOS-2894
On June 23, 2015, 5:39 a.m., Marco Massenzio wrote:
Can you please add one of the committers as a reviewer?
Did we document such requirement somewhere?
- Till
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35772/#review88952
---
Patch looks great!
Reviews applied: [35772]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/
---
(Updated June 24, 2015, 2 a.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815/#review89121
---
src/tests/master_contender_detector_tests.cpp (line 40)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815/#review89122
---
src/tests/master_contender_detector_tests.cpp (line 844)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815/#review89123
---
Ship it!
Ship It!
- haosdent huang
On June 24, 2015, 1:15 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815/#review89124
---
src/tests/master_contender_detector_tests.cpp (line 861)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35703/#review89125
---
Ship it!
Thanks.
- Zhiwei Chen
On June 21, 2015, 4:51 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/
---
(Updated June 24, 2015, 2:44 a.m.)
Review request for mesos and Cody Maloney.
On June 23, 2015, 5:29 p.m., Vinod Kone wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 76
https://reviews.apache.org/r/34256/diff/7/?file=990278#file990278line76
don't you want to do the same short circuit as in basename() for path
containing only slashes?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/
---
(Updated June 24, 2015, 2:44 a.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/#review89069
---
Patch looks great!
Reviews applied: [35797]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35743/#review89073
---
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp (line
On June 22, 2015, 10:02 p.m., Anand Mazumdar wrote:
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 418
https://reviews.apache.org/r/35743/diff/1/?file=989917#file989917line418
boost::size(...) would suffice here too albeit minus the small trivial
run-time cost.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35752/#review89099
---
src/sched/sched.cpp (lines 462 - 464)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35756/#review89111
---
Patch looks great!
Reviews applied: [35756]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35756/#review89071
---
Ship it!
Ship It!
- Niklas Nielsen
On June 23, 2015, 2:47 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35770/#review89087
---
Ship it!
Ship It!
- Isabel Jimenez
On June 23, 2015, 1:21 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35769/#review89088
---
Ship it!
Ship It!
- Isabel Jimenez
On June 23, 2015, 7:06 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35806/#review89091
---
hey isabel. i would like to take over this patch and add tests. i
On June 23, 2015, 11:31 p.m., Isabel Jimenez wrote:
src/sched/sched.cpp, line 438
https://reviews.apache.org/r/35752/diff/1/?file=990748#file990748line438
Aren't we using braces on switch cases syntax? like:
```
switch (type) {
case ENUM: {
break
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35766/
---
(Updated June 23, 2015, 6:49 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35768/#review89089
---
Ship it!
Ship It!
- Isabel Jimenez
On June 23, 2015, 7:05 a.m.,
On June 23, 2015, 11:09 p.m., Till Toenshoff wrote:
Ship It!
Needs rebase though.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35568/#review89077
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35766/#review89079
---
Patch looks great!
Reviews applied: [35585, 35586, 35762, 35765,
On June 23, 2015, 2:37 p.m., Kapil Arya wrote:
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, lines 40-52
https://reviews.apache.org/r/34256/diff/7/?file=990279#file990279line40
It probably applies to the Class itself, but should we also be testing
for repeated middle
On June 22, 2015, 10:02 p.m., Anand Mazumdar wrote:
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 418
https://reviews.apache.org/r/35743/diff/1/?file=989917#file989917line418
boost::size(...) would suffice here too albeit minus the small trivial
run-time cost.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35752/#review89085
---
src/sched/sched.cpp (line 438)
81 matches
Mail list logo
