---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review95238
---
src/slave/containerizer/provisioners/docker/token_manager.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
---
(Updated Aug. 13, 2015, 10:57 a.m.)
Review request for mesos, Adam B,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37328/#review95241
---
Patch looks great!
Reviews applied: [37302, 37303, 37328]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/
---
(Updated Aug. 13, 2015, 8:29 a.m.)
Review request for mesos, Lily Chen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review95243
---
Patch looks great!
Reviews applied: [37426, 37427]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
---
(Updated Aug. 13, 2015, 1:20 p.m.)
Review request for mesos, Adam B, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36050/#review95251
---
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 12, 2015, 6:52 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/#review95249
---
Ship it!
Fix minor typo, then ship it!
(We know that this is not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37303/#review95240
---
Ship it!
Looks good modulo minor fixes. I'll fix them and commit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37420/#review95245
---
Thanks for taking this on Greg.
docs/getting-started.md (line 1)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/
---
(Updated Aug. 13, 2015, 1:52 p.m.)
Review request for mesos, Benjamin Hindman
On July 28, 2015, 7:20 p.m., Timothy Chen wrote:
I notice there are no new tests added for this, can you add a test to
verify the new change works?
Timothy Chen wrote:
Are you able to add this? Otherwise let's add a TODO and get this in.
Created MESOS-3255 to follow up with tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34128/#review95256
---
Can this be merged now unless there are more comments?
- Anindya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34129/#review95257
---
Can this be merged now unless there are more comments?
Also needs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review95259
---
Patch looks great!
Reviews applied: [36612, 36620]
All tests
On Aug. 13, 2015, 6:24 a.m., Lily Chen wrote:
src/slave/containerizer/provisioners/docker/token_manager.cpp, lines 37-46
https://reviews.apache.org/r/37427/diff/2/?file=1039212#file1039212line37
no need to put underscore in front of parameters being passed in
As per style docs, its
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review95277
---
Patch looks great!
Reviews applied: [36847]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34129/#review95287
---
Ship it!
Ship It!
- Vinod Kone
On July 30, 2015, 10:36 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/#review95303
---
Ship it!
LGTM module the issue below. BTW, do we know if anyone
On Aug. 13, 2015, 6:27 p.m., Kapil Arya wrote:
src/cli/python/mesos/__init__.py, line 27
https://reviews.apache.org/r/36819/diff/6/?file=1034329#file1034329line27
Don't we need a `mesos.cli` here as well?
Kartic Krish wrote:
Looks like the module structure has been changed,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37414/
---
(Updated Aug. 13, 2015, 4:49 p.m.)
Review request for mesos, Joris Van
On Aug. 13, 2015, 4 p.m., Marco Massenzio wrote:
Today we are cutting a 0.24 RC (according to @Vinod's recent email) - it
would be great if we could have this fix in, which solves an issue with the
Python installers.
Can anyone please do anything about this one?
Thanks!
T_T?
On Aug. 13, 2015, 9:22 a.m., Till Toenshoff wrote:
src/examples/java/TestFramework.java, line 275
https://reviews.apache.org/r/37415/diff/1/?file=1038842#file1038842line275
Why 500 - not 200 or 1000? If I am not mistaken, then using 500 worked
fine on your test-machines but
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/
---
(Updated Aug. 13, 2015, 6:46 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37415/#review95299
---
Patch looks great!
Reviews applied: [37414, 37415]
All tests
On Aug. 13, 2015, 4:22 p.m., Till Toenshoff wrote:
src/examples/java/TestFramework.java, line 275
https://reviews.apache.org/r/37415/diff/1/?file=1038842#file1038842line275
Why 500 - not 200 or 1000? If I am not mistaken, then using 500 worked
fine on your test-machines but
On Aug. 13, 2015, 6:27 p.m., Kapil Arya wrote:
src/cli/python/mesos/__init__.py, line 27
https://reviews.apache.org/r/36819/diff/6/?file=1034329#file1034329line27
Don't we need a `mesos.cli` here as well?
Looks like the module structure has been changed, so just 'packages': [
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/#review95305
---
Looks good. Please include the she-bang in setup.py (as per
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 13, 2015, 6:40 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37426/#review95281
---
I wonder if we should add a test for this so that we can assert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
---
(Updated Aug. 13, 2015, 7:08 p.m.)
Review request for mesos, Adam B, Alexander
On Aug. 13, 2015, 6:43 p.m., Timothy Chen wrote:
src/authorizer/authorizer.cpp, line 19
https://reviews.apache.org/r/36048/diff/18/?file=1039308#file1039308line19
Is this our new style guide rule too to put this up before all other
imports?
Otherwise I would have
On Aug. 13, 2015, 4:56 p.m., Anand Mazumdar wrote:
I wonder if we should add a test for this so that we can assert that the
fix works ?
One easy way I can think about it, looking at the tests in
process_tests.cpp ( you should be able to use the already existing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/
---
(Updated Aug. 13, 2015, 10:26 p.m.)
Review request for mesos, Lily Chen, Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37449/
---
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-3260
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/
---
Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/#review95321
---
I re-created the issues from the previous avatar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36049/#review95328
---
Ship it!
src/local/local.cpp (line 219)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37449/#review95349
---
Ship it!
LGTM !
src/tests/scheduler_tests.cpp (line 103)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37311/
---
(Updated Aug. 13, 2015, 2:39 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37310/#review95333
---
Ship it!
src/slave/containerizer/provisioners/appc/spec.hpp
On Aug. 13, 2015, 8:06 p.m., Till Toenshoff wrote:
Thanks for your patience Alexander - I know it has been a long journey - in
the end, I think things are in great shape minus some nits I just
discovered on my final pass.
Please note that I will commit while fixing the noted issues but
On Aug. 13, 2015, 9:39 p.m., Jie Yu wrote:
src/slave/containerizer/provisioners/appc/spec.hpp, lines 41-42
https://reviews.apache.org/r/37310/diff/4/?file=1039588#file1039588line41
We wrap comments in 70 char width. Please make sure this is the case:)
Jiang Yan Xu wrote:
I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37442/
---
Review request for mesos and Ben Mahler.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37311/
---
(Updated Aug. 13, 2015, 3:11 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37310/
---
(Updated Aug. 13, 2015, 3:12 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37449/#review95348
---
Ship it!
src/tests/scheduler_tests.cpp (line 106)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/
---
(Updated Aug. 14, 2015, 12:09 a.m.)
Review request for mesos, Lily Chen, Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37311/#review95340
---
Ship it!
src/slave/containerizer/provisioners/appc/store.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37445/
---
Review request for mesos.
Repository: mesos
Description
---
Fix typos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37289/
---
(Updated Aug. 14, 2015, 12:06 a.m.)
Review request for mesos and Alexander
On Aug. 13, 2015, 2:39 p.m., Jie Yu wrote:
src/slave/containerizer/provisioners/appc/spec.hpp, lines 41-42
https://reviews.apache.org/r/37310/diff/4/?file=1039588#file1039588line41
We wrap comments in 70 char width. Please make sure this is the case:)
I adjusted the line wrapping
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37257/#review95351
---
Bad patch!
Reviews applied: [37257]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37457/
---
Review request for mesos, Cody Maloney and Timothy Chen.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/#review95362
---
Patch looks great!
Reviews applied: [37443]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37403/#review95296
---
Ship it!
Some minor comments and noticed that we were not setting
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/
---
(Updated Aug. 13, 2015, 7:50 p.m.)
Review request for mesos, Adam B, Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/#review95325
---
Ship it!
Ship It!
- Kapil Arya
On Aug. 13, 2015, 4:20 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37308/
---
(Updated Aug. 13, 2015, 2:24 p.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36050/#review95330
---
Ship it!
Ship It!
- Till Toenshoff
On Aug. 12, 2015, 1:52 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/#review95320
---
src/tests/master_tests.cpp (line 3608)
On Aug. 13, 2015, 4:22 p.m., Till Toenshoff wrote:
src/examples/java/TestFramework.java, line 275
https://reviews.apache.org/r/37415/diff/1/?file=1038842#file1038842line275
Why 500 - not 200 or 1000? If I am not mistaken, then using 500 worked
fine on your test-machines but
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/#review95266
---
Ship it!
Thanks for your patience Alexander - I know it has been a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/
---
(Updated Aug. 13, 2015, 8:20 p.m.)
Review request for mesos, Adam B, Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37308/#review95331
---
Ship it!
Ship It!
- Jie Yu
On Aug. 13, 2015, 9:24 p.m., Jiang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review95326
---
src/slave/containerizer/provisioners/docker/token_manager.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/
---
(Updated Aug. 13, 2015, 7:49 p.m.)
Review request for mesos, Adam B, Connor
On Aug. 13, 2015, 4:22 p.m., Till Toenshoff wrote:
src/examples/java/TestFramework.java, line 275
https://reviews.apache.org/r/37415/diff/1/?file=1038842#file1038842line275
Why 500 - not 200 or 1000? If I am not mistaken, then using 500 worked
fine on your test-machines but
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37257/
---
(Updated 八月 13, 2015, 7:44 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37310/
---
(Updated Aug. 13, 2015, 2:33 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37467/
---
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-2552
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37460/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-2834
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37442/#review95371
---
Patch looks great!
Reviews applied: [37423, 37424, 37417, 37416,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/#review95374
---
Ship it!
Ship It!
- Till Toenshoff
On Aug. 13, 2015, 6:46 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37457/#review95377
---
Patch looks great!
Reviews applied: [36978, 36979, 37457]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37466/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-2834
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37445/#review95364
---
Patch looks great!
Reviews applied: [37445]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37465/
---
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-2552
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37464/
---
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-2552
On 八月 13, 2015, 2:56 a.m., haosdent huang wrote:
src/examples/dynamic_reservation_framework.cpp, line 343
https://reviews.apache.org/r/37168/diff/1/?file=1033410#file1033410line343
Does we need add
```
logging::initialize(argv[0], flags, true);
```
here?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37467/#review95370
---
Ship it!
LGTM !
Would we do a test run on Jenkins before
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37462/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-2834
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37468/#review95378
---
Bad patch!
Reviews applied: [37468]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37415/
---
(Updated Aug. 14, 2015, 4:56 a.m.)
Review request for mesos, Joris Van
On Aug. 6, 2015, 9:56 a.m., Alexander Rojas wrote:
3rdparty/libprocess/include/process/http.hpp, line 754
https://reviews.apache.org/r/36847/diff/7/?file=1028524#file1028524line754
I'm rather late to the party, but AFAIK Mesos appreciates consistency
over doing some things right
On Aug. 13, 2015, 6:24 a.m., Lily Chen wrote:
src/slave/containerizer/provisioners/docker/token_manager.cpp, line 252
https://reviews.apache.org/r/37427/diff/2/?file=1039212#file1039212line252
space between () {}, you could also probably just do this in the header
file
The
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37415/#review95264
---
src/examples/java/TestFramework.java (line 275)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37471/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/#review95262
---
Ship it!
Today we are cutting a 0.24 RC (according to @Vinod's
89 matches
Mail list logo
