Re: Review Request 41789: Add put method for http PUT request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 4, 2016, 1:50 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Add put method for http PUT request.

> On Jan. 3, 2016, 10:48 a.m., Joerg Schad wrote: > > This pretty much duplicates https://reviews.apache.org/r/39466/ (except > > also has a test case). Even though the long term approach should be to > > replace all the individual http method call with a general one (accepting a > > Request

Re: Review Request 41869: Removed Docker auth server flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41869/#review112489 --- Patch looks great! Reviews applied: [41868, 41869] Passed

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41459/#review112481 --- Ship it! I assume you've gotten all of them? - Benjamin Hindman

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41460/#review112480 --- 3rdparty/libprocess/include/process/future.hpp (lines 220 - 223)

Re: Review Request 41840: Moved docker spec to the top level.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41840/#review112483 --- Ship it! Ship It! - Gilbert Song On Jan. 3, 2016, 10:30 a.m.,

Re: Review Request 41840: Moved docker spec to the top level.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41840/#review112487 --- Ship it! Ship It! - Timothy Chen On Jan. 3, 2016, 6:30 p.m.,

Re: Review Request 41839: Renamed FsLayers in docker v2 image manifest to FsLayer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41839/#review112486 --- Ship it! Ship It!

Re: Review Request 41842: Small style fixes in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41842/#review112488 --- Ship it! Ship It! - Timothy Chen On Jan. 1, 2016, 9:22 p.m.,

Review Request 41868: Added credential to Docker image protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41868/ --- Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese. Repository:

Review Request 41869: Removed Docker auth server flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41869/ --- Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese. Repository:

Re: Review Request 40546: Fixed framework CPU counters on slave page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40546/ --- (Updated Jan. 4, 2016, 3:43 a.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 41850: [WIP][MESOS-3892] Add map to trace evictable executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41850/#review112508 --- It is suggested to use past tone for the Summary and please also

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

> On Dec. 11, 2015, 7:47 p.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 1380-1382 > > > > > > I'm not sure if this is necessary. > > > > To be as backwards compatible as possible, the

Re: Review Request 41850: [WIP][MESOS-3892] Add map to trace evictable executors

> On Jan. 4, 2016, 7:19 a.m., Guangya Liu wrote: > > It is suggested to use past tone for the Summary and please also add a > > period to the end of the Summary. Please also update other patches for phase 1 to follow the above style. - Guangya

Re: Review Request 41856: [WIP][MESOS-3892] helper functions to get allocation slack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41856/ --- (Updated Jan. 4, 2016, 1:29 p.m.) Review request for mesos and Guangya Liu.

Re: Review Request 41869: Removed Docker auth server flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41869/#review112496 ---

Re: Review Request 41584: Added commit message guidelines to docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41584/#review112513 --- Ship it! Ship It! - Adam B On Dec. 19, 2015, 12:18 a.m., Artem

Re: Review Request 41856: [WIP][MESOS-3892] helper functions to get allocation slack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41856/#review112512 --- src/slave/slave.hpp (lines 392 - 400)

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

> On Dec. 24, 2015, 2:27 a.m., Adam B wrote: > > support/hooks/commit-msg, lines 6-7 > > > > > > # To enable this hook, do this from the root of the repo: > > # > > # $ ln -s ../../support/hooks/commit-message

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review112507 --- src/slave/slave.cpp (lines 4631 - 4632)

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

> On Nov. 4, 2015, 1:02 a.m., Michael Hopcroft wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp, > > line 14 > > > > > > Recommend #pragma once. This is supported by VS. GCC

Review Request 41870: [stout] Added ref-qualifiers to Option::get().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41870/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Repository:

Re: Review Request 41855: [WIP][MESOS-3982] Trace pending executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41855/#review112509 --- src/slave/slave.hpp (line 795)

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Dec. 15, 2015, 3:55 a.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 62 > > > > > > Nit: You're not reusing these, so might as well inline the calls.

Re: Review Request 41869: Removed Docker auth server flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41869/#review112502 --- Thanks Tim for taking care of this. I have been thinking that we

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

> On Dec. 21, 2015, 7:46 a.m., Michael Park wrote: > > src/master/http.cpp, line 1001 > > > > > > We actually don't need this `if` statement. Although the `role` field > > is marked `optional`, we "fill it in"

Re: Review Request 41584: Added commit message guidelines to docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41584/#review112514 --- Ship it! Ship It! - Guangya Liu On 十二月 19, 2015, 8:18 a.m.,

Re: Review Request 41850: [WIP][MESOS-3892] Add map to trace evictable executors

> On 一月 4, 2016, 7:19 a.m., Guangya Liu wrote: > > It is suggested to use past tone for the Summary and please also add a > > period to the end of the Summary. > > Guangya Liu wrote: > Please also update other patches for phase 1 to follow the above style. You can refer to

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/ --- (Updated 一月 3, 2016, 9:34 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41791: Updated allocation slack when dynamic reservation was updated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/#review112443 --- I think it's too early to update total allocation slack here; my

Re: Review Request 41848: Do not enable task and executor run on different resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41848/ --- (Updated 一月 3, 2016, 9:26 a.m.) Review request for mesos, Ben Mahler, Artem

Review Request 41862: Fix containerizer-internals Posix launcher TBD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41862/ --- Review request for mesos, Jie Yu and Timothy Chen. Bugs: MESOS-4268

Re: Review Request 41789: Add put method for http PUT request.

> On Jan. 3, 2016, 10:48 a.m., Joerg Schad wrote: > > This pretty much duplicates https://reviews.apache.org/r/39466/ (except > > also has a test case). Even though the long term approach should be to > > replace all the individual http method call with a general one (accepting a > > Request

Re: Review Request 41713: Added HDFS URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41713/#review112444 --- Hardcoded hadoop schemes? Eek! Guess we'll have to reopen

Re: Review Request 41772: Added helper function to flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 3, 2016, 9:42 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/#review112442 --- Ship it! Great. I'm fixing the pointer style as I commit.

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review112441 --- Ship it! Looks good. I'm cleaning up the comments before I

Re: Review Request 41789: Add put method for http PUT request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review112445 --- This pretty much duplicates https://reviews.apache.org/r/39466/

Re: Review Request 39466: Added http::put request method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39466/#review112447 --- Patch looks great! Reviews applied: [39466] Passed command:

Re: Review Request 41791: Updated allocation slack when dynamic reservation was updated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 3, 2016, 9:22 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41847: Updated allocation slack when slave was updated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41847/ --- (Updated 一月 3, 2016, 9:22 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 3, 2016, 9:21 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41346: WIP: Evict some executors if there are not enough reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41346/ --- (Updated 一月 3, 2016, 9:47 a.m.) Review request for mesos and Jian Qiu.

Re: Review Request 40456: MESOS-3950: show running task count in web ui

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40456/#review112461 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 41862: Fix containerizer-internals Posix launcher TBD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41862/#review112456 --- Patch looks great! Reviews applied: [41862] Passed command:

Review Request 41865: Use full width for mesos div.container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41865/ --- Review request for mesos, Bernd Mathiske and Michael Lunøe. Bugs: MESOS-2585

Re: Review Request 41254: Enabled master get ALLOCATION_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41254/#review112460 --- Patch looks great! Reviews applied: [40375, 41334, 41333, 40529,

Review Request 41863: Fixed a typo in the log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41863/ --- Review request for mesos. Bugs: MESOS-4269

Re: Review Request 41854: Added module initialization to Master main() method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/#review112448 --- Patch looks great! Reviews applied: [41760, 41854] Passed

Re: Review Request 41254: Enabled master get ALLOCATION_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41254/ --- (Updated 一月 3, 2016, 1:31 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41248: Enabled master get USAGE_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41248/ --- (Updated 一月 3, 2016, 1:31 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41246: Enabled slave get USAGE_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41246/ --- (Updated 一月 3, 2016, 1:31 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40456: MESOS-3950: show running task count in web ui

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40456/#review112455 --- Ship it! Ship It! - haosdent huang On Nov. 20, 2015, 5:01

Re: Review Request 40456: MESOS-3950: show running task count in web ui

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40456/#review112454 --- Ship it! Ship It! - haosdent huang On Nov. 20, 2015, 5:01

Review Request 41864: Web UI Display Bug when starting lots of tasks with small cpu value on frameworks tab.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41864/ --- Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-2635

Re: Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

> On 十二月 17, 2015, 10:43 a.m., Klaus Ma wrote: > > src/slave/slave.cpp, line 5194 > > > > > > So we are going to only cover `SCALAR` resources? Is that necessary? metrics/snapshot should expose metrics on

Re: Review Request 41864: Web UI Display Bug when starting lots of tasks with small cpu value on frameworks tab.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41864/ --- (Updated Jan. 3, 2016, 2:39 p.m.) Review request for mesos, Ben Mahler and Jie

Re: Review Request 41713: Added HDFS URI fetcher plugin.

> On Jan. 3, 2016, 10:50 a.m., Adam B wrote: > > src/uri/fetchers/hadoop.cpp, line 54 > > > > > > Why is this hardcoded again? We moved away from that for > > https://issues.apache.org/jira/browse/MESOS-1711 but now

Re: Review Request 41840: Moved docker spec to the top level.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41840/ --- (Updated Jan. 3, 2016, 6:30 p.m.) Review request for mesos, Gilbert Song, Jojy

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41861/ --- (Updated Jan. 3, 2016, 6:33 p.m.) Review request for mesos, Gilbert Song, Jojy

Re: Review Request 41865: Use full width for mesos div.container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41865/#review112473 --- Patch looks great! Reviews applied: [41865] Passed command:

Re: Review Request 39466: Added http::put request method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39466/#review112474 --- Thanks [~joerg84] for the patch. Can you help me understand why

Re: Review Request 41863: Fixed a typo in the log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41863/#review112463 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 41864: Web UI Display Bug when starting lots of tasks with small cpu value on frameworks tab.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41864/#review112467 --- Patch looks great! Reviews applied: [41864] Passed command:

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41861/#review112475 --- Patch looks great! Reviews applied: [41839, 41840, 41841, 41842,